1
0
mirror of https://github.com/samba-team/samba.git synced 2025-01-26 10:04:02 +03:00

1385 Commits

Author SHA1 Message Date
Christian Ambach
c9d70740e3 s3:modules:nfs4_acls fix memory hierarchy in smb_create_smb4acl
the ACEs should be talloc children of the ACL itself and not be placed on talloc_tos()

Signed-off-by: Christian Ambach <ambi@samba.org>

Reviewed-by: Andrew Bartlett <abartlet@samba.org>
2012-11-16 23:28:21 +01:00
Christian Ambach
775d0a78c4 s3:vfs_gpfs fix a memory leak in gpfsacl_get_posix_acl
Signed-off-by: Christian Ambach <ambi@samba.org>

Reviewed-by: Andrew Bartlett <abartlet@samba.org>
2012-11-16 23:28:21 +01:00
Christian Ambach
1a71f07cee s3:vfs_gpfs fix memory corruption in gpfs2smb_acl
sys_acl_init returns a SMB_ACL_T with zero entries in the acl array
reallocate the array to proper size before filling it, otherwise we overwrite memory

This one is a result of a improper fixing in 7a6182962966e5edb42728c8

Signed-off-by: Christian Ambach <ambi@samba.org>

Reviewed-by: Andrew Bartlett <abartlet@samba.org>
2012-11-16 23:28:21 +01:00
Christian Ambach
3dab1ef8a5 s3:vfs_gpfs fix memory leak in gpfs_get_nfs4_acl
Signed-off-by: Christian Ambach <ambi@samba.org>

Reviewed-by: Andrew Bartlett <abartlet@samba.org>
2012-11-16 23:28:21 +01:00
Christian Ambach
3925a7114c s3:vfs_gpfs fix memory leaks in gpfs_getacl_alloc
Signed-off-by: Christian Ambach <ambi@samba.org>

Reviewed-by: Andrew Bartlett <abartlet@samba.org>
2012-11-16 23:28:21 +01:00
Stefan Metzmacher
c2ca9e0210 s3:vfs_default: optimize vfswrap_asys_finished() and read as much as we can
Signed-off-by: Stefan Metzmacher <metze@samba.org>

Autobuild-User(master): Volker Lendecke <vl@samba.org>
Autobuild-Date(master): Mon Nov  5 19:01:13 CET 2012 on sn-devel-104
2012-11-05 19:01:13 +01:00
Andrew Bartlett
60cf4cb5a6 vfs_acl_common: In add_directory_inheritable_components allocate on psd as parent
When we add a new DACL to the security descriptor, we need to use the
SD as the memory context, so we can talloc_move() it as a tree to a
new parent.

Andrew Bartlett

Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed by: Jeremy Allison <jra@samba.org>

Autobuild-User(master): Jeremy Allison <jra@samba.org>
Autobuild-Date(master): Fri Nov  2 22:16:14 CET 2012 on sn-devel-104
2012-11-02 22:16:14 +01:00
Andrew Bartlett
60a06ff09c vfs: Fix compilation of ACL support on solaris 2012-10-23 09:29:18 +02:00
Christian Ambach
6d1be1caf9 s3:vfs_gpfs re-indent run-away lines
some lines added by the acl_blob additions were longer than 80 chars
2012-10-12 11:49:32 +02:00
Christian Ambach
fa728d1c0b s3:vfs_gpfs fix the build
make it compile again after the recent (untested) additions of the acl_blob functions
2012-10-12 11:49:32 +02:00
Christian Ambach
e4946cf10c s3:vfs_gpfs remove a trailing space 2012-10-12 11:49:32 +02:00
Christian Ambach
12ae1812d0 s3:vfs_gpfs skip local flock when gpfs sharemodes are disabled
no sense in calling local flock when clustered sharemodes should be disabled
2012-10-12 11:49:31 +02:00
Andrew Bartlett
1722074a9b vfs: Remove irixacl module (all the fucntions in it are unimplemented) 2012-10-11 14:52:27 +11:00
Andrew Bartlett
a0588fdea8 vfs: Fix alternative posix and no-op sys acl implementations to take a mem_ctx
These were missed with the initial conversion to use a talloc context.

Andrew Bartlett
2012-10-11 14:45:03 +11:00
Andrew Bartlett
547a260a28 vfs: Improve formatting of vfs_fake_acls
This avoids this bad style being copied into new modules.

Andrew Bartlett

Autobuild-User(master): Andrew Bartlett <abartlet@samba.org>
Autobuild-Date(master): Thu Oct 11 05:10:16 CEST 2012 on sn-devel-104
2012-10-11 05:10:16 +02:00
Andrew Bartlett
d07d888ce1 vfs: Improve formatting of vfs_default
This avoids this bad style being copied into new modules.

Andrew Bartlett
2012-10-11 12:25:14 +11:00
Andrew Bartlett
38416ccac3 vfs: Use a blocking function in vfs_zfsacl for system ACL blobs
This is so we do not query some other module for the ACL blob, as zfs
ACLs are not posix ACLs.  We may add a linearisation later.

Andrew Bartlett
2012-10-11 12:25:13 +11:00
Andrew Bartlett
bac3ed2696 vfs: Use posix_sys_acl_blob_get_file in vfs_tru64acl for posix ACLs 2012-10-11 12:25:13 +11:00
Andrew Bartlett
998bdd516a vfs: Use posix_sys_acl_blob_get_file in vfs_solarisacl for posix ACLs 2012-10-11 12:25:13 +11:00
Andrew Bartlett
010e589c29 vfs: Use posix_sys_acl_blob_get_file in vfs_posixacl for posix ACLs 2012-10-11 12:25:13 +11:00
Andrew Bartlett
598b565c63 vfs: Use posix_sys_acl_blob_get_file in vfs_irix for posix ACLs 2012-10-11 12:25:13 +11:00
Andrew Bartlett
4eb0e406f1 vfs: Use posix_sys_acl_blob_get_file in vfs_hpux for posix ACLs 2012-10-11 12:25:13 +11:00
Andrew Bartlett
abee79f99d vfs: Use posix_sys_acl_blob_get_file in vfs_gpfs for posix ACLs 2012-10-11 12:25:12 +11:00
Andrew Bartlett
5dddd9429e vfs: Use posix_sys_acl_blob_get_file in vfs_fake_acls for posix ACLs 2012-10-11 12:25:12 +11:00
Andrew Bartlett
76b38f75e9 vfs: Use posix_sys_acl_blob_get_file in vfs_default for posix ACLs 2012-10-11 12:25:12 +11:00
Andrew Bartlett
274ace37fd vfs: Use posix_sys_acl_blob_get_file in vfs_aixacl2 for posix ACLs 2012-10-11 12:25:12 +11:00
Andrew Bartlett
79edc54a94 vfs: Use posix_sys_acl_blob_get_file in vfs_aixacl 2012-10-11 12:25:12 +11:00
Andrew Bartlett
c960a49f42 vfs: Use a blocking function in vfs_afsacl for system ACL blobs
This is important, as we need to avoid asking any lower module for a
possible libear ACL blob.  We may implement a linearisation in the
future.

Andrew Bartlett
2012-10-11 12:25:12 +11:00
Andrew Bartlett
1f36ec1293 vfs: Remove type parameter from sys_acl_blob_get_{fd,file}
This interface actually needs to match the get_nt_acl interface in
that the system ACL implmenetation may not be posix ACLs, and the blob
is not meant to be enforced to be of a particular system ACL
structure.

Andrew Bartlett
2012-10-11 12:25:11 +11:00
Andrew Bartlett
c8ade07760 smbd: Add mem_ctx to {f,}get_nt_acl VFS call
This makes it clear which context the returned SD is allocated on, as
a number of callers do not want it on talloc_tos().

As the ACL transformation allocates and then no longer needs a great
deal of memory, a talloc_stackframe() call is used to contain the
memory that is not returned further up the stack.

Andrew Bartlett
2012-10-11 12:25:11 +11:00
Andrew Bartlett
9158974540 smbd: Add mem_ctx to sys_acl_init() and all callers
This changes from allocation on NULL to allocation on the supplied
memory context.

Currently that supplied context is talloc_tos() at the the final consumer of
the ACL.

Andrew Bartlett
2012-10-11 12:25:11 +11:00
Andrew Bartlett
a4d1f2223a build: Add vfs_media_harmony to the waf build 2012-10-11 12:25:11 +11:00
Volker Lendecke
1c35c22e62 s3: Pass down smb_filename to smbacl4_fill_ace4
A full fsp is a bit overkill here

Autobuild-User(master): Volker Lendecke <vl@samba.org>
Autobuild-Date(master): Tue Oct  9 13:38:49 CEST 2012 on sn-devel-104
2012-10-09 13:38:49 +02:00
Björn Baumbach
8da8a2289e s3: vfs_streams_depot: add delete_lost option
With this option lost stream directories will be removed
instead of renamed.

Autobuild-User(master): Volker Lendecke <vl@samba.org>
Autobuild-Date(master): Mon Oct  1 18:47:30 CEST 2012 on sn-devel-104
2012-10-01 18:47:30 +02:00
David Disseldorp
0d7a2af908 vfs: check full_audit enum->str mapping on startup
Signed-off-by: Jim McDonough <jmcd@samba.org>

Autobuild-User(master): David Disseldorp <ddiss@samba.org>
Autobuild-Date(master): Fri Sep 28 19:28:49 CEST 2012 on sn-devel-104
2012-09-28 19:28:49 +02:00
David Disseldorp
e8e91fbbab vfs: add missing pwrite ops to full_audit
The op enum is used by audit_opname() as an index into the vfs_op_names
array, so any decrepencies cause bogus audit log entries.

Signed-off-by: Jim McDonough <jmcd@samba.org>
2012-09-28 17:44:55 +02:00
Christian Ambach
1947164feb s3:nfs4acls filter away inheritance flags on files
While it is possible to define inheritance flags on files on Windows, this will
be denied by GPFS and UFS (and potentially others).

So it will be better to strip of these bits when being set for files instead of
failing to set the ACL completely (this is current behavior).

Users that want to retain the full SD will have to use acl_xattr (acl_tdb), as
other pieces of the SD are also lost when translating to NFSv4. So this should
not be a too intrusive change, but allow users to migrate data with such flags
instead of failing to migrate the ACL completely.
2012-09-27 04:36:52 +02:00
Christian Ambach
19631e8e7e s3:nfs4acls pass down fsp instead of just the filename 2012-09-27 04:36:52 +02:00
Christian Ambach
0319903b31 s3:vfs_fake_acls fix a compiler warning
about acl being potentially uninitialized

Autobuild-User(master): Christian Ambach <ambi@samba.org>
Autobuild-Date(master): Sun Sep 23 01:08:39 CEST 2012 on sn-devel-104
2012-09-23 01:08:39 +02:00
David Disseldorp
a125ea7419 vfs: fix acl_blob_get* in vfs_full_audit
Plumb-in functions and use correct return types.

Autobuild-User(master): David Disseldorp <ddiss@samba.org>
Autobuild-Date(master): Thu Sep 20 20:42:09 CEST 2012 on sn-devel-104
2012-09-20 20:42:09 +02:00
David Disseldorp
47becf6e20 vfs: fix lock logging in vfs_full_audit 2012-09-20 19:02:53 +02:00
Christian Ambach
7a61829629 s3:vfs_gpfs: fix build
after recent VFS changes
2012-09-16 11:50:12 -07:00
Björn Jacke
1aa281ecb0 s3: fix the hpux acl module
This was not adopted to the recent VFS acl structure changes.

Autobuild-User(master): Björn Jacke <bj@sernet.de>
Autobuild-Date(master): Fri Sep 14 12:23:23 CEST 2012 on sn-devel-104
2012-09-14 12:23:23 +02:00
Björn Jacke
9222f0f928 s3: fix the tru64 acl module
This was not adopted to the recent VFS acl structure changes.
2012-09-14 10:42:17 +02:00
Björn Jacke
35632eec8e s3: fix the aix acl module
This was not adopted to the recent VFS acl structure changes.
2012-09-14 10:42:17 +02:00
Ira Cooper
5e51f63e86 s3: Fix the vfs_solarisacl module to compile.
This got broken with the recent VFS acl structure changes.

Autobuild-User(master): Ira Cooper <ira@samba.org>
Autobuild-Date(master): Fri Sep 14 05:21:29 CEST 2012 on sn-devel-104
2012-09-14 05:21:29 +02:00
Jeremy Allison
f5a2379794 In vfs modules, don't use 'conn->origpath' when we really mean 'conn->cwd'.
This allows VFS modules to work even when we've changed directory
under the connect path in order to do root-safe calls.

Autobuild-User(master): Jeremy Allison <jra@samba.org>
Autobuild-Date(master): Wed Sep 12 23:45:23 CEST 2012 on sn-devel-104
2012-09-12 23:45:22 +02:00
Andrew Bartlett
e8375ddf2d smbd: Add extra VFS hooks to get the posix ACL as a blob
This will allow us to hash this, rather than the NT ACL it maps to.
This will in turn allow us to know if the NT ACL is valid even if we
have to change the mapping code.

Andrew Bartlett

Autobuild-User(master): Andrew Bartlett <abartlet@samba.org>
Autobuild-Date(master): Wed Sep 12 07:06:01 CEST 2012 on sn-devel-104
2012-09-12 07:06:01 +02:00
Andrew Bartlett
6638d10366 smbd: Remove pre-allocation of ACL array in sys_acl_init()
Instead, this is just handled with realloc in sys_acl_create_entry()

This allows us to remove the size element from the SMB_ACL_T.

Andrew Bartlett
2012-09-12 05:26:16 +02:00
Andrew Bartlett
ac804f0d7f smbd-posix_acls: Use a IDL union to store the ACL entry
This is a clearer, long-term-stable structure we can hash without
risking it changing.

Andrew Bartlett
2012-09-12 05:26:16 +02:00