1
0
mirror of https://github.com/samba-team/samba.git synced 2025-03-09 08:58:35 +03:00

29348 Commits

Author SHA1 Message Date
Jeremy Allison
661f0ba73b Fix coverity #729. Resource leak in error path.
Jeremy.
2009-06-19 17:26:53 -07:00
Jeremy Allison
271d09f599 Fix coverity #740. Resource leak in error paths. We should
always return queue here as the caller will free.
Jeremy.
2009-06-19 17:20:00 -07:00
Jeremy Allison
d9eb1d9764 Fix coverity #900. Resource leak.
Jeremy.
2009-06-19 16:44:15 -07:00
Jeremy Allison
f262f80a1c Fix coverity #920. Possible NULL deref.
Jeremy.
2009-06-19 15:29:35 -07:00
Jeremy Allison
1e989dbb91 Fix coverity #676. Forward NULL.
Jeremy.
2009-06-19 14:55:00 -07:00
Michael Adam
8925778a61 s3: fix make test with external libtalloc or libtdb.
This skips the talloctort and tdbtorture tests when the
corresponding binaries are not present.
There might be more clever ways of detecting wether samba
has been linked with internal or external libraries, but
as a first approximation, this seems valid.

Michael
2009-06-19 21:13:38 +02:00
Michael Adam
23c7eccc27 s3:build: build talloctort only when using the internal liballoc
Fixes the build with the external libtalloc.
And is the reasonable thing to do anyways.

Michael
2009-06-19 21:13:38 +02:00
Michael Adam
bd70351b94 s3:build: build the tdb tools only when using the internal libtdb
This fixes the build when internal libtdb is used.

Michael
2009-06-19 21:13:38 +02:00
Michael Adam
e3c7720bfd s3:build: remove LIBTDB_OBJ from TDBTORTURE_OBJ collection
tdbtorture is linked with LIBTDB_LIBS, which is whatever
configure has determined to be (-ltdb or LIBTDB_OBJ ...).

Michael
2009-06-19 21:13:38 +02:00
Michael Adam
5ceda58b8d s3:build: check for availability of external libtdb and use it if available
Link internal libtalloc statiaclly if extenal libtalloc is not found
or does not have appropriate version.

Michael
2009-06-19 21:13:37 +02:00
Michael Adam
ec154a1d81 s3:build: link libtalloc statically if using internal libtalloc
Michael
2009-06-19 21:13:37 +02:00
Jim McDonough
7930f15f5d Don't require "Modify property" perms to unjoin bug #6481)
"net ads leave" stopped working when "modify properties"
permissions were not granted (meaning you had to be allowed
to disable the account that you were about to delete).

Libnetapi should not delete machine accounts, as this does not
happen on win32.  The WKSSVC_JOIN_FLAGS_ACCOUNT_DELETE flag
really means "disable" (both in practice and docs).

However, to keep the functionality in "net ads leave", we
will still try to do the delete.  If this fails, we try
to do the disable.

Additionally, it is possible in windows to not disable or
delete the account, but just tell the local machine that it
is no longer in the account.  libnet can now do this as well.
2009-06-19 13:46:07 -04:00
Volker Lendecke
0524d24fb2 Add a missing talloc_move() in tldap_search_recv 2009-06-19 17:37:30 +02:00
Volker Lendecke
8d1b81926d Fix Coverity IDs 922 and 933
In copy_internals(), if the !CAN_WRITE(conn) kicks in, we end up
dereferencing a NULL smb_filename.

This adds a simple protection around it.

Tim, please check!

Volker
2009-06-19 16:25:10 +02:00
Volker Lendecke
756f83796f Add tiny tldap test 2009-06-19 14:28:22 +02:00
Volker Lendecke
b9c99a2928 Add tldap_fetch_rootdse 2009-06-19 14:28:22 +02:00
Volker Lendecke
663e841ecd Make tevent_req_is_ldap_error public 2009-06-19 14:28:22 +02:00
Volker Lendecke
5cb6bf6f9d Add tldap_context_[gs]etattr
This adds the ability to attach extended information to a tldap_context. This
will become useful once we start to do automatic reconnects for example, a
callback function might want attach a pointer to credentials so that it can
rebind.

The initial user of this will be a cached rootdse, so that things like the
ability to do paged searches can be cached.
2009-06-19 14:28:22 +02:00
Björn Jacke
862ae382b8 s3:dmapi: prefer dmapi libs from gpfs over system libs
Patch from William Jojo sent to samba-technical:

This is based on some pain felt when building 32-bit and 64-bit Clustered Samba
on AIX with GPFS support.

Part of the problem lies in AIX only providing 32-bit shared object in
libxdsm.a(shr.o). So without libdmapi.a from gpfs.base, you get no DMAPI
support under 64-bit.
2009-06-19 11:56:33 +02:00
Volker Lendecke
5a9ca3db03 Fix bug 4699: Remove pidfile on clean shutdown 2009-06-18 16:17:57 -07:00
Jeremy Allison
31885822ae acl_group_override() doesn't need to call stat. Pass this
down from above (as const).
Jeremy.
2009-06-18 15:40:14 -07:00
Jeremy Allison
d2da9dee68 Add some const to the stat struct in the dosmode calls.
Fix a couple more unix_convert uses to filename_convert.
Fix bug in acl_group_override() where an uninitialized
struct could be used. Move unix_convert with wildcard
use in SMBsearch reply to boilerplate code.
Jeremy.
2009-06-18 15:07:14 -07:00
Jeremy Allison
34267482d5 Replace the boilerplate calls to :
resolve_dfspath() -> unix_convert() -> get_full_smb_filename() -> check_name()
with a new function filename_convert().
This restores the check_name() calls that had gone missing
since the default create_file was changed. All "standard"
pathname processing now goes through filename_convert().
I'll take a look at the non-standard pathname processing
next. As a benefit, fixed a missing resolve_dfspath()
in the trans2 mkdir call.
Jeremy.
2009-06-18 13:13:38 -07:00
Andrew Bartlett
33a59921be s3:netlogon Cope with recent rename in netlogon.idl 2009-06-18 15:00:28 +10:00
Slava Semushin
89e979fe99 Fix resource leak in lib/ldb/tools/ldbmodify.c
Patch for bug #6389
2009-06-18 13:49:26 +10:00
Slava Semushin
e0caf399e1 Fix syntax error in lib/ldb/ldb_sqlite3/base160.c
Patch for bug #6388
2009-06-18 13:49:26 +10:00
Tim Prouty
5eac92697e s3 onefs: Remove dfs resolution from create_file() now that it's being done at a higher level 2009-06-17 20:11:53 -07:00
Tim Prouty
4e3656b8d1 s3: Change SMB_VFS_OPEN to take an smb_filename struct
This was a little messy because of all of the vfs modules I had to
touch.  Most of them were pretty straight forward, but the streams
modules required a little attention to handle smb_filename.  Since the
use of smb_filename enables the vfs modules to access the raw,
over-the-wire stream, a little bit of the handling that was being done
by split_ntfs_stream_name has now been shifted into the individual
stream modules.  It may be a little more code, but overall it gives
more flexibility to the streams modules, while also allowing correct
stream handling.
2009-06-17 20:11:53 -07:00
Tim Prouty
5cfac1a1bd s3: Plumb smb_filename from create_file all of the way down to fd_open
I used the smb_filename struct everywhere that was feasible for the
first pass.  There are still some places in this path that need to be
changed to use smb_filename, but this is a good start.

I also:
- Removed fname/path arguments from a few functions that weren't
  really using them.
- Added a utility function for detecting whether an smb_filename is a
  stream.
2009-06-17 20:11:53 -07:00
Jeremy Allison
7d20e8f7f4 Fix bug #6476 - more then 3000 smbd-zombies in memory
We weren't reaping children in the [x]inetd case.
Jeremy.
2009-06-17 13:56:21 -07:00
David Markey
86450bd59c s3-net: Fix Bug #6328: support "net sam rights grant/revoke" with multiple rights.
David

Signed-off-by: Günther Deschner <gd@samba.org>
2009-06-17 18:42:34 +02:00
Karolin Seeger
c5580cafcb s3/i18n: Add Russian to the list.
Karolin
2009-06-17 14:37:28 +02:00
Karolin Seeger
e26de2dadc s3/i18n: Add Russian translation for SWAT messages.
Thanks to Yuri Kozlov <kozlov.y [at] gmail.com>!

This is part of a fix for bug #4755.
2009-06-17 14:33:33 +02:00
Günther Deschner
5a8483ea74 s3-net: Fix Bug #6328: allow multiple rights in "net sam rights grant".
Guenther
2009-06-17 12:40:28 +02:00
Karolin Seeger
f0930cef83 s3/i18n: Update German SWAT translations.
This is part of a fix for bug #4755.
Patch was provided (mainly) by Helge Kreutzmann <debian [at] helgefjell.de>.
Thanks!

Karolin
2009-06-17 12:17:45 +02:00
Karolin Seeger
095f66b0ed s3/libsmb: Fix typo in error message.
Thanks to Herb Lewis <hlewis [at] panasas.com> for noticing!

Karolin
2009-06-17 10:25:11 +02:00
Jeremy Allison
eae3745a3b Remove msdfs pathname processing from default create file.
No longer needed.
Jeremy
2009-06-16 17:42:41 -07:00
Jeremy Allison
9b30c5c145 Fix msdfs after the change to smb_filename struct. We must *always*
pull the pathname, then call resolve_dfspath(), before unix_convert().
Jeremy.
2009-06-16 17:23:54 -07:00
Jeremy Allison
cbb55b34e2 _lsa_EnumAccountRights and _lsa_EnumPrivsAccount can return an
empty set of privilages if the SID doesn't have any.
(From [MS-LSAD.pdf])
Jeremy.
2009-06-16 13:17:24 -07:00
Günther Deschner
29b8e08b83 s3-netapi: Fix Bug #6451: net/libnetapi user rename using wrong access bits.
Guenther
2009-06-16 15:00:20 +02:00
Günther Deschner
33be1f56f7 s3-netapi: Fix Bug #6305. Correctly prompt for a password when a username was given.
When no callback or wrapping has managed to get a password, prompt in the
netapi connection manager for a password.

Guenther
2009-06-16 12:13:53 +02:00
Günther Deschner
c033039e62 s3-netapi: add NetGetJoinInformation example code.
Guenther
2009-06-16 10:42:49 +02:00
Tim Prouty
537aa4cf51 s3 onefs: Fix reading over the end of the array, because the incorrect array was being read. 2009-06-15 14:11:39 -07:00
Tim Prouty
6f335036fd s3 onefs: Change onefs modules to use the new createfile api 2009-06-15 14:03:40 -07:00
Karolin Seeger
f92269a6ce s3/libsmb: Fix debug message.
This fixes bug #6472.

Karolin

Signed-off-by: Volker Lendecke <vl@samba.org>
2009-06-15 08:43:43 +02:00
Volker Lendecke
0c3580c5de Do a correct TALLOC_FREE in an error case 2009-06-15 07:48:50 +02:00
Volker Lendecke
49eccee209 Remove "winbindd_request" and "winbindd_response" from winbindd_cli_state
This shrinks the memory footprint of an idle client by 5592 bytes to 60 bytes
on my 32-bit box.
2009-06-14 22:22:10 +02:00
Volker Lendecke
97ba4f6efd Make winbindd_cli_state->response a pointer instead of a struct member
Same comment as in baa6084378e530b: This is just a preparatory checkin.

Volker
2009-06-14 22:22:10 +02:00
Volker Lendecke
90535b5fad Remove an unused struct member in winbindd_cli_state 2009-06-14 22:21:07 +02:00
Volker Lendecke
cd9919643b Fix an error message: We get the errno in "err" 2009-06-14 20:55:25 +02:00