1
0
mirror of https://github.com/samba-team/samba.git synced 2025-02-05 21:57:51 +03:00

3849 Commits

Author SHA1 Message Date
Tim Prouty
2738e31674 s4 torture: Move target macros to a common header instead of redefining them in multiple files 2009-12-01 11:12:51 -08:00
Matthias Dieter Wallnöfer
2d1bd87f73 s4:torture/raw/lock - Fix "discard const" warnings by introducing "discard_const_p"s 2009-12-01 16:48:47 +11:00
Matthias Dieter Wallnöfer
262d26d05a s4:torture/nbt/wins - Add more casts 2009-12-01 16:48:38 +11:00
Matthias Dieter Wallnöfer
58a5e764a9 s4:torture/nbench/nbench - Add a cast before "str_list_make_shell" 2009-12-01 16:48:22 +11:00
Matthias Dieter Wallnöfer
8b4499942e s4:torture/ldap/ldap_sort - Add some casts to suppress warnings 2009-12-01 16:48:14 +11:00
Volker Lendecke
6aef5e591f Fix bug 6546: Avoid accessing buf[-1] if NUL byte comes from fgets 2009-11-30 21:48:59 +01:00
Günther Deschner
8f6df5d3ec s4-smbtorture: more and stricter tests for printer and data keys in RPC-SPOOLSS.
Guenther
2009-11-27 23:16:21 +01:00
Andrew Tridgell
9f3ac810a6 s4-torture: fixed error code for s4 in SMB2-LOCK test
s4 returns NETWORK_NAME_DELETED if you attempt to use an invalid tree connection
for a lock. This test (correctly I think) happens before we validate the file handle.
That implies that when you pass both a closed handle and a invalid tree you
should get NT_STATUS_NETWORK_NAME_DELETED.
2009-11-27 19:42:11 +11:00
Andrew Tridgell
7359a22219 s4-torture: mark s4 as doing valid lock range tests on SMB 2009-11-27 19:42:10 +11:00
Andrew Tridgell
f6ecb4efb0 s4-torture: fixed expected error codes for s4 in SMB2-LOCK
I think the error/success codes returned by windows for these tests
are quite bogus. The ones s4 gives are much more reasonable. The
locking ones returning NT_STATUS_SUCCESS could lead to data loss, as
an application thinks it has a file locked correctly when it fact it
doesn't, so it could do an unsafe modify.
2009-11-27 16:05:06 +11:00
Andrew Tridgell
0920e0b63b s4-drstest: don't use getenv("LDB_URL") in test suites
I was stumped for a while as to why the drs test suite was failing for
me. It turned out that it looked for LDB_URL in the environment, and
used it if set. I had it set in my terminal, and it was happily
munching on my sam.ldb while testing. Quite a cute bug really :-)
2009-11-27 16:05:06 +11:00
Andrew Tridgell
056473d588 torture: fixed SMB2-LOCK valgrind error 2009-11-27 16:05:05 +11:00
Günther Deschner
60419a0eb7 s4-smbtorture: refactor RPC-SAMR-LARGE-DC test a little more.
Guenther
2009-11-26 01:45:35 +01:00
Günther Deschner
d22eb75a13 s4-smbtorture: add torture_samr_context to carry some RPC-SAMR-X specifics.
Guenther
2009-11-26 01:45:35 +01:00
Steven Danneman
f66612f62e s4/torture: port SMBv1 RAW-LOCK tests to SMBv2
RAW-LOCK ported as:

RAW-LOCK-LOCK, RAW-LOCK-LOCKX -> SMB2-LOCK-LOCK
RAW-PIDHIGH -> removed, no longer relevant
RAW-ASYNC -> SMB2-LOCK-ASYNC, SMB2-LOCK-CANCEL, SMB2-LOCK-CANCEL-TDIS, SMB2-LOCK-CANCEL-LOGOFF
RAW-ERRORCODE -> SMB2-LOCK-ERRORCODE
RAW-CHANGETYPE -> removed, no longer relevant
RAW-ZEROBYTELOCKS -> SMB2-LOCK->ZEROBYTELENGTH
RAW-UNLOCK -> SMB2-LOCK-UNLOCK
RAW-MULTIPLE_UNLOCK -> SMB2-LOCK-MULTIPLE-UNLOCK
RAW-STACKING -> SMB2-LOCK-STACKING

BASE-LOCK ported as:

BASE-LOCK-LOCK1 -> SMB2-LOCK-ERRORCODE, timeout is no longer relevant
BASE-LOCK-LOCK2 -> SMB2-LOCK-CONTEND, SMB2-LOCK-LOCK, SMB2-LOCK-CONTEXT
BASE-LOCK-LOCK3 -> SMB2-LOCK-RANGE
BASE-LOCK-LOCK4 -> SMB2-LOCK-OVERLAP
BASE-LOCK-LOCK5 -> SMB2-LOCK-STACKING
BASE-LOCK-LOCK6 -> SMB2-LOCK-CANCEL, change_locktype no longer relevant
BASE-LOCK-LOCK7 -> SMB2-LOCK-RW-SHARED, SMB2-LOCK-RW-EXCLUSIVE
2009-11-25 12:55:48 -08:00
Steven Danneman
7f14388721 s4/libcli: rename previously reserved field in SMB2 LOCK struct
The lock.in.reserved field has been renamed lock_sequence in the
SMB 2.1 dialect.  See MS-SMB 2.2.26.
2009-11-25 12:55:48 -08:00
Tim Prouty
b6f972222f s4 torture: Change RAW-OPLOCK to use the documented version of SET_END_OF_FILE_INFO
The passtrhough version of SET_END_OF_FILE_INFO is tested in
RAW-SFILEINFO-END-OF-FILE.

Additionally, the first opener is changed to use SHARE_WRITE for the
share mode since SET_END_OF_FILE_INFO actually writes data to the file
via truncating/extending.
2009-11-25 08:45:58 -08:00
Tim Prouty
98f595036e s4 torture: Allow onefs to be checked like samba3 and samba4
This is needed for the new RAW-SFILEINFO-END-OF-FILE test to
differentiate what appears to be a windows bug.
2009-11-25 08:45:15 -08:00
Tim Prouty
6074a058df s4 torture: Add two new setfileinfo tests
These tests expose a potential bug in winXP, win7, and likely others.
There is also a bug in samba where share modes aren't being enforced
where they should.

For more details see:
http://lists.samba.org/archive/cifs-protocol/2009-November/001130.html
2009-11-25 08:45:14 -08:00
Tim Prouty
ce9ac3a685 s4 torture: Split up the torture suite setup for RAW-SFILEINFO
A side effect of this change is that RAW-SFILEINFO now runs the whole
suite instead of just the first test.  I changed the name of the first
test to RAW-SFILEINFO-BASE and changed all of the selftest scripts
that call it.
2009-11-25 08:45:14 -08:00
Stefan Metzmacher
23d81904eb RAW-PING-PONG: use timeval_current/timeval_elapsed instead of start_timer/end_timer
metze
2009-11-24 11:47:31 +01:00
Kamen Mazdrashki
65e95b8aa9 s4/drs(tort): DSSYNC test to print what is different in drs_msg also 2009-11-23 14:15:05 +01:00
Günther Deschner
0608d6b125 s4-smbtorture: fix spoolss_EnumPrinterKey client in RPC-SPOOLSS-WIN.
Guenther
2009-11-23 13:35:32 +01:00
Günther Deschner
d66b7d80d5 s4-smbtorture: add tests for spoolss_EnumPrinterKey to RPC-SPOOLSS-PRINTER.
Guenther
2009-11-23 12:17:54 +01:00
Matthias Dieter Wallnöfer
e406c17b2f s4:torture/smb2/oplock - Remove unneeded "status" redeclarations 2009-11-21 17:37:42 +01:00
Matthias Dieter Wallnöfer
ec49360778 s4:torture/smb2/notify - Rename nested "fname" variable to prevent warnings 2009-11-21 17:37:41 +01:00
Matthias Dieter Wallnöfer
5dc478e390 s4:torture/raw/unlink - Remove unused variable and label 2009-11-21 17:37:40 +01:00
Matthias Dieter Wallnöfer
28423114ec s4:torture/rpc/netlogon - Fix uninitialised variable 2009-11-21 17:37:39 +01:00
Stefan Metzmacher
c2a29967ea SMB2-LOCK: make use of torture_assert_*()
This is needed in order to mark tests as known failures.

metze
2009-11-18 08:24:13 +01:00
Stefan Metzmacher
63ff7a8db1 s4:torture/test_gentest.sh: make use of the PREFIX argument
We should not use hardcode pathes!

metze
2009-11-18 06:50:24 +01:00
Aravind Srinivasan
15d93a5d8e s4/torture: Port SMBv1 Change Notify tests to SMBv2
* Ported all tests from raw/notify.c to smb2/notify.c
* Parameterized the max_buffer_size so it can be set on a
  per-target basis.
* Fixed CHECK macros to use torture_result
* Created a SMB2-NOTIFY test suite
2009-11-17 17:06:26 -08:00
Steven Danneman
c14b0cea48 torture/smb2: make SMB2 BRL tests pass against W2K8R2
The BRL tests previously based their results off several bugs in the
W2K8 byte range lock code.  I've fixed up the tests to pass against
Win7 which has fixed these bugs, and assume that the Win7 behavior
is the default.

I have inverted the test behavior for >63-bit lock requests.  The
tests previously expected NT_STATUS_OK as their default in this
case.  I've changed that default to expect STATUS_INVALID_LOCK_RANGE.
This may requires some changing of make test to compensate.

I've also removed a few test scenarios from VALID-REQUEST in preparation
of replacing them with separate tests ported from RAW-LOCK.
2009-11-17 17:06:26 -08:00
Kamen Mazdrashki
b9e262c512 s4/drs(tort): Convert DSSYNC test to a test case fixture
Now it should be much more clear why and where a test
in DSSYNC test case has failed.

Signed-off-by: Andrew Bartlett <abartlet@samba.org>
2009-11-17 10:47:16 +11:00
Kamen Mazdrashki
442cded430 s4/drs(tort): replace DEBUG with torture_asert/comment/fail
I left dumping of decrypted attributes values 'as is'
(using DEBUG and DEBUGADD) as it uses dump_data() function.
dump_data() uses DEBUGADD internally, so I have no way
to redirect its output to torture_context at this point.

Signed-off-by: Andrew Bartlett <abartlet@samba.org>
2009-11-17 10:47:05 +11:00
Kamen Mazdrashki
aaff29f5b4 s4/drs(tort): use torture_drsuapi_assert_call() macro for error checking
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
2009-11-17 10:46:59 +11:00
Kamen Mazdrashki
673049142b s4/drs(tort): replace 'printf' with 'torture_...' calls
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
2009-11-17 10:46:48 +11:00
Kamen Mazdrashki
9e4beef614 s4/drs(tort): 'DsSyncBindInfo.pipe' renamed - 'pipe' is a system call
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
2009-11-17 10:46:42 +11:00
Kamen Mazdrashki
b0de573629 s4/drs(tort): 'DsPrivate.pipe' renamed - 'pipe' is a system call
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
2009-11-17 10:46:28 +11:00
Andrew Bartlett
b13518e4e8 s4:dsdb With these workarounds, we now pass the RPC-DSSYNC test 2009-11-17 10:38:09 +11:00
Andrew Bartlett
39b8f31d66 s4:dsdb Load objectGUID and extended DN defaultObjectCategory into the schema
The load of defaultObjectCategory as an extended DN means we need to
use the common parsing functions I just split out, rather than the
GET_DS_DN macro.

The objectGUIDs are loaded so that we can create the extended DN when
we load from LDIF (and are loaded for the other cases for
consistency).

Also adapt callers to API changes needed for common parsing code

Andrew Bartlett
2009-11-17 10:38:02 +11:00
Andrew Tridgell
c8884e1cf2 s4-ldb: changed the DN checks for \n to warnings
a \n is sometimes allowed in AD (eg in deleted DNs). Until we know
when is really is allowed, treat it as a warning only.
2009-11-13 19:32:47 +11:00
Andrew Bartlett
95a12cdf21 s4:torture Use (some) torture_assert() calls in RPC-DSSYNC test 2009-11-12 16:34:23 +11:00
Andrew Bartlett
06b234e811 s4:torture Remove _drs_util_verify_attids() from RPC-DSSYNC
I'm satisfied that the task this test does is already done by the time
we map the incoming schema, and process the objects.  If we have the
OID mapping wrong or incomplete, we will get any errors this test
found errors there.

(And this dramaticly reduces the test time, so we can now add
RPC-DSSYNC to 'make test').

Andrew Bartlett
2009-11-12 16:34:18 +11:00
Andrew Bartlett
6d1e60987b s4:torture/dsdb Add verification of the push-to-LDB functions in RPC-DSSYNC
This is done by comparing the values against the remote host's LDAP
server.

Andrew Bartlett
2009-11-12 16:34:17 +11:00
Andrew Bartlett
30a08005ca s4:torture Add const 2009-11-12 16:34:16 +11:00
Andrew Bartlett
87e984f0bd s4:torture Convert RPC-DSSYNC test to use LDB rather than raw LDAP
(This should make it easier to do more 'compare DRS with LDAP'
operations, as LDB is an easier interface to program.)

Andrew Bartlett
2009-11-12 16:34:13 +11:00
Stefan Metzmacher
1012b806a7 NET-API-BECOME-DC: resolve the host name to an address before calling
libnet_BecomeDC and libnet_UnbecomeDC()

We're supposed to pass in source_dsa_address...

metze
2009-11-12 16:34:12 +11:00
Andrew Bartlett
2a601719f2 s4:dsdb Add expected value tests for most DRS syntax conversions
I've left out those for which I could not find an expected value in my
default Windows 2003 server's database, and the values that rely on
the current prefix map at the time.

Andrew Bartlett
2009-11-12 16:34:12 +11:00
Andrew Bartlett
df7546ac16 s4:dsdb/repl Split the 'convert' or 'commit' stages in the DRS import
This will allow us in future to do tests on the LDB values we generate
from the DRS replication.

Andrew Bartlett
2009-11-12 16:34:10 +11:00
Andrew Bartlett
d6563801d1 s4:dsdb/schema Simplify schema loading from ldb messages
It turns out that we always add the class/attribute to the schema.
2009-11-12 16:34:09 +11:00