1
0
mirror of https://github.com/samba-team/samba.git synced 2025-03-03 12:58:35 +03:00

27854 Commits

Author SHA1 Message Date
Günther Deschner
669617036e s3-spoolss: fix vista fallback in _spoolss_AddPrinterDriverEx.
Martin Zielinski, if you're reading this, please have a look. Vista nicely takes
just a WERR_UNKNOWN_LEVEL here and retries with a level 6 add.

Guenther
2009-02-19 19:27:07 +01:00
Günther Deschner
38fde6d5d9 s3-spoolss: remove old spoolss_AddPrinterDriver{Ex}.
Guenther
2009-02-19 19:26:54 +01:00
Günther Deschner
0470feeb7f s3-spoolss: use pidl for _spoolss_AddPrinterDriver{Ex}.
Guenther
2009-02-19 19:26:44 +01:00
Günther Deschner
c71fa39c29 s3-spoolss: remove old spoolss_GetPrintProcessorDirectory.
Guenther
2009-02-19 19:23:51 +01:00
Günther Deschner
286ec6847b s3-spoolss: use pidl for _spoolss_GetPrintProcessorDirectory.
Guenther.
2009-02-19 19:21:57 +01:00
Günther Deschner
8c569b59f0 s3-rpcclient: use rpccli_spoolss_GetPrintProcessorDirectory in rpcclient.
Guenther
2009-02-19 19:21:48 +01:00
Günther Deschner
e9c42e3c21 s3-spoolss: fix _spoolss_GetPrinterDriverDirectory.
treat architecture correctly as it is a [unique] pointer, and newer
Windows versions sometimes send in an empty string.

Guenther
2009-02-19 19:20:19 +01:00
Günther Deschner
ebb3b30700 s3-rpcclient: use SPOOLSS_ARCHITECTURE_NT_X86 define in spoolss getdriverdir cmd.
Guenther
2009-02-19 19:20:07 +01:00
Günther Deschner
0038acb20d s3-spoolss: _spoolss_OpenPrinterEx needs to wipe out policy handle upon failure.
Guenther
2009-02-19 19:19:59 +01:00
Günther Deschner
bcb5331fa7 s3-spoolss: _spoolss_AddPrinterEx needs to wipe out policy handle upon failure.
Guenther
2009-02-19 19:19:50 +01:00
Volker Lendecke
d0ee90ace9 Fix a buffer handling bug when adding lots of registry keys
This is *ancient*... From 2002, and nobody noticed until someone added lots of
shares using net conf... :-)
2009-02-19 14:26:50 +01:00
Günther Deschner
e9d5405948 s3-libnet: fix coverity #848 (UNINIT).
Guenther
2009-02-19 13:01:59 +01:00
Stefan Metzmacher
7082e4526f s3:librpc/ndr: if uninitialized variable in string_array code
metze
2009-02-19 11:13:34 +01:00
Zack Kirsch
96b3242f12 s3 OneFS: Fixes "inherit permissions" and "nt acl support" for Onefs. 2009-02-19 00:15:44 -08:00
todd stecher
59d21afa83 S3: Dumb down debug spew in perfcount module code 2009-02-19 00:01:41 -08:00
todd stecher
fdcd5a3a20 S3: Make changes to perfcount API set for when a single request leads to multiple replies
(e.g. reply_echo). Change test and onefs modules to match new api set (thanks Volker!).
2009-02-19 00:01:00 -08:00
Tim Prouty
ab025bf0fe s3: Fix bug opening streams with truncating disposition
Do not attempt to delete streams on a truncating open, if the name
we're opening is itself a stream.

Port 176e8857203944bc332844b700749120ce90c891 to standard open path
2009-02-18 23:48:35 -08:00
Zack Kirsch
053e1873c5 s3: OneFS: Pass in the client's fnum to the ifs_cbrl syscall. 2009-02-18 20:50:05 -08:00
Aravind Srinivasan
176e885720 s3: Fix OneFS bug opening streams with truncating disposition
Do not attempt to delete streams on a truncating open, if the name we're
opening is itself a stream
2009-02-18 20:50:05 -08:00
Aravind Srinivasan
8e8aa27e1b s3: Fix streams enumeration bug in OneFS implementation
Previously, we didn’t call SMB_VFS_OPEN_DIR from the streams module,
instead we called fdopendir(). As a result we failed to populate the
dir_state list in the readdirplus module. So when we tried to view the
stream data, we will always returned NULL.

To solve this I separated onefs_opendir() and the initialization of
the dir_state list. This is done by introducing a new utility function
“onefs_rdp_add_dir_state()”, which initializes the dir_state structure
and adds it to the dir_state list.  This function is called from the
streams module before calling readdir().
2009-02-18 20:49:31 -08:00
todd stecher
c19214424b S3: Log warning in smbstatus about lack of pid in anonymous mode. 2009-02-18 18:08:33 -08:00
todd stecher
03421944b2 S3: Stop creating SMBD cores when failing to create a pipe.
This was uncovered when the MAX FD limit was hit, causing an instant core
and invoking error reporting. This fix causes SMBD to exit, but without
building a core.
2009-02-18 18:08:33 -08:00
todd stecher
c441f58ded S3: Allow SMBD processes to survive in low memory condidtions
This commit adds a configure argument which allows for setting MADV_PROTECT
in the madvise() API.  With this enabled the kernel won't kill SMBD when
it's running low on memory.
2009-02-18 18:08:32 -08:00
Günther Deschner
cdcd525a05 s3-spoolss: remove old spoolss_GetPrinterDriverDirectory.
Guenther
2009-02-19 02:07:58 +01:00
Günther Deschner
3b3ab50c05 s3-spoolss: use pidl for _spoolss_GetPrinterDriverDirectory.
Guenther
2009-02-19 02:06:57 +01:00
Günther Deschner
aaec578c51 s3-rpcclient: use rpccli_spoolss_GetPrinterDriverDirectory in rpcclient.
Guenther
2009-02-19 02:06:12 +01:00
Günther Deschner
8dbb1d63e5 s3-spoolss: add support for "AddPort" via _spoolss_XcvData for Vista.
Guenther
2009-02-19 00:56:07 +01:00
Volker Lendecke
c5cc27c493 Interesting C compiler you have there... :-) 2009-02-19 00:52:34 +01:00
Jeremy Allison
c9295c93d1 Fix coverity CID-602. Possible use of uninitialized var.
Jeremy.
2009-02-18 15:45:49 -08:00
Günther Deschner
1cd34565d0 s3-spoolss: remove old spoolss_XcvData.
Guenther
2009-02-18 16:12:27 +01:00
Günther Deschner
7312342062 s3-spoolss: use pidl for _spoolss_XcvData.
Guenther
2009-02-18 16:11:01 +01:00
Jeremy Allison
0281166bb9 Don't miss an absolute pathname as a kerberos keytab path. From Glenn Machin <gmachin@sandia.gov>.
Jeremy.
2009-02-17 15:54:33 -08:00
Jeremy Allison
fab0baeed1 Fix bug #6117 - Samba 3.3.0: pdbedit -a core dumps.
Jeremy.
2009-02-17 13:43:58 -08:00
Jeremy Allison
3737b758d6 Fix warning about missmatch of uint32_t and size_t.
Jeremy.
2009-02-17 13:18:10 -08:00
Michael Adam
2feaaa885a s3:winbindd: make do_async_domain() static.
Michael
2009-02-17 18:21:53 +01:00
Michael Adam
08bef5bba0 s3:build: improve the check for a working krb5-config.
Not only check if it exists and is executable, but also
check whether it accepts the command line "krb5-config --libs gssapi".

Chris Hoogendyk <hoogendyk@bio.umass.edu> has reported configure
failing on a Solaris machine due to krb5-config raising errors on
these options.

Michael
2009-02-17 18:21:52 +01:00
Günther Deschner
df17774412 s3-spoolss: remove old spoolss_ResetPrinter.
Guenther
2009-02-17 10:52:32 +01:00
Günther Deschner
ce71a7c9a7 s3-spoolss: use pidl for _spoolss_ResetPrinter.
Guenther
2009-02-17 10:52:31 +01:00
Günther Deschner
dc7f04aac7 s3-netapi: fix Coverity #881 and #882.
Guenther
2009-02-17 10:21:22 +01:00
Volker Lendecke
ea192f08e6 Fix an invalid typecasting
entry->num_of_strings is a uint16_t. Casting it with

(int *)&entry->num_of_strings

is wrong, because it gives add_string_to_array the illusion that the object
"num" points to is an int, which it is not.

In case we are running on a machine where "int" is 32 or 64 bits long, what
happens with that cast? "add_string_to_array" interprets the byte field that
starts where "num_of_strings" starts as an int. Under very particular
circumstances this might work in a limited number of cases: When the byte order
of an int is such that the lower order bits of the int are stored first, the
subsequent bytes which do not belong to the uint16_t anymore happen to be 0 and
the result of the increment still fits into the first 2 bytes of that int, i.e.
the result is < 65536.

The correct solution to this problem is to use the implicit type conversion
that happens when an assignment is done.

BTW, this bug is found if you compile with -O3 -Wall, it shows up as a warning:

rpc_server/srv_eventlog_lib.c:574: warning: dereferencing type-punned pointer
	will break strict-aliasing rules

Thanks,

Volker
2009-02-17 10:20:55 +01:00
Günther Deschner
046cb24d0a s3-rpcclient: use rpccli_spoolss_RemoteFindFirstPrinterChangeNotifyEx.
Guenther
2009-02-17 03:51:50 +01:00
Yasuma Takeda
e32f946114 Fix bug 5920
The length of the memcpy was calculated wrong, r->out.return_authenticator is
a pointer
2009-02-16 14:08:39 +01:00
Stefan Metzmacher
fe417b29bd s3:netlogon: implement _netr_LogonGetCapabilities() with NT_STATUS_NOT_IMPLEMENTED
This hopefully fixes bug #6100.

metze
2009-02-16 11:34:35 +01:00
Zach Loafman
8e19a28805 s3 auth: Add parameter that forces every user through an NSS lookup
When set to yes, "force username map" forces every user, even AD
users, through an NSS lookup. This allows the token to be overridden
with information from NSS in certain broken environments.
2009-02-16 00:29:21 -08:00
Tim Prouty
57a31ef203 s3 perfcount: Fix segfault with smbclient 'echo 3 foo' 2009-02-16 00:29:20 -08:00
Tim Prouty
6bd7e2b097 s3 OneFS: Add defaults to the fake timestamp parameters 2009-02-16 00:29:20 -08:00
Tim Prouty
dea223ba79 make receive_smb_raw_talloc more readable 2009-02-16 00:29:20 -08:00
Jeremy Allison
9a5d5cc1db Attempt to fix bug #6099. According to Microsoft
Windows 7 looks at the negotiate_flags
returned in this structure *even if the
call fails with access denied ! So in order
to allow Win7 to connect to a Samba NT style
PDC we set the flags before we know if it's
an error or not.
Jeremy.
2009-02-15 18:12:20 -08:00
Derrell Lipman
f608588ea3 remove accidental white space 2009-02-14 22:29:28 -05:00
Derrell Lipman
a796832683 enums are traditionally signed. Avoid use of high bit in bit flags. 2009-02-14 22:29:11 -05:00