1
0
mirror of https://github.com/samba-team/samba.git synced 2025-02-09 09:57:48 +03:00

1112 Commits

Author SHA1 Message Date
Andrew Bartlett
677838b999 Give volker a hand, and let domain joins with existing user accounts work
a bit better.

This just sets the minimum possible attributes - if we are 'upgrading' an
LDAP based user account, the attributes will be there anyway.  This matches
NT pretty well to.

This also fixes some use of unitialised values in the desired_access checking.
(found by valgrind).

Andrew Bartlett
(This used to be commit 929213ff2a5829ba8435ba1be0de317bca1e0da0)
2003-03-21 13:28:06 +00:00
Jeremy Allison
c8eed69be0 lib/messages.c: Check return from chainlock before modifying message queue.
Apply the job returned limit across all requests for job queues.
Jeremy.
(This used to be commit dee1326a1d8a0bf8977df22a0fe014dd5d8dc769)
2003-03-20 00:51:41 +00:00
Jelmer Vernooij
47ea3a2bf2 Put in the new modules system. It's now used by passdb and rpc. I will
put a doc about it in dev-doc later today.
(This used to be commit af7bfee0c6902c07fdb8d3abccf4c8d6bab00b5a)
2003-03-19 18:45:19 +00:00
Jeremy Allison
736c753841 Ensure dev in make_connection is const.
Jeremy.
(This used to be commit e8155fade61e9dc308a82f442453803160c36806)
2003-03-18 23:51:18 +00:00
Andrew Bartlett
7b18c5d164 Make sure we mark the assumption of a fstring parameter for 'devicetype'
in the function prototype, and change callers to respect this.

Andrew Bartlett
(This used to be commit 9f3d3c380120f16d76d68f346799282d61eec892)
2003-03-16 13:24:36 +00:00
Andrew Bartlett
04858cd702 Limit the number of SIDs that may be looked up, in line with existing code
for name->sid.
(This used to be commit 0ebccc0dbeecc10d423529909a2563fbc3bf9857)
2003-03-07 09:29:56 +00:00
Gerald Carter
03a4c1907f * always report ourselves as a Windows 2000 print server (even
without ADS support)
* add "MinorVersion" print server data key and comment on "OSVersion"
(This used to be commit 342734e3de71c7dc8e3d24fd66dae58cf647a569)
2003-03-03 17:33:57 +00:00
Gerald Carter
21be9e7776 * CR1868: only send a change notify message if we have something
that changed that the client is monitoring.

* couple of comments abnout how we need to validate driver names
  on SetPrinter() and AddPrinter()

* up the debug level on some overly verbose dev mode parsing messages
(This used to be commit 7377d671e8a95ac2ab0452f564b18b2a098699cb)
2003-03-03 16:34:19 +00:00
Jeremy Allison
e2366787ae Added limit to number of jobs enumerated. Set to 0 (means no limit).
Yes I will add the docs....
Jeremy.
(This used to be commit 4a739d914bb87a3c8d071dfd0f275a9aab1cf90a)
2003-03-01 02:39:14 +00:00
Gerald Carter
97e7d2ffae additional fix for CR 601
* distinguish WinXP from Win2k
  * add a 1/3 of a second delay in OpenPrinter
    in order to trigger a LAN/WAN optimization in
    2k clients.
(This used to be commit 96570699d1b715f47c35aa211da6ec18f6fc4109)
2003-02-27 21:21:02 +00:00
Gerald Carter
7c7d796b6d Progress on CR 601
cache the printer_info_2 with the open printer handle.
cache is invalidated on a mod_a_printer() call **on that smbd**.

Yes, this means that the window for admins to step on each other
from different clients just got larger, but since handles a generally
short lived this is probably ok.
(This used to be commit 33c7b7522504fb15989f32add8e9a087c8d9d0fa)
2003-02-25 20:51:23 +00:00
Gerald Carter
3d730f89cf i patched the wrong branch! s/unistr2_to_dos/unistr2_to_ascii/
(This used to be commit 513fb2ddd85a74de7684a6cb09d57011af69161f)
2003-02-21 20:00:46 +00:00
Gerald Carter
ab985b983f couple of merges from APP_HEAD
* performance optimization in enumprinterdataex() when keyname is empty
  * fix a few typos in comments
  * reload services after addprinter_command()

dump registry data in ascii when the key is REG_SZ or REG_MULTI_SZ
(This used to be commit fde6ef7cc62c58d512dc8053b214f0a3c59a78ab)
2003-02-21 17:08:43 +00:00
Tim Potter
9383d61f6c Fixed compiler warning.
(This used to be commit b3f9cf8c1c293e905a536dfa5bb6a827627b7024)
2003-02-21 04:47:24 +00:00
Jelmer Vernooij
8d8a8c9633 Make init_module() and thus smb_load_module() return an int.
modules/developer.c: init_module() should return an int
(This used to be commit 7f59703550378ff2333e3c851bf1a77037510abd)
2003-02-20 22:26:28 +00:00
Jelmer Vernooij
c536b88b2b Use the new modules stuff to load dynrpc modules. Basically this means:
- calling the initialization function in the module init_module() instead of rpc_pipe_init()
- calling smb_load_module() to do the dlopen(), dlsym() and init_module() calls

I'll merge this to 3.0, together with the smb_load_module() function.

Discussed with Anthony.
(This used to be commit 3757ed8df06ca2b306bef336bdb9c7671f5e6a65)
2003-02-18 18:34:48 +00:00
Gerald Carter
336ae66c5a set the various DsSpooler keys that are linked to PRINTER_INFO_2 fields; CR 985
(This used to be commit 9a4b7a86fdaab04328b5017c1dd42480753a9a10)
2003-02-18 03:43:08 +00:00
Andrew Bartlett
cc0202884b This patch fixes one of my longest-standing pet hates with Samba :-).
When we look see if a user is in a list, and we try to 'expand' an @group, we
should lookup the user's own list of groups, rather than looking for all the
members of a group.

I'm sure this will fix some nasty performance issues, particularly on large
domains etc.  In particular, this avoids contacting winbind at all, if the
group is not a winbind group.

(This caused a deadlock on my winbind-on-PDC setup).

The groups list always includes the user's primary group, as per the
getgrouplist manpage, and my recent changes to our implementation.

Andrew Bartlett
(This used to be commit 9be21976f7662ebe6eb92fff7cecbdb352eca334)
2003-02-17 12:27:34 +00:00
Gerald Carter
a703d55cd7 * set PRINTER_ATTRIBUTE_RAW_ONLY; CR 1736
* never save a pointer to an automatic variable (they go away)
  implement a deep copy for SPOOLSS_NOTIFY_MSG to correct
  messages being sent that have junk for strings;
  fix in response to changes for CR 1504
(This used to be commit 043b9dff22e909fc290c34d879cad8b4c980fc13)
2003-02-15 23:36:18 +00:00
Jeremy Allison
4cd6e31bd3 Ensure that only parse_prs.c access internal members of the prs_struct.
Needed to move to disk based i/o later.
Jeremy.
(This used to be commit 4c3ee228fcdb089eaeead95e79532a9cf6cb0de6)
2003-02-14 23:04:03 +00:00
Jeremy Allison
db937d3965 Removed unused variable.
Jeremy.
(This used to be commit c9654c8ec71903c59ff5f66c3fd6ea1baa599133)
2003-02-13 19:42:50 +00:00
Jeremy Allison
f4092b90bf Merge JohnR's patch.
Removed extra copy of server name in the printername field (it was
mangling the the name to be \\server\\\server\printer ... yes, there
were 3 backslashes) reported by get & enum jobs level 2.
Jeremy.
(This used to be commit d079edf7327acba7f00b5868e7e6ce91ddc1eb14)
2003-02-13 06:52:45 +00:00
Andrew Tridgell
faf30e69ae initial server side privileges implementation, using a tdb. This needs to be hooked into pdb, and we need some access control on changing privileges. That's next
(This used to be commit f4f1f84a6bf1d356ccc83f0ecb135bef4a39619e)
2003-02-12 09:14:35 +00:00
Andrew Tridgell
8ddccd47c7 added server stubs for lsa_enum_acct_with_right
(This used to be commit aa2abacaf48924797b6803786c14c9f303185e4a)
2003-02-11 21:55:48 +00:00
Andrew Tridgell
b4776d89ea added the LSA privileges server backend stubs. Right now they just log
what was requested.
(This used to be commit 64ac6c2bcb729c4658de48e929cc792681903ecc)
2003-02-06 05:42:19 +00:00
Jeremy Allison
56060dcf9e Fixed type.
Jeremy.
(This used to be commit ae635bb6ec05ded8a36d7876be8f3e1b8475e35b)
2003-02-05 22:09:32 +00:00
Andrew Bartlett
28e3e48431 Send the user's session key in the SAMLOGON reply, so that a member server can
use smb signing.

Andrew Bartlett
(This used to be commit 574e8a8ab7c94ecd9113df42e395e83632980675)
2003-02-02 05:10:26 +00:00
Gerald Carter
2bdcf68ab6 don't free() auto variables; fixes segfault when looking up RefusePasswordChange registry value
(This used to be commit d89b0bff44fe31244b1835aee0c96c4900d90dc6)
2003-01-21 03:42:38 +00:00
Gerald Carter
52b65f70ca strip any trailing \'s from reg key names in an open
(This used to be commit 03807cd56429e167ca8f3c003a4468461ecb854b)
2003-01-19 05:04:20 +00:00
Jim McDonough
e2f2558753 Fix some debug levels (were set to 0 with RPC module patch), and
change one fprintf(stderr,...) to DEBUG.
(This used to be commit 77f8913977343023f8ce123c305dcffc7463357b)
2003-01-18 20:41:19 +00:00
Gerald Carter
8c6790b6f0 removing extra debug statement
(This used to be commit 657f8c25a585a02b86f4021e38641ee896f098d2)
2003-01-18 01:41:00 +00:00
Jim McDonough
9eb368e068 Enable dynamic loading of RPC modules. See docs/textdocs/RPC_PLUGGIN.txt for instructions.
(This used to be commit d51e12df78ff8fc721d693fedbd1c633f39edd49)
2003-01-17 20:57:26 +00:00
Jeremy Allison
074c99a852 Fix reference count bug where smbd's would not terminate with no
open resources.
Jeremy.
(This used to be commit 0173d6fe164568a73247fa542895443fad6c20c3)
2003-01-17 06:35:33 +00:00
Andrew Tridgell
96c795cea7 reverted this patch till I sort out the craziness with UNIHDR
(This used to be commit e3d00fa47d38cd214f5e350e1d6b30d90ed8a52c)
2003-01-17 06:15:18 +00:00
Andrew Tridgell
ec879eacc2 This removes the 3rd argument from init_unistr2(). There were 240
calls to init_unistr2() in the code and every one of them got the 3rd
argument incorrect, so I thought it best just to remove the argument.

The incorrect usage was caused by callers using strlen() to determine
the length of the string. The 3rd argument to init_unistr2() was
supposed to be the character length, not the byte length of the
string, so for non-english this could come out wrong.

I also removed the bogus 'always allocate at least 256 bytes'
hack. There may be some code that relies on this, but if there is then
the code is broken and needs fixing.
(This used to be commit b9eff31b1433c81fbff733e194914a40f25e3bda)
2003-01-17 04:58:45 +00:00
Gerald Carter
5fb5950258 small merges from SAMBA_3_0; mostly typos, renames, etc...
(This used to be commit 9ac196dad4893b0ceef13281a140be5d85391e6c)
2003-01-15 18:31:46 +00:00
Andrew Bartlett
1fdaca3342 The last of the fstring/pstring mixups, and an extra 'static'.
(This used to be commit b328b67fd8fd605636ed58ffd33cf5be3d480672)
2003-01-14 06:46:14 +00:00
Andrew Bartlett
183ccefce7 A couple more pstcpy/fstrcpy mixups - doing an fstrcpy into a pstring is
harmless, but breaks my automated check.
(This used to be commit e5d2b1f6c3c0883054f4e0eab2cac958706a790d)
2003-01-14 06:36:40 +00:00
Gerald Carter
27b05b4df9 typo from merge
(This used to be commit 1f33b4acb32c5461b9249d3786ea5fc6898e5f18)
2003-01-11 02:36:13 +00:00
Gerald Carter
47873e781d [merge] make sure to updatre print queue cache during timeout_processing() to send notify events; CR 1491
(This used to be commit 142c5029c701e7a82074e301278846c02843f46f)
2003-01-11 02:29:23 +00:00
Gerald Carter
6df2dc56ff a 0 length printer data value is not a memory allocation error; fix CR601
(This used to be commit 3442c270f1bc67890f4e2de3386fcfdec610170d)
2003-01-09 19:51:28 +00:00
Andrew Bartlett
ff18825765 We already have one function to move unistr2 -> multibyte-static, so we
don't need a second just for pdb.

Also, remove magic 'is lp_guest_account' test - the magic RID should be
up to the passdb backend to set.

Andrew Bartlett
(This used to be commit f71c8338d35a2e8c73c3d8006ea6858cb522c715)
2003-01-02 13:10:25 +00:00
Andrew Bartlett
6d66fb308a BIG patch...
This patch makes Samba compile cleanly with -Wwrite-strings.
 - That is, all string literals are marked as 'const'.  These strings are
always read only, this just marks them as such for passing to other functions.

What is most supprising is that I didn't need to change more than a few lines of code (all
in 'net', which got a small cleanup of net.h and extern variables).  The rest
is just adding a lot of 'const'.

As far as I can tell, I have not added any new warnings - apart from making all
of tdbutil.c's function const (so they warn for adding that const string to
struct).

Andrew Bartlett
(This used to be commit 92a777d0eaa4fb3a1c7835816f93c6bdd456816d)
2003-01-02 09:07:17 +00:00
Andrew Bartlett
60f9614400 Move our password change code along a little - use NTSTATUS, and implmenet
minimum password age and min password length for all password changes.

Andrew Bartlett
(This used to be commit 028f808c032becfa4618924cb301a4af2708fa96)
2003-01-01 04:19:34 +00:00
Simo Sorce
60667264b7 the shutdown call does not have a 16 bit flags, but 2 byte representing booleans
this commit change the structure and code to reflect this

some test revelead I'm right.

some other revelead currently the abort shutdown does not work against my test machine even if it returns successfully ... need investigation
(This used to be commit c5892b656dedd0367adc33d9606311d1dde99a58)
2002-12-30 04:41:27 +00:00
Jeremy Allison
7f23546730 Forward port the change to talloc_init() to make all talloc contexts
named. Ensure we can query them.
Jeremy.
(This used to be commit 842e08e52a665ae678eea239759bb2de1a0d7b33)
2002-12-20 20:23:06 +00:00
Gerald Carter
b1cfbb0f69 * fix memory leak when constructing an driver_level_6 structure
and no dependent files (working on smbd memory leak).  No CR# yet.
(This used to be commit f017fa7c478f87165b7b6aa83059fe6fad29ac15)
2002-12-17 21:35:56 +00:00
Jim McDonough
5f9348d4fc Store printer guid in the dsspooler registry key so we don't have to
query the directory server every time someone asks
(This used to be commit f0fc4e30f6284565de404a20450a587cd3fe00a5)
2002-12-13 21:54:09 +00:00
Jim McDonough
bfd8043a40 More printer publishing code.
- Add published attribute to info2, needed for win clients to work properly
- Return proper info on getprinter 7

This means you can now look at the sharing tab of a printer and get correct
info about whether it is published or not, and change it.
(This used to be commit adda04379ee46f105436262663652f3f576fa3cf)
2002-12-13 18:56:48 +00:00
Jim McDonough
2dd0e949d0 Automatic printer publishing when using APW or choosing 'list in the directory' in printer settings. Currently very little is published, and you cannot unpublish because of a bug in win2k clients.
(This used to be commit bbd7c8071a095c4e410f92489050b677a0f0ace1)
2002-12-04 17:28:51 +00:00