1
0
mirror of https://github.com/samba-team/samba.git synced 2025-01-11 05:18:09 +03:00
Commit Graph

16923 Commits

Author SHA1 Message Date
Jeremy Allison
67af7a8c43 r16587: Fix Klocwork #1987. Memleak on reusing x_dbf.
Jeremy.
(This used to be commit 16b0617cb0)
2007-10-10 11:19:01 -05:00
Jeremy Allison
f18df87fe9 r16585: Fix Klocwork #1976. Possible null deref.
Jeremy.
(This used to be commit a912ef0d97)
2007-10-10 11:19:01 -05:00
Jeremy Allison
d1014c1cdf r16582: Fix Klocwork #1997 and all generic class of problems
where we don't correctly check the return from memdup.
Jeremy.
(This used to be commit ce14daf51c)
2007-10-10 11:19:01 -05:00
Jeremy Allison
5a1a08d428 r16581: Fix Klocwork #2017. Possible null deref.
Jeremy.
(This used to be commit 6967fd4cef)
2007-10-10 11:19:01 -05:00
Jeremy Allison
d70803ebe3 r16579: Fix Klocwork #2016. Possible null deref.
Jeremy.
(This used to be commit f6d5bae4a1)
2007-10-10 11:19:01 -05:00
Jeremy Allison
9a7adde8a3 r16576: Fix Klocwork #2015. Possible null deref.
Jeremy.
(This used to be commit 9cbfaf62a3)
2007-10-10 11:19:01 -05:00
Christopher R. Hertel
98118545c1 r16570: Corrected the copyright notice. I had requested and received permission
from my management at the University to release under my own copyright.
My mistake for entering the wrong info.
(This used to be commit c65ebeb028)
2007-10-10 11:19:00 -05:00
Jeremy Allison
b000e8f083 r16554: Sorry, just had to change this. Don't use int when
you're passing a BOOL parameter, don't use "clever"
code in while statement - make things easier and
clearer to understand when triggering something
with an if.
Jeremy.
(This used to be commit b1fc2d8b99)
2007-10-10 11:19:00 -05:00
Derrell Lipman
9220a7bb7b r16552: Fix bug 3849.
Added a next_token_no_ltrim() function which does not strip leading separator
characters.  The new function is used only where really necessary, even though
it could reasonably be used in many more places, to avoid superfluous code
changes.

Derrell
(This used to be commit d90061aa93)
2007-10-10 11:19:00 -05:00
Derrell Lipman
9718506d35 r16550: Fix bug 3866. Thanks for the report!
Although I've never met a computer or compiler that produced pointers to
functions which are a different size than pointers to data, I suppose they
probably exist.  Assigning a pointer to a function is technically illegal in C
anyway.

Change casts of the option_value based on the option_name to use of variable
argument lists.

For binary compatibility, I've maintained but deprecated the old behavior of
debug_stderr (which expected to be passed a NULL or non-NULL pointer) and
added a new option debug_to_stderr which properly expects a boolean (int)
parameter.

Derrell
(This used to be commit c1b4c51053)
2007-10-10 11:18:59 -05:00
Jeremy Allison
ad6f4f14ad r16548: Fix bug #3867 reported by jason@ncac.gwu.edu.
Jeremy.
(This used to be commit 2b8d72f09c)
2007-10-10 11:18:59 -05:00
Jeremy Allison
7d187fe7e0 r16546: Fix bug #3865 reported by jason@ncac.gwu.edu.
Jeremy.
(This used to be commit be888a3cda)
2007-10-10 11:18:59 -05:00
Jeremy Allison
24814867c3 r16544: Fix bug #3864 reported by jason@ncac.gwu.edu.
Jeremy.
(This used to be commit 16e42b446b)
2007-10-10 11:18:59 -05:00
Jeremy Allison
429cd6db0b r16542: Fix #3863, reported by jason@ncac.gwu.edu
Jeremy.
(This used to be commit cde8323fdc)
2007-10-10 11:18:59 -05:00
Jeremy Allison
fe28eb2e41 r16541: Fix #3862 reported by jason@ncac.gwu.edu.
Jeremy.
(This used to be commit 09e11dcb23)
2007-10-10 11:18:58 -05:00
Jeremy Allison
a24c404967 r16537: Fix for bug #3858, all files in a directory not
being deleted when hide unreadable set to true.

Here's the scoop.

This one is really interesting. The pattern of deleting a directory is to do a
findfirst to get the first part of the list, then for each name returned it
does a open/set delete on close/close -> thus deleting the file. Then it does a
findnext with the last file name THAT IT JUST DELETED ! Now we can handle this
in the findnext in the case where hide unreadable is set to false as we look
back in our cache of names and just seek to the right point. The bug is
actually fixed in the first hunk of this patch - the one that removes the
is_visible_file() check after SearchDir returns false. We don't actually need
it and in this case it's causing the delete to be aborted because it can't find
the name (doh ! it was just deleted). We don't need it as SearchDir is only
ever called from findnext, and findnext should only ever be returning names we
gave it.

The rest of the patch are the debugs I used to find
the problem but they're generically useful.

Phew - that one took a while to track down.....

Jerry, please merge for 3.0.23 final.

Jeremy.
(This used to be commit cd048cb775)
2007-10-10 11:18:57 -05:00
Gerald Carter
6612988d09 r16528: Self-confidence is plummeting. How could one person goof
the same change 3 times......

Fix pam_winbind compilation again.
(This used to be commit f3d2bbf0d2)
2007-10-10 11:18:57 -05:00
Gerald Carter
7e76f785f8 r16510: fix from Nicholas Brealey <nick@brealey.org> for building pam_winbind.so
(This used to be commit 4490fbdfc2)
2007-10-10 11:18:57 -05:00
Volker Lendecke
1d21b9659b r16490: Fix a memleak and two typos
(This used to be commit 8cf364e602)
2007-10-10 11:18:57 -05:00
James Peach
00a0b0cbf3 r16484: Bugzilla 3805. Only define _ABS if it is not already defined.
(This used to be commit 09fb20f4fe)
2007-10-10 11:18:57 -05:00
James Peach
ae412ebe71 r16483: Turn off some useless MIPSPro warnings be default.
(This used to be commit a22bf28bca)
2007-10-10 11:18:56 -05:00
James Peach
d2864af2e7 r16482: Fix bugzilla 3801 by forcing MIPSPro warning 1035 to be an error.
(This used to be commit 2131ddd7a1)
2007-10-10 11:18:56 -05:00
Günther Deschner
e9b3f293ae r16480: (Ugly) workaround before the set_dc_type_flags & friends cleanup:
When trying to login using krb5 with a trusted domain account, we
need to make sure that our and the remote domain are AD.

Guenther
(This used to be commit 5853525f11)
2007-10-10 11:18:56 -05:00
Günther Deschner
85e426fc76 r16479: When dcip_to_name failed to get the name of the ip in saf_servername we
cannot put saf_name in the failed conn cache as it's uninitialized.
Store saf_servername (the ip) in that case.

Volker, please check.

Guenther
(This used to be commit 098a87f492)
2007-10-10 11:18:56 -05:00
Gerald Carter
58edac3c27 r16478: small cleanup to make pam_winbind.so build and iniparser
include directory like other parts of the build files.
(This used to be commit 0fca41efde)
2007-10-10 11:18:56 -05:00
Günther Deschner
491b9e637d r16475: destroy talloc ctx when we weren't able to collect onlinestatus
messages.

Guenther
(This used to be commit d6b52e8181)
2007-10-10 11:18:56 -05:00
Günther Deschner
025b546392 r16474: There is no point in figuring out lockout policies if we do not allow
offline logons at all.

Guenther
(This used to be commit dfbe555c69)
2007-10-10 11:18:55 -05:00
Günther Deschner
4e7e731849 r16473: There is no point in calling set_dc_type_and_flags() before each
pam_auth login (when using kerberos).

Guenther
(This used to be commit 520777f794)
2007-10-10 11:18:55 -05:00
Gerald Carter
600b0ae2e9 r16471: Bug reported by Vitaly Protsko <villy@sft.ru> in 3.0.23rc1.
Add missing automatic add of the Administrators SID in the absence
of winbindd and precense of Domain Admins SID in the user's token.
(This used to be commit ce7846d6f1)
2007-10-10 11:18:55 -05:00
Gerald Carter
f17bdaf10a r16470: remove ntlm_auth_proto.h and passwd_proto.h in 'make clean
(This used to be commit 8421d1b080)
2007-10-10 11:18:55 -05:00
Günther Deschner
20286e5c03 r16458: Increase debuglevel of cli_rpc_pipe_close().
Guenther
(This used to be commit 840ac23ec0)
2007-10-10 11:18:55 -05:00
Günther Deschner
10252f270e r16453: Fix another memleak.
Guenther
(This used to be commit 49fb1a3ebc)
2007-10-10 11:18:55 -05:00
Günther Deschner
1b12b48a09 r16452: Fix memleak in the CLDAP processing (found by valgrind).
Guenther
(This used to be commit 479dec6845)
2007-10-10 11:18:54 -05:00
Jeremy Allison
54ea3c23e3 r16435: Add in the uid info that Jerry needs into the
share_mode struct. Allows us to know the unix
uid of the opener of the file/directory. Needed
for info level queries on open files.
Jeremy.
(This used to be commit d929323d6f)
2007-10-10 11:18:54 -05:00
Jeremy Allison
607f9ffc8e r16433: Fix Coverity #300 (triggered by a Klockwork bugfix
I think). If a alloc fails just return NT_STATUS_NO_MEMORY,
don't go to "done" label and deref pointers.
Jeremy.
(This used to be commit 490c7c8467)
2007-10-10 11:18:54 -05:00
Jeremy Allison
adc252c275 r16429: Fix final 4 Klocwork bugs we're going to fix before
release - #785, #786, #787, #788.
Jeremy.
(This used to be commit 9017547ccc)
2007-10-10 11:18:53 -05:00
Volker Lendecke
ca8b86c51a r16427: Fix bug # 3848. Thanks to Wilco Baan Hofman for testing the release candidate!
Volker
(This used to be commit adf2dcce09)
2007-10-10 11:18:53 -05:00
Jeremy Allison
4340b7cea7 r16426: Klocwork #1544, #1545, #1546, #1549, #1550, #1552, #1553, #1554
Jeremy.
(This used to be commit e71cc6647a)
2007-10-10 11:18:53 -05:00
Jeremy Allison
f014291edd r16424: Fix possible null deref and a memory leak found by
examining Klockwork #1519. get_printer_subkeys()
could return zero without initializing it's return
pointer arg. Fixed this. Added free of subkey pointer
return in registry/reg_printing.c (interesting that
neithe Coverity or Klocwork found this one).
Jeremy.
(This used to be commit 4fbeae1a3a)
2007-10-10 11:18:52 -05:00
Jeremy Allison
a167c2c09e r16422: winbindd_demote_client isn't used and generates
a Klocwork issue (#1844). Remove it
Jeremy.
(This used to be commit e83c3e0a65)
2007-10-10 11:18:52 -05:00
Jeremy Allison
dc36abe3a2 r16420: Fix Klocwork #1674. Null deref.
Jeremy.
(This used to be commit f5dddf339e)
2007-10-10 11:18:52 -05:00
Günther Deschner
0edf73c85a r16415: Also delete object files from iniparser.
Guenther
(This used to be commit 4e1816855a)
2007-10-10 11:18:52 -05:00
Volker Lendecke
7dad923a49 r16411: Fix compilation of vfs_afsacl, thanks to Greszler Szilard for trying
(This used to be commit 601643a460)
2007-10-10 11:18:52 -05:00
Volker Lendecke
3c34f6085a r16409: Fix Klocwork ID's.
1177

In reg_perfcount.c: 1200 1202 1203 1204
In regfio.c: 1243 1245 1246 1247 1251

Jerry, the reg_perfcount and regfio.c ones, can you take a look please? This
is really your code, and I'm not sure I did the right thing to return an
error.

smbcacls.c: 1377
srv_eventlog_nt.c: 1415 1416 1417
srv_lsa_nt.c: 1420 1421
srv_netlog_nt.c: 1429
srv_samr_nt: 1458 1459 1460

Volker

Volker
(This used to be commit d6547d12b1)
2007-10-10 11:18:52 -05:00
Jeremy Allison
ce61fb21d9 r16397: Fix Klocwork #11767 and drasticly simplify the
logic in smbd/process.c. All interested (Volker,
Jerry, James etc). PLEASE REVIEW THIS CHANGE.
The logic should be identical but *much* easier
to follow and change (and shouldn't confuse Klockwork :-).
Jeremy.
(This used to be commit d357f8b335)
2007-10-10 11:18:52 -05:00
Jeremy Allison
69678ce983 r16396: Klocwork #1170. Null deref.
Jeremy.
(This used to be commit 220627ab70)
2007-10-10 11:18:51 -05:00
Jeremy Allison
a77a699fe9 r16393: Klocwork #1164. Null deref.
Jeremy.
(This used to be commit c9a4ce51ed)
2007-10-10 11:18:51 -05:00
Jeremy Allison
1c8a871aaf r16392: Klockwork #1168. Protect against null deref.
Jeremy.
(This used to be commit cab256d72a)
2007-10-10 11:18:51 -05:00
Jeremy Allison
e98a2e1fca r16390: Klocwork #604 - ensure if NULL pointer we assert
if len != 0.
Jeremy.
(This used to be commit e99cedfb0c)
2007-10-10 11:18:51 -05:00
Jeremy Allison
a39643f170 r16388: Klocwork #320. Null deref.
Jeremy.
(This used to be commit ceea8e2100)
2007-10-10 11:18:51 -05:00