1
0
mirror of https://github.com/samba-team/samba.git synced 2025-01-15 23:24:37 +03:00

29104 Commits

Author SHA1 Message Date
Tim Prouty
6c935f95b3 s3: Fix chained sesssetupAndX/tconn messages
A sesssetupAndX chained with a tconn will not correctly set the TID in
the response header.  I'm seeing an XP client send this chained
sesssetup/tconn when samba has security = share.  Samba's current
behavior is to return a TID of 0 in the smb header rather than the
actual TID.  This patch also updates the UID in the header as well.
2009-05-08 17:09:16 -07:00
Günther Deschner
a21bfc4daf s3-samr: Fix SetUserInfo level 16 and 21 w.r.t. ACB_AUTOLOCK acct_flag.
It is not allowed to *set* this flag remotely if it has been not set already.

Found by torture test.

Guenther
2009-05-09 00:03:50 +02:00
Günther Deschner
705f36b804 s3-samr: Fix SetUserInfo level 7 when there has been no name change.
Found by torture test.

Guenther
2009-05-09 00:02:00 +02:00
Günther Deschner
d010094700 s3-selftest: enable running RPC-SAMR-USERS against Samba3.
Guenther
2009-05-08 22:23:51 +02:00
Günther Deschner
b7925cb3f2 s3-samr: more accurateness in _samr_SetDomainInfo().
Guenther
2009-05-08 22:15:31 +02:00
Jeremy Allison
3d6f4a7af7 Fix bug #6330 - DFS doesn't work on AIX. Jeremy. 2009-05-08 11:39:05 -07:00
Jeremy Allison
f47b220ce1 Expand the comment explaining why user_in_group_sid is
not reliable for winbindd users from foreign domains.
Jeremy.
2009-05-08 10:12:36 -07:00
Stefan Metzmacher
b79eff843b s3:smbd: fix posix acls when setting an ACL without explicit ACE for the owner (bug#2346)
The problem of bug #2346 remains for users exported by
winbindd, because create_token_from_username() just fakes
the token when the user is not in the local sam domain. This causes
user_in_group_sid() to give totally wrong results.
In uid_entry_in_group() we need to check if we already
have the full unix token in the current_user struct.
If so we should use the current_user unix token,
instead of doing a very complex user_in_group_sid()
which doesn't give reliable results anyway.

metze
2009-05-08 16:56:46 +02:00
Michael Adam
7d6e4c7e95 s3:smbd: fix the fix for mapped IPv4 address handling in release_ip().
It was too late... Thanks Metze for noticing.

Michael
2009-05-08 16:42:56 +02:00
Günther Deschner
66cf7e1835 s3-selftest: run RPC-LSA-GETUSER against Samba 3.
Guenther
2009-05-08 11:28:45 +02:00
Günther Deschner
266b79e004 s3-samr: implement more info levels in _samr_QueryDomainInfo().
Gets us closer to pass RPC-SAMR.

Guenther
2009-05-08 09:55:10 +02:00
Günther Deschner
d7b32b51f8 s3-samr: Fix potential memory leak in _samr_ChangePasswordUser().
Guenther
2009-05-08 01:24:28 +02:00
Michael Adam
e86a534fa7 s3: make release_ip() call (ctdb) cope with IPv4 mapped addresses
Michael
2009-05-08 01:18:58 +02:00
Günther Deschner
53713be2cb s3-selftest: finally enable RPC-SAMR-PASSWORDS which samba3 now passes.
Guenther
2009-05-08 00:47:16 +02:00
Günther Deschner
6f4b5798c9 s3-selftest: need to enable lanman auth in order make RPC-SAMR-PASSWORDS pass.
Guenther
2009-05-08 00:46:54 +02:00
Günther Deschner
227b61d7ea s3-samr: Do not leak information whether a user exist or not in pwd change calls.
Found by torture test.

Guenther
2009-05-08 00:46:54 +02:00
Günther Deschner
5773d7d102 s3-samr: implement _samr_ChangePasswordUser().
This is vastly copied from samba4 samr server.

Guenther
2009-05-08 00:46:49 +02:00
Günther Deschner
d17c6af57c s3-samr: implement _samr_OemChangePasswordUser2().
Guenther
2009-05-08 00:44:46 +02:00
Günther Deschner
c400fc1e1e s3-samr: disable check for ACB_DISABLED in check_oem_password().
It is a bad idea to just tell everyone that an account is disabled without
really having checked the password first.

Found by torture test.

Guenther
2009-05-08 00:43:24 +02:00
Günther Deschner
b9fa8285f7 s3-samr: rework check_oem_password() to take a struct samu, not to return one.
Guenther
2009-05-08 00:43:01 +02:00
Günther Deschner
6aca5fca8d s3-samr: Let _samr_TestPrivateFunctionsUser() return not supported.
This is to get us closer to pass RPC-SAMR-USERS.

Guenther
2009-05-08 00:41:40 +02:00
Günther Deschner
b96fdae1f4 s3-samr: Do not return users in _samr_QueryDisplayInfo() for builtin domain.
Found by torture test.

Guenther
2009-05-08 00:41:40 +02:00
Günther Deschner
f05d888d7a s3-samr: let set_user_info_16 and 20 follow the same pattern as all other levels.
Guenther
2009-05-08 00:41:40 +02:00
Günther Deschner
f93f713898 s3-samr: support some more info levels in samr_SetUserInfo calls.
Guenther
2009-05-08 00:41:40 +02:00
Günther Deschner
b0df0e8cc7 s3-samr: support some more info levels in samr_QueryUser calls.
Guenther
2009-05-08 00:41:40 +02:00
Björn Jacke
f238809d23 s3/ldap: also handle DirX return codes 2009-05-08 00:33:30 +02:00
Björn Jacke
ddd37c2b23 s3:configure: "test" only takes one "=" 2009-05-08 00:33:30 +02:00
Volker Lendecke
646668bc51 Fix some type-punned warnings 2009-05-07 23:38:48 +02:00
Volker Lendecke
26a9643e45 Remove a misleading comment 2009-05-07 23:38:48 +02:00
Volker Lendecke
2c1372b0d2 Fix some nonempty blank lines 2009-05-07 23:38:48 +02:00
Volker Lendecke
b475a1e7eb Convert lib/wb_reqtrans.c to unix calling conventions 2009-05-07 22:52:33 +02:00
Volker Lendecke
6f320d0208 Adapt wb_reqtrans to "recent" coding conventions 2009-05-07 22:52:33 +02:00
Günther Deschner
2d5e0eadb8 s3-auth: use full 16byte session key in make_user_info_netlogon_interactive().
Patch from Jeremy.

With this patch, I was able to join Windows 7 RC to a Samba3 DC, and login into a
Samba 3 Domain.

There are still two registry settings required:

        HKLM\System\CCS\Services\LanmanWorkstation\Parameters
	            DWORD  DomainCompatibilityMode = 1
		    DWORD  DNSNameResolutionRequired = 0

Do *not* modify the other netlogon registry parameters that were passed around,
they weaken security.

Guenther
(cherry picked from commit b5097d54cb74ca0ea328f9e029562f65f4a01134)
2009-05-07 19:25:46 +02:00
Jeremy Allison
bb8aff6ffa Async API needs all parameters to be kept around until sent,
ensure they're attached to the state structure. Thanks to Metze
for pointing this out.
Jeremy.
2009-05-07 10:01:28 -07:00
Volker Lendecke
5c43bc616a Fix a typo 2009-05-07 16:37:55 +02:00
Volker Lendecke
1b75345a9a Add simple test chaining up sesssetup and tcon 2009-05-07 16:37:54 +02:00
Volker Lendecke
d52b0a25ad Make cli_tcon_andx chainable 2009-05-07 16:37:54 +02:00
Volker Lendecke
b35967edba Make cli_session_setup_guest chainable 2009-05-07 16:37:54 +02:00
Günther Deschner
599b9fe86e s3-samr: Fix _samr_Connect5(). In error case it still needs to return empty info1.
Guenther
2009-05-07 14:33:33 +02:00
Günther Deschner
b8ddb8765c s3-rpcclient: rework enumdrivers call a bit to allow queries like win7 does.
Guenther
2009-05-07 13:35:00 +02:00
Günther Deschner
8e490d2fa1 s3-credentials: protect netlogon_creds_server_step() against NULL creds.
Found by SCHANNEL torture tests.

Guenther
2009-05-07 13:32:41 +02:00
Günther Deschner
949cd77ca2 s3-selftest: run RPC-SCHANNEL, RPC-SCHANNEL2 and RPC-BENCH-SCHANNEL1 against Samba3.
Guenther
2009-05-07 13:06:03 +02:00
Volker Lendecke
974223b927 Fix bug 6336: "net groupmap set" segfaults 2009-05-07 10:11:38 +02:00
Jeremy Allison
606edf0f35 Make cli_setatr async.
Jeremy.
2009-05-06 16:13:42 -07:00
Jeremy Allison
78fb479325 After getting confirmation from Guenther, add 3 changes we'll
ultimately need to fix bug #6099 Samba returns incurrate capabilities list.
1). Add a comment to point out that r->in.negotiate_flags is an aliased pointer to
r->out.negotiate_flags.
2). Ensure we return NETLOGON_NEG_STRONG_KEYS in our flags
return if the client requested it.
3). Clean up the error exits so we always return the same
way.
Signed off by Guenther.
Jeremy.
2009-05-06 16:10:20 -07:00
Jeremy Allison
512879a69b Make cli_setattrE async.
Jeremy.
2009-05-06 15:07:05 -07:00
Günther Deschner
78754ab2c9 s3-netlogon: Fix NETLOGON credential chain. Fixes Bug #6099 (Windows 7 joining Samba3) and probably many, many more.
Jeremy, with 9a5d5cc1db0ee60486f932e34cd7961b90c70a56 you alter the in negotiate
flags (which are a pointer to the out negotiate flags assigned in the generated
netlogon server code). So, while you wanted to just set the *out* negflags, you
did in fact reset the *in* negflags, effectively eliminating the
NETLOGON_NEG_STRONG_KEYS bit (formerly known as NETLOGON_NEG_128BIT) which then
caused creds_server_init() to generate 64bit creds instead of 128bit, causing
the whole chain to break. *Please* check.

Guenther
2009-05-06 19:37:39 +02:00
Volker Lendecke
ed88ff18dd Fix Coverity ID 897: REVERSE_INULL 2009-05-06 12:01:30 +02:00
Günther Deschner
d77c456757 s3-rpcclient: print more infolevels in printer and driver info levels.
Guenther
2009-05-06 10:21:31 +02:00
Günther Deschner
7ac1ae8d1c s3-printing: fix debug statement in virtual registry layer
(key_driver_fetch_keys).

Guenther
2009-05-06 10:20:52 +02:00