1
0
mirror of https://github.com/samba-team/samba.git synced 2024-12-24 21:34:56 +03:00
Commit Graph

29 Commits

Author SHA1 Message Date
Volker Lendecke
111118354a rpc_client: talloc_stackframe() aborts on failure
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
2021-04-19 18:18:31 +00:00
Volker Lendecke
3a5c2582e1 rpc_client: Direct struct initialization in dcerpc_winreg_enumvals()
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
2021-04-19 18:18:31 +00:00
Noel Power
9c16d8fb24 s3/rpc_client: clang: Fix 'Value stored during initialization is never read'
Fixes:

source3/rpc_client/cli_winreg.c:728:11: warning: Value stored to 'status' during its initialization is never read <--[clang]
        NTSTATUS status = NT_STATUS_OK;
                 ^~~~~~   ~~~~~~~~~~~~
/source3/rpc_client/cli_winreg.c:897:11: warning: Value stored to 'status' during its initialization is never read <--[clang]
        NTSTATUS status = NT_STATUS_OK;
                 ^~~~~~   ~~~~~~~~~~~~
Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Jeremy Allison <jra@samba.org>
2019-09-26 18:41:27 +00:00
Günther Deschner
f142b0aec5 werror: replace WERR_NOMEM with WERR_NOT_ENOUGH_MEMORY in source3/rpc_client/
Guenther

Signed-off-by: Guenther Deschner <gd@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
2016-09-28 00:04:18 +02:00
Vicentiu Ciorbaru
4558225cdd s3-rpc_client: Added dcerpc_winreg_delete_subkeys_recursive() function.
This function is set to replace the more specific printer function
winreg_printer_delete_subkeys().

Signed-off-by: Andreas Schneider <asn@samba.org>
2011-07-13 10:09:08 +02:00
Vicentiu Ciorbaru
8b3eff8b36 s3-rpc_client: Added dcerpc_winreg_enumvals() function.
The function is set to replace the more specific printer function
winreg_printer_enumvalues() function.

Signed-off-by: Andreas Schneider <asn@samba.org>
2011-07-13 10:08:56 +02:00
David Disseldorp
2a02f1c4af winreg: Ensure server return status is set on success
Currently cli_winreg.c functions only set the returned server werror
status on failure, if the server request succeeds the value remains
uninitialised.

Signed-off-by: Andreas Schneider <asn@samba.org>

Autobuild-User: Andreas Schneider <asn@cryptomilk.org>
Autobuild-Date: Fri Jul  8 16:32:39 CEST 2011 on sn-devel-104
2011-07-08 16:32:39 +02:00
David Disseldorp
1271066200 winreg: Use the ntstatus return code for client side errors
cli_winreg.c functions indicate status to the caller in two ways. The
ntstatus return code indicates client side errors, the pwerr argument
carries the server response error code.

Many functions are filling the pwerr argument on client side error, this
change removes these cases.

Signed-off-by: Andreas Schneider <asn@samba.org>
2011-07-08 15:22:27 +02:00
Andreas Schneider
a45120aea7 s3-rpc_client: Fix some valgrind warnings.
These are in/out values and need to be initialized.

Signed-off-by: Günther Deschner <gd@samba.org>
2011-06-21 17:46:37 +02:00
Andrew Bartlett
73b377432c s3-talloc Change TALLOC_REALLOC_ARRAY() to talloc_realloc()
Using the standard macro makes it easier to move code into common, as
TALLOC_REALLOC_ARRAY isn't standard talloc.

Andrew Bartlett
2011-06-09 12:40:08 +02:00
Günther Deschner
0a250f4946 registry: create and use shared libcli/registry/util_reg.h header.
Guenther
2011-03-30 01:13:07 +02:00
Volker Lendecke
d8068b5a4b s3: Fix Coverity ID 2319: Uninitialized read
We passed the structure including the uninitialized elements to
dcerpc_winreg_SetValue.
2011-03-16 18:08:51 +01:00
Volker Lendecke
d9a58791b0 s3: Fix Coverity ID 2278: Uninitialized read
We passed the structure including the uninitialized elements to
dcerpc_winreg_SetValue.
2011-03-15 11:10:46 +01:00
Volker Lendecke
c98c36e38b s3: Fix Coverity ID 2280: Uninitialized read
We passed the structure including the uninitialized elements to
dcerpc_winreg_SetValue.
2011-03-15 11:10:46 +01:00
Volker Lendecke
e68cf5e9bf s3: Fix Coverity ID 2282: Uninitialized read
We passed the structure including the uninitialized elements to
dcerpc_winreg_SetValue.
2011-03-15 11:10:45 +01:00
Volker Lendecke
09677d664f s3: Fix Coverity ID 2288: Uninitialized read
We passed the structure including the uninitialized elements to
dcerpc_winreg_SetValue.
2011-03-15 11:10:43 +01:00
Andreas Schneider
01b49b1a2b s3-rpc_client: Added a winreg query security descriptor helper.
Signed-off-by: Günther Deschner <gd@samba.org>
2011-02-07 12:32:00 +01:00
Andreas Schneider
35439a7b18 s3-rpc_client: Added a winreg set security descriptor helper.
Signed-off-by: Günther Deschner <gd@samba.org>
2011-02-07 12:32:00 +01:00
Andreas Schneider
a370b9605c s3-rpc_client: Added a winreg set binary helper.
Signed-off-by: Günther Deschner <gd@samba.org>
2011-02-07 12:32:00 +01:00
Andreas Schneider
56963d1f44 s3-rpc_client: Added a winreg query sz helper.
Signed-off-by: Günther Deschner <gd@samba.org>
2011-02-07 12:32:00 +01:00
Andreas Schneider
69e6db1a53 s3-rpc_client: Added a winreg helper to enum keys.
Signed-off-by: Günther Deschner <gd@samba.org>
2011-02-07 12:32:00 +01:00
Andreas Schneider
8ed91d6027 s3-rpc_client: Added a winreg add multi sz helper.
Signed-off-by: Günther Deschner <gd@samba.org>
2011-02-07 12:31:59 +01:00
Andreas Schneider
8c119e4757 s3-rpc_client: Added a winreg query multi sz helper.
Signed-off-by: Günther Deschner <gd@samba.org>
2011-02-07 12:31:59 +01:00
Andreas Schneider
913426b0c3 s3-rpc_client: Added a winreg set multi sz helper.
Signed-off-by: Günther Deschner <gd@samba.org>
2011-02-07 12:31:59 +01:00
Andreas Schneider
34d3e85f35 s3-rpc_client: Added a winreg set expand sz helper.
Signed-off-by: Günther Deschner <gd@samba.org>
2011-02-07 12:31:59 +01:00
Andreas Schneider
4b32f6c9d5 s3-rpc_client: Added a winreg set sz helper.
Signed-off-by: Günther Deschner <gd@samba.org>
2011-02-07 12:31:59 +01:00
Andreas Schneider
e5eb7582d3 s3-rpc_client: Added a winreg set dword helper.
Signed-off-by: Günther Deschner <gd@samba.org>
2011-02-07 12:31:59 +01:00
Andreas Schneider
d24bd4be91 s3-rpc_client: Added winreg query binary helper.
Signed-off-by: Günther Deschner <gd@samba.org>
2011-02-07 12:31:59 +01:00
Andreas Schneider
9c7607d3d3 s3-rpc_client: Added winreg query dword helper.
Signed-off-by: Günther Deschner <gd@samba.org>
2011-02-07 12:31:59 +01:00