sin/samba-mirror
1
0
Fork 0
mirror of https://github.com/samba-team/samba.git synced 2024-12-28 07:21:54 +03:00
Code
68,636 Commits 60 Branches 1,144 Tags 452 MiB
69155e4103
Commit Graph

35 Commits

Author SHA1 Message Date
Jeremy Allison
c79ca41baf Fix bug #7288 - SMB job IDs in CUPS job names wrong. 
Based on a patch from Michael Karcher <samba@mkarcher.dialup.fu-berlin.de>.

I think this is the correct fix. It causes cups_job_submit to use
print_parse_jobid(), which I've moved into printing/lpq_parse.c (to allow the
link to work).

It turns out the old print_parse_jobid() was *broken*, in that the pjob
filename was set as an absolute path - not relative to the sharename (due to it
not going through the VFS calls).

This meant that the original code doing a strncmp on the first part of the
filename would always fail - it starts with a "/", not the relative pathname of
PRINT_SPOOL_PREFIX ("smbprn.").

This fix could fix some other mysterious printing bugs - probably the ones
Guenther noticed where job control fails on non-cups backends.

Guenther PLEASE CHECK !

Jeremy.
 2010-03-25 17:36:47 -07:00
Volker Lendecke
f3ddf2b23f Fix some scary FC9 warnings 
(cherry picked from commit 6b0fed09ea)
(This used to be commit f1e85ff2bc)
 2008-06-10 17:21:23 +02:00
Volker Lendecke
587cf54c61 strtok -> strtok_r 
(This used to be commit fd34ce4370)
 2008-01-23 15:08:04 +01:00
Jeremy Allison
75ca692430 Remove another static fstring. 
Jeremy.
(This used to be commit f9182bbe62)
 2007-12-18 18:01:34 -08:00
Jeremy Allison
42cfffae80 Remove next_token - all uses must now be next_token_talloc. 
No more temptations to use static length strings.
Jeremy.
(This used to be commit ec003f3936)
 2007-12-07 17:32:32 -08:00
Jeremy Allison
a22487025d Fix the build. fstrterminate was used in one place. 
Jeremy.
(This used to be commit 0ccd87c56b)
 2007-12-03 15:47:30 -08:00
Jeremy Allison
4c6b01b0ef Remove more pstring. Unify talloc_sub functions to make 
them a better match for replacing string_sub. Remove
more unused code.
Jeremy.
(This used to be commit ae7885711f)
 2007-11-19 18:56:22 -08:00
Jeremy Allison
30191d1a57 RIP BOOL. Convert BOOL -> bool. I found a few interesting 
bugs in various places whilst doing this (places that assumed
BOOL == int). I also need to fix the Samba4 pidl generation
(next checkin).
Jeremy.
(This used to be commit f35a266b3c)
 2007-10-18 17:40:25 -07:00
Andrew Tridgell
5e54558c6d r23784: use the GPLv3 boilerplate as recommended by the FSF and the license text 
(This used to be commit b0132e94fc)
 2007-10-10 12:28:22 -05:00
Jeremy Allison
d824b98f80 r23779: Change from v2 or later to v3 or later. 
Jeremy.
(This used to be commit 407e6e695b)
 2007-10-10 12:28:20 -05:00
Jeremy Allison
8f2d6e4852 r16243: Fix Klocwork bugs #581 and #706, ensure we check 
the end of array first in the loop. Reformat to
modern standards.
Jeremy.
(This used to be commit 66275bd3bc)
 2007-10-10 11:17:27 -05:00
Jeremy Allison
a1e0a0e928 r16230: Fix Klocwork #861 and others. localtime and asctime 
can return NULL. Ensure we check all returns correctly.
Jeremy.
(This used to be commit 6c61dc8ed6)
 2007-10-10 11:17:26 -05:00
Jeremy Allison
3527b5cc25 r14003: Clarify code that lead to Coverity report #13. 
Not a bug, but better to remove false positives.
Jeremy.
(This used to be commit f9a75d7654)
 2007-10-10 11:11:04 -05:00
Gerald Carter
293136c04b r3067: patch based on volker's initial work in trunk that fixes the queu update problem when using the background daemon 
(This used to be commit de7af09e72)
 2007-10-10 10:53:00 -05:00
Jeremy Allison
c9b7cbbfa5 Added strstr_m() function. Use in all places where we might run into mb 
(should fix the mb service name problem, can't remember the bugid).
Jeremy.
(This used to be commit 94a272b9a8)
 2004-03-09 00:17:14 +00:00
Jeremy Allison
94f59f5492 More tuning from cachegrind. Change most trim_string() calls to trim_char(0, 
as that's what they do. Fix string_replace() to fast-path ascii.
Jeremy.
(This used to be commit f35e9a8b90)
 2003-09-05 19:59:55 +00:00
Jeremy Allison
ce72beb2b5 Removed strupper/strlower macros that automatically map to strupper_m/strlower_m. 
I really want people to think about when they're using multibyte strings.
Jeremy.
(This used to be commit ff222716a0)
 2003-07-03 19:11:31 +00:00
Gerald Carter
6760896739 removing printing = SOFTQ since no one knows what it is 
(This used to be commit 2839534722)
 2003-04-29 05:06:18 +00:00
Andrew Bartlett
2a3a9f0bf4 Merge the 'safe' parts of my StrnCpy patch - many of the users really wanted 
a pstrcpy/fstrcpy or at most a safe_strcpy().

These have the advantage of being compiler-verifiable.

Get these out of the way, along with a rewrite of 'get_short_archi' in the
spoolss client and server.  (This pushes around const string pointers, rather
than copied strings).

Andrew Bartlett
(This used to be commit 32fb801ddc)
 2003-04-23 13:27:35 +00:00
Jeremy Allison
6626fef5d4 Fix for little-used lpq parser. 
Jeremy.
(This used to be commit 75b36459ab)
 2003-03-05 00:54:47 +00:00
Andrew Bartlett
634c54310c Merge from HEAD - make Samba compile with -Wwrite-strings without additional 
warnings.  (Adds a lot of const).

Andrew Bartlett
(This used to be commit 3a7458f947)
 2003-01-03 08:28:12 +00:00
Jeremy Allison
2f194322d4 Removed global_myworkgroup, global_myname, global_myscope. Added liberal 
dashes of const. This is a rather large check-in, some things may break.
It does compile though :-).
Jeremy.
(This used to be commit f755711df8)
 2002-11-12 23:20:50 +00:00
Andrew Tridgell
e90b652848 updated the 3.0 branch from the head branch - ready for alpha18 
(This used to be commit 03ac082dcb)
 2002-07-15 10:35:28 +00:00
Gerald Carter
2699f9b9df printing merge from HEAD 
(This used to be commit d3aed37dd8)
 2002-04-22 18:48:45 +00:00
Gerald Carter
65c007b583 syncing up printing code with SAMBA_2_2 (already done some merges 
in the reverse).

  * add in new printer change notify code from SAMBA_2_2

  * add in se_map_standard() from 2.2 in _spoolss_open_printer_ex()

  * sync up the _print_queue_struct in smb.h (why did someone change the
    user/file names in fs_user/fs_file (or vice-versa) ? )

  * sync up some cli_spoolss_XXX functions
(This used to be commit 5760315c1d)
 2002-03-15 08:14:10 +00:00
Martin Pool
570cdd8529 FIXME: Use next_token rather than strtok! 
(This used to be commit d56b8a30c5)
 2002-02-26 23:22:02 +00:00
Tim Potter
cd68afe312 Removed version number from file header. 
Changed "SMB/Netbios" to "SMB/CIFS" in file header.
(This used to be commit 6a58c9bd06)
 2002-01-30 06:08:46 +00:00
Tim Potter
dc1fc3ee8e Removed 'extern int DEBUGLEVEL' as it is now in the smb.h header. 
(This used to be commit 2d0922b0ea)
 2001-10-02 04:29:50 +00:00
Andrew Tridgell
527e824293 strchr and strrchr are macros when compiling with optimisation in gcc, so we can't redefine them. damn. 
(This used to be commit c41fc06376)
 2001-07-04 07:36:09 +00:00
Jeremy Allison
524619561a Patch from itegem <J.P.M.v.Itegem@ele.tue.nl> to handle LPRng v3.16 and above. 
Jeremy
(This used to be commit 40bccf26db)
 2001-03-27 03:16:05 +00:00
David O'Neill
f9680a444b Changes from APPLIANCE_HEAD: 
- merged Tim's vlp (virtual lp) test program.  Enable it with
      -DDEVELOPER or by using ./configure.developer
	  (source/include/smb.h source/configure.developer
	   source/printing/lpq_parse.c source/param/loadparm.c
	   testsuite/printing/.cvsignore testsuite/printing/Makefile.vlp
	   testsuite/printing/vlp.c)
(This used to be commit fbcf83140d)
 2000-11-14 15:26:53 +00:00
Jeremy Allison
0b0681388d We already have a perfectly good next_token() function we should be using 
instead of strtok - this fixes a bug with NT users with spaces in their
names when using winbindd. Needs to be added to the other parse_lpXX functions
(currently only added to lprng parsing code).
Jeremy.
(This used to be commit c3e4ac9a2d)
 2000-10-25 21:28:15 +00:00
Jeremy Allison
5d4f5cdddc Integrated support for NT and OS/2 lpq parsing. Code from 
Jim McDonough
Infoprint Manager Development
Linux Technology Center
IBM Boulder

Jeremy.
(This used to be commit d9eedd5db1)
 2000-10-07 00:48:27 +00:00
Andrew Tridgell
f3a861e04e - use full_name instead of real_name 
- got rid of guest map code in lpq parser
(This used to be commit 8e53f781d3)
 2000-05-04 07:59:34 +00:00
Andrew Tridgell
001765501e split out the lpq parsing code into a separate file 
printing/lpq_parse.c

getting ready for the new printing backend
(This used to be commit 0ec1072e01)
 2000-04-10 03:09:42 +00:00