Jeremy Allison
1f8b6238dd
Attempt to fix crash seen with new CUPS async printcap loading code.
...
Jeremy.
2009-01-05 13:47:34 -08:00
Jelmer Vernooij
37e6849d45
Merge branch 'master' of ssh://git.samba.org/data/git/samba
2009-01-05 18:01:04 +01:00
Stefan Metzmacher
c34d5f445a
s3:events: change event_add_timed() prototype to match samba4
...
metze
2009-01-05 15:07:35 +01:00
Bo Yang
022e2f8199
clean event context after child is forked.
...
Signed-off-by: Stefan Metzmacher <metze@samba.org>
2009-01-05 15:07:31 +01:00
Jelmer Vernooij
08259c1c52
Add iconv_convenience argument to size functions.
2009-01-01 04:45:33 +01:00
Volker Lendecke
ce2ff557bd
Fix an ancient uninitialized variable read
...
The callers of open_file_ntcreate expect *psbuf to be filled correctly
2008-12-31 10:51:44 +01:00
Volker Lendecke
fee2664dad
Fix a memory leak in cups_pull_comment_location
...
We allocated "request" with ippNew, so we also should ippDelete it.
2008-12-30 15:59:25 +01:00
Volker Lendecke
b3abd484db
Fix a spinning smbd when printing
...
Without this, we end up adding more than one timed event. In the event handler
print_notify_event_send_messages() only one event will be deleted, all others
will fire indefinitely.
2008-12-30 14:14:06 +01:00
Jeremy Allison
d0eeb9aa8d
Fix more asprintf warnings and some error path errors.
...
Jeremy.
2008-12-23 12:11:12 -08:00
Jeremy Allison
b143938b8a
Fix more asprintf errors and error code paths.
...
Jeremy.
2008-12-23 11:27:19 -08:00
SATOH Fumiyasu
f62e0d6c96
Fix bug #5688 LPQ process is orphaned if socket address parameter is invalid
2008-12-09 14:26:22 -08:00
Volker Lendecke
1db7076b8e
Fix nonempty blank lines
2008-12-07 21:30:35 +01:00
Tim Prouty
5844012285
s3: Change SMB_VFS_CREATE_FILE to take a create_file_flags argument
...
This replaces the is_dos_path bool with a more future-proof argument.
The next step is to plumb INTERNAL_OPEN_ONLY through this flag instead
of overridding the oplock_request.
2008-12-03 17:51:44 -08:00
Tim Prouty
08ce060475
s3: Modify direct callers of open_file_ntcreate and open_directory to call SMB_VFS_CREATE_FILE
2008-12-03 17:51:16 -08:00
Volker Lendecke
c25f5c778a
Convert delete_driver_files to use create_conn_struct
...
Jerry, please check!
2008-11-24 11:39:03 +01:00
Volker Lendecke
cb4f8573ba
Convert get_correct_cversion to use create_conn_struct
...
Jerry, please check!
2008-11-24 11:39:03 +01:00
Volker Lendecke
783ab0480b
Convert move_driver_to_download_area to use create_conn_struct
...
This removes a use of struct current_user and the vuid
The become_user() here is unnecessary, within the spoolss handling code we have
switched to the authenticated pipe user anyway.
Jerry, please check!
2008-11-24 11:39:03 +01:00
Jeremy Allison
97fb05c2c0
First part of fix for bug #5903 - vfs_streams_xattr breaks contents of the file.
...
Restructures parts of open code so that fsp must be allocated before calling
open_file_ntcreate(_internal). Also fix up file ref-counting inside files.c.
Jeremy.
2008-11-21 12:14:53 -08:00
Volker Lendecke
c6973e69b7
Remove an unused variable
2008-11-02 09:40:30 +01:00
Jelmer Vernooij
ddcab787c4
Rename dos_errstr() to win_errstr() for consistency with Samba 4.
2008-11-01 17:19:26 +01:00
Jeremy Allison
8344e94574
Unify se_access_check with the S4 code. Will make
...
calculation of SEC_FLAG_MAXIMUM_ALLOWED much easier
for files.
Jeremy.
2008-10-31 10:51:45 -07:00
Jeremy Allison
7c53ffea28
Allow a new file to inherit the Windows ACL from its parent.
...
Now to do the same for directories.
Jeremy.
2008-10-29 13:27:14 -07:00
Kai Blin
c88cbbfdf3
vlp: Move closer to the code tested.
2008-10-19 15:03:22 +02:00
Jelmer Vernooij
f0c4829e82
Remove silly safe_free() function which is a wrapper around SAFE_FREE().
...
Since it's a function it just sets the local pointer to NULL and basically
is an equivalent to free().
It also claims it's being used for callbacks but isn't used that way
anywhere.
2008-10-19 13:06:14 +02:00
Jelmer Vernooij
a62c510d8b
Use GUID_from_string.
2008-10-14 02:33:41 +02:00
Jelmer Vernooij
1f3e4f39c5
Use GUID_string rather than smb_uuid_string().
2008-10-14 02:26:18 +02:00
Jelmer Vernooij
4746f79d50
Use {u,}int64_t instead of SMB_BIG_{U,}INT.
2008-10-14 01:59:36 +02:00
Volker Lendecke
c530009401
Pass struct smb_request to file_free
...
on the way to get rid of chain_fsp
2008-10-13 19:32:38 +02:00
Volker Lendecke
c3fedcddd5
Pass struct smb_request to file_new
...
Goal is to remove the chain_fsp global variable
2008-10-13 19:32:38 +02:00
Jelmer Vernooij
1b99d8fbb5
Use common util_file code.
2008-10-12 17:34:43 +02:00
Volker Lendecke
d661ac196e
Fix the build
2008-10-12 10:38:55 +02:00
Jelmer Vernooij
cb78d4593b
Cope with changed signature of http_timestring().
2008-10-11 23:57:44 +02:00
Jeremy Allison
47f7ef8f39
Initialize near creation of resource. Makes code clearer.
...
Jeremy.
2008-10-10 16:48:18 -07:00
Jeremy Allison
1d151b3161
Ensure we do reinit_after_fork().
...
Jeremy.
2008-10-10 16:43:13 -07:00
Jeremy Allison
4cbb3b23a4
Allow data flow to be debugged and only log on error. All seems ok now.
...
Jeremy.
2008-10-10 16:29:14 -07:00
Jeremy Allison
430cc44390
Async is trickier than it looks :-). Don't use a stack variable for a private data ptr.
...
Jeremy.
2008-10-10 15:55:49 -07:00
Jeremy Allison
eada8f8abe
If you have a large number of cups printers, then scanning for print info can cause a client to timeout
...
(it takes longer than 30 seconds to enumerate them). Make scanning for printers async with a callback
from the main loop. This fixes a bug that was irritating *me* :-).
Jeremy.
2008-10-10 11:55:14 -07:00
Jeremy Allison
e5692d4cbe
Remove SEC_ACCESS. It's a uint32_t.
...
Jeremy.
2008-10-09 09:49:03 -07:00
Jeremy Allison
f6c883b4b0
Simply our main loop processing. A lot :-). Correctly use events for all the previous "special" cases.
...
A step on the way to adding signals to the events and being able to merge the S3 event system with
the S4 one.
Jeremy.
2008-10-03 14:18:35 -07:00
Jeremy Allison
e0dbac6873
Don't reject a successful alloc :-(.
...
Jeremy.
2008-10-02 12:21:11 -07:00
Jeremy Allison
3bfb53caa8
Fix bug #5080 . Access to cups-printers via samba broken with cups 1.3.4, Unsupported character set.
...
Cups 1.3.4 expects utf8 to be used in all messages to/from the server. We may be using a
different character set so we need to use talloc utf8 push/pull functions in all communication.
Needs more testing. Don't release until I've done a thorough test. I also have a version for 3.2.x.
Jeremy.
2008-10-01 16:40:41 -07:00
Jeremy Allison
ea85ceefa9
Whitespace cleanup.
...
Jeremy.
2008-10-01 15:01:05 -07:00
Jeremy Allison
c383e8d760
Ensure we null out fsp after a close in all paths.
...
Jeremy.
2008-09-29 10:57:22 -07:00
Jelmer Vernooij
55e201b0a1
Avoid freeing fsp twice when opening new_file fails. (Debian #431696 )
...
If opening new_file fails, fsp would still be set to the files_struct of
old_file.
2008-09-29 19:09:53 +02:00
Karolin Seeger
9cf1a68977
printing: Rename new parameter "cups timeout" to "cups connection timeout".
...
Karolin
2008-09-24 11:09:04 -07:00
Karolin Seeger
765e5d2282
printing: Add new parameter "cups timeout".
...
The default timeout for connections to CUPS servers is set
to 5 minutes in the CUPS libraries. The smbd hangs on startup
until the timeout is reached if the CUPS server is unreachable.
This parameter makes the timeout configurable. The default value
is set to 30 seconds.
Karolin
2008-09-23 16:57:58 -07:00
Jim McDonough
6e6d4c1f5b
Allow %u parameters for print job username - use advanced sub
...
Based on 3.0 and 3.2 patch from Bo Yang <boyang@novell.com>
Bo, please verify this version works for you.
(This used to be commit 9e6760cfea
)
2008-07-16 12:37:48 -04:00
Volker Lendecke
44e9a2bb9a
remove unused extern current_user from nt_printing.c
...
(This used to be commit b34283adef
)
2008-06-26 13:13:23 +02:00
Volker Lendecke
c885ae01eb
Remove current_user reference from printfsp.c
...
(This used to be commit 510f45d01a
)
2008-06-26 13:13:23 +02:00
Volker Lendecke
a3c0be6325
Change print_access_check to take auth_serversupplied_info instead of current_user
...
Reason: This is the main user of p->current_user which I would like to remove
(This used to be commit fd43059b3d
)
2008-06-26 13:13:23 +02:00