1
0
mirror of https://github.com/samba-team/samba.git synced 2025-01-14 19:24:43 +03:00

340 Commits

Author SHA1 Message Date
Jeremy Allison
f7fc540d84 r22354: Make client select krb5 encrpyt if krb5 already on.
Jeremy.
(This used to be commit 7b89a5de57cd5fed814eda95e44dcc345f380fb2)
2007-10-10 12:19:28 -05:00
Jeremy Allison
e5428ef189 r22155: Fixed warning #4498 from jason@ncac.gwu.edu.
Jeremy.
(This used to be commit f1b22c952719f004d7e33813c4d0f10514e1fff9)
2007-10-10 12:19:17 -05:00
Simo Sorce
73c8eee9b2 r22002: Fix bug #3974, there are still open issues with -N behavior (doc fix next)
and -T argument parsing behavior (which is just insane but a separate bug)
(This used to be commit 1a3980f1fcb6431aa6bce83f7c34338436b4e962)
2007-10-10 12:18:59 -05:00
Jeremy Allison
0eab431194 r21992: Fix keepalive processing when encryption turned on.
Jeremy.
(This used to be commit 8f113ad1918dcd2746ec527ceb79a2a7baa1d415)
2007-10-10 12:18:58 -05:00
Jeremy Allison
7ae9e6aff5 r21901: Don't use fstrcat when you mean fstrcpy. Doh !
Jeremy.
(This used to be commit c7153411f1840e41470311db00d728e1461c56f6)
2007-10-10 12:18:47 -05:00
Jeremy Allison
a828b56884 r21898: Added test command, fixed first valgrind bugs.
Now to investigate why it doesn't work :-).
Jeremy.
(This used to be commit 73f7c6cef8371ad63eb1dc3e79bfc78503dbd7a4)
2007-10-10 12:18:47 -05:00
Jeremy Allison
540911001d r21768: Fix the client dfs code such that smbclient can
process deep dfs links (ie. links that go to non root
parts of a share). Make the directory handling conanonical
in POSIX and Windows pathname processing.
dfs should not be fully working in client tools. Please
bug me if not.
Jeremy.
(This used to be commit 1c9e10569cd97ee41de39f9f012bea4e4c932b5d)
2007-10-10 12:18:30 -05:00
Jeremy Allison
b81b6b31c5 r21750: Sync up with SAMBA_3_0_25. Only client changes are in libsmbclient
right now.
Jeremy.
(This used to be commit 6dd5f0ef0fe3a673081e16e656ca579bf50457ff)
2007-10-10 12:18:27 -05:00
Jeremy Allison
0a78e20bf0 r21734: Fix bug #4369. Patch from David Leonard <dleonard@vintela.com>.
Jeremy.
(This used to be commit 62a5c22a13001010753975442e62841ac62d8d6a)
2007-10-10 12:18:27 -05:00
Jeremy Allison
4952fe368a r21714: Change the VFS interface to use struct timespec
for utimes - change the call to ntimes. This preserves
nsec timestamps we get from stat (if the system supports
it) and only maps back down to usec or sec resolution
on time set. Looks bigger than it is as I had to move
lots of internal code from using time_t and struct utimebuf
to struct timespec.
Jeremy.
(This used to be commit 8f3d530c5a748ea90f42ed8fbe68ae92178d4875)
2007-10-10 12:18:24 -05:00
Herb Lewis
36f20fca7b r21657: get rid of warning - not everyone understands %F
(This used to be commit 5a7330cfe460cd53b89f5a27e18857f4ea7f9939)
2007-10-10 12:18:22 -05:00
Jeremy Allison
402affb0d7 r21641: Add test code for POSIX pathname calls into smbclient.
Jeremy.
(This used to be commit 9858e5b72526360fc415b848a84042e09d9b2453)
2007-10-10 12:18:20 -05:00
Jelmer Vernooij
62e11c4f17 r20832: Remove extra pointers previously added to unique [out] pointers. Instead,
add [ref] pointers where necessary (top-level [ref] pointers,
by spec, don't appear on the wire).

This brings us closer to the DCE/RPC standard again.
(This used to be commit 580f2a7197b1bc9db14a643fdd112b40ef37aaef)
2007-10-10 12:17:11 -05:00
Volker Lendecke
01367cdfd0 r19797: Convert the remaining pipes to the "new" unique out ptr handling
(This used to be commit bc4e0a388a2859d2ddcfb8f07920f3b121a37894)
2007-10-10 12:15:56 -05:00
Jeremy Allison
b7bf248985 r19529: Added showacls togle. Previously was vendor-specific code.
Merging these in - should have been merged back before (will
be tidied up later).
Jeremy.
(This used to be commit 1e9284590f42b61bd730104920bc535bf7dfcbf4)
2007-10-10 12:15:41 -05:00
Volker Lendecke
2c94123e86 r18876: Fix smbclient -L
(This used to be commit a03fb81a9d16c9db787c539d63c13ecaf6d6f80d)
2007-10-10 12:14:40 -05:00
Stefan Metzmacher
e8b442c964 r18813: the generated rpccli_ functions give NTSTATUS
metze
(This used to be commit 4a198cebe37d74437a8d526aff1139f1668bcd37)
2007-10-10 12:01:02 -05:00
Jelmer Vernooij
7ba2554d88 r18802: Use the pidl-generated code for the srvsvc interface, both client and server code.
This has had some basic testing. I'll do more during the next couple of days and hopefully also
make RPC-SRVSVC from Samba4 pass against it.
(This used to be commit ef10672399c4b82700dc431b4d93431ffdd42d98)
2007-10-10 12:00:59 -05:00
Volker Lendecke
ff7b6e52b5 r18402: Comment and (hopefully) fix remote command completion for smbclient.
Fix Bug ID 4084.

Volker
(This used to be commit 0baa3fcfa6b7d39d0f490ad0682042706f2518f2)
2007-10-10 11:51:22 -05:00
Jeremy Allison
a64925ddff r17800: Start using struct timespec internally for file times
on the wire. This allows us to go to nsec resolution
for systems that support it. It should also now be
easy to add a correct "create time" (birth time)
for systems that support it (*BSD). I'll be watching
the build farm closely after this one for breakage :-).
Jeremy.
(This used to be commit 425280a1d23f97ef0b0be77462386d619f47b21d)
2007-10-10 11:38:48 -05:00
Volker Lendecke
b29915d611 r17571: Change the return code of cli_session_setup from BOOL to NTSTATUS
Volker
(This used to be commit 94817a8ef53589011bc4ead4e17807a101acf5c9)
2007-10-10 11:38:39 -05:00
Jeremy Allison
4ef1f8e425 r16971: Ensure we use the correct separator for pathnames
in POSIX mode (clitar needs fixing too). Add test
posix lock/unlock commands.
Jeremy.
(This used to be commit 596497ccc250896025253be1d67711d6d7f059f0)
2007-10-10 11:19:16 -05:00
Jeremy Allison
760671b0e2 r16962: Add a few utility fns into client. Allow POSIX capabilities
to be selected.
Jeremy.
(This used to be commit 2d8d4bd77bac6f5e7865657e12affd8b94aa85c3)
2007-10-10 11:19:16 -05:00
Jeremy Allison
fbdcf2663b r16945: Sync trunk -> 3.0 for 3.0.24 code. Still need
to do the upper layer directories but this is what
everyone is waiting for....

Jeremy.
(This used to be commit 9dafb7f48ca3e7af956b0a7d1720c2546fc4cfb8)
2007-10-10 11:19:14 -05:00
Jeremy Allison
67af7a8c43 r16587: Fix Klocwork #1987. Memleak on reusing x_dbf.
Jeremy.
(This used to be commit 16b0617cb0f91fbe1ce53dcb601fe5ed9e51bddf)
2007-10-10 11:19:01 -05:00
Volker Lendecke
ec49dff326 r16338: Fix Klocwork ID 150
(This used to be commit ded2952e00fec712ce612cf6aaabf85c1a6f4488)
2007-10-10 11:17:36 -05:00
James Peach
06491a4cb1 r16274: Fix the smbclient prompting behaviour for both systems that have
libreadline and those that don't. We always use the built-in readline
replacement for non-interactive mode. Interactive prompts are always
emitted to stdout and non-interactive mode never prompts at all.

Introduce x_fdup to avoid spuriously closing stdout when a logfile is
specified on the command line and setup_logging is called a second time.
(This used to be commit 848ac756f651a4be231e5635580c0fd5f3d3fa0e)
2007-10-10 11:17:30 -05:00
Volker Lendecke
d93b408678 r16251: for i in seq 1 1000
do
	echo "I will always compile before commit :-)"
done

Also fix Klokwork ID 806.

Volker
(This used to be commit 4974c598c00abc20cfb73eee12a7c49c279e0f54)
2007-10-10 11:17:28 -05:00
Volker Lendecke
05f59b2c34 r16250: Fix Klokwork IDs 148, 151, 152, 154.
Volker
(This used to be commit d7a75ee94db009085165c062f73b68162a8b6da8)
2007-10-10 11:17:28 -05:00
Jeremy Allison
a1e0a0e928 r16230: Fix Klocwork #861 and others. localtime and asctime
can return NULL. Ensure we check all returns correctly.
Jeremy.
(This used to be commit 6c61dc8ed6d84f310ef391fb7700e93ef42c4afc)
2007-10-10 11:17:26 -05:00
Volker Lendecke
76a2ac3ac3 r15098: Make smbclient -L use RPC to list shares, fall back to RAP. This should list
long share names.

Volker
(This used to be commit d3d388180dacb7b9db5d122bc3f2ce1045434f53)
2007-10-10 11:16:23 -05:00
Jeremy Allison
c1bcddd803 r14359: Try and fix Coverity #176 by making the pointer
aliasing clearer. This isn't a bug but a code
clarification.
Jeremy.
(This used to be commit a3b8bee3ff8211d78f793877c877ccd2e15825dd)
2007-10-10 11:15:26 -05:00
Jeremy Allison
8f96b1bf0f r14351: Ensure we use the minimum of PATH_MAX and sizeof(pstring).
Fix Coverity #59.
Jeremy.
(This used to be commit d793e1550cc8c79a2764609cddec082470d226e4)
2007-10-10 11:15:26 -05:00
Jeremy Allison
894358a8f3 r13915: Fixed a very interesting class of realloc() bugs found by Coverity.
realloc can return NULL in one of two cases - (1) the realloc failed,
(2) realloc succeeded but the new size requested was zero, in which
case this is identical to a free() call.

The error paths dealing with these two cases should be different,
but mostly weren't. Secondly the standard idiom for dealing with
realloc when you know the new size is non-zero is the following :

 tmp = realloc(p, size);
 if (!tmp) {
    SAFE_FREE(p);
    return error;
 } else {
    p = tmp;
 }

However, there were *many* *many* places in Samba where we were
using the old (broken) idiom of :

 p = realloc(p, size)
 if (!p) {
    return error;
 }

which will leak the memory pointed to by p on realloc fail.

This commit (hopefully) fixes all these cases by moving to
a standard idiom of :

 p = SMB_REALLOC(p, size)
 if (!p) {
    return error;
 }

Where if the realloc returns null due to the realloc failing
or size == 0 we *guarentee* that the storage pointed to by p
has been freed. This allows me to remove a lot of code that
was dealing with the standard (more verbose) method that required
a tmp pointer. This is almost always what you want. When a
realloc fails you never usually want the old memory, you
want to free it and get into your error processing asap.

For the 11 remaining cases where we really do need to keep the
old pointer I have invented the new macro SMB_REALLOC_KEEP_OLD_ON_ERROR,
which can be used as follows :

 tmp = SMB_REALLOC_KEEP_OLD_ON_ERROR(p, size);
 if (!tmp) {
    SAFE_FREE(p);
    return error;
 } else {
    p = tmp;
 }

SMB_REALLOC_KEEP_OLD_ON_ERROR guarentees never to free the
pointer p, even on size == 0 or realloc fail. All this is
done by a hidden extra argument to Realloc(), BOOL free_old_on_error
which is set appropriately by the SMB_REALLOC and SMB_REALLOC_KEEP_OLD_ON_ERROR
macros (and their array counterparts).

It remains to be seen what this will do to our Coverity bug count :-).

Jeremy.
(This used to be commit 1d710d06a214f3f1740e80e0bffd6aab44aac2b0)
2007-10-10 11:10:59 -05:00
Derrell Lipman
9c15bd311d r13212: r12414@cabra: derrell | 2006-01-28 17:52:17 -0500
lp_load() could not be called multiple times to modify parameter settings based
 on reading from multiple configuration settings.  Each time, it initialized all
 of the settings back to their defaults before reading the specified
 configuration file.

 This patch adds a parameter to lp_load() specifying whether the settings should
 be initialized.  It does, however, still force the settings to be initialized
 the first time, even if the request was to not initialize them.  (Not doing so
 could wreak havoc due to uninitialized values.)
(This used to be commit f2a24de769d1b2266e576597c57a8e3b1e2a2b51)
2007-10-10 11:06:18 -05:00
Jeremy Allison
c8f28c92a7 r12555: Fix more load_case_table swegfaults. Arggg.
What I'd give for a global constructor...
Jeremy.
(This used to be commit c970d7d0a5ba225465dfb0980989b8817b17c643)
2007-10-10 11:05:59 -05:00
Jeremy Allison
0732d25057 r11978: Volker's fix for #3292 (smbclient spins if server terminates
connection).
Jeremy.
(This used to be commit 9b8602e0551500916a9d79c317589cd82d3da111)
2007-10-10 11:05:41 -05:00
Jeremy Allison
0af6dcacec r11976: (Slightly modified) Volker fix for #3293. Use SMBecho instead of
chkpath to keep a connection alive.
Jeremy.
(This used to be commit f1c88de7a28942b6aaa634551dde7a8af91f4de3)
2007-10-10 11:05:40 -05:00
Jeremy Allison
8e178d8dce r11839: Info level 0x101 is really a protocol NT level.
Fix bug #3274 from Guenter Kukkukk <guenter.kukkukk@kukkukk.com>
Jeremy.
(This used to be commit e4b3b70ef1c0fea3252b73c55ea3e9cad7229afd)
2007-10-10 11:05:29 -05:00
Gerald Carter
04b6c1303c r11770: BUG 2718: don't use qpathinfo_basic() call when remote server is Win9x or the do_cd() call will fail
(This used to be commit be31c2a105ae2b6e655530190c939caae1b41294)
2007-10-10 11:05:28 -05:00
Jeremy Allison
6d5757395a r11511: A classic "friday night check-in" :-). This moves much
of the Samba4 timezone handling code back into Samba3.
Gets rid of "kludge-gmt" and removes the effectiveness
of the parameter "time offset" (I can add this back
in very easily if needed) - it's no longer being
looked at. I'm hoping this will fix the problems people
have been having with DST transitions. I'll start comprehensive
testing tomorrow, but for now all modifications are done.
Splits time get/set functions into srv_XXX and cli_XXX
as they need to look at different timezone offsets.
Get rid of much of the "efficiency" cruft that was
added to Samba back in the day when the C library
timezone handling functions were slow.
Jeremy.
(This used to be commit 414303bc0272f207046b471a0364fa296b67c1f8)
2007-10-10 11:05:19 -05:00
Gerald Carter
057060feaf r10964: BUG 1051: store the directory path so we can send the full name in the unlink call (del tmp\foo)
(This used to be commit 49b8d7d7f5ed93a2b9b21404194452f35bcf7b26)
2007-10-10 11:04:58 -05:00
Jeremy Allison
b67ba1e36b r9545: (Hopefully the last) fixes for DIR -> SMB_STRUCT_DIR.
Jeremy.
(This used to be commit b242f278601e1a23c9116009482e802326d418f7)
2007-10-10 11:01:12 -05:00
Tim Potter
ab398643a4 r8572: Remove crufty #define NO_SYSLOG as it's not used at all anymore.
(This used to be commit 985dbb47d925e79c1195ca219f7ab5d6648b22b8)
2007-10-10 11:00:11 -05:00
Gerald Carter
d8601c4a37 r8478: remove unused printmode command from smbclient (noticed by kalim@samba.org)
(This used to be commit aa5de7d0b35b07dfb32aa43df00f73de80de9fdd)
2007-10-10 11:00:06 -05:00
Gerald Carter
6a3a0766d5 r6685: smbclient fixes
* BUG 2680: copy files from an MSDFS win2k root share
* BUG 2688: re-implement support for the -P (--port) option
* support connecting to an 'msdfs proxy' share on a Samba server
(This used to be commit 9e3e473632fee669eda477d8cbe309b7109552ea)
2007-10-10 10:56:51 -05:00
Gerald Carter
67e9fb7c7c r6388: BUG 2626: ensure that the calling_name is set to something after parsing smb.conf (if not set via -n)
(This used to be commit 97c68ec1e86c1de44fa1ab6e5a9d7f58b2843a34)
2007-10-10 10:56:39 -05:00
Jeremy Allison
cc7ebb3f14 r6348: Fix for bug #2605 reported by Daniel Patterson <Daniel_Patterson@national.com.au>.
Ensure smbclient doesn't perform commands if the "chdir" fails in a scripted set.
Jeremy.
(This used to be commit 644608ea7db6d8d73a8c028a82cd0767ffe32af6)
2007-10-10 10:56:37 -05:00
Gerald Carter
121c22d1d5 r6291: BUG 2588: force smbclient messages to port 139 unless someone set the -p option
(This used to be commit 40f573e202096088957bfff8ca2eb49f5b4985bd)
2007-10-10 10:56:35 -05:00
Herb Lewis
978ca84860 r6225: get rid of warnings from my compiler about nested externs
(This used to be commit efea76ac71412f8622cd233912309e91b9ea52da)
2007-10-10 10:56:30 -05:00