1
0
mirror of https://github.com/samba-team/samba.git synced 2024-12-25 23:21:54 +03:00
Commit Graph

284 Commits

Author SHA1 Message Date
Volker Lendecke
ba6fa9e527 s3: Fix Coverity ID 242723 Uninitialized scalar variable
In an error path we are closing hnd without opening it
2012-05-10 09:11:57 +02:00
Volker Lendecke
4487f26815 s3: Fix Coverity ID 241961 Uninitialized scalar variable 2012-05-10 09:11:57 +02:00
Volker Lendecke
446791c6bf s3: Fix Coverity ID 242724 Uninitialized scalar variable
In an error path we are closing pol without opening it
2012-05-10 09:11:57 +02:00
Gregor Beck
d14ca5d07a s3:registry: remove usage of reg_objects from cmd_spoolss.c
Signed-off-by: Andreas Schneider <asn@samba.org>
2012-04-25 14:23:03 +02:00
Andrew Bartlett
34d52532b5 s3-rpcclient: pass struct ndr_interface_table down
This will allow the target service (as determined from the IDL) to be
passed to GSSAPI (rather than the current, incorrect, "cifs").

Andrew Bartlett

Signed-off-by: Stefan Metzmacher <metze@samba.org>
2012-01-18 16:23:24 +01:00
David Disseldorp
97818fd6e5 s3-rpcclient: add deldriverex flags argument
The spoolss DeletePrinterDriverEx command offers three flags for
controlling how associated files and other versions of the driver are
effected: DPD_DELETE_UNUSED_FILES (1), DPD_DELETE_SPECIFIC_VERSION (2)
and DPD_DELETE_ALL_FILES (4).

This commit adds an optional numeric flags argument to the rpcclient
deldriverex command.

Signed-off-by: David Disseldorp <ddiss@samba.org>
Signed-off-by: Andreas Schneider <asn@samba.org>

Autobuild-User: David Disseldorp <ddiss@samba.org>
Autobuild-Date: Wed Jan 11 14:39:35 CET 2012 on sn-devel-104
2012-01-11 14:39:35 +01:00
Andrew Bartlett
74eed8f3ed s3-param Remove special case for global_myname(), rename to lp_netbios_name()
There is no reason this can't be a normal constant string in the
loadparm system, now that we have lp_set_cmdline() to handle overrides
correctly.

Andrew Bartlett
2011-06-09 12:40:09 +02:00
Andrew Bartlett
c615ebed6e s3-lib Replace StrCaseCmp() with strcasecmp_m()
strcasecmp_m() never needs to call to talloc, and via next_codepoint()
still has an ASCII fast-path bypassing iconv() calls.

Andrew Bartlett
2011-05-18 16:12:08 +02:00
Günther Deschner
27022587e3 s3-libsmb: move protos to libsmb/proto.h
Guenther
2011-05-06 16:37:18 +02:00
Günther Deschner
c11d52c7f6 s3-rpcclient: run minimal_includes.pl.
Guenther
2011-05-05 02:05:27 +02:00
Günther Deschner
2352e7cb7f s3-rpcclient: include rpc_client/cli_pipe.h globally in rpcclient.h
Guenther
2011-03-31 00:14:01 +02:00
Günther Deschner
0a250f4946 registry: create and use shared libcli/registry/util_reg.h header.
Guenther
2011-03-30 01:13:07 +02:00
Günther Deschner
49ccae1c20 s3-includes: no point in including all security headers globally.
Guenther
2011-03-30 01:13:07 +02:00
Günther Deschner
e1f84330ba libcli/security: move display_sec headers to own header file and add to
security.h grouping header.

Guenther
2011-03-16 10:11:08 +01:00
Jelmer Vernooij
59a077d8f5 Fix some types
Autobuild-User: Jelmer Vernooij <jelmer@samba.org>
Autobuild-Date: Mon Feb 28 23:30:06 CET 2011 on sn-devel-104
2011-02-28 23:30:06 +01:00
Andreas Schneider
bf18403c81 s3-rpc_client: Move client pipe functions to own header. 2011-02-28 18:15:04 +01:00
Günther Deschner
50be0b2c1e s3: Remove superfluous ;
Guenther

Autobuild-User: Günther Deschner <gd@samba.org>
Autobuild-Date: Wed Feb  2 15:44:21 CET 2011 on sn-devel-104
2011-02-02 15:44:21 +01:00
Günther Deschner
d4414f08cb s3-rpcclient: use struct based dcerpc_spoolss_EnumPrinterData_r() call.
This is a workaround for a string issue we currently have with argument based
generated dcerpc client code (see bug #7804 for details).

Guenther
2011-01-28 21:16:46 +01:00
Günther Deschner
cf7a78b64f s3-rpcclient: prefer dcerpc_spoolss_X functions.
Guenther
2011-01-21 15:20:22 +01:00
Björn Baumbach
f5af66e67d s3-rpcclient: Fix bug #7880: cmd_spoolss_deletedriver() returned without checking all architectures.
Continues now with next architecture if no driver is available.

Because of the broken behavior of the rpccli_*() functions,
we need special error code handling.

Signed-off-by: Stefan Metzmacher <metze@samba.org>
2011-01-12 17:25:53 +01:00
Volker Lendecke
d096de56b1 s3: Remove unused "retry" from cli_full_connection 2010-12-20 17:10:58 +01:00
Günther Deschner
b432a3ba19 s3-rpcclient: exit early in cmd_spoolss_enum_data() when there is a failure.
Guenther
2010-11-17 15:20:14 +01:00
Günther Deschner
12112d545c s3-rpcclient: add openprinter_ex command.
Guenther
2010-10-07 17:26:00 +02:00
Günther Deschner
813fbbd68c s3-build: avoid to globally include printing and spoolss headers.
This shrinks precompiled headers by 3MB and will slightly speed up any build.

Guenther
2010-07-31 00:50:31 +02:00
Jeremy Allison
f34db12d7f Add parse_setjob_command() to make setting job state easier for users.
Jeremy.
2010-06-23 13:25:15 -07:00
Günther Deschner
b3ebebd3b1 s3-rpcclient: allow to add access_mask in cmd_spoolss_open_printer_ex().
Guenther
2010-06-05 00:35:09 +02:00
Günther Deschner
30a9ddccff s3-spoolss: add and use spoolss_printerinfo2_to_setprinterinfo2().
This fixes some invalid typecasts.

Guenther
2010-06-03 16:32:49 +02:00
Michael Adam
0fe1ff99a1 s3:registry: move reg_objects.h to registry/ and use it only where needed
Every place outside of registry/ where this is used, should probably
be changed to use pure reg_api.c code.
2010-05-25 10:35:31 +02:00
Michael Adam
7b2f5f20da s3:rpcclient:spoolss: use regval_ctr/blob accessor functions. 2010-05-25 10:35:30 +02:00
Günther Deschner
5a6f3a0666 s3-rpc_client: move protos to init_spoolss.h
Guenther
2010-05-18 21:42:48 +02:00
Günther Deschner
cc06133b0a s3-rpc_client: move protos to cli_spoolss.h
Guenther
2010-05-18 21:42:45 +02:00
Günther Deschner
7f6bb48bdf s3-secdesc: remove "typedef struct security_descriptor SEC_DESC".
Guenther
2010-05-18 12:30:12 +02:00
Jelmer Vernooij
b8268cf7b0 s3: Remove use of iconv_convenience. 2010-05-18 11:45:31 +02:00
Günther Deschner
fe31b67d5e s3-registry: only include registry headers when really needed.
Guenther
2010-05-18 01:15:38 +02:00
Günther Deschner
83736066a3 s3-rpcclient: fix two more invalid typecasts in spoolss commands.
Guenther
2010-05-10 14:51:14 +02:00
Günther Deschner
9cc10e6a57 s3-rpcclient: Fix Bug #7277. rpcclient was sending invalid data, causing cupsaddsmb to fail.
Guenther
2010-05-03 16:30:13 +02:00
Günther Deschner
63b111bd32 s3: add iconv_convenience handle to pull/push sz helpers.
Guenther
2010-04-09 18:33:45 +02:00
Andreas Schneider
47d366b572 s3-rpcclient: Leave setprinterdata directly if not enough args were passed.
If we don't pass enough arguments we don't have to close the connection.

Signed-off-by: Günther Deschner <gd@samba.org>
2010-03-05 21:27:15 +01:00
Günther Deschner
becbb624eb s3-rpcclient: fix rpcclient after spoolss_EnumPrinterDataEx IDL change.
Guenther
2010-03-05 15:18:01 +01:00
Günther Deschner
7643afa70e s3-rpcclient: fix rpcclient after spoolss_GetPrinterData{Ex} IDL change.
Guenther
2010-03-05 15:18:00 +01:00
Günther Deschner
4956650369 s3-rpcclient: fix rpcclient after spoolss_SetPrinterData{Ex} IDL change.
Guenther
2010-03-05 15:17:59 +01:00
Günther Deschner
31cf2b086a s3-spoolss: fix rpcclient after setprinter IDL fixes.
Guenther
2009-12-17 10:43:31 +01:00
Günther Deschner
c2618d2c6f s3-rpcclient: allow to set offered size for enumkey command.
Guenther
2009-12-10 22:49:16 +01:00
Günther Deschner
c85ed0054e s3: fix net and rpcclient after setprinterdataex changes.
Guenther
2009-12-07 14:42:13 +01:00
Günther Deschner
3d679a3b5f s3-rpc: Avoid including every pipe's client and server stubs everywhere in samba.
Guenther
2009-11-26 20:03:17 +01:00
Volker Lendecke
bb283af16f Revert "s3: Do not directly reference the ndr_table_* in rpcclient"
This reverts commit 70c698fd54.
2009-11-08 19:43:47 +01:00
Volker Lendecke
70c698fd54 s3: Do not directly reference the ndr_table_* in rpcclient 2009-11-08 00:28:36 +01:00
Günther Deschner
ad836c4d48 s3-registry: use pull_reg_sz() where appropriate.
(and move away from rpcstr_pull and rpcstr_pull_talloc).

Guenther
2009-10-01 11:40:30 +02:00
Günther Deschner
b0a66496f5 s3: use pull_reg_multi_sz in rpcclient and net.
Guenther
2009-09-30 00:31:42 +02:00
Günther Deschner
ffbcf3b491 s3-rpcclient: add createprinteric command.
Guenther
2009-07-17 15:40:18 +02:00