Karolin Seeger
490b60b500
Use LDAP macros instead of attribute names.
...
Karolin
(This used to be commit 7dae8b04f126d0ac86a452dcf373a690ee687ead)
2008-07-18 15:36:20 +02:00
Karolin Seeger
df15541926
Fix typo.
...
retieve -> retrieve
Karolin
(This used to be commit 37c64130701ab13b6f34998ac17fec2d128c2e08)
2008-07-14 16:40:36 +02:00
Volker Lendecke
e613ecbea5
Revert "Make use of sid_check_is_in_unix_users/groups"
...
This reverts commit cd8e63b2b45402091d6d328b3c6ca593fc19ac92.
(This used to be commit 061e55d4f48d269dc45fad6739e0872501b9433d)
2008-07-11 17:53:25 +02:00
Volker Lendecke
68071e94a5
Revert "Don't scream, better explain a bit in comments"
...
This reverts commit dcc39ed00453a075b23daece2844ca4817bfbfaf.
(This used to be commit 26ca09a3570a0df051d042bef586ea57ad9f198c)
2008-07-11 17:53:25 +02:00
Volker Lendecke
d803fa6e46
Revert "Remove an unused variable"
...
This reverts commit 454cb852e06fa3d8bdd0eebb3ebdb24b3d74ecd0.
(This used to be commit cae8ec3199d5b0ffe0bfb6f15adaa5a12343c763)
2008-07-11 17:53:25 +02:00
Volker Lendecke
90f3da4720
Fix some memleaks regarding trustdom passwords
...
(This used to be commit 3d2913d599a4cd773614110ec7b7493aa7adb547)
2008-07-10 18:25:00 +02:00
Volker Lendecke
ad91d960d0
Fix some uninitialized variable references via ndr_print
...
(This used to be commit 26fb3fea812867f8b0dfe6a1be59e4922ed86e45)
2008-07-10 18:24:54 +02:00
Volker Lendecke
516e381e09
Give a nice error message if trying to join with a non-privileged user
...
(This used to be commit 347772fc39d9c7a96fcc72c9707696cc6abd89d7)
2008-07-10 10:48:15 +02:00
Volker Lendecke
b611fd9550
Remove an unused variable
...
(This used to be commit 454cb852e06fa3d8bdd0eebb3ebdb24b3d74ecd0)
2008-07-03 16:44:13 +02:00
Volker Lendecke
d1635687ae
Don't scream, better explain a bit in comments
...
(This used to be commit dcc39ed00453a075b23daece2844ca4817bfbfaf)
2008-07-03 11:08:51 +02:00
Volker Lendecke
abb42b267b
Make use of sid_check_is_in_unix_users/groups
...
Don't replicate code unnecessarily
(This used to be commit cd8e63b2b45402091d6d328b3c6ca593fc19ac92)
2008-07-03 11:08:51 +02:00
Volker Lendecke
0e7d1aae2f
Fix a memleak in secrets_fetch_afs_key
...
Coverity ID 570
(This used to be commit 0f52dc3f7eae7e87b8a71bd099b99b0b3e76a387)
2008-06-07 08:51:35 +02:00
Volker Lendecke
8c98f5af6f
Fix a memleak in secrets_fetch_trust_account_password_legacy
...
Coverity ID 571
(This used to be commit a551773e34af1c118f77784a285e1b885da8655d)
2008-06-07 08:50:02 +02:00
Volker Lendecke
32452565be
Fix a memleak in fetch_ldap_pw
...
Fix Coverity ID 572, also fix the error check for secrets_fetch failing
(This used to be commit 2663c81a782fd4394a9feaaaa987c7f6d38ca5da)
2008-06-07 08:48:13 +02:00
Michael Adam
6cebad5b67
Remove unused function is_trusted_domain_situation().
...
This combined check has been replaced by is_dc_trusted_domain_situation()
which does not check for lp_allow_trusted_domains().
Michael
(This used to be commit 0a24c038b7bc6edef0021eb121a072cc7e8f9165)
2008-05-26 16:42:25 +02:00
Michael Adam
6efce4738f
passdb: check for is_dc_trusted_domain_situation() in get_trust_pw_hash().
...
Before fetching legacy password hash, check for trusted domain situation,
but also fail if trusted domain support is not enabled.
Michael
(This used to be commit aa1b8287f44f47f23bd4158112d0a132df04426c)
2008-05-26 16:42:24 +02:00
Michael Adam
48026d814b
passdb: add comment explaining logic in get_trust_pw_clear().
...
Michael
(This used to be commit 5f197c659e9c8a573ba5032c7f90c816df45770c)
2008-05-26 16:42:24 +02:00
Michael Adam
a186e598c4
passdb: in get_trust_pw_clear() correctly fail if trusted domains not supported
...
(but trusted domain situation was found)
This completes the fix for bugs #5425 and #5451 by Steven Dannemann,
in that now no special cases are left uncovered.
Michael
(This used to be commit 0b26bcd3becb869319bca48bbf244c18b6e8e3dd)
2008-05-26 16:42:24 +02:00
Michael Adam
4de01a909a
Add function is_dc_trusted_domain_situation().
...
This is like is_trusted_domain_situation() except that it does not
check for lp_allow_trusted_domains().
Michael
(This used to be commit a284c8843528972904d142b573f1170a08c97751)
2008-05-26 16:42:24 +02:00
Gerald W. Carter
b72fc49f44
Manually port Steven Dannenman fix for using the correct machine domain when
...
looking up trust credentials in our tdb.
commit fd0ae47046d37ec8297396a2733209c4d999ea91
Author: Steven Danneman <sdanneman@isilon.com>
Date: Thu May 8 13:34:49 2008 -0700
Use machine account and machine password from our domain when
contacting trusted domains.
(This used to be commit 69b37ae60757075a0712149c5f97f17ee22c2e41)
2008-05-23 15:19:58 -05:00
Tim Prouty
fb37f15600
Cleanup size_t return values in callers of convert_string_allocate
...
This patch is the second iteration of an inside-out conversion to cleanup
functions in charcnv.c returning size_t == -1 to indicate failure.
(This used to be commit 6b189dabc562d86dcaa685419d0cb6ea276f100d)
2008-05-20 22:40:13 +02:00
Volker Lendecke
3643aa9a63
Fix a panic in the [ug]id2sid valgrind bug fix
...
Always, always run "make test" before pushing stuff :-)
(This used to be commit 1444db8be1de00a3e9c805f1accd8f1f4670d729)
2008-05-06 13:56:21 +02:00
Volker Lendecke
1fe90d8d04
Fix a valgrind bug in the new [ug]id2sid cache
...
When we're given a SID, it is not always padded with zeros. Only look at the
initialized parts in the SID.
(This used to be commit 8717085dba832cfe6d7b807a10f779e495adc326)
2008-05-06 12:16:02 +02:00
Volker Lendecke
2b3d03d6f1
Remove unix_homedir from struct user_struct
...
This makes pdb_get_unix_homedir unused. I wonder if that was ever really used...
(This used to be commit 36bfd32f1ff878e827db91e9bf233719ecca5b01)
2008-05-05 18:28:58 +02:00
Stefan Metzmacher
625f2d6c23
pdb_tdb: fix the upgrade code, db_traverse returns the number of records!
...
metze
(This used to be commit baaf571d540ace5119c528fd35bceab335bd6741)
2008-04-15 00:25:11 +02:00
Volker Lendecke
16198dc51e
Convert dbwrap_trans_delete to NTSTATUS
...
Signed-off-by: Stefan Metzmacher <metze@samba.org>
(This used to be commit dead193f46c2b19955ab3e5ac5ba343694f4858a)
2008-04-01 14:04:22 +02:00
Volker Lendecke
fcdfff1cc8
Convert dbwrap_trans_store to NTSTATUS
...
Signed-off-by: Stefan Metzmacher <metze@samba.org>
(This used to be commit 5f4de856af1abe63b13059bbe1615cb5877770d0)
2008-04-01 14:04:22 +02:00
Stefan Metzmacher
8957f6b0cf
pdb_tdb: use != 0 instead off == -1 for dbwrap functions
...
metze
(This used to be commit d4826a01369c00b5e83cd62c2412a4eb826e216d)
2008-04-01 14:04:20 +02:00
Stefan Metzmacher
663eb087e6
passdb: guard pdb_generate_sam_sid() with a transaction
...
This prevents possible races with some dbwrap backends
metze
(This used to be commit 9322442510d9c2cf16c25f5109fe81b277c44881)
2008-04-01 14:04:20 +02:00
Stefan Metzmacher
a5f3911d70
passdb/secrets: add secrets_db_ctx() to get the db_context
...
metze
(This used to be commit 986bc7e8b260265da019b67ec751509eb589d24b)
2008-04-01 14:04:20 +02:00
Stefan Metzmacher
dbd2e3860d
pdb_tdb: use db_open_trans()
...
metze
Signed-off-by: Stefan Metzmacher <metze@samba.org>
(This used to be commit 9925cc01a2a4739d6cde5991eb0d0b79ae13353b)
2008-03-27 18:14:57 +01:00
Stefan Metzmacher
7d413b8bee
pdb_tdb: use db_sam->transaction_start(db_sam) != 0 consistent
...
metze
Signed-off-by: Stefan Metzmacher <metze@samba.org>
(This used to be commit 3bf9ab640e9a79157fcfee0b5d0cde5badc92755)
2008-03-27 18:14:57 +01:00
Stefan Metzmacher
4b2ce410a5
passdb/secrets: use db_open_trans()
...
metze
Signed-off-by: Stefan Metzmacher <metze@samba.org>
(This used to be commit b61b8ca4944f399216d8e67a48ea7d259258b432)
2008-03-27 18:14:57 +01:00
Stefan Metzmacher
3b0592bc15
passdb/secrets: it's enough to use traverse_read() in secrets_trusted_domains()
...
metze
Signed-off-by: Stefan Metzmacher <metze@samba.org>
(This used to be commit 729f7b9ff30e81537a7257daeaa1728c7ae96853)
2008-03-27 18:14:56 +01:00
Marc VanHeyningen
e06aa46b9f
Coverity fixes
...
(This used to be commit 3fc85d22590550f0539215d020e4411bf5b14363)
2008-03-17 20:52:25 +01:00
Volker Lendecke
88ee949777
Convert pdb_tdb to use dbwrap
...
(This used to be commit 948ab77863b12b1b0bd1c970004b84b9bb1bb2fa)
2008-03-17 11:51:50 +01:00
Volker Lendecke
f3856d074f
Fix bug 4901
...
(This used to be commit 1dd8fa9a521046f1de8173ac00224706c5249665)
2008-03-14 18:01:23 +01:00
Volker Lendecke
28244425b2
Convert secrets.c to use dbwrap
...
(This used to be commit 9d30e5991c6fe77ef5fd505efb756554bbe77256)
2008-03-11 17:09:19 +01:00
Volker Lendecke
1ebfc66b2c
Use a separate tdb for mutexes
...
Another preparation to convert secrets.c to dbwrap: The dbwrap API does not
provide a sane tdb_lock_with_timeout abstraction. In the clustered case the DC
mutex is needed per-node anyway, so it is perfectly fine to use a local mutex
only.
(This used to be commit f94a63cd8f94490780ad9331da229c0bcb2ca5d6)
2008-03-10 21:08:45 +01:00
Volker Lendecke
d634ab06b3
Convert secrets_lock_trust_account_password to talloc
...
This is preparing the conversion of secrets.c to ctdb
(This used to be commit 1307f0130c47b8d740d2b7afe7a5d8d1a655e2a2)
2008-03-10 21:08:45 +01:00
Volker Lendecke
b175ffa702
Make use of talloc_asprintf_strupper_m in secrets.c
...
(This used to be commit 3ac4f935c074af768d0b83514f86d010c387817a)
2008-03-10 09:52:08 +01:00
Volker Lendecke
2e8d375346
Avoid some pointless checks
...
secrets_init() makes sure that the tdb is initialized
(This used to be commit 8725dbc8888cf7a1d3d9d1205678fcd3ca3c6350)
2008-03-10 09:51:58 +01:00
Volker Lendecke
c2cd0e3c54
Use talloc_tos() in secrets_init
...
(This used to be commit 27065382d9b692b5885265c9d60ffb7ec7748c38)
2008-03-10 09:51:51 +01:00
Volker Lendecke
9d7cad7e82
Fix a memleak -- Coverity ID 222
...
(cherry picked from commit a40781bafa3a8f0c7737164bca6cf74b0a452e72)
(This used to be commit 86cabcad74ac06d888f2a352a2bef3abea1ed85c)
2008-03-05 18:44:26 +01:00
Günther Deschner
2c5e04b1f7
Fix crash bug in pdb_init_ldapsam().
...
Karolin, this needs to be in 3-2-stable.
Guenther
(This used to be commit 0d73bde6de4391e7aec862424762473441fa0905)
2008-03-04 11:03:35 +01:00
Volker Lendecke
3176392878
Fix some warnings
...
warning: ignoring return value of 'asprintf', declared with attribute warn_unused_result
(This used to be commit ad37b7b0aee265a3e4d8b7552610f4b9a105434d)
2008-02-25 16:09:26 +01:00
Karolin Seeger
cdb88dcf6b
Change ldap search filter. This function is also used to search machine accounts which may be located in a different ou. This is an extension to e71a48bb80cee85afcccacbce2884c0d600f4d72.
...
Karolin
(This used to be commit e5cc8b683cba3f2f3a84b1636b3d5bee1bfc0dda)
2008-02-19 12:35:54 +01:00
Günther Deschner
7dfeae6073
Use netr_SamInfo3 in remaining places.
...
Guenther
(This used to be commit 92fca97951bf7adf8caaeabdaff21682b18dd91f)
2008-02-17 02:12:01 +01:00
Stefan Metzmacher
cedfcaec0c
nsswitch: convert winbind_env_set(), winbind_on() and winbind_off() into macros
...
metze
(This used to be commit 5f623f54a919cc687d0ff16c16038c05a501008d)
2008-02-13 10:44:52 +01:00
Günther Deschner
e4501b0913
Add get_logon_hours_from_pdb() (inspired by samba4).
...
Guenther
(This used to be commit e1bcb7d82f22810e342a18aacbcfe49c3902bcb4)
2008-02-12 14:52:25 +01:00