Pavel Shilovsky
7690d9d70c
Fix bug #7928 - Samba problems with kernel oplocks option set to "no"
...
We should not grant levelII oplocks on a file with existing
byte range locks.
2011-01-31 12:00:15 -08:00
Stefan Metzmacher
ad10289ebc
s3:lib/events: use DLIST_DEMOTE() for fd events
...
This makes sure that fd events doesn't dry out,
because a fd with a lower number is busy.
metze
Autobuild-User: Stefan Metzmacher <metze@samba.org>
Autobuild-Date: Mon Jan 31 16:59:44 CET 2011 on sn-devel-104
2011-01-31 16:59:44 +01:00
Stefan Metzmacher
0bbe7334d6
s3:smbd: let smbd_server_connection_loop_once() check for select errors
...
metze
2011-01-31 16:16:09 +01:00
Stefan Metzmacher
1f2be10ebf
s3:lib/events: don't loop over fd events is select gave -1
...
metze
2011-01-31 16:16:09 +01:00
Stefan Metzmacher
6953e2fa66
Revert "s3: Fix starving the echo responder"
...
This reverts commit d5cf6482ed
.
I'll add a more generic fix for this problem.
metze
2011-01-31 16:16:09 +01:00
Stefan Metzmacher
19d3779274
Revert "s3:events: Call all ready fd event handlers on each iteration of the main loop"
...
This reverts commit 455fccf86b
.
I'll add a more generic fix for this problem.
metze
2011-01-31 16:16:09 +01:00
Günther Deschner
35a7bebe2b
s3-waf: On FreeBSD, compile zfsacl if sunacl.h is around.
...
Volker, please check.
Guenther
Autobuild-User: Günther Deschner <gd@samba.org>
Autobuild-Date: Mon Jan 31 10:51:10 CET 2011 on sn-devel-104
2011-01-31 10:51:10 +01:00
Günther Deschner
eb5d884b15
s3-waf: these libs are not private libs.
...
Guenther
2011-01-31 10:04:42 +01:00
Stefan Metzmacher
e2e426588b
s3:libsmb: display NT_STATUS_RPC_SEC_PKG_ERROR in error strings
...
metze
2011-01-30 17:36:21 +01:00
Michael Adam
e57d4c41d7
s3:net registry: ignore WERR_BADFILE when --force is given in deletekey[_recursive]
...
Autobuild-User: Michael Adam <obnox@samba.org>
Autobuild-Date: Sun Jan 30 14:53:13 CET 2011 on sn-devel-104
2011-01-30 14:53:13 +01:00
Michael Adam
b1f800a0d1
s3:registry: in deletekey_recursive, fix return code upon error.
...
correctly keep the werr from inside the transaction when the opearation
inside the transaction fails.
What is the correct behaviour if the cancel operation fails?
2011-01-30 14:09:04 +01:00
Michael Adam
e81ddbcade
s3:net registry: fix a debug message.
2011-01-30 14:09:04 +01:00
Michael Adam
3649798bee
s3:net registry: fix a debug message.
2011-01-30 14:09:04 +01:00
Volker Lendecke
e6e7c724ad
s3: On FreeBSD, compile zfsacl if sunacl.h is around
...
Autobuild-User: Volker Lendecke <vlendec@samba.org>
Autobuild-Date: Sun Jan 30 12:17:49 CET 2011 on sn-devel-104
2011-01-30 12:17:48 +01:00
Volker Lendecke
619e5cb646
s3: Make _lp_maxprotocol static
...
Autobuild-User: Volker Lendecke <vlendec@samba.org>
Autobuild-Date: Sat Jan 29 16:07:28 CET 2011 on sn-devel-104
2011-01-29 16:07:28 +01:00
Volker Lendecke
a042617e97
s3: Remove an unneeded check
...
In many other places we already assume that if asprintf returns !=-1 then the
result is allocated.
Autobuild-User: Volker Lendecke <vlendec@samba.org>
Autobuild-Date: Sat Jan 29 15:00:09 CET 2011 on sn-devel-104
2011-01-29 15:00:09 +01:00
Volker Lendecke
c52c75338f
s3: inline get_uid_from_state
...
Autobuild-User: Volker Lendecke <vlendec@samba.org>
Autobuild-Date: Fri Jan 28 23:38:16 CET 2011 on sn-devel-104
2011-01-28 23:38:16 +01:00
Volker Lendecke
e099c91ef9
s3: Lift winbindd_cli_state from fillup_password_policy
2011-01-28 22:54:19 +01:00
Volker Lendecke
fe516a3fb7
s3: Do not use state->mem_ctx in fillup_password_policy
2011-01-28 22:54:19 +01:00
Volker Lendecke
2d174d49cd
s3: Lift winbindd_cli_state from winbindd_dual_pam_auth_samlogon
2011-01-28 22:54:19 +01:00
Volker Lendecke
5d4bfc949b
s3: Lift winbindd_cli_state from winbindd_raw_kerberos_login
2011-01-28 22:54:19 +01:00
Jeremy Allison
f2900a8b04
We need to reply to SMB2_GETINFO_FILE with a class of SMB2_FILE_STANDARD_INFO on an IPC$ share.
...
Otherwise a Win7 client issues this request twice (2xroundtrips)
if we return NOT_SUPPORTED. We do the same for SMB1 in call_trans2qpipeinfo()
Jeremy.
Autobuild-User: Jeremy Allison <jra@samba.org>
Autobuild-Date: Fri Jan 28 22:53:18 CET 2011 on sn-devel-104
2011-01-28 22:53:18 +01:00
Günther Deschner
fc16baaf91
s3-net: use struct based dcerpc_spoolss_EnumPrinterData_r() call.
...
This is a workaround for a string issue we currently have with argument based
generated dcerpc client code (see bug #7804 for details).
Guenther
Autobuild-User: Günther Deschner <gd@samba.org>
Autobuild-Date: Fri Jan 28 22:05:20 CET 2011 on sn-devel-104
2011-01-28 22:05:20 +01:00
Günther Deschner
d4414f08cb
s3-rpcclient: use struct based dcerpc_spoolss_EnumPrinterData_r() call.
...
This is a workaround for a string issue we currently have with argument based
generated dcerpc client code (see bug #7804 for details).
Guenther
2011-01-28 21:16:46 +01:00
Günther Deschner
1232fb5a1e
s3-rpc_client: remove some more obsolete cli_X.h header files.
...
Guenther
Autobuild-User: Günther Deschner <gd@samba.org>
Autobuild-Date: Fri Jan 28 11:18:44 CET 2011 on sn-devel-104
2011-01-28 11:18:44 +01:00
Jeremy Allison
ba6dda1934
Add delete-ln test now we can correctly delete hardlinks.
...
Autobuild-User: Jeremy Allison <jra@samba.org>
Autobuild-Date: Fri Jan 28 01:24:19 CET 2011 on sn-devel-104
2011-01-28 01:24:19 +01:00
Jeremy Allison
eec50b21f6
Change "security=share" to downgrade to SMB1 from SMB2, rather than trying to fake it.
2011-01-27 15:26:47 -08:00
Michael Adam
5dd63c6c14
libwbclient: bump the libwbclient SOVER 0 -> 1 due to ABI changes
...
Autobuild-User: Michael Adam <obnox@samba.org>
Autobuild-Date: Fri Jan 28 00:25:11 CET 2011 on sn-devel-104
2011-01-28 00:25:11 +01:00
Michael Adam
14502c5458
s3:registry: fix comments in regdb_store_regdb_version()
2011-01-27 21:43:48 +01:00
Günther Deschner
9d04f2bd68
s3-build: remove another leftover of -I../source4.
...
Guenther
Autobuild-User: Günther Deschner <gd@samba.org>
Autobuild-Date: Thu Jan 27 13:30:30 CET 2011 on sn-devel-104
2011-01-27 13:30:30 +01:00
David Disseldorp
eb55338ccd
Looking into printer driver issues, I ran across some peculiarities in
...
copy_file():
- Firstly, if the source file is zero bytes, NT_STATUS_DISK_FULL is
returned.
- Secondly, the conditional lseek is confusing. It fires when
OPENX_FILE_EXISTS_OPEN is set and I can't see why the lseek is
necessary in this case.
- Finally, the lseek error path also results in NT_STATUS_DISK_FULL.
Proposed fix for first and third point below.
Autobuild-User: Jeremy Allison <jra@samba.org>
Autobuild-Date: Thu Jan 27 00:59:56 CET 2011 on sn-devel-104
2011-01-27 00:59:56 +01:00
Andreas Schneider
efde1d870b
s3-utils: Fixed a resource leak in net_afs.
...
s3-utils: Fixed a resource leak in net_afs.
Autobuild-User: Jeremy Allison <jra@samba.org>
Autobuild-Date: Thu Jan 27 00:12:47 CET 2011 on sn-devel-104
2011-01-27 00:12:47 +01:00
Andreas Schneider
4fc75c755d
s3-utils: Fixed a resource leak in smbta-util.
...
s3-utils: Fixed a resource leak in smbta-util.
2011-01-26 14:20:37 -08:00
Andreas Schneider
f419c2b091
s3-utils: Fixed possible resource leak in net_usershare.
...
s3-utils: Fixed possible resource leak in net_usershare.
2011-01-26 14:20:37 -08:00
Andreas Schneider
de4ef101c1
s3-utils: Fixed possible resource leak in smbget.
...
s3-utils: Fixed possible resource leak in smbget.
2011-01-26 14:20:37 -08:00
Andreas Schneider
08dc51d3ca
s3-utils: Fixed possible resource leak in smbfilter.
...
s3-utils: Fixed possible resource leak in smbfilter.
2011-01-26 14:20:37 -08:00
Andreas Schneider
f6f0dac427
s3-modules: Fixed the for-loop code block.
...
s3-modules: Fixed the for-loop code block.
2011-01-26 14:20:37 -08:00
Andreas Schneider
2c47368d68
s3-lib: Fixed a missing return value in tldap.
...
s3-lib: Fixed a missing return value in tldap.
2011-01-26 14:20:37 -08:00
Kai Blin
278c6f8fc5
errormap: Add unix_to_werror() function
...
While this function technically is closest to the
map_nt_status_from_unix() function, I think it is better to keep the new
function in line with our usual fooerror_to_barerror() naming scheme.
Signed-off-by: Kai Blin <kai@samba.org>
Autobuild-User: Kai Blin <kai@samba.org>
Autobuild-Date: Wed Jan 26 23:07:24 CET 2011 on sn-devel-104
2011-01-26 23:07:24 +01:00
Jeremy Allison
67e578ab5a
Allow "security = share" with SMB2. We already handle this in smb2/smb2_server.c
...
Autobuild-User: Jeremy Allison <jra@samba.org>
Autobuild-Date: Wed Jan 26 20:37:29 CET 2011 on sn-devel-104
2011-01-26 20:37:29 +01:00
Jeremy Allison
bb358ecd5a
From Metze - make sure we're using the same string length for the hash.
...
Autobuild-User: Jeremy Allison <jra@samba.org>
Autobuild-Date: Wed Jan 26 18:32:15 CET 2011 on sn-devel-104
2011-01-26 18:32:15 +01:00
Günther Deschner
abb7c07de5
s3-winbind: share a common winbind_samlogon_retry_loop().
...
Guenther
Autobuild-User: Günther Deschner <gd@samba.org>
Autobuild-Date: Wed Jan 26 12:41:14 CET 2011 on sn-devel-104
2011-01-26 12:41:14 +01:00
Günther Deschner
035a0d2fb3
Revert "s3: These assignments are overwritten immediately"
...
This reverts commit 18962ea385
.
2011-01-26 11:55:37 +01:00
Günther Deschner
36cfa1792e
Revert "s3-winbind: fix winbindd_dual_pam_auth_samlogon() for NT4 domains."
...
This reverts commit cea36aeacf
.
2011-01-26 11:55:36 +01:00
Jeremy Allison
3272e16846
Missed one debug printf of name_hash. Ensure always use %x.
...
Autobuild-User: Jeremy Allison <jra@samba.org>
Autobuild-Date: Wed Jan 26 00:46:28 CET 2011 on sn-devel-104
2011-01-26 00:46:27 +01:00
Jeremy Allison
44732734cc
Fix bug #7863 - Unlink may unlink wrong file when hardlinks are involved.
...
Do this by keeping a linked list of delete on close tokens, one for
each filename that identifies a path to the dev/inode. Use the
jenkins hash of the pathname to identify the correct token.
2011-01-25 14:23:19 -08:00
Jeremy Allison
a65bce4e38
Add uint32_t name_hash argument (currently unused) to get_file_infos().
...
Will be used when we store more than one delete on close token.
2011-01-25 14:02:18 -08:00
Jeremy Allison
b97f1ce68a
Add name_hash into the share mode entry struct (as yet only use for renames to identify a specific path).
2011-01-25 14:01:52 -08:00
Jeremy Allison
76418e23bc
Add name_hash to files_struct. Set within fsp_set_smb_fname().
2011-01-25 13:49:01 -08:00
Günther Deschner
c9f4fad75c
idl: add file_id idl.
...
Guenther
Autobuild-User: Günther Deschner <gd@samba.org>
Autobuild-Date: Tue Jan 25 12:27:00 CET 2011 on sn-devel-104
2011-01-25 12:27:00 +01:00