1
0
mirror of https://github.com/samba-team/samba.git synced 2025-03-10 12:58:35 +03:00

108 Commits

Author SHA1 Message Date
Tim Potter
4c8091ef9c Use PRINTER_ALL_ACCESS instead of MAXIMUM_ALLOWED_ACCESS in setprinter
command.  From Ronan Waide <waider@waider.ie>.
(This used to be commit 992b5eb4e05fbf99d91d7235b9a002957533f95b)
2003-03-05 05:14:19 +00:00
Tim Potter
991f6cc3c1 More const fixes and flow on fixes from yesterday's const-fest.
(This used to be commit 018733eedd7897e6811e8461c07e3acf418c0e09)
2003-02-25 23:34:57 +00:00
Martin Pool
7741d66b18 Doxygen janitor. No other changes.
(This used to be commit 735c99dadbaffbb53662890e3dc8a668b211da9d)
2003-02-18 01:55:50 +00:00
Andrew Bartlett
749d90dfc7 Match Samba 2.2 by chosing the correct desired access, and getting cupsaddsmb
back working again.

Andrew Bartlett
(This used to be commit 512e65a6a6ac5ee97edf1868007db20bb144857f)
2003-02-12 11:17:35 +00:00
Tim Potter
e536c2e9d3 Remove NULL buffer checks before rpcstr_pull() as they're now done
inside this function.
(This used to be commit cdc7c599c72119e96a2a3d392458cd6d52bf56a5)
2003-01-29 02:57:03 +00:00
Jim McDonough
e47fbbd37f revert accidentally committed changes
(This used to be commit 5d43346761cd120c12766536efb0513994d7bace)
2003-01-21 14:05:37 +00:00
Jim McDonough
19938c0d2c Properly display popt errors. Also fix debug to be -d for consistency with other progs.
(This used to be commit 97133f7168852dc185dbf4492afcaf4b68180f65)
2003-01-21 13:58:16 +00:00
Andrew Tridgell
96c795cea7 reverted this patch till I sort out the craziness with UNIHDR
(This used to be commit e3d00fa47d38cd214f5e350e1d6b30d90ed8a52c)
2003-01-17 06:15:18 +00:00
Andrew Tridgell
ec879eacc2 This removes the 3rd argument from init_unistr2(). There were 240
calls to init_unistr2() in the code and every one of them got the 3rd
argument incorrect, so I thought it best just to remove the argument.

The incorrect usage was caused by callers using strlen() to determine
the length of the string. The 3rd argument to init_unistr2() was
supposed to be the character length, not the byte length of the
string, so for non-english this could come out wrong.

I also removed the bogus 'always allocate at least 256 bytes'
hack. There may be some code that relies on this, but if there is then
the code is broken and needs fixing.
(This used to be commit b9eff31b1433c81fbff733e194914a40f25e3bda)
2003-01-17 04:58:45 +00:00
Andrew Bartlett
ad20186707 A couple more fstring/pstring issues - and move from sizeof(fstring) to
sizeof(var) in slprintf statements, so as to ensure we don't get mixups there.

Also remove fstrcpy() into a variable that is about to be printed into anyway.

Andrew Bartlett
(This used to be commit 9b761237321d475c324a3995fe6f0922550ae995)
2003-01-11 12:18:57 +00:00
Andrew Bartlett
6d66fb308a BIG patch...
This patch makes Samba compile cleanly with -Wwrite-strings.
 - That is, all string literals are marked as 'const'.  These strings are
always read only, this just marks them as such for passing to other functions.

What is most supprising is that I didn't need to change more than a few lines of code (all
in 'net', which got a small cleanup of net.h and extern variables).  The rest
is just adding a lot of 'const'.

As far as I can tell, I have not added any new warnings - apart from making all
of tdbutil.c's function const (so they warn for adding that const string to
struct).

Andrew Bartlett
(This used to be commit 92a777d0eaa4fb3a1c7835816f93c6bdd456816d)
2003-01-02 09:07:17 +00:00
Jim McDonough
3eb60559d8 Add getdata and getdataex commands
(This used to be commit 101727335fffd4011659bfa9f7f8ab24b641fc4e)
2002-11-11 15:41:04 +00:00
Gerald Carter
4be3750d8e deldriver fix
(This used to be commit f20de1f9b0dcac15fbf968e6d5d5af2fdd5fbda1)
2002-11-09 14:48:27 +00:00
Jim McDonough
66a1f9b1fe Add enumdataex command
(This used to be commit 6d1d2849a7b2f99d927ba168ed2d01a879b09e69)
2002-11-08 21:39:53 +00:00
Jim McDonough
9429b7d8ab Implement enumdata command
(This used to be commit a22fdf26fef0cd58c84ca13891a762e3fdc6af8b)
2002-11-08 20:51:04 +00:00
Jim McDonough
eedcd7239b Add enumkey command (EnumPrinterKey api)
(This used to be commit a2e17d4344f996b64cd9c4f01b6b15c069fde41b)
2002-11-08 19:06:34 +00:00
Gerald Carter
83e58265b5 merge of new client side support the Win2k LSARPC UUID in rpcbind
from APP_HEAD
(This used to be commit 38c9e4299845fd77cc8629945ce2d259489f7437)
2002-10-04 03:51:43 +00:00
Tim Potter
9a4110d3d1 Fix setprinterdata rpcclient command to use new cli_spoolss_setprinterdata
function.  Also fixed crash bug - I don't think anyone uses this
command anymore...
(This used to be commit 82c9bf2a6f03c801e701636aff726090483cea25)
2002-09-03 04:56:39 +00:00
Tim Potter
f02b14f7c6 Change JOB_INFO_CTR to return a pointer to an array rather than array of pointers.
(This used to be commit e9b71b354d923b2cd0f028dd197e7ca81339ec3a)
2002-09-03 03:20:21 +00:00
Andrew Tridgell
901ffd7ca8 slprintf() takes a size argument
(This used to be commit 4e142ba3749d2eb45687425ff87c153fb6147056)
2002-08-27 05:04:16 +00:00
Tim Potter
dbbb157b2e Don't try to convert enumprinters name to a unc name.
(This used to be commit e09007dd5d17d5f84aea3c2fed16ce79ba7be1f2)
2002-08-27 01:48:00 +00:00
Tim Potter
83c5985880 Pass the object name down to the enum_printers rpc. By default this is the
server name and everything works as advertised.  See the MSDN doco for details.
(This used to be commit d6b10fe9691bfc96d5933c029990c60fd292bdc9)
2002-08-27 00:38:55 +00:00
Tim Potter
335aa54b46 Merge of incomplete rffpcnex testing code from APPLIANCE_HEAD.
(This used to be commit fe43c2ac2d2e1dd3b3a25c807d4dd379c5ac4960)
2002-08-08 04:58:19 +00:00
Jeremy Allison
452eb38df0 Proper merge of all the working printing stuff from APPLIANCE_HEAD.
Now let's keep this in sync !
Jeremy.
(This used to be commit 3603cd4947df2c10df604447dc542932cb9e5d5a)
2002-06-28 00:17:15 +00:00
Tim Potter
1df5f81247 The cli_spoolss_setprinterdata() function interface changed slightly.
(This used to be commit 79d7bcf42e568b8fe75818c1d2344bff738afd70)
2002-05-14 05:27:58 +00:00
Tim Potter
5f0a3bf295 Added cmd_spoolss_enumjobs() function to rpcclient.
The semantics of the src_len argument to rpcstr_pull() seem to have changed
breaking most of the spoolss commands in rpcclient.  Changed a bunch of
0's to -1's to fix it.
(This used to be commit f32e3f2087c44f27bcfc8a8b1c76ee2b29f01dea)
2002-05-07 06:30:10 +00:00
Gerald Carter
9cb6a94406 some mergee from SAMBA_2_2. Does compile, but needs some more testing.
This is an intermediate check-in.  More to come....
(This used to be commit 5b9b152971aa635d484cde45413a7880424ee22d)
2002-04-02 01:10:41 +00:00
Jim McDonough
bc6959c6f6 Swap order of close brace and done: tag to appease AIX compiler. Order shouldn't matter for logic...if anyone disagrees whack me over the head and explain why...
(This used to be commit 4081ce40dda886aeb01f590f00bfe50e0e4e8ae4)
2002-03-08 03:36:03 +00:00
Tim Potter
fd7cdf6da4 Cosmetic fixup for enum_printers
(This used to be commit bb0ef8bc305da7490a19a6f4efd2aa60bf14aef1)
2002-03-07 04:29:13 +00:00
Tim Potter
6fbd44c77a Fixed a bunch of crash bugs for enumprinters at various info levels.
(This used to be commit d9df00e2b1764619491900b7dbd7d5af34feed1b)
2002-03-07 04:22:16 +00:00
Tim Potter
bb117fdca7 Implemented client side functions for SPOOLSS addform, getform, setform and
enumforms.
(This used to be commit e69222f0816878e3211e3dedb049de50ca90fed0)
2002-02-25 06:43:31 +00:00
Tim Potter
e026103a97 Converted remaining spoolss rpcclient functions to werror/needed/offered.
I couldn't test some of these because I didn't know the right magic
arguments to pass to rpcclient (familiar anyone? (-:) so there may be some
bugs lurking.
(This used to be commit 029e2b307d91171168040e71d2e5d5e0d01b7633)
2002-02-20 18:41:07 +00:00
Tim Potter
902cc03807 Converted {cmd,cli}_spoolss_getprinter() to WERROR and offered/neede.
(This used to be commit fccfa034e92bca145b8e0639e405f6af5bb1a50b)
2002-02-19 02:12:01 +00:00
Tim Potter
9a0a35d09a Converted cmd_spoolss_enumprinterdrivers() to use new
cli_spoolss_enumprinterdrivers() function.
(This used to be commit ae38fcf62c4b9503d4df02761dadb1bb7d166a9c)
2002-02-19 01:06:55 +00:00
Tim Potter
1b70d2769a Added addform, setform and deleteform commands. The only one I could get
to actually work was addform.  )-:

Removed a whole bunch of calls to werror_to_ntstatus() because there isn't
a one-to-one mapping of NTSTATUS values to WERROR values.  This function
maps WERR_ACCESS_DENIED to NTSTATUS_INVALID_LOCK_SEQUENCE or something
silly like that.
(This used to be commit 825b5c8bd6d0f114faf3b0fd91eb374cbfb8c8b7)
2002-01-31 11:36:30 +00:00
Tim Potter
cd68afe312 Removed version number from file header.
Changed "SMB/Netbios" to "SMB/CIFS" in file header.
(This used to be commit 6a58c9bd06d0d7502a24bf5ce5a2faf0a146edfa)
2002-01-30 06:08:46 +00:00
Simo Sorce
7019bfe546 fixes (asprintf) from 2.2
(This used to be commit 6b123adda901ff05b0271eeda060297448f64eec)
2002-01-19 17:29:32 +00:00
Tim Potter
9a02c6b4e8 Converted getprinterdriver to WERROR - it always returns dos error 6
(invalid handle) though.  )-:
(This used to be commit 7bfd1f35e4e194f8a2f07046e4a6c005c256c05b)
2002-01-07 03:33:46 +00:00
Tim Potter
2f25e5118f Converted enumprinters and enumports cmd functions to use WERROR
values returned from cli functions.  They are converted to NTSTATUS codes
using the error map functions.

Do buffer size loop checks by setting offered = 0 and using the return
value of needed in the next call.
(This used to be commit 4efbdda3fcfd1fad2f2b8909d250735382497836)
2002-01-06 09:03:48 +00:00
Tim Potter
cd0772e51e spoolss rpc client cleanup:
- converted OpenPrinterEx and ClosePrinter to WERROR instead of NT_STATUS
 - doc
(This used to be commit 248d114f856f1adb76c903b683e0927530771443)
2002-01-06 03:54:40 +00:00
Tim Potter
9c1ddeca6f Fixed crash bug in display_print_info_2()
(This used to be commit b70f870cd98e30d0ce74d322391cc79d65c5f838)
2002-01-03 03:51:13 +00:00
Tim Potter
af8ed15401 Fixed crash bug in display_print_info_1()
(This used to be commit d1564fbf1f4950c12516470d4566efeca3ad79e5)
2002-01-03 02:48:23 +00:00
Tim Potter
a4c612078f Unicode byte ording fix from Benjamin Kuit <bj@it.uts.edu.au>
(This used to be commit 6b7e9d03cf6093f1108642deddb0f8cc42e59067)
2001-12-30 21:25:46 +00:00
Tim Potter
b872787f01 Doing some research into ACLs on the LSA and SAM policy objects.
- added lsaquerysecobj to rpcclient
 - renamed querysecobj to samquerysecobj
 - removed duplicated display_sec_acl() code from cmd_spoolss.c and
   cmd_samr.c and moved it into display_sec.c
(This used to be commit 59b2e3f408a5ff22f2d81a927d010a7df5f19f7f)
2001-12-11 02:17:26 +00:00
Tim Potter
4f53486d78 Added client and server code for the GetPrintProcessorDirectory SPOOLSS
rpc.  This was supposed to fix a printer driver download bug but it didn't
but it seemed a shame to trash all this code so I'm commiting it #ifdef'ed
out in case someone needs it one day.
(This used to be commit bef43656471741c6c10b12e7516c15de9ae76394)
2001-12-10 05:03:17 +00:00
Tim Potter
6d9adfe73c Renamed sid field in SEC_ACE to trustee to be more in line with MS's
definitions.
(This used to be commit 9712d3f15a47155f558d0034ef71fd06afb11301)
2001-11-30 01:04:15 +00:00
Tim Potter
06ff349e21 FALSE -> False
(This used to be commit 7c6529c081abe051055be5fbf3016fbea2474752)
2001-11-15 05:26:22 +00:00
Tim Potter
439c7e0ca2 Some old stuff hanging around since the CIFS conference. Big cleanup of
rpcclient code.  Refactored cmd_* functions to move common mem_ctx and pipe
opening stuff up one level.  Moved rpcclient.h into rpcclient directory and
out of includes/smb.h
(This used to be commit a40facba9651f9fb1dcc9e143f92ca298a324312)
2001-10-12 05:56:23 +00:00
Tim Potter
dc1fc3ee8e Removed 'extern int DEBUGLEVEL' as it is now in the smb.h header.
(This used to be commit 2d0922b0eabfdc0aaf1d0797482fef47ed7fde8e)
2001-10-02 04:29:50 +00:00
Andrew Tridgell
c76dd14040 it now all compiles - so try enabling it by default and see what explodes on the build farm
(This used to be commit 5bb7e4f0f65edf1db20245f403cbe81833134240)
2001-09-04 10:57:29 +00:00