Michael Adam
2aded6aebd
s3:torture:delete: untangle function call from result check
2012-08-09 15:29:32 +02:00
Michael Adam
ef3684739a
s3:torture:delete: untangle function call from result check
2012-08-09 15:29:26 +02:00
Michael Adam
4e75b0c717
s3:torture:delete: untangle function call from result check
2012-08-09 15:27:16 +02:00
Michael Adam
ccb25831e2
s3:torture:delete: untanlge function call from result check
2012-08-09 15:27:15 +02:00
Michael Adam
8a92ae23fe
s3:torture:delete: untangle function call from result check
2012-08-09 15:26:09 +02:00
Michael Adam
02b092533a
s3:torture:delete: untangle function call from result check
2012-08-09 15:26:08 +02:00
Michael Adam
5138eb50a3
s3:torture:delete: untangle function call from result check
2012-08-09 15:26:07 +02:00
Michael Adam
5bc7c77cd8
s3:torture:delete: untangle function call from result check
2012-08-09 15:26:06 +02:00
Michael Adam
b5e9378e28
s3:torture:delete: untangle function call from result check
2012-08-09 15:25:19 +02:00
Michael Adam
361429d02f
s3:torture:delete: untangle function call from result check
2012-08-09 15:25:18 +02:00
Michael Adam
8684506478
s3:torture:delete: untangle function call from result check
2012-08-09 15:25:17 +02:00
Michael Adam
1db70c0b8b
s3:torture:delete: untangle function call from result check
2012-08-09 15:25:16 +02:00
Michael Adam
a70a4ad731
s3:torture:delete: untangle function call from result check
2012-08-09 15:13:33 +02:00
Andrew Bartlett
434bed75c4
s3-events: Do not vasprintf() the tevent debug messages that will not be shown
...
This malloc() and free() actually shows up quite high on a call profile of
provision of the AD DC (and this is the matching patch for source3).
Andrew Bartlett
2012-08-09 20:14:22 +10:00
Stefan Metzmacher
0d7b17f4db
s3:smb2_sesssetup: setup global->[en|de]cryption_key
...
metze
Autobuild-User(master): Stefan Metzmacher <metze@samba.org>
Autobuild-Date(master): Thu Aug 9 09:59:02 CEST 2012 on sn-devel-104
2012-08-09 09:59:02 +02:00
Stefan Metzmacher
0cb11efa87
s3:smb2_read: don't try sendfile if encryption is used
...
metze
2012-08-09 08:21:35 +02:00
Stefan Metzmacher
a0cf42b709
s3:smb2_server: add smbd_smb2_request->do_encryption
...
For now it's always false...
metze
2012-08-09 08:21:35 +02:00
Stefan Metzmacher
95e4270813
s3:smb2_tcon: set global->encryption_required and enforce it
...
This the account or client doesn't support encryption we should
reject the tree connect.
metze
2012-08-09 08:21:35 +02:00
Stefan Metzmacher
64dce26533
s3:smb2_sesssetup: set global->encryption_required and enforce it
...
This the account or client doesn't support encryption we should
reject the session setup.
metze
2012-08-09 08:21:35 +02:00
Stefan Metzmacher
8734887348
s3:smbXsrv.idl: add encryption_required to smbXsrv_tcon_global0
...
metze
2012-08-09 08:21:35 +02:00
Stefan Metzmacher
b5a72f4f35
s3:smb2_server: check the session before we could response with an error.
...
metze
2012-08-09 08:21:35 +02:00
Stefan Metzmacher
f15d9a6670
s3:smb2_server: do central file_id check if the operation requires it
...
Note that it's fine to call file_fsp_smb2() twice, the 2nd call
just returns smb2req->compat_chain_fsp without a 2nd lookup.
metze
2012-08-09 08:21:35 +02:00
Stefan Metzmacher
47c5900040
s3:nmbd: log a failure in get_domain_master_name_node_status_success() as level 1
...
metze
Autobuild-User(master): Stefan Metzmacher <metze@samba.org>
Autobuild-Date(master): Wed Aug 8 20:14:29 CEST 2012 on sn-devel-104
2012-08-08 20:14:29 +02:00
Stefan Metzmacher
a3ccdafd1b
s3:nmbd: don't log get_domain_master_name_node_status_fail at level 0
...
metze
2012-08-08 18:20:47 +02:00
Stefan Metzmacher
1c76e99ae4
s3:smb2_server: s/i/idx in smbd_smb2_request_pending_queue()
...
metze
Autobuild-User(master): Stefan Metzmacher <metze@samba.org>
Autobuild-Date(master): Wed Aug 8 17:32:26 CEST 2012 on sn-devel-104
2012-08-08 17:32:26 +02:00
Stefan Metzmacher
83d262088b
s3:smb2_server: make use of SMBD_SMB2_OUT_HDR_PTR() in smbd_smb2_request_pending_queue()
...
metze
2012-08-08 12:52:52 +02:00
Stefan Metzmacher
0067de2074
s3:smb2_server: remove useless variable 'i'
...
metze
2012-08-08 12:52:51 +02:00
Stefan Metzmacher
63d92a192d
s3:smb2_server: rewrite dup_smb2_vec3() using SMBD_SMB2_*_IOV_OFS and helper variables
...
metze
2012-08-08 12:52:51 +02:00
Stefan Metzmacher
fc8e3bd569
s3:smb2_server: make use of SMBD_SMB2_* macros in smbd_smb2_request_done_ex()
...
metze
2012-08-08 12:52:51 +02:00
Stefan Metzmacher
97b5aaa648
s3:smb2_server: make use of SMBD_SMB2_* macros in smbd_smb2_request_verify_sizes()
...
metze
2012-08-08 12:52:50 +02:00
Stefan Metzmacher
05ae95a0d5
s3:smb2_server: use the common buffer layout for smbd_smb2_request_pending*
...
metze
2012-08-08 12:52:50 +02:00
Stefan Metzmacher
644eab32af
s3:smb2_read: use SMBD_SMB2_NUM_IOV_PER_REQ when checking for sendfile() support
...
metze
2012-08-08 12:52:50 +02:00
Stefan Metzmacher
2b9dd9049e
s3:smb2_read: fix indentation in schedule_smb2_sendfile_read()
...
metze
2012-08-08 12:52:50 +02:00
Stefan Metzmacher
9f51d610d2
s3:smb2_server: don't try to update req->in.vector[0] in smbd_smb2_request_pending_queue()
...
req->in.vector[0] is reserved for the transport and might be removed in future.
This is currently always { NULL, 0 }, as it's not used, by our
transport layer code. The SMB2 layer should never touch this!
metze
2012-08-08 12:50:22 +02:00
Andrew Bartlett
b7b4879350
s3-torture: Extend pdbtest to also run an authentication unit-test
...
This tests both the builtin auth_sam against passdb directly and the
configured auth module.
Andrew Bartlett
2012-08-08 08:03:21 +02:00
Andrew Bartlett
de2d813898
build: Remove pdbtest from the autoconf build
...
pdbtest is internal test utility that is not installed. It is only
run from the full (waf) make test, and does not need to be built in
the autoconf build.
Removing it from the autoconf build makes it easier to expand this
test to depend on more parts of Samba.
Andrew Bartlett
2012-08-08 08:03:21 +02:00
Stefan Metzmacher
6bfdca4786
s3:smb2_sesssetup: remove unused code in smbd_smb2_reauth_generic_return()
...
A reauth exchange is already signed, with the channel signing key.
metze
2012-08-08 05:37:49 +02:00
Stefan Metzmacher
5f7d786b08
s3:smb2_sesssetup: remove TALLOC_FREE(session) from smbd_smb2_[re]auth_generic_return
...
The caller does this via the smbd_smb2_session_setup_state_destructor()
metze
2012-08-08 05:37:49 +02:00
Stefan Metzmacher
c9ecfd6f3d
s3:smb2_server: sign the last request at the start of smbd_smb2_request_reply()
...
This means we correctly sign all responses in a compound chain.
metze
2012-08-08 05:13:42 +02:00
Volker Lendecke
64c0367335
s3: Fix a crash in reply_lockingX_error
...
A timed brlock with 2 locks comes in and the second one blocks,
file is closed. smbd_cancel_pending_lock_requests_by_fid sets
blr->fsp to NULL. reply_lockingX_error (called via
MSG_SMB_BLOCKING_LOCK_CANCEL) deferences blr->fsp because
blr->lock_num==1 (the second one blocked).
This patch fixes the bug by only undoing the locks if fsp!=NULL.
fsp==NULL is the close case where everything is undone anyway.
Thanks to Peter Somogyi, somogyi@hu.ibm.com for this bug report.
Autobuild-User(master): Jeremy Allison <jra@samba.org>
Autobuild-Date(master): Wed Aug 8 04:12:04 CEST 2012 on sn-devel-104
2012-08-08 04:12:04 +02:00
Björn Jacke
c2dee12d67
vfs_dirsort: Remove unnecessary return; statement
...
Autobuild-User(master): Björn Jacke <bj@sernet.de>
Autobuild-Date(master): Wed Aug 8 02:17:13 CEST 2012 on sn-devel-104
2012-08-08 02:17:13 +02:00
Björn Jacke
375ba1b483
vfs_afsacl.c: Remove some unnecessary return; statements
2012-08-08 00:21:26 +02:00
Björn Jacke
ebc92d0715
vfs_full_audit: Remove some unnecessary return; statements
2012-08-08 00:21:26 +02:00
Björn Jacke
dab8fe5dea
vfs_time_audit: Remove unnecessary return; statement
2012-08-08 00:21:26 +02:00
Björn Jacke
3f9b2cc682
vfs_time_audit: Remove some unnecessary return; statements
2012-08-08 00:21:26 +02:00
Volker Lendecke
9adf6a061a
vfs-mediaharmony: Remove some unnecessary return; statements
2012-08-08 00:21:26 +02:00
Björn Jacke
da4057fdca
vfs_media_harmony: fix return of void
...
caught by the Studio Compiler
Autobuild-User(master): Björn Jacke <bj@sernet.de>
Autobuild-Date(master): Tue Aug 7 22:22:48 CEST 2012 on sn-devel-104
2012-08-07 22:22:48 +02:00
Stefan Metzmacher
c3016915a1
s3:smb2_server: fix SMB2 signing of compound responses
...
We need to defer the signing until we know the response
doesn't change anymore before it goes over the wire.
metze
Autobuild-User(master): Stefan Metzmacher <metze@samba.org>
Autobuild-Date(master): Tue Aug 7 20:29:30 CEST 2012 on sn-devel-104
2012-08-07 20:29:30 +02:00
Stefan Metzmacher
40f771e010
s3:smb2_server: there's no need to copy req->out.vector when we just keep the last request
...
metze
2012-08-07 18:32:47 +02:00
Stefan Metzmacher
8d63efe273
s3:smb2_server: use memmove instead of copying single vector elements
...
metze
2012-08-07 18:32:47 +02:00