Michael Adam
8185d31fb0
s3:registry: replace typedef REGISTRY_VALUE by struct regval_blob
...
Michael
2009-04-27 11:21:03 +02:00
Jeremy Allison
2012770393
Fix coverity #908 , #909 , uninitialized variable.
...
Jeremy.
2009-04-23 01:47:04 -07:00
Jeremy Allison
1e315b0013
Fix coverity #910 , uninitialized variable.
...
Jeremy.
2009-04-23 01:38:21 -07:00
Jelmer Vernooij
f4195183a4
s3: Use common security_descriptor_equal().
2009-04-21 18:17:40 +02:00
Volker Lendecke
9b3f2e69f7
Make "struct policy" private to srv_lsa_hnd.c
2009-04-19 09:27:14 +02:00
Günther Deschner
81b18464be
s3-spoolss: remove some direct checks for 0 uid in AddForm,SetForm,DelForm.
...
Also add some become_root()/unbecome_root() pairs which were missing IMHO.
Guenther
2009-04-17 23:20:22 +02:00
Günther Deschner
6900d61d36
s3-spoolss: add support for _spoolss_EnumPrinterDrivers() level 6.
...
Guenther
2009-04-17 17:27:32 +02:00
Günther Deschner
5e563ee508
s3-spoolss: add support for _spoolss_EnumPrinterDrivers() level 5.
...
Guenther
2009-04-17 17:27:26 +02:00
Günther Deschner
d76837f6da
s3-spoolss: add support for _spoolss_EnumPrinterDrivers() level 4.
...
Guenther
2009-04-17 17:27:18 +02:00
Günther Deschner
4721be488c
s3-spoolss: Fix format of description string in spoolss_PrinterInfo1.
...
This is what windows does and should get us closer to show the appropriate
printer location string in explorer.
Guenther
2009-04-14 23:21:47 +02:00
Günther Deschner
a79e1ce048
s3-spoolss: fix typo in fill_printer_driver_info3().
...
Guenther
2009-04-13 23:45:12 +02:00
Günther Deschner
3ef0b8671d
s3-spoolss: Fix permission checks for _spoolss_AddForm,SetForm and DelForm.
...
Found by smbtorture test.
Guenther
2009-04-13 16:15:32 +02:00
Günther Deschner
97ffd709f8
s3-spoolss: use enumprinterdrivers_level() for level 3 enum.
...
Guenther
2009-04-13 16:12:56 +02:00
Günther Deschner
9b3d3e8aeb
s3-spoolss: use enumprinterdrivers_level() for level 2 enum.
...
Guenther
2009-04-13 16:12:49 +02:00
Günther Deschner
f325c34203
s3-spoolss: use enumprinterdrivers_level() for level 1 enum.
...
Guenther
2009-04-13 16:12:42 +02:00
Günther Deschner
0393c99302
s3-spoolss: add generic enumprinterdrivers_level function.
...
Guenther
2009-04-13 16:12:35 +02:00
Günther Deschner
bc5cd07764
s3-spoolss: implement dummy _spoolss_AddPort().
...
Guenther
2009-04-10 13:25:09 +02:00
Günther Deschner
65ee4ae30b
s3-spoolss: add support for level 8 in _spoolss_GetPrinter().
...
Guenther
2009-04-10 13:25:01 +02:00
Günther Deschner
c5b24d65cd
s3-spoolss: set servername to global_myname() in set_printer_hnd_name().
...
This allows spoolss_OpenPrinterEx to open a printer by printername.
Now the Samba3 spoolss server passes the RPC-SPOOLSS-WIN test.
Guenther
2009-04-07 22:15:15 +02:00
Günther Deschner
37aff885a6
s3-spoolss: implement _spoolss_GetPrinterDriver2 level 101 (Bug #5140 ).
...
Guenther
2009-04-02 12:46:04 +02:00
Günther Deschner
283e135298
s3-spoolss: implement enumprinters_level0.
...
Guenther
2009-03-25 12:46:40 +01:00
Günther Deschner
19de802c17
s3-spoolss: _spoolss_EnumPrinters level 3 always returns WERR_UNKNOWN_LEVEL.
...
Guenther
2009-03-20 17:20:33 +01:00
Günther Deschner
d2de9b068c
s3-spoolss: implement enumprinters_level4.
...
Guenther
2009-03-20 17:20:33 +01:00
Günther Deschner
aa6dbcfc11
s3-spoolss: implement enumprinters_level5.
...
Guenther
2009-03-20 17:20:33 +01:00
Günther Deschner
6713244d46
s3-spoolss: use enum_all_printers_info_level for level 1 and 2.
...
Guenther
2009-03-20 17:20:33 +01:00
Günther Deschner
95f2913c7d
s3-spoolss: add enum_all_printers_info_level().
...
Guenther
2009-03-20 17:20:33 +01:00
Günther Deschner
5a388115a9
s3-spoolss: apply some const in spoolss server.
...
Guenther
2009-03-20 17:20:32 +01:00
Günther Deschner
045151b767
s3-spoolss: pure comsetics.
...
sorry, I just need to do that.
Guenther
2009-03-20 10:49:45 +01:00
Günther Deschner
531af136f9
s3: remove POLICY_HND.
...
Guenther
2009-03-18 23:22:29 +01:00
Günther Deschner
a1256594b0
s3-spoolss: fix _spoolss_GetPrinterData printerserver handle query error code.
...
When _spoolss_GetPrinterData receives a query on a printserver handle for a
value that we have not stored or do not provide, we need to return
WERR_INVALID_PARAM, not WERR_BADFILE. Tested with w2k and w2k3 servers.
Found by torture test.
Guenther
2009-03-18 21:57:07 +01:00
Günther Deschner
43182fdff8
s3-spoolss: fix _spoolss_EnumPrinterDataEx error path.
...
When a windows clients queries the "" key, we need to make sure to return with
the appropriate error (WERR_INVALID_PARAM in that case), and not fall through
to the buffer size handling macros. Found by torture test.
Guenther
2009-03-18 21:56:38 +01:00
Günther Deschner
9d1ab9a001
spoolss: add my copyright.
...
Guenther
2009-03-18 17:18:46 +01:00
Günther Deschner
0cfb1aea29
s3-spoolss: use pidl for _spoolss_EnumPrinterDataEx.
...
Please note that this has been the last call in samba3 that was
using hand-marshalled rpc. With this commit all named pipe rpc services
in samba3 have now fully moved to pidl generated code :-)
Guenther
2009-03-18 17:07:39 +01:00
Günther Deschner
31106cdace
s3-spoolss: use printer and job notify enums provided by idl.
...
Guenther
2009-03-18 16:47:01 +01:00
Günther Deschner
e61c9ca36d
s3-spoolss: fix spoolss server after spoolss_Field changes.
...
Guenther
2009-03-18 16:46:49 +01:00
Günther Deschner
9fdeb7f7b3
s3-spoolss: remove custom syntax_spoolss and use the syntax defined in IDL.
...
Guenther
2009-03-18 14:18:42 +01:00
Günther Deschner
ef02342562
s3-spoolss: add registry_value_to_printer_enum_value.
...
Guenther
2009-03-18 11:55:54 +01:00
Günther Deschner
f683341294
s3-spoolss: add SPOOLSS_BUFFER_ARRAY macro.
...
Guenther
2009-03-18 11:55:47 +01:00
Günther Deschner
b57d5eaac0
s3-spoolss: remove (disabled) enum_all_printers_info_1_remote.
...
Jerry, please check. I do not understand how this could work and in
it's current form, we cannot make this even compile anymore, I'm afraid :)
I think it is safe to remove.
Guenther
2009-03-17 19:07:38 +01:00
Günther Deschner
479d91ae9f
s3-spoolss: remove SPL Port definitions now in IDL.
...
Guenther
2009-03-17 19:07:37 +01:00
Günther Deschner
5778a36357
s3-spoolss: rename convert_printer_info_new to convert_printer_info.
...
Guenther
2009-03-17 18:39:55 +01:00
Günther Deschner
1e7f602f8c
s3-spoolss: rename convert_nt_devicemode_new to convert_nt_devicemode.
...
Guenther
2009-03-17 18:39:49 +01:00
Günther Deschner
6549408a4d
s3-spoolss: rename construct_dev_mode_new to construct_dev_mode.
...
Guenther
2009-03-17 18:39:43 +01:00
Günther Deschner
47c024fd75
s3-spoolss: rename temporary convert_devicemode_new function.
...
Guenther
2009-03-17 18:39:17 +01:00
Günther Deschner
e89e739e22
s3-spoolss: remove unused init_unistr_array().
...
Guenther
2009-03-17 12:21:31 +01:00
Günther Deschner
4a58f263b9
s3-spoolss: remove unused get_printer_dataex().
...
Guenther
2009-03-17 12:21:23 +01:00
Günther Deschner
63d78712bc
s3-spoolss: use pidl for _spoolss_EnumPrinterKey.
...
Guenther
2009-03-17 12:18:57 +01:00
Günther Deschner
56691dfe4b
s3-spoolss: cleanup _spoolss_SetPrinterDataEx a little.
...
Guenther
2009-03-17 12:14:35 +01:00
Günther Deschner
d189824240
s3-spoolss: cleanup _spoolss_GetPrinterDataEx a little.
...
Guenther
2009-03-17 12:14:28 +01:00
Günther Deschner
80ecd11050
s3-spoolss: use pidl for _spoolss_EnumPrinterData.
...
Guenther
2009-03-17 12:07:58 +01:00