Günther Deschner
c6ebab846d
s3: only include gen_ndr headers where needed.
...
This shrinks include/includes.h.gch by the size of 7 MB and reduces build time
as follows:
ccache build w/o patch
real 4m21.529s
ccache build with patch
real 3m6.402s
pch build w/o patch
real 4m26.318s
pch build with patch
real 3m6.932s
Guenther
2010-05-06 00:22:59 +02:00
Günther Deschner
7532640a74
s3-spoolss: publish "Monitor" in winreg for drivers.
...
Found by torture test.
Guenther
2010-04-27 17:56:48 +02:00
Günther Deschner
70ec7e0700
s3-spoolss: fix winreg attribute for storing datatype.
...
Found by torture test (and checked with w2k, w2k3 and w2k8).
Guenther
2010-04-27 17:56:47 +02:00
Günther Deschner
63b111bd32
s3: add iconv_convenience handle to pull/push sz helpers.
...
Guenther
2010-04-09 18:33:45 +02:00
Günther Deschner
84f3eeeca3
s3-registry: fix fill_in_printer_values() for datatype and printprocessor.
...
It is wise and good to enforce RAW and winprint, but we need to be consistent
with spoolss (and enforce it there).
Found by torture test.
Guenther
2010-04-08 16:21:40 +02:00
Günther Deschner
b4d09134fd
s3-registry: make sure root has full registry access (in particular for make test).
...
Guenther
2010-03-16 15:13:52 +01:00
Michael Adam
9a825dc770
s3:registry-legacy: use talloc_stackframe() instead of NULL in regkey_open_internal()
...
Michael
2010-03-16 00:12:25 +01:00
Andrew Tridgell
7cff685c7e
s3: convert registry and printing code to TYPESAFE_QSORT()
2010-02-14 18:44:21 +11:00
Volker Lendecke
613777e6dc
s3: Remove unused comparison fn from "struct sorted_tree"
2010-02-13 13:26:11 +01:00
Volker Lendecke
2260732084
s3: SORTED_TREE -> struct sorted_tree
2010-02-13 13:26:11 +01:00
Michael Adam
a752bbd10d
s3:registry: eliminate race condition in creating/scanning sorted subkeys
...
Called, from key_exists, scan_sorted_subkeys re-creates the sorted
subkeys record of the given key and then searches through it.
The race is that between creation and parsing of the sorted subkey
record, another process that stores some other subkey of the same
parent key will delete the sorted subkey record, resulting in an
WERR_BADFILE of an operation that should actually succeed.
This patch fixes the issue by wrapping the creation and parsing
into a transaction.
Michael
2010-02-12 23:12:12 +01:00
Andrew Tridgell
aa52a0925d
s3-registry: update to use new DLIST macros
...
(cherry picked from commit 3437713ad7e5bccafde30553a8232119fd2a9eb9)
2010-02-10 15:42:00 -08:00
Volker Lendecke
1b4a3cc3f4
s3: Fix some DEBUG statements
2010-02-07 20:56:09 +01:00
Volker Lendecke
ff2d7d9b82
s3: Fix some comments
2010-02-07 12:29:25 +01:00
Volker Lendecke
5552b44960
s3: Fix some nonempty blank lines
2010-02-07 12:29:25 +01:00
Karolin Seeger
9ce9fdd9f4
s3/registry: Fix typo in comment.
...
Karolin
2010-01-25 19:50:21 +01:00
Volker Lendecke
9acbed13e8
s3: Fix some nonempty blank lines
2010-01-22 13:34:25 +01:00
Volker Lendecke
ee4a3606e6
s3: Fix a typo in a comment
2010-01-22 13:34:25 +01:00
Günther Deschner
35c50dcce3
s3-spoolss: use driver level info8 everywhere in spoolss server internally.
...
Guenther
2009-12-08 11:05:21 +01:00
Volker Lendecke
77fb5e19d8
s3: "regf_hbin_allocate" only looks at the size
2009-11-29 11:22:04 +01:00
Volker Lendecke
d5e5d09d73
s3: "read_block" only looks at the size
2009-11-29 11:22:04 +01:00
Volker Lendecke
13e70058c0
s3: "write_block" does not use the sbuf at all
2009-11-29 11:22:04 +01:00
Volker Lendecke
44ce5603dd
s3: Pass the "fake dir create times" parameter to sys_*stat
...
Step 0 to restore it as a per-share paramter
2009-11-29 11:22:01 +01:00
Günther Deschner
ec56895bde
s3-printing: use spoolss types and structs while getting and deleting drivers.
...
Guenther
2009-11-23 12:19:11 +01:00
Michael Adam
cc5b22a016
s3:registry: add an extra check for dsize==0 to regdb_fetch_keys_internal()
...
Don't only rely on dptr == NULL.
I stumbled over this one when rewriting some of the dbwrap_ctdb code.
Michael
2009-11-03 01:02:39 +01:00
Michael Adam
f6f2151a39
s3:registry: add safety check for return value of tdb_unpack to regdb_fetch_keys_internal()
...
Prevents segfaults in some situations.
(For a non existent or empty record, we sometimes rely on the fetch operation
to return dsize==0 and sometimes we rely on dptr==NULL.)
Michael
2009-11-03 01:02:38 +01:00
Günther Deschner
e80891db41
s3-perfcount: more cleanup.
...
Guenther
2009-10-01 12:19:48 +02:00
Günther Deschner
25ab8828a1
s3-perfcount: only pass down prs_struct when really required.
...
Guenther
2009-10-01 12:19:48 +02:00
Günther Deschner
cd82d4ba56
s3: add perfcount idl and generated files.
...
Guenther
2009-10-01 12:19:43 +02:00
Günther Deschner
347eb9b970
s3-printing: more use of pull_reg_sz().
...
Guenther
2009-10-01 11:40:31 +02:00
Günther Deschner
ad836c4d48
s3-registry: use pull_reg_sz() where appropriate.
...
(and move away from rpcstr_pull and rpcstr_pull_talloc).
Guenther
2009-10-01 11:40:30 +02:00
Günther Deschner
05e8e90976
s3-registry: add regval_ctr_addvalue_multi_sz.
...
Guenther
2009-09-30 16:23:33 +02:00
Günther Deschner
26e798da19
s3: remove unused regval_convert_multi_sz().
...
Guenther
2009-09-30 00:34:01 +02:00
Günther Deschner
2ccf75d9a9
s3: remove unused regval_build_multi_sz().
...
Guenther
2009-09-30 00:33:54 +02:00
Günther Deschner
661342ee2f
s3-registry: use pull_reg_multi_sz().
...
Guenther
2009-09-30 00:30:59 +02:00
Günther Deschner
2d6e5e160b
s3: use push_reg_multi_sz().
...
Guenther
2009-09-30 00:30:25 +02:00
Günther Deschner
1b0f3b7e3a
s3-registry: use regval_ctr_addvalue_sz().
...
Greatly simplifies and cleanes up the code.
Guenther
2009-09-30 00:30:12 +02:00
Günther Deschner
a50cc61ee6
s3-registry: add regval_ctr_addvalue_sz.
...
Guenther
2009-09-30 00:29:56 +02:00
Günther Deschner
2c11b73391
s3-registry: use push_reg_sz().
...
Guenther
2009-09-30 00:29:49 +02:00
Michael Adam
5a525f7f28
s3:registry: db backend: add my C
...
Michael
2009-07-15 14:01:58 +02:00
Michael Adam
78576117eb
s3:registry: flush the provided subkey_ctr in regdb_fetch_keys_internal()
...
This way, we always return what has really been read from the db,
and not more. The callers assume exactly this, but one could hand
in an already pre-filled subkey container...
Michael
2009-07-15 14:01:58 +02:00
Michael Adam
92df5e4a02
s3:registry: add function regsubkey_ctr_reinit()
...
This reinitializes an already allocated regsubkey_ctr structure,
emptying out the subkey array and hash table.
Michael
2009-07-15 14:01:57 +02:00
Michael Adam
dc0bcfa188
s3:registry: turn regdb_fetch_keys_internal() from int to WERROR return type
...
This way, more error information is propagated to the callers.
Michael
2009-07-15 14:01:57 +02:00
Michael Adam
c52dd1d5b8
s3:registry: use transaction wrapper in create_sorted_subkeys()
...
Michael
2009-07-15 14:01:56 +02:00
Michael Adam
109ea29b2c
s3:registry: restructure logic of create_sorted_subkes() slightly
...
This makes it clearer to me, and it also makes it easier to
use the transaction retry wrapper in the next step.
Michael
2009-07-15 14:01:56 +02:00
Michael Adam
2d6dbcd0b1
s3:registry: use transaction wrapper in regdb_delete_subkey().
...
Michael
2009-07-15 14:01:55 +02:00
Michael Adam
a48d8353c7
s3:registry: add a comment header for the delete_subkey set of commands.
...
Michael
2009-07-15 14:01:55 +02:00
Michael Adam
5640598cbb
s3:registry: add a comment header for the create_subkey set of functions
...
Michael
2009-07-15 14:01:54 +02:00
Michael Adam
8c7b960493
s3:registry: use transaction wrapper in regdb_create_subkey()
...
Michael
2009-07-15 14:01:54 +02:00
Michael Adam
86d747e19f
s3:registry: use transaction wrapper in regdb_store_keys_internal().
...
Michael
2009-07-15 14:01:53 +02:00