sin/samba-mirror
1
0
Fork 0
mirror of https://github.com/samba-team/samba.git synced 2025-02-18 17:57:55 +03:00
Code
10,939 Commits 62 Branches 1,152 Tags
Commit Graph

1512 Commits

Author SHA1 Message Date
Simo Sorce
4c6d461a85 Some progress towards gums and tdbsam2 
genparser works fine, and it is a marvelous tool to store objects in tdb :)
 -
Jeremy Allison
ff3827a62b dlsym takes a const char *. 
Jeremy.
 -
Martin Pool
a4b9c5c257 Doxygen janitor: add note that strequal is in fact case-insensitive. -
Martin Pool
9af0717315 Doxygen janitor -
Martin Pool
42d9ec28cd Doxygen janitor: fix parameter names, grammar, tag names. -
Martin Pool
eb876ee9cf Add a comment about the meaning of samba's internal character set and 
how this interacts with it.
 -
Gerald Carter
96570699d1 additional fix for CR 601 
* distinguish WinXP from Win2k
  * add a 1/3 of a second delay in OpenPrinter
    in order to trigger a LAN/WAN optimization in
    2k clients.
 -
Martin Pool
67bf36c69d Doxygen janitor -
Jelmer Vernooij
f8f2165322 - Rename 'modules = ' to 'preload modules = ' 
- Add smb_probe_module()
- Add init_modules()
- Call these functions
 -
Martin Pool
e42b237d98 init_valid_table: Fix a memory leak that would lose the 
dynamically-created valid table every time the configuration was
reloaded.
 -
Andrew Bartlett
c26881633d Move off-by-one buggy malloc()/safe_strcpy() combination to strdup() instead. 
Andrew Bartlett
 -
Martin Pool
5002555a97 Merge documentation from 3_0. -
Andrew Bartlett
ffaa608be0 Add const -
Andrew Bartlett
e908fd164d Fix 2 off-by-one bugs in the use of malloc()ed strings and safe_strcpy(). 
safe_strcpy() isn't particularly safe (this has been noted before) as it does
not take the size of the buffer, but instead the size of the buffer *minus 1*

The locking.c fix was causing segfaults on machines running with
--enable-developer, and was tracked down thanks to the fact that vance's build
farm machine runs with such an option, and smbtorture's DIR1 test hits this
bug very well.

(The --enable-developer code writes to the last byte of the string, to check
for incorrect use of safe_strcpy()).

Andrew Bartlett
 -
Simo Sorce
70fce680c0 move genparser to use talloc contexts instead of [m|c|re]alloc() and free()s -
Andrew Bartlett
2943c69578 More signed/unsigned fixes (yes, I run with funny compiler options) and 
make x_fwrite() match fwrite() in returning a size_t.

Andrew Bartlett
 -
Martin Pool
3679975629 Doxygen janitor -
Jelmer Vernooij
7f59703550 Make init_module() and thus smb_load_module() return an int. 
modules/developer.c: init_module() should return an int
 -
Andrew Bartlett
50bced1e26 Move to a in-memory ccache for winbind, and replace setenv() properly. 
(According to the manpages, you cannot put a stack variable into putenv()).

Yes, this leaks memory.

Andrew Bartlett
 -
Jim McDonough
8c69212eeb base64_decode() with heimdal libs, so I've renamed it base64_decode_inplace(). -
Jeremy Allison
e7c4616c45 Ensure we use getgrnam() unless BROKEN_GETGRNAM is defined. I now need 
to set this for Tru64.
Jeremy.
 -
Martin Pool
e22465749d Remove obsolete comment. -
Martin Pool
82414706e6 Doxygen janitor and some doc typo fixes. -
Martin Pool
fa38e7956c Doxygen janitor. No other changes. -
Martin Pool
90e1d8bdfa Add comment explaining the -DDEVELOPER safe_strcpy overflow hack. -
Andrew Bartlett
3588ebb35b This is a very nice way to detect pstrcpy() into a malloc()ed string, but 
it really is a developer hack...

Andrew Bartlett
 -
Andrew Bartlett
9be21976f7 This patch fixes one of my longest-standing pet hates with Samba :-). 
When we look see if a user is in a list, and we try to 'expand' an @group, we
should lookup the user's own list of groups, rather than looking for all the
members of a group.

I'm sure this will fix some nasty performance issues, particularly on large
domains etc.  In particular, this avoids contacting winbind at all, if the
group is not a winbind group.

(This caused a deadlock on my winbind-on-PDC setup).

The groups list always includes the user's primary group, as per the
getgrouplist manpage, and my recent changes to our implementation.

Andrew Bartlett
 -
Andrew Bartlett
4560594a67 Set the length back to zero when we free the data_blob. -
Andrew Bartlett
0cd4b339b7 Try to make our getgrouplist replacement better match the 'real' implemenations. 
In particular, make sure we include the primary gid in the list.

Andrew Bartlett
 -
Jelmer Vernooij
28653989cf Remove obsolete file lib/netatalk.c - We have a VFS module now -
Tim Potter
026b988b13 Simplify some return values in gencache functions: 
-	return ret == 0 ? True : False;
+	return ret == 0;

and

-	return tdb_close(cache) ? False : True;
+	return tdb_close(cache) != -1;
 -
Martin Pool
2b5664823e Add FIXME about checking exit code for popen'd commands. 
Fix typo.
 -
Andrew Tridgell
3cf539421f pull_ucs2_talloc() should pull to a char**, not a void** -
Andrew Bartlett
7e56014b28 One more fix for the difference between FILE and X_FILE. -
Andrew Bartlett
6a028507f0 Ensure we don't get problems between FILE and X_FILE buffers - always use the 
x_ varient of the command.

Andrew Bartlett
 -
Jeremy Allison
babbbd9c65 Samba janitor: adding mbp's umask patch :-). 
Jeremy.
 -
Andrew Tridgell
b4c210ccb0 make sure we don't run over the end of 'name' in unix_convert() 
Thanks to Andrew Bartlett for spotting this.
 -
Andrew Bartlett
8f495e8634 Bitmap offsets and counts are always positive. -
Andrew Bartlett
34b2e558a4 Always escape ldap filter strings. Escaping code was from pam_ldap, but I'm to 
blame for the realloc() stuff.

Plus a couple of minor updates to libads.

Andrew Bartlett
 -
Andrew Bartlett
0676b4e35f Make it clear that the magic value is (size_t)-1. 
Andrew Bartlett
 -
Jeremy Allison
4ae130bfa8 Add 3 second timeout when terminating server and sending print notify 
messages. Stops build-up of large numbers of smbd's waiting to terminate
on large print throughput.
Jeremy.
 -
Tim Potter
6fee7196d6 Move debug level message handling into debug.c from messages.c 
Removed duplicate message_register() for REQ_DEBUGLEVEL message.
 -
Tim Potter
55d268fdd6 Removed duplicate fn to avoid compiler warning. -
Tim Potter
b9c4cc1195 Return 0 instead of crashing when a NULL source string is passed 
to rpcstr_pull()
 -
Tim Potter
1e7236371d Quieten debug about gencache.tdb not being able to be opened. 
Perhaps we should try to open O_RDONLY if O_RDWR fails?
 -
Jeremy Allison
af6e4ea640 Fix memory leak found my Leo Qiu <leoxqiu@yahoo.com>. 
Jeremy.
 -
Tim Potter
303710c206 Merge of max log file fixes from appliance: 
- smbd/process.c: check log file sizes more often than in
       timeout_processing()

 - lib/debug.c: increment debug_count inside Debug1() instead of
       when log file sizes are checked.
 -
Tim Potter
f150af98a7 Updated some comments. -
Tim Potter
88d977ecce Keep the list of dead WINS servers in gencache.tdb instead of in 
memory.  This allows the information to be shared amongst all smbd
processes.

HP CR #1099
 -
Tim Potter
9ff4fe7e0d Make the valstr and timeout return pointers optional so a caller can 
pass NULL if it doesn't care about the gencache key.
 -