1
0
mirror of https://github.com/samba-team/samba.git synced 2025-02-10 13:57:47 +03:00

19854 Commits

Author SHA1 Message Date
Jeremy Allison
e6aacb1426 r16216: Add debug messages to make it possible to try and
debug why a job pause or resume command is not being
done.
Jeremy.
2007-10-10 11:17:26 -05:00
Jeremy Allison
c2f0ea2ff2 r16213: Fix Klocwork #852. iface_n_ip can potentially
return NULL. Ensure we don't deref.
Jeremy.
2007-10-10 11:17:26 -05:00
Jeremy Allison
79e693798c r16209: Klocwork bug #66, ensure no null deref.
Jeremy.
2007-10-10 11:17:25 -05:00
Jeremy Allison
2c1a2d7b40 r16207: Ensure we don't allocate an OID string unless
we know we don't have an error. Klocwork #6.
Jeremy.
2007-10-10 11:17:25 -05:00
Gerald Carter
304b7913cd r16206: Don Meyer <dlmeyer@uiuc.edu> pointed out that RHEL4 rpms use 'Epoch: 0' so work around that 2007-10-10 11:17:25 -05:00
Gerald Carter
44d4bab991 r16205: Fix 'make install' when srcdir != builddir 2007-10-10 11:17:25 -05:00
Volker Lendecke
07c5dcb863 r16204: Fix Klocwork # 14
localtime() can return NULL.

Volker
2007-10-10 11:17:25 -05:00
Volker Lendecke
4cb8cf221f r16203: Fix potentially writing one result of strtok beyond the end of alt_path.
Found by Klocwork, ID 653.

Volker
2007-10-10 11:17:25 -05:00
Jeremy Allison
319f80bbf0 r16202: Fix Klocwork #3. Strange - was already fixed in HEAD.
Jeremy.
2007-10-10 11:17:25 -05:00
Volker Lendecke
b369d0891a r16201: Fix Klocwork 439 2007-10-10 11:17:24 -05:00
Jeremy Allison
98751e8190 r16199: Fix Klocwork #1 - ensure we test the first
strtok for NULL.
Jeremy.
2007-10-10 11:17:24 -05:00
Volker Lendecke
3a7d01afbe r16198: Fix Klocwork 1023 2007-10-10 11:17:24 -05:00
Volker Lendecke
963ae5bd14 r16197: Fix Klocwork id 1338 2007-10-10 11:17:24 -05:00
Volker Lendecke
b5602cc4f1 r16196: A bit of defensive programming:
Klocwork ID 1773 complained about oldest being dereferenced in line 2275 where
it could be NULL. I think you can construct extreme racy conditions where this
actually could happen.

Volker
2007-10-10 11:17:24 -05:00
Gerald Carter
1b64f9a48b r16195: starting development for 3.0.24pre1 2007-10-10 11:17:24 -05:00
Gerald Carter
abca3b12e7 r16193: fix packaging dependency on RH platforms for the Unicode::MapUTF8 perl module (caused by upgarde in smbldap-tools) 2007-10-10 11:17:24 -05:00
Günther Deschner
65643d3172 r16192: Fix timeformats in the winbind response struct.
(pam_winbind users were forced to change a password inappropriately)

Guenther
2007-10-10 11:17:23 -05:00
Günther Deschner
dfebcc8e19 r16190: Fix more memleaks.
Guenther
2007-10-10 11:17:23 -05:00
Günther Deschner
e7d2b84aba r16187: Fix memleak.
Guenther
2007-10-10 11:17:23 -05:00
Volker Lendecke
7674a4f836 r16156: Fix storing NULL in the wrong place. Klocwork id's 127 and 128.
Volker
2007-10-10 11:17:23 -05:00
Jeremy Allison
da768bf9c2 r16155: Janitor for jelmer.
Fix typo in DEBUG()
Jeremy.
2007-10-10 11:17:23 -05:00
Günther Deschner
aeff1f0c47 r16154: Fix winbind function table typo.
Guenther
2007-10-10 11:17:23 -05:00
Volker Lendecke
128260527b r16153: Fix possible NULL dereference found by Klocwork # 252 2007-10-10 11:17:23 -05:00
Volker Lendecke
3159bd3a4e r16150: Fix possible NULL dereference found by Klocwork ID # 17 2007-10-10 11:17:22 -05:00
Volker Lendecke
a1fcacf756 r16141: Dummy commit to make the build farm re-test against Samba4 16140 2007-10-10 11:17:22 -05:00
Alexander Bokovoy
a18af427d7 r16138: By default, rootsbindir relies on SBINDIR so import it here 2007-10-10 11:17:22 -05:00
Alexander Bokovoy
5ffb424641 r16136: By default, rootsbindir relies on SBINDIR so import it here 2007-10-10 11:17:22 -05:00
Gerald Carter
1ffb0f06ad r16131: fix RedHat 9 spec files 2007-10-10 11:17:22 -05:00
Gerald Carter
9be3e07884 r16130: fix a shell portability issue for Solaris sh in installman.sh 2007-10-10 11:17:22 -05:00
Jeremy Allison
ee1b9207d3 r16126: Janitor for Volker..... This looks correct to me.
Jeremy.

Fix a parsing error that became apparent in 'make test': If we have no
group
rids in the info3 we set the array buffer pointer to "1" but fail to
actually
ship the array.

Volker.
2007-10-10 11:17:22 -05:00
Günther Deschner
e018ea3d1d r16122: As we use 'inetOrgPerson' as structural objectclass for new accounts for
eDir, we already add 'sn' as required attribute on LDAP add
operations.

When we modify an entry, we need to request 'sn' as well in our
attribute lists, so that we don't try to add it a second time.

Guenther
2007-10-10 11:17:21 -05:00
Günther Deschner
322f1664df r16121: Fix a eDir related memory leak.
Guenther
2007-10-10 11:17:21 -05:00
Günther Deschner
f6516a799a r16117: Make winbindd work again in security=ads.
We still used the old HOST/* UPN to get e.g. users, now we need
samaccountname$@REA.LM.

Guenther
2007-10-10 11:17:21 -05:00
James Peach
60b5f9618b r16116: Hoist the slow CLOCK_REALTIME message inside the branch so we never
confuse an uninitialised __profile_clock with CLOCK_REALTIME. Flip the
condition argument to SMB_WARN around so that it's correct (though
completely non-intuitive).
2007-10-10 11:17:21 -05:00
Günther Deschner
8fc70d0df0 r16115: Make "net ads changetrustpw" work again.
(adapt to the new UPN/SPN scheme).

Guenther
2007-10-10 11:17:21 -05:00
Günther Deschner
3a738a855d r16114: Make winbindd's group enumeration (set|get|endgrent) work again (when
enabled).

Do not bail out when a group just has 0 members.

Jeremy, please check, this has been removed with r13915.

Guenther
2007-10-10 11:17:21 -05:00
Jeremy Allison
6cd1cb5c9d r16112: Added Volker's fix for extra odd byte at the end
of UNIX_BASIC infolevel. Checked client implementations
(cifsfs and libsmb) and they ignore it. Thanks Volker.
Jeremy.
2007-10-10 11:17:20 -05:00
James Peach
fc6ed6a1aa r16111: Patch from Björn JACKE <samba@j3e.de>.
This fixes a problem where the clock definition for clock_gettime() is
present at compile time, but is not available on the running system. In
this case, we fall back to less-preferred clocks until we find one that
we can use.
2007-10-10 11:17:20 -05:00
Paul Green
f5be3e12e2 r16103: Properly rebuild timelimit on systems with executable extensions.
Paul
2007-10-10 11:17:20 -05:00
Günther Deschner
8759a00fed r16080: Re-add accidentially excluded in-forest domain trusts (fixes bug #3823).
Guenther
2007-10-10 11:17:20 -05:00
Gerald Carter
f3bd1c8c7d r16079: How embarassing. :-( Broke the build.
I will *always* compile before checking in...
I will *always* compile before checking in...
I will *always* compile before checking in...
I will *always* compile before checking in...
I will *always* compile before checking in...
2007-10-10 11:17:20 -05:00
Gerald Carter
b01f289f1a r16078: Patch from Aleksey Fedoseev <fedoseev@ru.ibm.com> to correctly
set the type of 'acl compatibility from string to integer
after the changes in r14207.
2007-10-10 11:17:20 -05:00
Jeremy Allison
5cd234a1ff r16076: Fix for machine password timeout overflow from Shlomi Yaakobovich
<Shlomi@exanet.com>.
Jeremy.
2007-10-10 11:17:19 -05:00
Volker Lendecke
bc78cca290 r16065: Re-add a strlower_m(account) in samr_create_user that was dropped for no
reason but to increase fidelity with W2k3. Tom Bork has raised valid concerns
that Unix scripts might rely on the account names being lower-case, so keep
that. We might later decide to only lower-case the unix name passed to
'add [user|group] script' but keep the passdb entry upper-case. But there are
enough user-visible changes in 3_0 already so that we should push this off to
a later date.

Tom, waiting for more bug reports from you ;-))

Thanks for insisting!

Volker
2007-10-10 11:17:19 -05:00
Volker Lendecke
8f9ba5f96c r16064: Bug fix for another one Tom Bork has reported:
'valid users = +unixgroup' failed with smbpasswd if 'unixgroup' has a
(non-algorithmic) group mapping.

Thanks a lot!

People out there listening, please test current code, this release is

	   **BIG**

:-)

Volker
2007-10-10 11:17:19 -05:00
Volker Lendecke
5a37aba105 r16060: This is one of the more dirty patches I've put in lately. Parse enough of
SetUserInfo level 25 to survive the join method XP uses if the user did not
exist before. For good taste this contains way too much cut&paste, but for a
real fix there is just not enough time.

Up to 3.0.22 we completely ignored that a full level 21 is being sent together
with level 25, but we got away with that because on creation we did not set
the "disabled" flag on the workstation account. Now we correctly follow W2k3
in this regard, and we end up with a disabled workstation after join.

Man, I hate rpc_parse/. The correct fix would be to import PIDL generated samr
parsing, but this is would probably be a bit too much for .23...

Thanks to Tom Bork for finding this one.

Volker
2007-10-10 11:17:18 -05:00
James Peach
aafd4db457 r16057: Coalesce the DMAPI configure tests into a single macro. Add
a more specific probe to try and eliminate old, incompatible
DMAPI implementations provided by IRIX 6.4 and AIX 4.3.
2007-10-10 11:17:18 -05:00
Jeremy Allison
e5b7acc9b5 r16054: Janitor for Volker ? Volker - some reason you didn't
fix this in 3.0 ?
Jeremy.

We had no way to return NT_STATUS_OK from the netlogon serverpwset,
although
we successfully set the machine password...

One thing the samba3 join test found.

Volker
2007-10-10 11:17:18 -05:00
Jim McDonough
00eb42791a r16047: Remove unnecessary line, as this value is set in either branch of the
'if' below.  Spotted by Aleksey Fedoseev.
2007-10-10 11:17:18 -05:00
Volker Lendecke
91534146b4 r16046: Hmmm. I don't fully understand popt, but this is necessary for smbclient to
show a prompt again :-)

James, could you check that this is ok? I think this was part of your Revision
15848.

Thanks,

Volker
2007-10-10 11:17:18 -05:00