1
0
mirror of https://github.com/samba-team/samba.git synced 2025-01-28 17:47:29 +03:00

758 Commits

Author SHA1 Message Date
Jeremy Allison
84bfd7395c Remove the extraneous logic in smb_set_info_standard - we
do the time twiddling logic at the smb_set_file_time level.
Jeremy.
2009-07-30 13:16:40 -07:00
Jeremy Allison
e411ec6a8a SMB_INFO_STANDARD is not a valid info level on set,
and was being read incorrectly anyway. Remove.
Jeremy.
2009-07-30 13:13:23 -07:00
Tim Prouty
f49f3fcb01 s3: Convert a few callers of unix_convert() over to filename_convert()
This patch also changes the unix convert flags to make sure the
correct semantics are preservered for allowing/disallowing wildcards
in the last component of the path.
2009-07-24 18:51:41 -07:00
Tim Prouty
7197ba3abd s3: Remove a few callers of get_full_smb_filename() 2009-07-24 18:51:40 -07:00
Tim Prouty
cd5133b112 s3: Simplify rename_internals() by passing in smb_filename structs 2009-07-24 15:10:45 -07:00
Tim Prouty
10324b177e s3: Allow filename_convert() to pass through unix_convert_flags and let the caller know if the path has a wildcard
This also eliminates the need for resolve_dfspath().
2009-07-24 15:10:45 -07:00
Tim Prouty
4b42927ec3 s3: Convert some callers of vfs_stat_smb_fname to SMB_VFS_STAT() 2009-07-22 09:51:17 -07:00
Tim Prouty
605649edc3 s3: plumb smb_filename through some of the trans2 posix_* functions 2009-07-21 12:04:59 -07:00
Tim Prouty
23c703a01e s3: Remove unnecessary callers of get_full_smb_filename
This often times means explicitly denying certain operations on a stream
as they are not supported or don't make sense at a particular level.  At
some point in the future these can be enabled, but for now it's better to
remove ambiguity
2009-07-21 12:04:59 -07:00
Tim Prouty
00e267008d s3: Remove the now unused fname parameter from filename_convert() 2009-07-21 12:04:59 -07:00
Tim Prouty
78ce9dd471 s3: Remove unnecessary fname argument from callers of filename_convert 2009-07-21 12:04:59 -07:00
Tim Prouty
6b49f28592 s3: Plumb smb_filename through map_open_params_to_ntcreate 2009-07-21 12:04:58 -07:00
Tim Prouty
5a8d70d465 s3: Change fsp->fsp_name to be an smb_filename struct! 2009-07-20 17:26:56 -07:00
Jeremy Allison
0bd13fda76 Fix Coverity CID 928. Removed check as this can never be null.
Jeremy.
2009-07-17 21:40:23 -07:00
Jeremy Allison
3036a9c7c1 Fix Coverity CID 929. Potential NULL deref after code refactoring.
Jeremy.
2009-07-17 21:36:55 -07:00
Jeremy Allison
d654782806 Fix coverity CID 930. Pointer check can never be null here.
Jeremy
2009-07-17 21:29:28 -07:00
Jeremy Allison
7254898bc7 Fix coverity CID 931. This check is redundent as smb_fname can
never be null in this function.
Jeremy.
2009-07-17 21:26:16 -07:00
Stefan Metzmacher
377a97579b s3:smbd: try to fix a compiler warning on i386 : left shift count >= width of type
metze
2009-07-15 21:04:06 +02:00
Stefan Metzmacher
9e2c50971e s3:smbd: check quota access against sec_initial_uid() instead of 0
And return an NTSTATUS mapped from errno. Instead of hardcoded values.

metze
2009-07-15 11:56:17 +02:00
Jeremy Allison
b25e3b6c8a Fix set_posix_lock check which had been reversed in the recent
changes.
Jeremy.
2009-07-13 17:17:37 -07:00
Stefan Metzmacher
ed99bf7317 s3:smbd: make smbd_do_qfsinfo() non static for use in SMB2 GetInfo
metze
2009-07-13 14:13:06 +02:00
Stefan Metzmacher
2a92139a1c s3:smbd: split out smbd_do_qfsinfo() from call_trans2qfsinfo()
metze
2009-07-13 14:12:33 +02:00
Stefan Metzmacher
7d735519d7 s3:smbd: make smbd_do_setfilepathinfo() non static for use in SMB2 SetInfo
metze
2009-07-13 11:18:59 +02:00
Stefan Metzmacher
f26a2ca8e4 s3:smbd: split out smbd_do_setfilepathinfo() from call_trans2setfilepathinfo()
metze
2009-07-13 11:18:50 +02:00
Stefan Metzmacher
64221bc3fa s3:smbd: add support for marshalling SMB2 FileFullEaInformation
metze
2009-07-12 17:11:08 +02:00
Stefan Metzmacher
e9865150df s3:smbd: add support for marshalling SMB2 FileAllInformation
metze
2009-07-12 17:10:03 +02:00
Stefan Metzmacher
0851d73f4d s3:smbd: filter out SMB2 specific private query info levels for SMB1
metze
2009-07-12 17:07:34 +02:00
Stefan Metzmacher
0ba532e1b2 s3:smbd: make smbd_do_qfilepathinfo() non static for use in SMB2
metze
2009-07-12 16:55:22 +02:00
Stefan Metzmacher
ee690df294 s3:smbd: split calculation and mashalling of file index and access_mask
metze
2009-07-12 16:54:46 +02:00
Stefan Metzmacher
8422e03233 s3:smbd: split out smbd_do_qfilepathinfo() from call_trans2qfilepathinfo()
This prepares SMB2 GetInfo.

metze
2009-07-12 16:54:29 +02:00
Stefan Metzmacher
20bc933c5b s3:smbd: add missing return after reply_nterror()
metze
2009-07-12 16:42:43 +02:00
Jeremy Allison
2000421c59 Remove reply_unixerror() - no longer needed. Should make Metze's refactoring a lot easier.
Jeremy.
2009-07-10 18:23:00 -07:00
Tim Prouty
dcc97c5ad7 s3 plumb smb_filename through smb_set_file_allocation_info() 2009-07-08 21:36:04 -07:00
Tim Prouty
161e182b65 s3: Remove is_ntfs_stream_name() and split_ntfs_stream_name()
Actually I moved split_ntfs_stream_name into torture.c which is the one
consumer of it.  This could probably be changed at some point.
2009-07-08 21:36:04 -07:00
Tim Prouty
1a1d10d22f s3: Plumb smb_filename through dos_mode() and related funtions 2009-07-08 21:36:03 -07:00
Jeremy Allison
400c18a8c4 Rename update_stat_ex_writetime() -> update_stat_ex_mtime()
to better describe what we're doing here.
Jeremy
2009-07-08 18:05:30 -07:00
Jeremy Allison
c9c3d4312d The migration to struct stat_ex broke the calculation of
create time from the existing timestamps (for systems
that need to do this). Once the write time is changed
via a sticky write, the create time might need to be
recalculated. To do this I needed to add a bool into
struct stat_ex to remember if the st_ex_btime field
was calculated, or read from the OS. Also fixed the
returning of modified write timestamps in the return
from NTCreateX, SMBattr and SMBattrE (which weren't
taking into account the modified timestamp stored
in the open file table). Attempting to fix an issue
with Excel 2003 and offline files. Volker and Metze,
please review.
Jeremy
2009-07-08 17:51:35 -07:00
Tim Prouty
3cb0e521e1 s3: Plumb smb_filename through SMB_VFS_NTIMES 2009-07-06 15:38:42 -07:00
Tim Prouty
18a27a8df2 s3 sticky write time: Removed unused args and tighten up a function by making an arg const 2009-07-06 15:38:41 -07:00
Tim Prouty
99bd4fda0c s3: Plumb smb_filename around SMB_VFS_CHFLAGS
SMB_VFS_CHFLAGS isn't actually getting the smb_filename struct for now
since it only operates on the basefile.  This is the strategy for all
path-based operations that will never actually operate on a stream.

By clarifying the meaning of path based operations that don't take an
smb_filename struct, modules that implement streams such as vfs_onefs
no longer need to implement SMB_VFS_CHFLAGS to ensure it's only called
on the base_name.
2009-07-06 15:38:41 -07:00
Tim Prouty
0f6e10886f s3: Change some filename_convert to pass in NULL for char **fname argument 2009-07-06 15:38:41 -07:00
Tim Prouty
258952aa85 s3: Plumb smb_filename through SMB_VFS_UNLINK 2009-07-06 15:38:36 -07:00
Tim Prouty
5a09ba460c s3: Plumb smb_filename through SMB_VFS_RENAME 2009-07-06 15:38:29 -07:00
Stefan Metzmacher
8b94eb6cc8 s3:smbd: push nttrans and trans2 responses with no data to the client
For sync replies it's not a problem, as construct_reply() will send
the response, but for async replies we would not send the reply to the client.
Currently the notify code works arround this manually, so I assume
we didn't have a bug here. But the next commits will simplify
the notify code.

metze
2009-07-02 09:10:59 +02:00
Jeremy Allison
82b5fad8be Ensure we don't use delayed writes on POSIX opened files.
Don't remove pending writetime changes if no time changes
are sent in UNIX_BASIC infolevel.
Jeremy
2009-07-01 17:39:10 -07:00
Jeremy Allison
b971860e01 Fix bug #6520 time stamps - e.g. last mod time is not preserved when "unix extensions=yes" are set - and using latest cifs vfs client
Cancel out any pending "sticky" writes or "last write" changes when
doing a UNIX info level set.
Jeremy.
2009-07-01 16:58:14 -07:00
Tim Prouty
6395bc55db s3: pass a valid stat into file_ntimes()
file_ntimes() calls can_write_to_file() which expects a valid stat struct
2009-06-25 18:40:32 -07:00
Tim Prouty
358ccc3282 s3: Change set_ea() and its callers to use smb_filename 2009-06-25 18:25:47 -07:00
Tim Prouty
e129384d7c s3: Plumb smb_filename through SMB_VFS_STAT and SMB_VFS_LSTAT
This patch introduces two new temporary helper functions
vfs_stat_smb_fname and vfs_lstat_smb_fname.  They basically allowed me
to call the new smb_filename version of stat, while avoiding plumbing
it through callers that are still too inconvenient.  As the conversion
moves along, I will be able to remove callers of this, with the goal
being to remove all callers.

There was also a bug in create_synthetic_smb_fname_split (also a
temporary utility function) that caused it to incorrectly handle
filenames with ':'s in them when in posix mode.  This is now fixed.
2009-06-24 21:15:25 -07:00
Jeremy Allison
34267482d5 Replace the boilerplate calls to :
resolve_dfspath() -> unix_convert() -> get_full_smb_filename() -> check_name()
with a new function filename_convert().
This restores the check_name() calls that had gone missing
since the default create_file was changed. All "standard"
pathname processing now goes through filename_convert().
I'll take a look at the non-standard pathname processing
next. As a benefit, fixed a missing resolve_dfspath()
in the trans2 mkdir call.
Jeremy.
2009-06-18 13:13:38 -07:00