1
0
mirror of https://github.com/samba-team/samba.git synced 2025-03-12 20:58:37 +03:00

1304 Commits

Author SHA1 Message Date
Andrew Tridgell
86b91f5073 r23058: the cldap code was getting too intimate with the internals of struct
asn1_context. A hangover from when it wasn't a allocated structure
(This used to be commit e4b7968a40e11a96a0b9671f8ef5436f18427818)
2007-10-10 14:52:45 -05:00
Andrew Tridgell
31f047f734 r23057: only call the async recv function for the first pending receive, not
all pending receives, when the transport dies. This is because the
async callback most commonly shuts down the connection (it's the only
reasonable thing to do when it's dead), and that frees the whole
context. That means that if we loop more than once, we'll end up using
freed memory.
(This used to be commit 75d537d3a5e3fc5258ce48bfec0c0ce6160978f6)
2007-10-10 14:52:45 -05:00
Stefan Metzmacher
774d66c1e6 r23037: actually fix the asn1 memory leak :-)
metze
(This used to be commit 13bda1152d3b88c0b93610d4698ce24183334276)
2007-10-10 14:52:43 -05:00
Andrew Tridgell
931f594cf1 r23036: error checking on asn1_init() failure
(This used to be commit 26cf8494084c0106ef0e1c9b6ef40eeadf945ef2)
2007-10-10 14:52:43 -05:00
Andrew Tridgell
7bb939b1cb r23030: finally fixed up our asn1 code to use better memory allocation. This
should allow us to fix some long standing memory leaks.
(This used to be commit 3db49c2ec9968221c1361785b94061046ecd159d)
2007-10-10 14:52:42 -05:00
Ronnie Sahlberg
a777eb0cfa r22986: error 2312 is returned when NetSessDel() fails because a matching session (username/clientname)
could not be found
(This used to be commit e2b46d280db114656e18f023a9efa939b5c893d5)
2007-10-10 14:52:36 -05:00
Ronnie Sahlberg
402218516a r22958: For SRVSVC/NetFileClose only Administrator is allowed to close open files.
If a normal user tries to close a file that exists, even that users own files   the server
responds with this error on w2k

if the file does not exist, the server instead responds with WERR_BADFILE
(This used to be commit c17df8bed66d70765b85b6e04f2ad0a57073ffb4)
2007-10-10 14:52:31 -05:00
Stefan Metzmacher
40cd2d7780 r22944: fix bug #4618:
rename private -> private_data

metze
(This used to be commit 58551f2f28fce8f1fcd04736c47ecd7458f32ea2)
2007-10-10 14:52:30 -05:00
Andrew Bartlett
cb00a33c67 r22884: Be consistant with the case of these constants.
Andrew Bartlett
(This used to be commit 7b086eebd6af21674ca18c7d9b35cb2c6b57514a)
2007-10-10 14:52:28 -05:00
Stefan Metzmacher
bf62b6642c r22866: handle incoming chained smb2 requests in our server code to let
the windows explorer in longhorn beta3 work.

metze
(This used to be commit 2390c9f24daccec917608cac0870890cdc73cb1c)
2007-10-10 14:52:26 -05:00
Stefan Metzmacher
5151068d5a r22858: - let SMB2-LOCK-VALID-REQUEST pass against longhorn beta3
- add modify the SMB2-LOCK-BLOCK-WRITE test to also test reading
  and name in SMB2-LOCK-RW-EXCLUSIV
- add SMB2-LOCK-NONE and SMB2-LOCK-SHARED

metze
(This used to be commit 258555975d3877cff3bc3022f3439cdd61f6c8ac)
2007-10-10 14:52:24 -05:00
Stefan Metzmacher
4ef7bab6d0 r22791: make it possible to use smb2_create_blob_add() in the server code too
metze
(This used to be commit c08eeb62ca001cebcb7af2b655269e4b388e69c1)
2007-10-10 14:52:18 -05:00
Stefan Metzmacher
e1635caaf3 r22790: fix initialization for chained requests
metze
(This used to be commit e1cc933c009f98264c0e8c65bfd93a0d1219a0e2)
2007-10-10 14:52:17 -05:00
Stefan Metzmacher
7e330c7c0c r22788: fix typo
metze
(This used to be commit 635a636e89e462825efaacd5563c40fec2ceefb1)
2007-10-10 14:52:17 -05:00
Jelmer Vernooij
cc26fe9b74 r22762: Some ldb_map changes:
* Change license to LGPL, so it can be used by non-Samba users of
LDB (cleared with Martin as well).

* Include ldb_map in standalone build.

* Move ldb_map to its own directory
(This used to be commit a90202abca26c0da5425a2f3dd8494077c3290fd)
2007-10-10 14:52:15 -05:00
Stefan Metzmacher
7fe9a3255a r22749: fix memory leak of nbt_name_request structure which are used to send replies
and never have an async callback that could free it.

we only had the memory leak in the error path the
standard path was ok.

metze
(This used to be commit d2a2fe662db5b773f4bd54498d6b31b773633903)
2007-10-10 14:52:09 -05:00
Stefan Metzmacher
68b531e817 r22748: fix memleaks by passing an mem_ctx to
irpc_servers_byname()

metze
(This used to be commit b54584dfabee77ec7743cab431bda9765057a295)
2007-10-10 14:52:09 -05:00
Stefan Metzmacher
298f178dca r22628: convert to new composite api
and free the smbcli_request explicit to fix a crash where
the request handler gets called after its private data is already
freed

metze
(This used to be commit 55306c618807f2661090d2189e269cb3e142ee06)
2007-10-10 14:51:55 -05:00
Stefan Metzmacher
a475bfdcca r22620: fix compiler warnings
metze
(This used to be commit b7adc88e743308742545f3ee6710f8c0bfa197d8)
2007-10-10 14:51:53 -05:00
Andrew Tridgell
b7e20c87e3 r22616: allow the unclist file to not specify a share name, and instead
inherit the share name from the command line if it is not
specified. This allows you to just specify the servers in the unclist,
and connect to the same share on all servers.
(This used to be commit 946f5d09ae204348026170173cf2bfd30d49e4f2)
2007-10-10 14:51:52 -05:00
Stefan Metzmacher
1c8b46bb72 r22405: fix memory leak in error path
metze
(This used to be commit d19195bfa5405822613d5236cd76547f0ac77bde)
2007-10-10 14:51:15 -05:00
Andrew Tridgell
4685a42eaf r22090: fix error handling in cldap client library to cope with bad host names
(This used to be commit 99c51b104d05a8ad32563497216271e2f20d4985)
2007-10-10 14:49:51 -05:00
James Peach
c61db93c7e r21949: After discussion with the Apple and Linux client maintainers,
changing the FindFirst response for the UNIX_INFO2 level to include
a length field before the name. The name is not required to be null
terminated. the lenght field does not count any null.
(This used to be commit eef672bfff6b112ceceec2a58c78042352e83276)
2007-10-10 14:49:39 -05:00
Andrew Bartlett
9b03286b32 r21806: I've been working over the last week to fix up the LDAP backend for
Samba4.  This only broke on global catalog queries, which turned out to
be due to changes in the partitions module that metze needed for his
DRSUAPI work.

I've reworked partitions.c to always include the 'problematic' control,
and therefore demonstrated that this is the issue.  This ensures
consistency, and should help with finding issues like this in future.

As this control (DSDB_CONTROL_CURRENT_PARTITION_OID) is not intended to
be linearised, I've added logic to allow it to be skipped when creating
network packets.

I've likewise make our LDAP server skip unknown controls, when marked
'not critical' on it's input, rather than just dropping the entire
request.  I need some help to generate a correct error packet when it is
marked critical.

Further work could perhaps be to have the ldap_encode routine return a
textual description of what failed to encode, as that would have saved
me a lot of time...

Andrew Bartlett
(This used to be commit eef710668f91d1bbaa2d834d9e653e11c8aac817)
2007-10-10 14:49:29 -05:00
Andrew Bartlett
3370f2f2d7 r21761: - Give more detail on LDAP client library failures (make it clear
where the error is from)

- Make default error string more consistant

Andrew Bartlett
(This used to be commit 7f115579d20a3112efd11444fafcbf78698fc9a1)
2007-10-10 14:49:24 -05:00
James Peach
754d416ea5 r21710: Add client support for the UNIX_INFO2 info level in the QueryFile,
QueryPath and FindFirst calls. Add a new torture test to verify the
server side.
(This used to be commit 7f56da2d1fa0718e5282bb4aea7d9a63a62f0bc7)
2007-10-10 14:49:16 -05:00
James Peach
fcaeedeff3 r21668: Add SMB_QFS_POSIX_WHOAMI to trans2.h so it's easy to find. Add
convenience API to create an anonymous credential. Don't clobber
cmdline_credentials in the UNIX-WHOAMI test.
(This used to be commit 73cea4e0c66f57057ed12b07bbb94b4e783ba6bf)
2007-10-10 14:49:07 -05:00
Stefan Metzmacher
c6b66db2b2 r21594: give the same error in all resolve backends
metze
(This used to be commit 5534ba591deb362e30e40afff923af4b890ab7a9)
2007-10-10 14:49:03 -05:00
Stefan Metzmacher
e31d922592 r21593: give a more useful error, when we can't resolve a long name
via broadcast of wins

metze
(This used to be commit 49591d699653e48f2e9540359e5b4ae97786511c)
2007-10-10 14:49:02 -05:00
Stefan Metzmacher
7f13043d7e r21592: compress_name() returns NULL for names longer than 15 chars
giving NO_MEMORY back is ugly, so give a useful error

metze
(This used to be commit fbc1e16331c5957892e4bfc439ea5c4e0387b32e)
2007-10-10 14:49:02 -05:00
Stefan Metzmacher
505fd4eb99 r21591: add new error code
metze
(This used to be commit 04da3db29d57ffeab3ba39551b326b8c176a5bcb)
2007-10-10 14:49:02 -05:00
Andrew Tridgell
60fd088c48 r21535: - fixed a crash in the RAW-ACLS test. When a dcerpc_pipe is created
using the pattern in the clilsa code, it didn't fill in the p->binding
structure. This affects nearly all users of dcerpc_pipe_open_smb(), so
the simplest fix is to ensure that dcerpc_pipe_open_smb() initialises
the binding if its not already there.

- re-enable the RAW-ACLS test
(This used to be commit d8875c286d2be49c01703d8fd58bbc1842054bd9)
2007-10-10 14:48:54 -05:00
Stefan Metzmacher
bf772399bf r21511: this seems to be the nicer fix for the problem with
the windows 2000 LDAP client

metze
(This used to be commit d40465470fa09827ea529e1f2c80bca9efc152a8)
2007-10-10 14:48:47 -05:00
Stefan Metzmacher
7f9d949bd3 r21510: make it possible to push tags with length > 0xFFFFFF
metze
(This used to be commit 8e604107da4a8a1bf6ccab45e85e147daab29519)
2007-10-10 14:48:47 -05:00
Stefan Metzmacher
31d6d8c457 r21501: ugly but the windows 2000 mmc deturns decoding error without this
metze
(This used to be commit f17da75754f8cc79b60e04b54a4bc99191e71ff3)
2007-10-10 14:48:45 -05:00
Stefan Metzmacher
aa5677040c r21316: if we got an unexpected nbt packet that most times mean
we got a 2nd answer to a broadcast message and have already remove
the packet id from out list while getting the first response

metze
(This used to be commit 8c26e04900da02bdf440f1d48b512e2550e89c34)
2007-10-10 14:48:09 -05:00
Stefan Metzmacher
08de05ce5a r21307: make it possible to pass in NULL for domain or rid,
if someone isn't interessted in one of it

metze
(This used to be commit 1fdc71918a430c35af91fa7788e191d381f76d56)
2007-10-10 14:48:08 -05:00
Jelmer Vernooij
97416e6b01 r21297: Remove the GTK+ tools and library from the main repository. They are now maintained separately in bzr at http://people.samba.org/bzr/jelmer/samba-gtk
This also adds some more headers to the list that is installed and a couple of extra #include lines so these
headers can be used externally without problems.
(This used to be commit 07652f65ce7a5b19130f1a27cbf0e1e5fae13454)
2007-10-10 14:48:04 -05:00
Stefan Metzmacher
10c928a94f r21291: add two more error codes
metze
(This used to be commit dd04c5dec58b18048ca5029f7bfe513242cbe4e9)
2007-10-10 14:48:02 -05:00
Andrew Tridgell
21650cf377 r21206: - a couple more nttrans places were a memcpy() should be used
- changed the setup array in nttrans to be a uint8 array, instead of a
  uint16 array. This makes it clearer that it is the job of the caller
  to do any byte swapping within that data
(This used to be commit fa3c9b29ae1c7c6a9bc97484cc386aeec9b5d266)
2007-10-10 14:44:45 -05:00
Volker Lendecke
2342219d69 r21183: Commit the big/little endian fix for nttrans setup[] handling.
Please check!

For code symmetry reasons, trans2 might also see this fix, but this is left to
the interested reader :-)

Volker
(This used to be commit f2d364ebe69fc5d624e456cc7d941071811a5567)
2007-10-10 14:44:43 -05:00
Stefan Metzmacher
a9a3e4eafc r21072: fix compiler warning
metze
(This used to be commit e788709835fa13b512fbf38951c9d0ca9bc3df18)
2007-10-10 14:44:28 -05:00
Jelmer Vernooij
c471abbcfe r20963: remove unused functions, run LOCAL-TDR by default
(This used to be commit 0f34c67fff53d5bd3c1b5a5618190ad7154e8d07)
2007-10-10 14:44:04 -05:00
Stefan Metzmacher
d363192d64 r20801: try to always fix up the acl revision when we add or remove
an ace

metze
(This used to be commit 18cc56be6a7c21e5b19d0826aca6ae2416c116b8)
2007-10-10 14:43:31 -05:00
Stefan Metzmacher
d6fafdb237 r20800: fix compiler warnings
metze
(This used to be commit 6ce994720cdd8b7dd0b789460b5ae7da19261696)
2007-10-10 14:43:31 -05:00
Stefan Metzmacher
e754ec1d8a r20799: if any ace has the optional sub object, the acl revision needs
to be SECURITY_ACL_REVISION_ADS (4)

metze
(This used to be commit a67bb4365958f4bfadbf47b2231992e2aadd26a1)
2007-10-10 14:43:31 -05:00
Stefan Metzmacher
2246d32e70 r20795: dom_sid_parse_talloc() gets an null terminated string as input,
the SDDL string has the sid strings embedded, so we need to create
a null terminated string...

metze
(This used to be commit 532395a18db84affa8a743b995e9fae2e3c312f2)
2007-10-10 14:43:30 -05:00
Stefan Metzmacher
15f6cf2449 r20765: add two more schema related error codes
metze
(This used to be commit 75f5a88f2229fa604726ecb0ebb2b5a4589d5b86)
2007-10-10 14:40:48 -05:00
Andrew Tridgell
1c211a2e43 r20650: revert a bunch of code I didn't mean to commit yet
(This used to be commit b3e2d4908781781a487eaeb683d22eb967e5597d)
2007-10-10 14:37:26 -05:00
Andrew Tridgell
f6274959ba r20647: add cluster code
(This used to be commit 5870830b99a8d76bda1ff5af3fcf8dda9aba50ec)
2007-10-10 14:37:24 -05:00