Andrew Tridgell
6cd01c9665
s4-dsdb: give full error message for operational failures
2010-11-29 18:04:42 +11:00
Andrew Tridgell
74d373d0f7
s4-pydsdb: two more GPO related flags
2010-11-29 18:04:41 +11:00
Andrew Tridgell
e54c8bef8a
s4-pydsdb: added GPO policy flags
2010-11-29 18:04:41 +11:00
Matthias Dieter Wallnöfer
736d36a948
s4:dsdb/repl/drepl* - move "lib/messaging/irpc.h" include into "drepl_service.h"
...
This is needed to fix a Tru64 "cc" warning regarding "enum drepl_role_master".
Autobuild-User: Matthias Dieter Wallnöfer <mdw@samba.org>
Autobuild-Date: Sun Nov 28 12:46:19 CET 2010 on sn-devel-104
2010-11-28 12:46:19 +01:00
Matthias Dieter Wallnöfer
eaac277381
s4:dsdb/repl/drepl_service.c - return the correct WERR result
2010-11-27 21:50:42 +01:00
Matthias Dieter Wallnöfer
bfb28243d0
s4:drepl_service.c - fix error macro (use "_werr" and not "werr")
...
Detected by Tru64 "cc".
2010-11-27 21:50:42 +01:00
Matthias Dieter Wallnöfer
a13bd32fa9
s4:dsdb/repl/drepl_out_helpers.c - print out the correct error message (werr)
...
Also detected by Tru64 "cc".
2010-11-27 21:50:42 +01:00
Matthias Dieter Wallnöfer
c8aa7d5837
s4:param/secrets.h - fix "enum netr_SchannelType" include correctly
2010-11-27 21:50:41 +01:00
Matthias Dieter Wallnöfer
4dece699ed
s4:dsdb/samdb/samdb.h - fix include ordering in order to prevent warnings on Tru64
2010-11-27 21:50:41 +01:00
Matthias Dieter Wallnöfer
258dc02a9d
s4:role transfer - use always type "enum drepl_role_master" for role specifications
...
Autobuild-User: Matthias Dieter Wallnöfer <mdw@samba.org>
Autobuild-Date: Sat Nov 27 16:03:43 CET 2010 on sn-devel-104
2010-11-27 16:03:42 +01:00
Matthias Dieter Wallnöfer
d613f91a74
s4:samba3sam LDB module - correctly print out an unsigned value
...
Here we can print it out as unsigned since we are generating a string
attribute.
2010-11-27 15:17:18 +01:00
Matthias Dieter Wallnöfer
2163c7a298
s4:samba3sam LDB module - make the "pw_uid"/"pw_gid" conversion a bit clearer
...
And remove the "long" specifier since at least on the major platforms
(Linux, BSD and Solaris) these types are defined as "uint32_t".
2010-11-27 15:17:18 +01:00
Matthias Dieter Wallnöfer
e9f019e28c
s4:dsdb tests - make use of "ldb.get_domain_sid()"
2010-11-27 15:17:18 +01:00
Matthias Dieter Wallnöfer
7545b5b3db
s4:dsdb/tests/python/sam.py - we don't need the domain SID
2010-11-27 15:17:18 +01:00
Andrew Tridgell
a589b9a033
s4-pydsdb: use cpp macro to simplify flags definitions
...
also added some more from flags.h
2010-11-28 00:16:37 +11:00
Matthias Dieter Wallnöfer
6a2171c739
s4:rootdse LDB module - remove unused variable
...
Autobuild-User: Matthias Dieter Wallnöfer <mdw@samba.org>
Autobuild-Date: Fri Nov 26 13:58:27 CET 2010 on sn-devel-104
2010-11-26 13:58:27 +01:00
Matthias Dieter Wallnöfer
8680c6f888
s4:objectclass LDB module - simply use "msg" when requesting the message
2010-11-26 13:10:01 +01:00
Matthias Dieter Wallnöfer
848010b570
s4:objectclass LDB module - move the "mem_ctx" allocation to a better place
...
It's only needed if we've a schema around.
2010-11-26 13:10:00 +01:00
Andrew Bartlett
7048ad11f5
s4-dsdb Reorganise and clarify the LSA objectClass check (forbidden on LDAP)
...
This arranged the check to avoid talloc_strdup() (the schema pointers
are constant, and can be relied upon), and checks the untrusted bit
first (it is faster), before the ldb_attr_cmp().
The strcmp() here was valid, if unusual, because the ldapDisplayName
values are already in the correct case, but strcasecmp() is more
correct, as for the small extra cost, we avoid a difficult to diagnose
bug later.
Andrew Bartlett
Signed-off-by: Matthias Dieter Wallnöfer <mdw@samba.org>
2010-11-26 13:10:00 +01:00
Andrew Bartlett
439a2d6983
s4-objectclass Use a specific local variable name, not 'value'
...
This makes it clearer what the local variable in use here does.
Andrew Bartlett
Signed-off-by: Matthias Dieter Wallnöfer <mdw@samba.org>
2010-11-26 13:09:59 +01:00
Andrew Tridgell
bf52cffd25
s4-kcc: fixed valgrind errors in drs replicaInfo server side
...
Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>
Autobuild-User: Andrew Tridgell <tridge@samba.org>
Autobuild-Date: Fri Nov 26 03:52:30 CET 2010 on sn-devel-104
2010-11-26 03:52:30 +01:00
Andrew Bartlett
fab9d94006
s4-dsdb Remove rootDSE and anonymous checks from acl_read
...
The rootdse module handles rootDSE requests, and blocks anonymous
access, so we on't need to do it again here.
Andrew Bartlett
Autobuild-User: Andrew Bartlett <abartlet@samba.org>
Autobuild-Date: Fri Nov 26 00:36:19 CET 2010 on sn-devel-104
2010-11-26 00:36:19 +01:00
Andrew Bartlett
d184da8065
s4-dsdb Add 'block anonymous' checks to the rootdse module
...
This ensures that one single point checks for and blocks anonymous
read access to the database over LDAP.
Andrew Bartlett
2010-11-26 08:50:42 +11:00
Andrew Bartlett
885ecd7b6b
s4-dsdb Remove mem_ctx argument from dsdb_module_find_dsheuristics().
...
A function that does not return memory should not take a memory context.
Andrew Bartlett
2010-11-26 08:50:42 +11:00
Nadezhda Ivanova
fad57d8ad0
s4-tests: Made acl tests to reconnect if dSHeuristics is being manipulated
...
Also made password tests set dSHeuristics only once rather that once per test.
Autobuild-User: Nadezhda Ivanova <nivanova@samba.org>
Autobuild-Date: Thu Nov 25 20:48:38 CET 2010 on sn-devel-104
2010-11-25 20:48:38 +01:00
Nadezhda Ivanova
1e9a7882be
s4-tests: Modified create_ou to only accept security.descriptor type for sd to avoid confusion
...
It used to work with sddl as well, but this is confusing and could lead to errors. It also caused a message about tallocing a security descriptor to appear.
Autobuild-User: Nadezhda Ivanova <nivanova@samba.org>
Autobuild-Date: Thu Nov 25 19:46:42 CET 2010 on sn-devel-104
2010-11-25 19:46:42 +01:00
Matthias Dieter Wallnöfer
ae61408e2f
s4:lsa RPC server / objectclass LDB module - fix the creation of trusted domain objects
...
Tridge pointed out that it is to dangerous to allow them to be created
with SYSTEM permissions. The solution using the "untrusted" flag should
be much more viable.
Autobuild-User: Matthias Dieter Wallnöfer <mdw@samba.org>
Autobuild-Date: Thu Nov 25 13:05:56 CET 2010 on sn-devel-104
2010-11-25 13:05:56 +01:00
Nadezhda Ivanova
21aceb1374
s4-tests: Modified sec_descriptor.py to use samba.tests.delete_force
2010-11-25 01:15:24 +02:00
Nadezhda Ivanova
9917525b96
s4-tests: Modified sam.py to use samba.tests.delete_force
2010-11-25 01:14:58 +02:00
Nadezhda Ivanova
0d99a5f27c
s4-tests: Modified passwords.py to use samba.tests.delete_force
2010-11-25 01:13:47 +02:00
Nadezhda Ivanova
71af506950
s4-tests: delete_force was unused, removed it.
2010-11-25 01:13:24 +02:00
Nadezhda Ivanova
5e7d99a5d8
s4-tests: Modified ldap_schema.py to use samba.tests.delete_force
2010-11-25 01:12:42 +02:00
Nadezhda Ivanova
d21d3e7db8
s4-tests: Modified ldap.py to use samba.tests.delete_force
2010-11-25 01:12:18 +02:00
Nadezhda Ivanova
66aa40b9d9
s4-tests: Modified deletetest.py to use samba.tests.delete_force
2010-11-25 01:11:57 +02:00
Nadezhda Ivanova
d7731f6f39
s4-tests: Modified acly.py to use common delete_force instead of defining its own.
2010-11-25 01:09:27 +02:00
Matthias Dieter Wallnöfer
1352a9406f
s4:objectclass LDB module - LSA objects - allow them if the SYSTEM control is specified
...
This fits better than the RELAX one.
Autobuild-User: Matthias Dieter Wallnöfer <mdw@samba.org>
Autobuild-Date: Wed Nov 24 18:23:01 CET 2010 on sn-devel-104
2010-11-24 18:23:01 +01:00
Matthias Dieter Wallnöfer
8c01d6a837
s4:objectclass LDB module - move one checks into the "objectclass derivation loop"
...
This denies objects created from possible derivated classes from the prohibited
ones.
Also small cosmetic improvements for another check.
2010-11-24 17:39:18 +01:00
Matthias Dieter Wallnöfer
0a6834e630
s4:objectclass LDB module - some more or less cosmetic return value macro changes
...
Sometimes "ldb_module_oom" fits better than "ldb_operr" or "ldb_oom".
2010-11-24 17:39:18 +01:00
Nadezhda Ivanova
dab4e008a0
s4-tests: Modified sec_descriptor to use samdb.newgroup instead of locally defined method.
...
Autobuild-User: Nadezhda Ivanova <nivanova@samba.org>
Autobuild-Date: Wed Nov 24 17:38:28 CET 2010 on sn-devel-104
2010-11-24 17:38:28 +01:00
Andrew Tridgell
5d014cad08
s4-kcc: disable the NDR printing of DRS getinfo requests
2010-11-24 00:19:15 +01:00
Nadezhda Ivanova
91b687d42b
s4-tests: Modified acl.py to use samdb.newgroup instead of custom methods.
...
Autobuild-User: Nadezhda Ivanova <nivanova@samba.org>
Autobuild-Date: Tue Nov 23 21:46:07 CET 2010 on sn-devel-104
2010-11-23 21:46:07 +01:00
Nadezhda Ivanova
ff822209c1
s4-tests: Modified sec_descriptor.py to use samdb.newuser instead of custom methods.
...
Autobuild-User: Nadezhda Ivanova <nivanova@samba.org>
Autobuild-Date: Tue Nov 23 17:58:38 CET 2010 on sn-devel-104
2010-11-23 17:58:38 +01:00
Nadezhda Ivanova
860ad87340
s4-tests: Modified acl.py to use samdb.newuser instead of custom methods.
2010-11-23 17:15:16 +01:00
Nadezhda Ivanova
5d27aee107
s4-tests: Modified sec_descriptor.py to use SamDB.create_ou()
...
Autobuild-User: Nadezhda Ivanova <nivanova@samba.org>
Autobuild-Date: Tue Nov 23 14:19:34 CET 2010 on sn-devel-104
2010-11-23 14:19:33 +01:00
Nadezhda Ivanova
868dd26efd
s4-tests: Modified acl.py to use SamDB.create_ou()
2010-11-23 14:33:27 +02:00
Nadezhda Ivanova
439ff8717d
s4-tests: Ldap tests now use the get_dsheuristics and set_dsheuristics from SamDB.
...
Autobuild-User: Nadezhda Ivanova <nivanova@samba.org>
Autobuild-Date: Tue Nov 23 11:08:37 CET 2010 on sn-devel-104
2010-11-23 11:08:36 +01:00
Nadezhda Ivanova
c252dac1b3
s4-tests: Password tests now use the get_dsheuristics and set_dsheuristics from SamDB.
2010-11-23 11:22:26 +02:00
Nadezhda Ivanova
d6679cb75a
s4-tests: Acl tests now use the get_dsheuristics and set_dsheuristics from SamDB.
2010-11-23 11:22:26 +02:00
Nadezhda Ivanova
2c993f0d4e
s4-tests: Adapted passwords.py to use set_minPwdAge from SamDB.
...
Autobuild-User: Nadezhda Ivanova <nivanova@samba.org>
Autobuild-Date: Mon Nov 22 18:39:06 CET 2010 on sn-devel-104
2010-11-22 18:39:06 +01:00
Nadezhda Ivanova
2c96be185d
s4-tests: Adapted acl.py to use set_minPwdAge from SamDB.
2010-11-22 18:52:04 +02:00