sin/samba-mirror
1
0
Fork 0
mirror of https://github.com/samba-team/samba.git synced 2025-03-12 20:58:37 +03:00
Code
49,191 Commits 62 Branches 1,155 Tags
Commit Graph

4269 Commits

Author SHA1 Message Date
Volker Lendecke
87d4138d09 Converting notify.c to store a request, not an inbuf 2008-11-08 10:42:20 +01:00
Jeremy Allison
8962be69c7 Make us clean under valgrind --leak-check=full by using talloc_autofree_context() instead of NULL. 
Remove the code in memcache that does a TALLOC_FREE on stored pointers. That's a disaster waiting
to happen. If you're storing talloc'ed pointers, you can't know their lifecycle and they should
be deleted when their parent context is deleted, so freeing them at some arbitrary point later
will be a double-free.
Jeremy.
 2008-11-06 20:48:13 -08:00
Herb Lewis
7ae6253455 Convert to use VFS layer. 2008-11-06 20:40:20 -08:00
Jeremy Allison
8b4b5c3a92 Add wrapper str_list_make_v3() to replace the old S3 behavior of 
str_list_make(). From Dan Sledz <dan.sledz@isilon.com>:
In samba 3.2 passing NULL or an empty string returned NULL.
In master, it now returns a list of length 1 with the first string set
to NULL (an empty list).
Jeremy.
 2008-11-06 18:53:00 -08:00
Jeremy Allison
7522ef15ac Final fix to make us pass NULL SD test in RAW-ACLs. Not sure if this is 100% right. Only inheritance left to fix. 
Jeremy.
 2008-11-06 01:45:40 -08:00
Jeremy Allison
24c598b1b9 Don't call FSET_NT_ACL on file create if there's no SD to set. Leave the default ACL in place. 
Jeremy.
 2008-11-06 01:40:21 -08:00
Jeremy Allison
d93041e336 Add reference to bug #4308 to remind me to add regression test to smbtorture. 
Jeremy.
 2008-11-05 19:11:40 -08:00
Volker Lendecke
b9211deba8 Fix the build 2008-11-05 10:48:43 +01:00
Volker Lendecke
95d1825a51 Fix a const warning 2008-11-04 21:53:14 +01:00
Volker Lendecke
6b4d48c4bf Convert blocking.c to store a smb_request instead of just inbuf 2008-11-04 20:52:07 +01:00
Volker Lendecke
d5f91d7a08 Simplify logic of cancel_pending_lock_requests_by_fid() 
The only caller of this function is locking_close_file(). This checks itself if
brl_lock != NULL. The additional check is not necessary here.
 2008-11-04 20:52:07 +01:00
Volker Lendecke
3376e7a6a0 Slightly simplify logic in process_lockingX() 
The "else" is pointless here, we did a "return True" in the if branch.
 2008-11-04 20:52:07 +01:00
Volker Lendecke
59e237cae5 Slightly simplify logic in remove_pending_lock_requests_by_mid() 
Use "continue" for (SVAL(blr->inbuf,smb_mid) != mid)
 2008-11-04 20:52:07 +01:00
Volker Lendecke
eddb43c713 Slightly simplify logic in cancel_pending_lock_requests_by_fid() 
Use a "continue" for (blr->fsp->fnum != fsp->fnum)
 2008-11-04 20:52:07 +01:00
Volker Lendecke
f0ba601c26 Convert blocking.c to use talloc 2008-11-04 20:52:06 +01:00
Volker Lendecke
8987641db8 Rewrite aio.c to keep the whole smb_request structure, not just the inbuf 2008-11-04 20:52:06 +01:00
Volker Lendecke
b8125663d9 Make "inbuf" a talloc child of "smb_request" for normal smb requests 
This is necessary if we want to keep the whole smb_request for deferred ops.
The explicit settings of req->inbuf will be removed once all those deferring
operations are converted to store the whole request and not just the inbuf.
 2008-11-04 20:52:06 +01:00
Volker Lendecke
e4897a5376 Add construct_reply_common_req wrapper 
The goal is to remove the remaining direct calls to construct_reply_common.
 2008-11-04 20:52:06 +01:00
Volker Lendecke
d62ff20cd5 Fix nonempty blank lines 2008-11-04 20:52:06 +01:00
Volker Lendecke
71bc6e93a1 Use talloc for struct aio_extra 2008-11-04 20:52:06 +01:00
Jeremy Allison
bfc59f63f3 Pass all of RAW-ACLS except for inheritence. Working on that next. 
Jeremy.
 2008-11-04 01:34:08 -08:00
Volker Lendecke
0953688012 Trigger (and fix) a bug in Samba3 making smbd an infinite data source 
A deferred open directly followed by a ulogoffX makes smbd3 send an infinite
stream of ERRinvuid replies :-(
 2008-11-04 09:41:15 +01:00
Jeremy Allison
6a37302b55 Pass the directory versions of the RAW-ACL (still not inheritance). Refactor some common code between open_file_ntcreate() and open_directory(). 
Jeremy.
 2008-11-03 23:18:43 -08:00
Jeremy Allison
4f8fac1b8e Pass all the non-inherited S4 RAW-ACL tests. 
Jeremy.
 2008-11-03 22:42:53 -08:00
Volker Lendecke
eb9656e757 Fix nonempty blank lines 2008-11-03 17:58:12 +01:00
Volker Lendecke
9a05c277ca Make a comment match its function definition 2008-11-03 17:58:07 +01:00
Volker Lendecke
7808a2594c Remove some inbuf references by adding "cmd" to smb_request 2008-11-02 23:17:01 +01:00
Volker Lendecke
792324bf5a Remove the inbuf reference from map_checkpath_error() 2008-11-02 22:38:03 +01:00
Volker Lendecke
e7607b95f2 Remove a direct inbuf reference in reply_negprot 2008-11-02 22:38:02 +01:00
Volker Lendecke
f3e638bc9f Make a [un]become_root wrap a bit tighter 
Sooner or later this would bite us.
 2008-11-02 21:53:44 +01:00
Volker Lendecke
c2a280ac63 Pass smb_request to send_trans_reply to match with send_[nt]trans[2]_reply 2008-11-02 21:20:41 +01:00
Volker Lendecke
77f52d903f Use "vwv" in trans parsing 2008-11-02 17:46:08 +01:00
Volker Lendecke
2bab73a18d Remove a bunch of direct inbuf references by adding "vwv" to smb_request 2008-11-02 16:58:19 +01:00
Volker Lendecke
f120038a1f Fix bug 5860: safe_strcpy gives a nasty error message for overlong strings 
Thanks to Robert Dahlem <Robert.Dahlem@gmx.net> for reporting this!
 2008-11-02 10:41:09 +01:00
Volker Lendecke
e48364af2f Rename "inbuf" to "base_ptr" in srvstr_get_path_* 2008-11-02 09:22:40 +01:00
Volker Lendecke
af7cf4f992 Remove some direct inbuf references by adding smbreq_bufrem 2008-11-02 09:22:40 +01:00
Volker Lendecke
a31fab8156 Simplify params of srvstr_pull_buf_talloc() 
Now that "req" is available everywhere, use it. Rename srvstr_pull_buf_talloc()
to srvstr_pull_req()
 2008-11-02 09:22:40 +01:00
Volker Lendecke
2bd5ac86ff Add srvstr_get_path_req[_wcard] 2008-11-02 09:22:40 +01:00
Volker Lendecke
fa47f03356 Kill some fstrings 2008-11-01 23:21:54 +01:00
Volker Lendecke
7bdb571ec4 Remove a bunch of direct inbuf references by adding "buf" to smb_request 2008-11-01 19:41:08 +01:00
Volker Lendecke
ac97d7d4b0 In reply_copy, don't write to inbuf when splitting directory and mask 2008-11-01 19:41:07 +01:00
Volker Lendecke
cc546c0191 In reply_search(), don't write to inbuf when splitting directory and mask 2008-11-01 19:41:07 +01:00
Volker Lendecke
ab0561f3c3 Apply some const to get_lock_*() 2008-11-01 19:41:07 +01:00
Volker Lendecke
7f9d6f80ef Add a "buflen" struct member to smb_request 
This removes some explicit inbuf references and also removes a pointless check
in reply_echo. The buflen can never be more than 64k, this is just a 16 bit
value.
 2008-11-01 19:41:07 +01:00
Volker Lendecke
7a0ed93169 Remove unused extern declaration 2008-11-01 19:41:07 +01:00
Jelmer Vernooij
31fa08dcbd Merge branch 'master' of /home/jelmer/samba3 
Conflicts:
	lib/replace/README
	lib/replace/libreplace.m4
	lib/replace/replace.c
	source3/include/proto.h
	source3/lib/system.c
 2008-11-01 04:02:47 +01:00
Jelmer Vernooij
5a56c0adf2 Use dup2() replacement from libreplace. 2008-11-01 03:58:14 +01:00
Jelmer Vernooij
6a2caa34b2 Remove sys_chroot() - libreplace already provides an alternative. 2008-11-01 03:46:09 +01:00
Jeremy Allison
54eaf2de74 Get closer to passing S4 RAW-ACLs. 
Jeremy.
 2008-10-31 18:04:53 -07:00
Volker Lendecke
ff274e57ea Remove a pointles call to smb_bufrem 
This call expanded to

(smb_buflen(req->inbuf)
  - PTR_DIFF(smb_buf(req->inbuf) - smb_buf(req->inbuf)))

which seems pretty pointless :-)
 2008-10-31 22:06:22 +01:00