1
0
mirror of https://github.com/samba-team/samba.git synced 2025-11-12 04:23:49 +03:00
Commit Graph

21 Commits

Author SHA1 Message Date
Jelmer Vernooij
61ad78ac98 r26638: libndr: Require explicitly specifying iconv_convenience for ndr_struct_push_blob(). 2008-01-01 16:12:11 -06:00
Jelmer Vernooij
6ac86f8be7 r26540: Revert my previous commit after concerns raised by Andrew. 2007-12-21 05:52:06 +01:00
Jelmer Vernooij
e53e79eebe r26539: Remove unnecessary statics. 2007-12-21 05:52:05 +01:00
Andrew Bartlett
47422b5e59 r26297: Correct error message. This function verifies attributes, not
objectclasses.

Andrew Bartlett
2007-12-21 05:48:14 +01:00
Andrew Bartlett
9ac7f4f609 r26282: These modules expect errors, but if we don't wipe the error string, we
get phony error strings at the caller, which is very confusing.

Andrew Bartlett
2007-12-21 05:48:07 +01:00
Andrew Bartlett
d3894c90f3 r25942: Make various ldb modules handle an LDB backend that enforces validity
of Base DNs in searches (returning an error of LDB_ERR_NO_SUCH_ENTRY).

We need to handle this if ldb_tdb is to behave correctly compared with
LDAP, as well as if we are using an LDAP backend.

In doing so, I realised that subtree_rename and subtree_delete
(prevention) need rather different wait loops, so it seemed easier to
split it out into it's own module.

I've fixed the licence on both of these modules to be GPLv3.

Andrew Bartlett
2007-12-21 05:45:11 +01:00
Stefan Metzmacher
6223c7fddc r25920: ndr: change NTSTAUS into enum ndr_err_code (samba4 callers)
lib/messaging/
lib/registry/
lib/ldb-samba/
librpc/rpc/
auth/auth_winbind.c
auth/gensec/
auth/kerberos/
dsdb/repl/
dsdb/samdb/
dsdb/schema/
torture/
cluster/ctdb/
kdc/
ntvfs/ipc/
torture/rap/
ntvfs/
utils/getntacl.c
ntptr/
smb_server/
libcli/wrepl/
wrepl_server/
libcli/cldap/
libcli/dgram/
libcli/ldap/
libcli/raw/
libcli/nbt/
libnet/
winbind/
rpc_server/

metze
2007-12-21 05:45:02 +01:00
Andrew Bartlett
16a292fcb1 r25762: This test belongs best with the other checks for a valid parent, in
the objectclass module.

Andrew Bartlett
2007-12-21 05:43:47 +01:00
Andrew Bartlett
2a835d900f r25755: Fix a couple of memory leaks, in particular a new leak onto the NULL
context caused by my objectclass module work.

Andrew Bartlett
2007-12-21 05:43:46 +01:00
Andrew Bartlett
bfc96fff06 r25754: More work on normal forms for ldb input.
This patch is to ensure that all attributes are in the same case as
the schema specifies.  In the process, I ensure that all attributes
are indeed in the schema.

This ensures we use the schema case, not the user supplied case for
future responses, which assists any (incorrect, but possible) case
sensitive processing on a client.

I've also removed more of the subtle 'schema &&' that metze objected
to in the for loops, moving to a much more explicit 'if (schema)'.

Andrew Bartlett
2007-12-21 05:43:45 +01:00
Andrew Bartlett
c0a0c69ac5 r25750: Update the objectclass module to improve consistency in Samba4.
The aim here is to ensure that if we have

CN=Users,DC=samba,DC=example,DC=com

that we cannot have a DN of the form

cn=admin ,cn=useRS,DC=samba,DC=example,DC=com

This module pulls apart the DN, fixes up the relative DN part, and
searches for the parent to copy the base from.

I've used the objectclass module, as I intend to also validate the
placement of child objects, by reading the allowedChildClasses virtual
attribute.

In the future, I'll also force the attribute names to be consistant
(using the case from the schema).

Andrew Bartlett
2007-12-21 05:43:43 +01:00
Andrew Bartlett
3434262ad7 r25705: Ensure we return the out value to the caller.
Andrew Bartlett
2007-12-21 05:43:22 +01:00
Andrew Bartlett
f350ef5f19 r25704: Handle the chicken-and-egg problem of setting up the LDB before we get
a schema.  perhaps i need to look into metze's 'load a schema from
ldif' code.

Andrew Bartlett
2007-12-21 05:43:22 +01:00
Andrew Bartlett
ecea817a3e r25702: Clarify comments and make this module more strict on objectclasses.
This is becoming the schema module...

Andrew Bartlett
2007-12-21 05:43:21 +01:00
Andrew Bartlett
d17a0058ba r24914: In response to bug #4892 by Matthias Wallnöfer <mwallnoefer@yahoo.de>,
allow the objectclass module to reconstruct the objectclass hierarchy,
rather than using templates.

The issue being fixed in particular is that 'top' was not being set on
containers.

This should ensure we do this right for all objects.

Andrew Bartlett
2007-10-10 15:03:37 -05:00
Andrew Bartlett
62320616ff r24731: Remove unused code - if we hit these error conditions, then we are
dead anyway, and a segfault would leave us with more infomation.

Andrew Bartlett
2007-10-10 15:03:00 -05:00
Andrew Bartlett
b474be9507 r24459: Fix up ldap.js and test_ldb.sh to test the domain_scope control, and
to test the behaviour of objectCategory=user searches.

It turns out (thanks to a hint on
http://blog.joeware.net/2005/12/08/147/) that objectCategory=user maps
into objectCategory=CN=Person,... (by the defaultObjectCategory of
that objectclass).

Simplify the entryUUID module by using the fact that we now set the DN
as the canoncical form of objectCategory.

Andrew Bartlett
2007-10-10 15:01:53 -05:00
Andrew Bartlett
43d62181f2 r24277: Tidyup as requested by metze.
Andrew Bartlett
2007-10-10 15:01:35 -05:00
Andrew Bartlett
72f4ae8246 r24263: Fix bug 4846 (unable to copy users in MMC Active Directory Users and
Computers).

We now generate a security descriptor for each object, when it is
created.  This seems to keep MMC happy.  The next step is to honour
it.

Andrew Bartlett
2007-10-10 15:01:32 -05:00
Andrew Bartlett
53c248c264 r24262: Set the objectCategory by default in the objectclass module, rather than using templates.
Modify the samba3sam test to be less fussy, and not use the
objectclass module (which requires proper schema stuff now).

Andrew Bartlett
2007-10-10 15:01:32 -05:00
Andrew Bartlett
0f7135a468 r24259: Rework the objectclass module to use the new schema, rather than the
ldb_subclass list.

Next step will be to have this module also set the objectCategory and
default ntSecurityDescriptor

Andrew Bartlett
2007-10-10 15:01:31 -05:00