Simo Sorce
8cd3912afa
s3-dcerpc: Convert frag from prs_struct to a simple DATA_BLOB
...
Signed-off-by: Günther Deschner <gd@samba.org>
2010-07-16 01:51:16 +02:00
Simo Sorce
31b59bbf99
s3-dcerpc: Convert rdata from prs_struct to a simple DATA_BLOB
...
Signed-off-by: Günther Deschner <gd@samba.org>
2010-07-16 01:51:16 +02:00
Simo Sorce
8ffac961db
s3-dcerpc: Stop using hand marshalling in create_next_pdu_noauth()
...
Signed-off-by: Günther Deschner <gd@samba.org>
2010-07-16 01:51:16 +02:00
Simo Sorce
a678d4e3b4
s3-dcerpc: Stop using hand marshalling in create_next_pdu_schannel()
...
Signed-off-by: Günther Deschner <gd@samba.org>
2010-07-16 01:51:16 +02:00
Simo Sorce
5918a6c751
s3-dcerpc: Stop using hand marshalling in create_next_pdu_ntlmssp()
...
Signed-off-by: Günther Deschner <gd@samba.org>
2010-07-16 01:51:16 +02:00
Simo Sorce
23ad6919a1
s3-dcerpc: Break memory hierarchy for shared structure
...
Handles are shared among multiple pipes_struct. We cannot allocate
them on any specific pipes_struct or it will vanish for all others
as soon as that pipes_struct is freed, leaving back dangling
pointers.
Signed-off-by: Andreas Schneider <asn@samba.org>
2010-07-14 15:03:02 +02:00
Günther Deschner
e30aa45666
s3-dcerpc: fix crash bug in error path of process_complete_pdu().
...
Guenther
2010-07-14 12:36:47 +02:00
Andrew Bartlett
0d95cee58f
s3:auth Change auth_ntlmssp_server_info API to return NTSTATUS
...
This fixes a bug where register_existing_vuid() could be called with a
NULL server_info if the alloction failed.
Andrew Bartlett
Signed-off-by: Andrew Tridgell <tridge@samba.org>
2010-07-14 16:22:49 +10:00
Günther Deschner
80b47fcb0a
s3-libnet: better separate headers.
...
Guenther
2010-07-13 22:40:46 +02:00
Simo Sorce
bc6a3e0030
s3-dcerpc: Use dcerpc_push_ncacn_packet() in api_pipe_alter_context()
...
Signed-off-by: Günther Deschner <gd@samba.org>
2010-07-13 14:44:12 +02:00
Simo Sorce
3ba93a986f
s3-dcerpc: Use dcerpc_push_dcerpc_auth() for spnego auth continuations.
...
Signed-off-by: Günther Deschner <gd@samba.org>
2010-07-13 14:44:12 +02:00
Simo Sorce
70500734f9
s3-dceprc: Use dcerpc_push_ncacn_packet() in api_pipe_bind_req()
...
Signed-off-by: Günther Deschner <gd@samba.org>
2010-07-13 14:44:12 +02:00
Simo Sorce
f6648c500b
s3-dcerpc: Use a DATA_BLOB in bind processing and avoid one mem copy
...
Also move dcerpc_push_dcerpc_auth() invocation in api_pipe_bind_req()
to simplify the workflow.
Signed-off-by: Günther Deschner <gd@samba.org>
2010-07-13 14:44:11 +02:00
Simo Sorce
8213bba892
s3-dcerpc: Rearrange api_pipe_bind_req() to do checks before allocating memory
...
Signed-off-by: Günther Deschner <gd@samba.org>
2010-07-13 14:44:11 +02:00
Simo Sorce
87605e2030
s3-dcerpc: fix dcerpc_push_ncacn_packet, pass arg by address
...
There is no need to copy the whole structure twice by passing it in by value.
Signed-off-by: Günther Deschner <gd@samba.org>
2010-07-13 14:44:11 +02:00
Simo Sorce
fe9036cf5b
s3-dcerpc: pass the packet to setup_bind_nack()
...
Allows to not rely on p->call_id but use the value directly from the request
packet header.
Signed-off-by: Günther Deschner <gd@samba.org>
2010-07-13 14:44:11 +02:00
Simo Sorce
272704e8c2
s3-dceprc: Add debug messages
...
Signed-off-by: Günther Deschner <gd@samba.org>
2010-07-13 14:44:11 +02:00
Simo Sorce
29a3142be8
s3-dcerpc: Remove unused functions
...
Signed-off-by: Günther Deschner <gd@samba.org>
2010-07-13 14:44:11 +02:00
Simo Sorce
8e235df2de
s3-dcerpc: Use dcerpc_pull_ncacn_packet() to unmarshall dceprc requests
...
Signed-off-by: Günther Deschner <gd@samba.org>
2010-07-13 14:44:11 +02:00
Simo Sorce
77fb3649ce
s3-dceprc: Store opnum in its own variable
...
Signed-off-by: Günther Deschner <gd@samba.org>
2010-07-13 14:44:10 +02:00
Simo Sorce
a138b3d31e
s3-dceprc use a DATA_BLOB to hold the curren pdu in pipes_struct
...
Signed-off-by: Günther Deschner <gd@samba.org>
2010-07-13 14:44:10 +02:00
Simo Sorce
d078b54b22
s3-dcerpc: use dceprc_push_ncacn_packet_header in create_next_pdu_noauth()
...
Signed-off-by: Günther Deschner <gd@samba.org>
2010-07-13 14:44:10 +02:00
Simo Sorce
53e9c26271
s3-dcerpc: Use dcerpc_push_ncacn_packet_header() in create_next_pdu_schannel()
...
Signed-off-by: Günther Deschner <gd@samba.org>
2010-07-13 14:44:10 +02:00
Simo Sorce
98913d8f44
s3-dcerpc: use dcerpc_push_ncacn_packet_header() in create_next_pdu_ntlmssp()
...
Signed-off-by: Günther Deschner <gd@samba.org>
2010-07-13 14:44:10 +02:00
Simo Sorce
aca330a2c5
s3-dcerpc delay rpc header unmarshalling
...
Use dcerpc_get_frag_length() to get the whole pdu first
Signed-off-by: Günther Deschner <gd@samba.org>
2010-07-13 14:44:10 +02:00
Simo Sorce
cf664b73a4
s3-dcerpc: Use dcerpc_set_frag_length()
...
Automatically calculate the fragment length where possible.
Signed-off-by: Günther Deschner <gd@samba.org>
2010-07-13 14:44:09 +02:00
Simo Sorce
966641b9fe
s3-dcerpc: Use dcerpc_pull_dcerpc_auth in api_pipe_bind_auth3()
2010-07-08 18:39:12 -04:00
Simo Sorce
207600991c
s3-dcerpc: Use dcerpc_auth in api_pipe_bind_req()
2010-07-08 18:39:01 -04:00
Günther Deschner
690ed0c5e2
s3-rpc: when using rpc_pipe_open_internal, make sure to go through NDR.
...
Otherwise a lot of information that is usually generated in the ndr_push remains
in an uninitialized state.
Guenther
2010-07-08 16:35:26 +02:00
Simo Sorce
7236f8cda9
s3:dcerpc Use prs_parse_dcerpc_bind
2010-07-08 01:41:29 -04:00
Simo Sorce
ae526514a9
s3:rpc user idl define dcerpc_ctx_list instead of custom RPC_CONTEXT
2010-07-08 01:08:05 -04:00
Günther Deschner
0cbe0f3c5f
s3-dcerpc: use dcerpc_push_ncacn_packet() for setup_fault_pdu().
...
Guenther
Signed-off-by: Simo Sorce <idra@samba.org>
2010-07-07 23:45:50 -04:00
Günther Deschner
8fdc02aa63
s3-dcerpc: use dcerpc_push_ncacn_packet() for setup_bind_nak().
...
Guenther
Signed-off-by: Simo Sorce <idra@samba.org>
2010-07-07 23:45:50 -04:00
Volker Lendecke
b4c3f72d44
s3: Fix a segfault in the RPC server
...
After converting the rpc infratructure to talloc, read_from_internal_pipe freed
the outdata too early. If the last fragment was read in two pieces (as
rpcclient does it), all the outdata was freed during the read of the first
piece of the read of the last fragment. Later read&x calls, trying to read the
rest of the last fragment stepped into p->out_data.frag with non-zero offset
when this was already freed.
2010-07-06 15:11:31 +02:00
Matthias Dieter Wallnöfer
915ddf0dc7
samr.idl:UserInfo structures - fix some names according to MS-SAMR documentation
...
See MS-SAMR section "FULL IDL"
2010-07-05 15:35:54 +02:00
Volker Lendecke
dfc84ece9d
s3: Remove procid_self() from srv_spoolss_reply[open|close]printer()
2010-07-05 11:06:32 +02:00
Volker Lendecke
6436ea3e7a
s3: Remove procid_self() from srv_spoolss_drv_upgrade_printer()
2010-07-05 11:06:31 +02:00
Volker Lendecke
b0c83d50f9
s3: Replace register_message_flags() with serverid_register_msg_flags()
...
message_send_all is now done by walking the serverid.tdb, not the
connections.tdb anymore.
Günther, Simo, please check!
2010-07-04 21:49:03 +02:00
Günther Deschner
786198e523
s3-registry: remove unused reg_util_marshalling code.
...
Guenther
2010-07-02 10:50:21 +02:00
Günther Deschner
b381fba089
s3-registry: avoid using registry_value union.
...
Just pull and push data as is.
Guenther
2010-07-02 10:50:21 +02:00
Simo Sorce
3721161d90
s3:auth Fix switch statement referencing a uninitialized variable
...
Looking at the original commit (9a747d500f
)
this seem the right solution.
Andrew please check.
2010-07-01 18:18:41 -04:00
Günther Deschner
e4ba8fb3b9
s3-printing: Fix Bug #7541 , %D in "printer admin" causing smbd crash.
...
Guenther
2010-07-01 14:13:16 +02:00
Günther Deschner
2a4bd64973
s3-winreg: implement _winreg_QueryMultipleValues().
...
Guenther
2010-06-30 21:46:08 +02:00
Günther Deschner
de0d9e0bff
s3-winreg: implement _winreg_QueryMultipleValues2().
...
Guenther
2010-06-30 21:46:08 +02:00
Andreas Schneider
f8b6ac6a08
s3-eventlog: Fixed the keyname delimiter for the registry key.
2010-06-28 12:56:13 +02:00
Günther Deschner
b6100fa72f
s3-eventlog: make sure _eventlog_OpenEventLogW fails when we cannot open the registry key.
...
Guenther
2010-06-28 12:53:10 +02:00
Jeremy Allison
2e8c563961
Second part of fix converting prs_XX struct and functions to talloc. Remove unneeded prs_mem_free calls.
...
Jeremy.
Signed-off-by: Simo Sorce <idra@samba.org>
2010-06-18 07:42:05 -04:00
Jeremy Allison
f4e7d9d38e
Convert the prs_XXX struct and functions to use talloc instead of malloc. Passes valgrind and make tests for client and server. Second version of this patch after splitting up at Simo's request. Patch to follow will delete extraneous prs_mem_free() calls.
...
Jeremy.
Signed-off-by: Simo Sorce <idra@samba.org>
2010-06-18 07:41:47 -04:00
Jeremy Allison
7e388c8b27
Remove an unused chunk of code (will make it easier to talloc'ize prs_XXX).
...
Jeremy.
2010-06-16 10:27:54 -07:00
Andreas Schneider
47ae4a518c
s3-spoolss: Provide a memory context for clean_up_driver_struct().
...
If we use a stack variable to setup spoolss_AddDriverInfoCtr this would
segfault with a talloc bad magic value.
2010-06-16 12:03:46 +02:00