1
0
mirror of https://github.com/samba-team/samba.git synced 2025-01-14 19:24:43 +03:00

414 Commits

Author SHA1 Message Date
Michael Adam
80b6d7b1d6 registry: change reghook_cache_add() to return WERROR instead of bool
Michael
(This used to be commit e65a999989c97c4c7b0af5093e0e89583691e9a8)
2008-04-13 15:33:48 +02:00
Michael Adam
5166d562ea registry cachehook: change helper function keyname_to_path() to return WERROR.
Michael
(This used to be commit 78bb005ee45e7a0be24b5222c3f878058b5cd8ea)
2008-04-13 15:33:47 +02:00
Michael Adam
01f4bd4f4d adt_tree: change pathtree_add to return WERR instead of bool.
Michael
(This used to be commit da45fb92f69221758f36db4cbb7d871e3ce60718)
2008-04-13 15:33:47 +02:00
Michael Adam
84c5da2ff4 registry cachehook: revert logic to make fast path more obvious and reduce indent.
Michael
(This used to be commit e97d558c5660e6d235b62528f5527a62ac1252d7)
2008-04-13 15:33:47 +02:00
Michael Adam
4b4306eb4a registry: change reghook_cache_init() to return WERROR and use it in the callers.
Michael
(This used to be commit 2f4ca62dce50225d67ba8643afba4199e1845c5f)
2008-04-13 15:33:47 +02:00
Michael Adam
2ffe46e24d registry cachehook: compare cache_tree against NULL, not 0.
Michael
(This used to be commit 4bfc0be55f2a436a9c687ab6ad86e704fcb753d6)
2008-04-13 15:33:47 +02:00
Michael Adam
26a5652f6d registry: change init_registry_key() and init_registry_data() to return WERR
Michael
(This used to be commit e0718f04a7392695eed6cd1bf888d3af1d5d6177)
2008-04-13 15:33:47 +02:00
Michael Adam
cb624c4057 registry: unify debug output in the registry init functions.
Michael
(This used to be commit 4fd9b45ffc08e7deeae58be3129832148748af13)
2008-04-13 15:33:47 +02:00
Michael Adam
6b85938f27 registry: change regdb_init() to return WERROR instead of bool.
Michael
(This used to be commit c312852abce72bc167abee8b29fc699c4a643ca7)
2008-04-13 15:33:47 +02:00
Michael Adam
bcb19766d6 registry: make registry_init_smbconf() hook the registry ops onto given key.
This still defaults to HKLM\Software\Samba\smbconf, but is interchangeable now.
This allows us to open the libsmbconf registry backend on different registry keys.

Michael
(This used to be commit 8fe1a2f567afbecbe487f08825cb43b038065e99)
2008-04-13 15:33:47 +02:00
Michael Adam
b5a75ec402 registry cachehook: add talloc failed debug messages.
Michael
(This used to be commit 9841ee7fd429c7ff367dbb43b754cd5b6f53c065)
2008-04-13 01:47:16 +02:00
Michael Adam
a721f0a729 registry cachehook: eliminate a couple trailing spaces (empty lines).
Michael
(This used to be commit c9f01aee37165216fa8a5331c64dd93963b38802)
2008-04-13 01:44:57 +02:00
Michael Adam
0fa8845fa0 registry cachehook: fix memleak (to talloc_tos()): free key at the end.
Michael
(This used to be commit 3f5955d361da5278773b46dccb34c8f63eb04157)
2008-04-13 01:43:43 +02:00
Michael Adam
227904434a registry cachehook: refactor normalization of keyname out.
Michael
(This used to be commit acb9c98dff7dac5e0688a04dbf6d63a7a7f67fd2)
2008-04-13 01:43:42 +02:00
Michael Adam
bbca983507 registry: adapt copied function header comments.
Michael
(This used to be commit 2e762be0db7a098b6da09756a9c9dfa3931ca3c6)
2008-04-13 01:43:42 +02:00
Michael Adam
413c2e9b0a registry: remove the REGISTRY_HOOKS layer from the reghook cache.
There is no need to save the keyname again, we only need to
get the REGISTRY_OPS out of the pathtree.

Furthermore, this makes life easier, since we can now pass
in keynames as temporarily allocated strings.

Michael
(This used to be commit 2f9ee2f782c77ed99669af5ac2ba40cb0978f0da)
2008-04-13 01:43:42 +02:00
Michael Adam
c890aef164 registry: move normalize_dbkey() from lib/util_reg.c to registry/reg_util.c
This function is only used inside registry code.

Michael
(This used to be commit 48745e3fbd6b38f39678938b8c3f145769065e7b)
2008-04-12 02:41:20 +02:00
Michael Adam
2830626877 registry: remove parameter checks from smbconf backend: they are in libsmbconf.
Michael
(This used to be commit 118cf3813336122a060916848e37d2d5d25bff92)
2008-04-03 15:43:04 +02:00
Volker Lendecke
16198dc51e Convert dbwrap_trans_delete to NTSTATUS
Signed-off-by: Stefan Metzmacher <metze@samba.org>
(This used to be commit dead193f46c2b19955ab3e5ac5ba343694f4858a)
2008-04-01 14:04:22 +02:00
Volker Lendecke
fcdfff1cc8 Convert dbwrap_trans_store to NTSTATUS
Signed-off-by: Stefan Metzmacher <metze@samba.org>
(This used to be commit 5f4de856af1abe63b13059bbe1615cb5877770d0)
2008-04-01 14:04:22 +02:00
Stefan Metzmacher
b8dcade819 regdb: let regdb_fetch_keys() handle NULL and failure cases in the same way and return -1
metze
(This used to be commit 983fd58805a429792fc8eaa816e2dd908643414e)
2008-04-01 14:04:20 +02:00
Stefan Metzmacher
b55942a763 regdb: get the seqnum before the record, to not miss something
metze
(This used to be commit c214107bd9bbf9b17936757437ec211d7de3048e)
2008-04-01 14:04:20 +02:00
Stefan Metzmacher
2b21b02c6a regdb: use dbwrap->fetch() instead of fetch_locked() for readonly access"
This is the fixed version of commit 5c28c74aa06a82559f498373b3d6e9892d5c2cbe.

metze
(This used to be commit 924acd7f695d7514b1a4628468137cf632c8f1f0)
2008-04-01 14:04:20 +02:00
Michael Adam
0bf8ba9f26 registry: reg_deletevalue should return error, when the value does not exist.
Michael
(This used to be commit 04b48984bbf84c55bb41a74a11cbcc7358377fed)
2008-03-31 17:22:02 +02:00
Michael Adam
ce0bbc82fd Revert "regdb: use dbwrap->fetch() instead of fetch_locked() for readonly access"
This reverts commit 4e2be189e97f653b75bd88135a631ce0f42db267.

Metze, this broke the registry (reg_api layer), but I don't yet know
exactly how and why. By the way, the locks there had the purpose of
fetching the seqnum that really matches the data.

This needs some more thought / debugging. But I wanted to have
the tree in a working state again.

Michael
(This used to be commit 5c28c74aa06a82559f498373b3d6e9892d5c2cbe)
2008-03-30 03:05:34 +02:00
Michael Adam
f8fdc36fdb regdb: use == 0 (instead of != -1) as indicator for success of dbwrap_trans_[delete|store]()
Michael
(This used to be commit 7dcd0c1e539df9ff1768a9c878b6687b9e1bfeac)
2008-03-27 18:14:57 +01:00
Michael Adam
c86d10ae83 regdb: use != 0 instead of == -1 check for transaction_[commit|cancel]
Michael
(This used to be commit b6ceeaabae94b86fe79d6a60e497fb472ca23021)
2008-03-27 18:14:57 +01:00
Stefan Metzmacher
5439f5f710 regdb: use db_open_trans()
metze

Signed-off-by: Stefan Metzmacher <metze@samba.org>
(This used to be commit a77b5b91dd439b5965fef17f2b2ff98fefd77dbb)
2008-03-27 18:14:56 +01:00
Stefan Metzmacher
618f22409a regdb: use regdb->transaction_start(regdb) != 0 consistent
metze

Signed-off-by: Stefan Metzmacher <metze@samba.org>
(This used to be commit 093c3bced96c934419af69cc065a240368027dcf)
2008-03-27 18:14:56 +01:00
Stefan Metzmacher
2a95f3f874 regdb: use dbwrap->fetch() instead of fetch_locked() for readonly access
metze

Signed-off-by: Stefan Metzmacher <metze@samba.org>
(This used to be commit 4e2be189e97f653b75bd88135a631ce0f42db267)
2008-03-27 18:14:56 +01:00
Stefan Metzmacher
d9de61341c regdb: use dbwrap_trans_store_int32
metze

Signed-off-by: Stefan Metzmacher <metze@samba.org>
(This used to be commit 9620696083473e3a98b46dd90b3b4aa287580940)
2008-03-27 18:14:56 +01:00
Volker Lendecke
fac2d8546b Fix Coverity ID 471
(This used to be commit d3b6df67fea0da5ffa962837400ebe07b34a5384)
2008-03-23 18:28:24 +01:00
Volker Lendecke
2e2f1d57b1 Fix Coverity ID 477
(This used to be commit f17b1b0fc6340d21f1a2f43aa7eb2e87f851c51f)
2008-03-23 18:28:24 +01:00
Volker Lendecke
988cffe9ca Fix Coverity ID 478
(This used to be commit 5f77938dc4a280b654b8d08656f19a7d04cea8c7)
2008-03-23 18:28:23 +01:00
Michael Adam
178c430821 registry: add reg_init_basic() - init registry with only the db backend.
Michael
(This used to be commit 1831042bdcbfe569ae39177058dfe1d914416513)
2008-03-22 02:05:53 +01:00
Michael Adam
4825cef8bc registry: close registry in exit path in registry_init_smbconf().
Michael
(This used to be commit 5aa3141bff35a85dd97e9fd339e19b0fe3a73afc)
2008-03-22 01:54:18 +01:00
Michael Adam
b8a949b566 registry: some whitespace cleanup in init_registry().
Michael
(This used to be commit f33095e44ba22f4451a5deeffdd4f9ed3f99ed85)
2008-03-22 01:53:44 +01:00
Michael Adam
88d46f4ea4 registry: remove unneeded talloc stackframe variable.
Michael
(This used to be commit 81993db828bf11b13d7ee1f43483968dc6241bcc)
2008-03-22 01:52:03 +01:00
Michael Adam
e12ed5279a registry: close regdb in error path (and use it) in init_registry().
Michael
(This used to be commit 73b325fe7a9d7fd67ac9b99144a3776f5a1a9e15)
2008-03-22 01:49:21 +01:00
Michael Adam
9ec7af58c6 registry: fix registry_init_smbconf() to close the registry at the end.
Michael
(This used to be commit f4d87fdbf266a36fbb50dae863ee0784165c2fe1)
2008-03-21 23:50:49 +01:00
Volker Lendecke
1e696c2845 Fix Coverity ID 506
(This used to be commit c9add4d59a1615aabc565e323cb19cf7ef4b6b64)
2008-03-21 11:48:09 +01:00
Michael Adam
060f554adc registry: use available string constant in debug statement.
Michael
(This used to be commit 6bac03a2ec6351ab9db457d904b8925c828086e8)
2008-03-20 15:01:52 +01:00
Michael Adam
cef4e1bd9e registry: in regdb_init, not only complain about INFO/version, store it...
Michael
(This used to be commit 27d67365ad03f0a0cd86011758a122a97513b82e)
2008-03-20 15:01:52 +01:00
Michael Adam
4bac0e505f registry: reformat regdb_init() slightly, breaking long lines.
Michael
(This used to be commit 11da885f1e82e7a08fac2bc0ec1515694caa6340)
2008-03-20 15:01:52 +01:00
Michael Adam
13b894b01e registry: untangle assignment and if-statement in regdb_init().
Michael
(This used to be commit 504058df9706ee4e4c2e7fb1b1e41710bce2f87d)
2008-03-20 15:01:52 +01:00
Michael Adam
2f01e055cf registry: separate initialization of registry data from regdb_init().
Leave this to the users (currently registry_init_smbconf() and
init_registry()) to initialize as much of preliminary registry data
as needed.

Michael
(This used to be commit 59fdd30c789ccfd5cff356e459f1653b065b985c)
2008-03-20 15:01:52 +01:00
Michael Adam
8880111466 registry: add a transaction wrapper to init_registry_key_internal().
Michael
(This used to be commit 8b9cff84d5c39e6d7c315d87ac2fdf7fc0d4e4c4)
2008-03-20 15:01:52 +01:00
Michael Adam
1f3139df25 registry: refactor creation of subkeys out of init_registry_data().
Michael
(This used to be commit 55233f875ebe1d515c65d9322cda69eb52d4c7d5)
2008-03-20 15:01:51 +01:00
Günther Deschner
e8bd75ec73 Bind Group Policy processing closer to the samba registry.
Guenther
(This used to be commit e9c56250eb7a2dc4e69962c5b48875834941ccfc)
2008-03-18 21:31:24 +01:00
Marc VanHeyningen
e06aa46b9f Coverity fixes
(This used to be commit 3fc85d22590550f0539215d020e4411bf5b14363)
2008-03-17 20:52:25 +01:00