David Disseldorp
dbcd59f46b
s3-smb2_server: fix ioctl InputOffset checking
...
Currently the InputOffset is always check to point to the input data
buffer, regardless of whether input data is present.
Signed-off-by: Stefan Metzmacher <metze@samba.org>
2011-09-29 13:14:21 +02:00
David Disseldorp
18482957da
s3-smb2_server: SMB2_OP_IOCTL doesn't require at least 1 dyn byte
...
Signed-off-by: Stefan Metzmacher <metze@samba.org>
2011-09-29 13:14:21 +02:00
Stefan Metzmacher
ea00f0e452
s3:smb2_server: SMB2_OP_CANCEL requests don't have to be signed
...
metze
Autobuild-User: Stefan Metzmacher <metze@samba.org>
Autobuild-Date: Thu Sep 29 02:58:41 CEST 2011 on sn-devel-104
2011-09-29 02:58:41 +02:00
Volker Lendecke
b35d80aa38
s3: Remove the smbd_server_conn ref from create_junction
...
Autobuild-User: Volker Lendecke <vlendec@samba.org>
Autobuild-Date: Mon Sep 26 16:33:30 CEST 2011 on sn-devel-104
2011-09-26 16:33:29 +02:00
Volker Lendecke
d2958fd064
s3: Remove the smbd_server_conn ref from setup_dfs_referral
2011-09-26 14:59:12 +02:00
Volker Lendecke
fba833d055
s3: Remove the smbd_server_conn ref from get_referred_path
2011-09-26 14:59:12 +02:00
Volker Lendecke
cb2b5c521b
s3: Remove the smbd_server_conn ref from dfs_redirect
2011-09-26 14:59:12 +02:00
Volker Lendecke
425b93ef69
s3: Remove the smbd_server_conn ref from create_conn_struct
2011-09-26 14:59:12 +02:00
Volker Lendecke
649437af3d
s3: Remove the smbd_server_conn ref from parse_dfs_path
2011-09-26 14:59:12 +02:00
Stefan Metzmacher
5494856294
s3:smbd: disconnect the socket if we got an unexpected request
...
If we got a SMB2_OP_NEGPROT after the protocol is already negotiated
or if we got a non SMB2_OP_NEGPROT before the protocol was negotiated
we should close the connection (as windows does).
metze
Autobuild-User: Stefan Metzmacher <metze@samba.org>
Autobuild-Date: Fri Sep 23 12:30:50 CEST 2011 on sn-devel-104
2011-09-23 12:30:50 +02:00
Stefan Metzmacher
02d83d8fd4
s3:smbd: don't call smbd_terminate_connection in smb2_validate_message_id() (bug #8476 )
...
Only return false and the caller will terminate the connection.
metze
2011-09-23 11:00:04 +02:00
Jeremy Allison
f0f91d0117
Fix bug #8477 - Map to guest can return uninitialized blob of data.
...
Found by Codenomicon at SNIA SDC.
Autobuild-User: Jeremy Allison <jra@samba.org>
Autobuild-Date: Fri Sep 23 03:19:46 CEST 2011 on sn-devel-104
2011-09-23 03:19:46 +02:00
Stefan Metzmacher
1bb6e6758c
s3:smb2_server: fix a logic error, we should sign non guest sessions
...
metze
2011-09-22 22:30:22 +02:00
Jeremy Allison
d50fa9c21e
Fix bug #8476 - Samba asserts when SMB2 client breaks the crediting rules.
...
Just drop the connection, not SMB_ASSERT.
Autobuild-User: Jeremy Allison <jra@samba.org>
Autobuild-Date: Thu Sep 22 19:41:31 CEST 2011 on sn-devel-104
2011-09-22 19:41:31 +02:00
Jeremy Allison
893497ee16
Fix bug #8458 ] - IE9 on Windows 7 cannot download files to samba 3.5.11 share
...
Handle the SECINFO_LABEL flag in the same was as Win2k3.
2011-09-21 13:34:50 -07:00
Jeremy Allison
e68ebe600d
Fix bug #8473 - smb2_find uses a hard coded max reply size of 0x10000 instead of smb2_max_trans.
...
Use lp_smb2_max_trans() instead of 0x10000.
2011-09-21 11:30:06 -07:00
Michael Adam
39dcf4bf02
s3:smb2-server: session setup replies should always be signed (except for guest sessions)
...
not only if the session should be signed
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Autobuild-User: Stefan Metzmacher <metze@samba.org>
Autobuild-Date: Wed Sep 21 11:00:09 CEST 2011 on sn-devel-104
2011-09-21 11:00:09 +02:00
Volker Lendecke
80d643f7e3
s3: Trim a debug to 80 chars
...
Autobuild-User: Volker Lendecke <vlendec@samba.org>
Autobuild-Date: Sun Sep 18 01:15:02 CEST 2011 on sn-devel-104
2011-09-18 01:15:02 +02:00
Volker Lendecke
b5ff6d86e7
s3: Fix a cut&paste error
2011-09-17 23:44:16 +02:00
Stefan Metzmacher
f8c26c16b8
s3:smbd: SMB ReadX with size > 0xffff should only possible for samba clients.
...
Windows 2008 R2 (and others) ignore the high bits for the read size.
Unless we're using the unix extentions and the client
uses CIFS_UNIX_LARGE_READ_CAP, we should also ignore
the high bits.
But we still need to support old "smbclient" binaries
and have to check if the client is "Samba".
metze
Signed-off-by: Jeremy Allison <jra@samba.org>
2011-09-14 12:37:02 -07:00
Stefan Metzmacher
555c626af8
s3:smbd: remember the client unix capabilities on the connection
...
metze
Signed-off-by: Jeremy Allison <jra@samba.org>
2011-09-14 12:37:02 -07:00
Stefan Metzmacher
563fa741f6
s3:smb2_server: SMB2_OP_GETINFO doesn't require at least 1 dyn byte
...
metze
2011-09-14 15:53:36 +02:00
Stefan Metzmacher
abb24bf8e8
s3:smbd: make use of better SMB signing negotiation
...
metze
Autobuild-User: Stefan Metzmacher <metze@samba.org>
Autobuild-Date: Wed Sep 14 09:41:02 CEST 2011 on sn-devel-104
2011-09-14 09:41:02 +02:00
Stefan Metzmacher
0a6d0f8eda
s3:smb_signing: add support for easier negotiation of SMB signing
...
We don't make use of it yet, but it will follow.
metze
2011-09-14 08:09:15 +02:00
Stefan Metzmacher
f205e4cada
s3:smbd: echo FLAGS2_SMB_SECURITY_SIGNATURES* and the signature field in the reply
...
This matches what windows is doing.
metze
2011-09-14 08:09:15 +02:00
Volker Lendecke
6344482f00
s3: Remove a reference to smbd_server_conn
2011-09-13 11:00:13 +02:00
Volker Lendecke
3e8a8d08e3
s3: Remove a reference to smbd_server_conn
2011-09-13 11:00:13 +02:00
Volker Lendecke
d911bd5c69
s3: Remove a reference to smbd_server_conn
2011-09-13 11:00:13 +02:00
Volker Lendecke
d08885b0c4
s3: Remove a reference to smbd_server_conn
2011-09-13 11:00:12 +02:00
Volker Lendecke
2b32918117
s3: Remove a reference to smbd_server_conn
2011-09-13 11:00:12 +02:00
Volker Lendecke
f6fa51ddf7
s3: Fix some nonempty blank lines
2011-09-13 11:00:12 +02:00
Stefan Metzmacher
258ffddf1c
libcli/smb: s/FLAGS2_UNKNOWN_BIT4/FLAGS2_SMB_SECURITY_SIGNATURES_REQUIRED
...
metze
Autobuild-User: Stefan Metzmacher <metze@samba.org>
Autobuild-Date: Sat Sep 10 00:34:50 CEST 2011 on sn-devel-104
2011-09-10 00:34:50 +02:00
Jeremy Allison
e30b8c72de
Second part of fix for bug #8443 - Default user entry is set to minimal permissions on incoming ACL change with no user specified.
...
Be smarter about setting default permissions when a ACL_USER_OBJ isn't given. Use the principle of least surprises for the user.
Autobuild-User: Jeremy Allison <jra@samba.org>
Autobuild-Date: Fri Sep 9 00:26:08 CEST 2011 on sn-devel-104
2011-09-09 00:26:08 +02:00
Jeremy Allison
793bd527fd
First part of fix for bug #8443 - Default user entry is set to minimal permissions on incoming ACL change with no user specified.
...
create_default_mode() is not needed - it's taken care of by code
inside ensure_canon_entry_valid().
2011-09-08 13:54:04 -07:00
Jeremy Allison
de710cee37
Revert "Part 4 of bugfix for bug #7509 - smb_acl_to_posix: ACL is invalid for set (Invalid argument)"
...
This belongs as part of the bugfix for bug #8443 - Default user entry is set to minimal permissions on incoming ACL change with no user specified.
Not as part of #7509 .
This reverts commit 2a1453e231
.
Autobuild-User: Jeremy Allison <jra@samba.org>
Autobuild-Date: Thu Sep 8 08:50:12 CEST 2011 on sn-devel-104
2011-09-08 08:50:12 +02:00
Stefan Metzmacher
9bc4decc1c
s3:smb2_server: return OBJECT_NAME_INVALID if the path is terminated in SMB2_FIND/QUERY_DIRECTORY
...
metze
Autobuild-User: Stefan Metzmacher <metze@samba.org>
Autobuild-Date: Wed Sep 7 12:15:51 CEST 2011 on sn-devel-104
2011-09-07 12:15:51 +02:00
Stefan Metzmacher
1bc93c2605
s3:smb2_server: return OBJECT_NAME_INVALID if the path is terminated in SMB2_CREATE
...
metze
2011-09-07 10:38:08 +02:00
Stefan Metzmacher
68b33aa61a
s3:smb2_server: return BAD_NETWORK_NAME if the path is terminated in SMB2_TCON
...
metze
2011-09-07 10:38:08 +02:00
Stefan Metzmacher
1a726b88ec
s3:smb2_server: use smbd_smb2_request_verify_sizes() in smb2_write.c
...
metze
2011-09-07 10:38:08 +02:00
Stefan Metzmacher
3643a05ba6
s3:smb2_server: use smbd_smb2_request_verify_sizes() in smb2_setinfo.c
...
metze
2011-09-07 10:38:07 +02:00
Stefan Metzmacher
f3a8d65bdf
s3:smb2_server: use smbd_smb2_request_verify_sizes() in smb2_read.c
...
metze
2011-09-07 10:38:07 +02:00
Stefan Metzmacher
c6480366e5
s3:smb2_server: use smbd_smb2_request_verify_sizes() in smb2_notify.c
...
metze
2011-09-07 10:38:07 +02:00
Stefan Metzmacher
a358eee2d8
s3:smb2_server: use smbd_smb2_request_verify_sizes() in smb2_lock.c
...
metze
2011-09-07 10:38:06 +02:00
Stefan Metzmacher
22d479f757
s3:smb2_server: use smbd_smb2_request_verify_sizes() in smb2_keepalive.c
...
metze
2011-09-07 10:38:06 +02:00
Stefan Metzmacher
29b3601c02
s3:smb2_server: use smbd_smb2_request_verify_sizes() in smb2_ioctl.c
...
metze
2011-09-07 10:38:06 +02:00
Stefan Metzmacher
880eafd7e8
s3:smb2_server: use smbd_smb2_request_verify_sizes() in smb2_getinfo.c
...
metze
2011-09-07 10:38:05 +02:00
Stefan Metzmacher
440f702aa9
s3:smb2_server: use smbd_smb2_request_verify_sizes() in smb2_flush.c
...
metze
2011-09-07 10:38:05 +02:00
Stefan Metzmacher
bc95ab99dc
s3:smb2_server: use smbd_smb2_request_verify_sizes() in smb2_find.c
...
metze
2011-09-07 10:38:05 +02:00
Stefan Metzmacher
251815bfd3
s3:smb2_server: use smbd_smb2_request_verify_sizes() in smb2_create.c
...
metze
2011-09-07 10:38:04 +02:00
Stefan Metzmacher
e09b3940a7
s3:smb2_server: use smbd_smb2_request_verify_sizes() in smb2_close.c
...
metze
2011-09-07 10:38:04 +02:00