1
0
mirror of https://github.com/samba-team/samba.git synced 2025-01-15 23:24:37 +03:00

959 Commits

Author SHA1 Message Date
Andrew Tridgell
4b9eee02c4 r19402: - use the new tdb_lockall_read() to make ldb_search() more efficient,
by avoiding chain locks on each tdb_fetch() within the search

- use the tdb_get_seqnum() call to avoid re-reading the @BASEINFO
  record when it hasn't changed.

These speed up the LOCAL-DBSPEED test for ldb from 7k ops/sec to a bit
over 11k ops/sec
(This used to be commit 1347ad254eb8cd12ce22a5a2a37bec0a0ac8dbf1)
2007-10-10 14:21:26 -05:00
Simo Sorce
946225b683 r19375: very basic helper script to build ldb standalone
(This used to be commit b4c8bf7398cd8a9a2132dd4b04a0ea8004e7f1b0)
2007-10-10 14:21:19 -05:00
Simo Sorce
8c015370d2 r19370: Handle errors if talloc_reference fails
(This used to be commit 05134a90e3ff0e4039dbd34c52f824bc666feb11)
2007-10-10 14:21:18 -05:00
Andrew Tridgell
0cf42c464e r19365: fixed a memory leak in the ldb attribute handling
(This used to be commit d7e07685164141f8fb2c2a6258e1fcb46ff9d06c)
2007-10-10 14:21:17 -05:00
Andrew Tridgell
1865044d5c r19363: - don't need to store the baseinfo message after cache load
(This used to be commit 8c091bcdece5c17073838ad2367f3f4e22e97c31)
2007-10-10 14:21:17 -05:00
Andrew Tridgell
e36ea2e8eb r19362: - don't need to store the baseinfo message after cache load
- set better names on talloc structures in ldb modules, making leaks
  easier to track down
(This used to be commit 3bf76db42dc6dde5d71083216dba819869b31c75)
2007-10-10 14:21:17 -05:00
Andrew Tridgell
5535b43efd r19361: added a comment
(This used to be commit 1581babfb5a5bbbfc2706dbec9b37b03fe9a5af6)
2007-10-10 14:21:16 -05:00
Simo Sorce
0f2347e417 r19338: leak on error
(This used to be commit 326389afed0521133ac07339bd5e2bfbf8d80d0a)
2007-10-10 14:21:12 -05:00
Simo Sorce
549dd10f0f r19332: ldb_parse_tree leaks
(This used to be commit 3e0e2787c1da1c3831e21b163e1370001d725a3d)
2007-10-10 14:21:11 -05:00
Andrew Tridgell
64eed1e78e r19327: fixed a leak in ldif_canonicalise_objectCategory()
(This used to be commit 5cc92d915b7442d2eebc4b66ab89bbd15b96a493)
2007-10-10 14:21:10 -05:00
Andrew Tridgell
91c33d44b6 r19324: fixed a leak on deleting records when no index is in place
(This used to be commit 0824b3b8c1003064b0f2c5a3f084f3e711155e8c)
2007-10-10 14:21:09 -05:00
Andrew Tridgell
888458d434 r19323: fixed a leak in the ldif parse code
(This used to be commit 06387e1cf2d12a74e15a6cdf19e83a28c75cb5fd)
2007-10-10 14:21:08 -05:00
Andrew Tridgell
7f00bee3dc r19322: fix a minor memory leak in the ltdb cache code
(This used to be commit e03ed5822a690e2d151107f2edb9b4f1d3a1e1b9)
2007-10-10 14:21:08 -05:00
Simo Sorce
1b8e6fa6e9 r19314: Commit tridge's fixes for a big mem leak in ltdb I introduced
when the code has been changed to be async.
With the other committed fixes now this works.
(This used to be commit 49fc640b5c0398516ac3a9e3f7c55205cd60b1de)
2007-10-10 14:21:07 -05:00
Simo Sorce
508a04fe57 r19312: This should fix a nasty bug with values and names being freed before the results where used.
Seem that el is hanging out of a request, and the target is put on the final results.

Still one to catch and fix, but this seem to cure most of them
(This used to be commit bfeaa08fde805439dbda974be6fcb692957b00f1)
2007-10-10 14:21:07 -05:00
Andrew Bartlett
e0294c9f66 r19310: Add another conflicting oid
Cope with there being no attributes to skip in the ad2oLscheam tool

Andrew Bartlett
(This used to be commit 942d7ad0c3534770ad05977b180e1c8111a5b6a6)
2007-10-10 14:21:06 -05:00
Simo Sorce
3cabd0dcae r19305: Potential memleak on the ldb_context if we don't use a temp mem context
(This used to be commit c989dfbe18a2f700e952f478e258bd626c9eb2f5)
2007-10-10 14:21:05 -05:00
Simo Sorce
59b66744f7 r19299: Fix possible memleaks
(This used to be commit 6fad80bb09113a60689061a2de67711c9924708b)
2007-10-10 14:21:04 -05:00
Andrew Tridgell
d0ba572fab r19289: fixed a memory leak in ldb_dn_string_compose()
(This used to be commit 669aa1424c7a931f57856af0cd4a6f6f4a60b823)
2007-10-10 14:21:02 -05:00
Andrew Tridgell
04140ac3c7 r19274: fix ldbdel and ldbmodify to return an error if the underlying ldb call
fails
(This used to be commit 330a722f1330059cbba19f99210a1a5a7c773a36)
2007-10-10 14:21:00 -05:00
Andrew Tridgell
2ad8e1443d r19273: - fixed error handling with the ldap backend
- propogate errors to the ldbadd command line tool

- use the rdn_name module when testing the tdb backend to allow the
  same test code to correctly test the ldap and non-ldap backends
(This used to be commit dd82c474a123d90329bda653a4cb73c93e087b15)
2007-10-10 14:21:00 -05:00
Andrew Bartlett
fa67b43ae8 r19264: Clarify behaviour in ldb_search_callback() and provide more
information when modules fail to load.

Andrew Bartlett
(This used to be commit 512ef62f4a63fd90b67757b2c7b2e8ec83969204)
2007-10-10 14:20:59 -05:00
Stefan Metzmacher
bbc056e067 r19196: merge from samba3:
pass always a mem_ctx to functions and a ldb_context where needed

metze
(This used to be commit 67a6a41ba3af840cd8226de73576a90ecf602caa)
2007-10-10 14:20:52 -05:00
Stefan Metzmacher
c403dd11fb r19188: merge from samba3:
fix compiler warnings

metze
(This used to be commit dc139d8715f58b27363266f1426da451907845eb)
2007-10-10 14:20:51 -05:00
Stefan Metzmacher
47f90dde40 r19146: merge from samba3:
talloc_reference() can fail

metze
(This used to be commit 542cd5d029e97c2e0c7c006a1ced12114c1bb6da)
2007-10-10 14:20:43 -05:00
Volker Lendecke
109bf77ea3 r19134: Merge the second set of C++ warning fixes from Samba3. I'll leave r19132 to
metze to merge until the questions have been answered.

Volker
(This used to be commit e946717bf600f4ff922dc55a9a5d259535d0d1c9)
2007-10-10 14:20:38 -05:00
Simo Sorce
f7005d48d2 r19129: Add comment to clarify behavior
(This used to be commit 7180f38e9e436ca7a7c49f2d4b315ec5eb9c7631)
2007-10-10 14:20:37 -05:00
Stefan Metzmacher
d544f8a6de r19123: - pass LDFLAGS from configure to Makefile
which should fix the build on Tru64 in the build farm.

Thanks to Bjoern Jacke for finding this!

metze
(This used to be commit 165722a16cf9b8e3f352ed44285cdae0fba66536)
2007-10-10 14:20:37 -05:00
Andrew Tridgell
31e50ccae7 r19114: fixed another checker warning and a possible error on allocation
failure
(This used to be commit bc02f7ef96e164a59441e3fd9429221be83fc7e4)
2007-10-10 14:20:36 -05:00
Andrew Tridgell
f1f807e66b r19113: fixed another checker warning.
(This used to be commit d12550af01f8d4c135fbf6f429852c31570ec92b)
2007-10-10 14:20:35 -05:00
Andrew Tridgell
36246a191c r19112: fixed a checker warning.
In case you haven't noticed, lots of our packages now run the IBM
checker in the build farm on 'snab'
(This used to be commit b39a79f17c9d8729264436bb774e8bd2b88e12f9)
2007-10-10 14:20:35 -05:00
Volker Lendecke
06ac3dbd9a r19079: talloc_array can fail
(This used to be commit 441ad8a45c390f807a6ec5f27d585aad54f3b210)
2007-10-10 14:20:34 -05:00
Volker Lendecke
ecd970abb6 r19076: ldb_dn_copy_partial can fail
(This used to be commit 78aa689a74941cd6873a91c429889a4c1d1a6432)
2007-10-10 14:20:33 -05:00
Volker Lendecke
c56585e5fe r19075: Fix a potential NULL dereference
(This used to be commit 84ae80b39bfa49fe7f9fa801d45a79bf04df8aff)
2007-10-10 14:20:33 -05:00
Volker Lendecke
9bbc8736e7 r19074: Merge from 3_0: Fix a potential NULL dereference.
Volker
(This used to be commit af72af684bca68c1759be1357f817db7be699eed)
2007-10-10 14:20:33 -05:00
Simo Sorce
118dae99de r19069: The sequence number is a 64 bit unsigned integer
Well spotted Volker
(This used to be commit f4239ef5983cfc06fd5cab42448564faed676944)
2007-10-10 14:20:33 -05:00
Volker Lendecke
19df909135 r19068: Fix a potential NULL dereference
(This used to be commit 2dff8ee8cc8b9faf3fbec46d458d6de214622afc)
2007-10-10 14:20:33 -05:00
Andrew Tridgell
bf86ece6cb r19009: ensure that data values from ldap libs are null terminated, to allow
ldb_msg_find_attr_as_string() to work correctly.

Thanks to Jim Myers for spotting this!
(This used to be commit b2076c1a7e4b70644b59689ce46952ef940be6b0)
2007-10-10 14:20:28 -05:00
Andrew Bartlett
c2a2c2456d r18978: Fix bug found by:
http://www.ee.oulu.fi/research/ouspg/protos/testing/c06/ldapv3/

The issue here is that if the UTF8 conversion fails, because this
isn't actually UTF8 data, then we need to do a binary compare instead.

Andrew Bartlett
(This used to be commit a113e47784157ec6086b014c1fc998e8a23e7382)
2007-10-10 14:20:26 -05:00
Andrew Tridgell
4c3b07b654 r18942: add a ldb_set_create_perms() function in ldb. I didn't call it
ldb_set_umask() (which is what we had discussed) as it doesn't
actually set the umask (in effect it sets the inverse of the umask -
the perms to be used for the file)
(This used to be commit 7e2ec875908c112d5c3b0f6d18f9a8bbacf33539)
2007-10-10 14:20:22 -05:00
Andrew Tridgell
4e7c9367a7 r18939: don't rely on the umask being right in ldb creation. Both Samba3 and
Samba4 smbd force the umask to 0, which meant we ended up with ldb
being world writable.

This isn't really an ideal fix, as it means ldb no longer honors umask
(as it should do, like all good libraries).

Unfortunately the 'proper' fix is too complex for now

this also merges a tiny code style fix from s4 to s3
(This used to be commit 1a42f38dfdc55d7429a1f8d3e811f3d857195a58)
2007-10-10 14:20:22 -05:00
Andrew Tridgell
26ece8f697 r18910: Change ldb_msg_add_string() to not actually add an attribute if the
string is zero length. This allows callers to not have to worry about
creating an invalid ldap attribute.

See extensive discussion on samba-technical list :-)
(This used to be commit 7a1db8c2a432b9ab59b29ee1bfce6c8fe8e981a2)
2007-10-10 14:20:20 -05:00
Stefan Metzmacher
95340f8afb r18903: merge from samba3:
define HAVE_LDB_LDAP and HAVE_LDB_SQLITE3

metze
(This used to be commit 4e2f5ba490d717283ab089d90ebd5c108a8c53b0)
2007-10-10 14:20:19 -05:00
Volker Lendecke
1b8d6b3e7d r18894: Merge const fixes from 3_0
(This used to be commit 4ce447223cc71b8b2a31c2da3b0afd8e3fcf0c01)
2007-10-10 14:20:19 -05:00
Simo Sorce
5e1e97a20d r18882: make style consistent
(This used to be commit a141ee9473ae46c63dea247456f156b40f766d42)
2007-10-10 14:20:18 -05:00
Simo Sorce
df83913eb1 r18881: remove wrong check and statement.
to manipulate rootDSE we use ldb_dn_new() as base and that has 0 elements.
(This used to be commit 3e131177dae3536c07632fe09e7ebe877bcd9332)
2007-10-10 14:20:18 -05:00
Volker Lendecke
51f27dc3f1 r18851: Some C++ warnings
(This used to be commit 69f05f288ce7a8508760db861d0910495bd1d578)
2007-10-10 14:20:16 -05:00
Andrew Tridgell
088c24e4e6 r18840: make these compatible with g++ warnings
(This used to be commit bcfa93954fdb00f500f174cd227e3d9b2ef94fdc)
2007-10-10 14:20:15 -05:00
Andrew Tridgell
45ca27699c r18834: get the log context code right
(This used to be commit b6bb5d7b772467042cee6ea372119781c42b91c1)
2007-10-10 14:19:16 -05:00
Andrew Tridgell
0b5e01c19b r18832: fixed standalone build
(This used to be commit 1ebc098b6776d38451e441280ac13664d64569f4)
2007-10-10 14:19:15 -05:00