sin/samba-mirror
1
0
Fork 0
mirror of https://github.com/samba-team/samba.git synced 2024-12-23 17:34:34 +03:00
Code
134,500 Commits 60 Branches 1,144 Tags 452 MiB
8f2a9f836f
Commit Graph

451 Commits

Author SHA1 Message Date
Joseph Sutton
88acf7de08 s3:utils: Fix code spelling 
Signed-off-by: Joseph Sutton <josephsutton@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
 2023-08-08 04:39:38 +00:00
Andreas Schneider
746ef717a7 s3:utils: Fix code spelling 
Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Joseph Sutton <josephsutton@catalyst.net.nz>
 2023-07-19 09:58:37 +00:00
Noel Power
22ab42c100 s3/utils: avoid erronous NO MEMORY detection 
since 5cc3c1b5f6 if we don't have
a realm specified either on cmdline or in conf file we try to
copy (talloc_strdup) a NULL variable which triggers a NO_MEMORY
error when we check the result of the copy

BUG: https://bugzilla.samba.org/show_bug.cgi?id=15384

Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Stefan Metzmacher <metze@samba.org>

Autobuild-User(master): Stefan Metzmacher <metze@samba.org>
Autobuild-Date(master): Sun Jun  4 12:42:16 UTC 2023 on atb-devel-224
 2023-06-04 12:42:16 +00:00
Joseph Sutton
e14b5974c6 net_ads: Handle new NBT_SERVER_* flags 
Signed-off-by: Joseph Sutton <josephsutton@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
 2023-05-29 22:32:28 +00:00
Stefan Metzmacher
0ef53b948e net_ads: fill ads->auth.realm from c->creds 
We get the realm we use for authentication needs to
the realm belonging to the username we use.

We derive the username from c->creds, so we need to
do the same for the realm.

Otherwise we try to authenticate as the wrong user.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=15323

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
 2023-04-06 12:51:30 +00:00
Björn Baumbach
e3cfb99d28 net: add hint which options can be used with net ads dns register command 
Signed-off-by: Björn Baumbach <bb@sernet.de>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>

Autobuild-User(master): Björn Baumbach <bb@sernet.de>
Autobuild-Date(master): Fri Mar  3 12:52:00 UTC 2023 on atb-devel-224
 2023-03-03 12:52:00 +00:00
Günther Deschner
39e8489dfc s3-librpc: add ads.idl and convert ads_struct to talloc. 
Guenther

Signed-off-by: Guenther Deschner <gd@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
 2022-12-16 20:38:32 +00:00
Stefan Metzmacher
b7260c89e0 CVE-2022-37966 s3:net_ads: let 'net ads enctypes list' pretty print AES256-SK and RESOURCE-SID-COMPRESSION-DISABLED 
BUG: https://bugzilla.samba.org/show_bug.cgi?id=15237

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Joseph Sutton <josephsutton@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
 2022-12-13 13:07:30 +00:00
Stefan Metzmacher
4cedaa643b CVE-2022-37966 s3:net_ads: no longer reference des encryption types 
We no longer have support for des encryption types in the kerberos
libraries anyway.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=15237

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Joseph Sutton <josephsutton@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
 2022-12-13 13:07:30 +00:00
Stefan Metzmacher
f3fe1f2ce6 CVE-2022-37966 s3:net_ads: remove unused ifdef HAVE_ENCTYPE_AES* 
aes encryption types are always supported.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=15237

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Joseph Sutton <josephsutton@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
 2022-12-13 13:07:30 +00:00
Stefan Metzmacher
1fdf1d55a5 CVE-2022-38023 s3:net: add and use net_warn_member_options() helper 
This makes sure domain member related 'net' commands print warnings
about unsecure smb.conf options.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=15240

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
 2022-12-13 13:07:29 +00:00
Stefan Metzmacher
17779a6833 s3:util: add 'net ads keytab delete' 
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
 2022-10-27 21:14:43 +00:00
Jeremy Allison
da589447bd s3: net_ads: Cleanup, remove unused talloc_ctx in net_ads_kerberos_kinit(). 
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Samuel Cabrero <scabrero@samba.org>

Autobuild-User(master): Jeremy Allison <jra@samba.org>
Autobuild-Date(master): Mon Jun 27 16:48:32 UTC 2022 on sn-devel-184
 2022-06-27 16:48:31 +00:00
Samuel Cabrero
b8a0446a4d s3:libads: Allocate ads->config.realm under ADS_STRUCT talloc context 
Signed-off-by: Samuel Cabrero <scabrero@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
 2022-06-27 15:50:30 +00:00
Samuel Cabrero
633ccc55c0 s3:libads: Allocate ads->auth.user_name under ADS_STRUCT talloc context 
Signed-off-by: Samuel Cabrero <scabrero@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
 2022-06-27 15:50:30 +00:00
Samuel Cabrero
d64335eaef s3:libads: Allocate ads->auth.password under ADS_STRUCT talloc context 
Signed-off-by: Samuel Cabrero <scabrero@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
 2022-06-27 15:50:30 +00:00
Samuel Cabrero
c1ab39163b s3:libads: Allocate ads->auth.realm under ADS_STRUCT talloc context 
Signed-off-by: Samuel Cabrero <scabrero@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
 2022-06-27 15:50:30 +00:00
Samuel Cabrero
d0dc0171ad s3:libads: Allocate ADS_STRUCT under a talloc context 
The ads_destroy() function is now static and only called from the
ADS_STRUCT destructor.

Signed-off-by: Samuel Cabrero <scabrero@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
 2022-06-27 15:50:30 +00:00
Samuel Cabrero
50934b85ff s3:net: Refactor net_ads_check_int(), allocate a talloc context 
ADS_STRUCT will be allocated in the talloc context.

Signed-off-by: Samuel Cabrero <scabrero@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
 2022-06-27 15:50:30 +00:00
Samuel Cabrero
ba7a3667e9 s3:net: Pass a talloc context to ads_startup_int() 
The ads struct will be allocated under this context.

Signed-off-by: Samuel Cabrero <scabrero@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
 2022-06-27 15:50:30 +00:00
Samuel Cabrero
0748783396 s3:net: Pass a talloc context to ads_startup() 
The ads struct will be allocated under this context.

Signed-off-by: Samuel Cabrero <scabrero@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
 2022-06-27 15:50:30 +00:00
Samuel Cabrero
2979196d69 s3:net: Exit returning -1 when usage is displayed 
Signed-off-by: Samuel Cabrero <scabrero@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
 2022-06-27 15:50:30 +00:00
Samuel Cabrero
923db0f2b8 s3:net: Refactor net_ads_enctypes_delete(), allocate a talloc context 
ADS_STRUCT will be allocated in the talloc context.

Signed-off-by: Samuel Cabrero <scabrero@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
 2022-06-27 15:50:30 +00:00
Samuel Cabrero
5a4ccc5e92 s3:net: Refactor net_ads_enctypes_set(), allocate a talloc context 
ADS_STRUCT will be allocated in the talloc context.

Signed-off-by: Samuel Cabrero <scabrero@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
 2022-06-27 15:50:30 +00:00
Samuel Cabrero
1b04ae0d3c s3:net: Refactor net_ads_enctypes_list(), allocate a talloc context 
ADS_STRUCT will be allocated in the talloc context.

Signed-off-by: Samuel Cabrero <scabrero@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
 2022-06-27 15:50:30 +00:00
Samuel Cabrero
998e9b9a19 s3:net: Refactor net_ads_setspn_delete(), allocate a talloc context 
ADS_STRUCT will be allocated in the talloc context.

Signed-off-by: Samuel Cabrero <scabrero@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
 2022-06-27 15:50:30 +00:00
Samuel Cabrero
d4059d525c s3:net: Refactor net_ads_setspn_add(), allocate a talloc context 
ADS_STRUCT will be allocated in the talloc context.

Signed-off-by: Samuel Cabrero <scabrero@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
 2022-06-27 15:50:30 +00:00
Samuel Cabrero
d8c84717ee s3:net: Refactor net_ads_setspn_list(), allocate a talloc context 
ADS_STRUCT will be allocated in the talloc context.

Signed-off-by: Samuel Cabrero <scabrero@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
 2022-06-27 15:50:30 +00:00
Samuel Cabrero
04fa6e9882 s3:net: Refactor net_ads_keytab_create(), allocate a talloc context 
ADS_STRUCT will be allocated in the talloc context.

Signed-off-by: Samuel Cabrero <scabrero@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
 2022-06-27 15:50:30 +00:00
Samuel Cabrero
d4937439a6 s3:net: Refactor net_ads_keytab_add(), allocate a talloc context 
ADS_STRUCT will be allocated in the talloc context.

Signed-off-by: Samuel Cabrero <scabrero@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
 2022-06-27 15:50:30 +00:00
Samuel Cabrero
484345bd4b s3:net: Refactor net_ads_keytab_flush(), allocate a talloc context 
ADS_STRUCT will be allocated in the talloc context.

Signed-off-by: Samuel Cabrero <scabrero@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
 2022-06-27 15:50:30 +00:00
Samuel Cabrero
c443b0b18e s3:net: Refactor net_ads_sid(), allocate a talloc context 
ADS_STRUCT will be allocated in the talloc context.

Signed-off-by: Samuel Cabrero <scabrero@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
 2022-06-27 15:50:30 +00:00
Samuel Cabrero
c0ed4d85ad s3:net: Refactor net_ads_dn(), allocate a talloc context 
ADS_STRUCT will be allocated in the talloc context.

Signed-off-by: Samuel Cabrero <scabrero@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
 2022-06-27 15:50:30 +00:00
Samuel Cabrero
f665c66133 s3:net: Refactor net_ads_search(), allocate a talloc context 
ADS_STRUCT will be allocated in the talloc context.

Signed-off-by: Samuel Cabrero <scabrero@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
 2022-06-27 15:50:30 +00:00
Samuel Cabrero
407e156d59 s3:net: Refactor net_ads_changetrustpw(), allocate a talloc context 
ADS_STRUCT will be allocated in the talloc context.

Signed-off-by: Samuel Cabrero <scabrero@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
 2022-06-27 15:50:30 +00:00
Samuel Cabrero
4e2f7cf565 s3:net: Refactor net_ads_password(), allocate a talloc context 
ADS_STRUCT will be allocated in the talloc context.

Signed-off-by: Samuel Cabrero <scabrero@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
 2022-06-27 15:50:30 +00:00
Samuel Cabrero
bb1a344844 s3:net: Refactor net_ads_printer_remove(), allocate a talloc context 
ADS_STRUCT will be allocated in the talloc context.

Signed-off-by: Samuel Cabrero <scabrero@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
 2022-06-27 15:50:30 +00:00
Samuel Cabrero
75a3f3800d s3:net: Refactor net_ads_printer_publish(), allocate a talloc context 
ADS_STRUCT will be allocated in the talloc context.

Signed-off-by: Samuel Cabrero <scabrero@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
 2022-06-27 15:50:29 +00:00
Samuel Cabrero
7f2267cce9 s3:net: Refactor net_ads_printer_info(), allocate a talloc context 
ADS_STRUCT will be allocated in the talloc context.

Signed-off-by: Samuel Cabrero <scabrero@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
 2022-06-27 15:50:29 +00:00
Samuel Cabrero
507c90e2fb s3:net: Refactor net_ads_printer_search(), allocate a talloc context 
ADS_STRUCT will be allocated in the talloc context.

Signed-off-by: Samuel Cabrero <scabrero@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
 2022-06-27 15:50:29 +00:00
Samuel Cabrero
1867b09c8f s3:net: Refactor net_ads_dns_unregister(), allocate a talloc context 
ADS_STRUCT will be allocated in the talloc context.

Signed-off-by: Samuel Cabrero <scabrero@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
 2022-06-27 15:50:29 +00:00
Samuel Cabrero
d92055e01b s3:net: Refactor net_ads_dns_register(), allocate a talloc context 
ADS_STRUCT will be allocated in the talloc context.

Signed-off-by: Samuel Cabrero <scabrero@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
 2022-06-27 15:50:29 +00:00
Samuel Cabrero
ec00cbc6e0 s3:net: Refactor net_ads_join(), allocate a talloc context 
ADS_STRUCT will be allocated in the talloc context.

Signed-off-by: Samuel Cabrero <scabrero@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
 2022-06-27 15:50:29 +00:00
Samuel Cabrero
f810a41f6a s3:net: Refactor net_ads_join_ok(), allocate a talloc context 
ADS_STRUCT will be allocated in the talloc context.

Signed-off-by: Samuel Cabrero <scabrero@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
 2022-06-27 15:50:29 +00:00
Samuel Cabrero
818ed102a3 s3:net: Refactor net_ads_leave(), allocate a talloc context 
ADS_STRUCT will be allocated in the talloc context.

Signed-off-by: Samuel Cabrero <scabrero@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
 2022-06-27 15:50:29 +00:00
Samuel Cabrero
ce9da6e650 s3:net: Refactor net_ads_status(), allocate a talloc context 
ADS_STRUCT will be allocated in the talloc context.

Signed-off-by: Samuel Cabrero <scabrero@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
 2022-06-27 15:50:29 +00:00
Samuel Cabrero
786e0394df s3:net: Refactor net_ads_group(), allocate a talloc context 
ADS_STRUCT will be allocated in the talloc context.

Best viewed with "git diff -b".

Signed-off-by: Samuel Cabrero <scabrero@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
 2022-06-27 15:50:29 +00:00
Samuel Cabrero
356aa3e357 s3:net: Refactor ads_group_delete(), allocate a talloc context 
ADS_STRUCT will be allocated in the talloc context.

Signed-off-by: Samuel Cabrero <scabrero@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
 2022-06-27 15:50:29 +00:00
Samuel Cabrero
66a72fbe01 s3:net: Refactor ads_group_add(), allocate a talloc context 
ADS_STRUCT will be allocated in the talloc context.

Signed-off-by: Samuel Cabrero <scabrero@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
 2022-06-27 15:50:29 +00:00
Samuel Cabrero
937021d51b s3:net: Refactor net_ads_user(), allocate a talloc context 
ADS_STRUCT will be allocated in the talloc context.

Best viewed using "git diff -b".

Signed-off-by: Samuel Cabrero <scabrero@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
 2022-06-27 15:50:29 +00:00