1
0
mirror of https://github.com/samba-team/samba.git synced 2025-01-17 02:05:21 +03:00

60 Commits

Author SHA1 Message Date
Günther Deschner
8fb6b18bac s3-eventlog: allow to open eventlog tdbs readonly.
Guenther
2009-02-03 15:44:06 +01:00
Günther Deschner
9629897094 s3-eventlog: add missing _eventlog_ReportEventAndSourceW stub call.
Guenther
2009-01-24 03:33:22 +01:00
Günther Deschner
5bcd6d760b Revert "s3-eventlog: trying to avoid to pass around full ndr structures in rpc_server."
This reverts commit c0f1309010b79be67557af5ffbd1c429a3f3d99a.
2009-01-24 03:00:38 +01:00
Günther Deschner
dd2695fe52 s3-eventlog: fix various invalid memcpy in read_package_entry().
Guenther
2009-01-24 03:00:38 +01:00
Günther Deschner
740c5ce081 s3-eventlog: fix _eventlog_CloseEventLog.
Guenther
2009-01-16 11:52:49 +01:00
Günther Deschner
6dc18f2cab s3-eventlog: some minor code cleanup in eventlog server.
Guenther
2009-01-16 00:28:45 +01:00
Günther Deschner
990491d187 s3-eventlog: fix ps struct removal leftover.
Guenther
2009-01-14 10:53:04 +01:00
Günther Deschner
df8b724819 s3-eventlog: use main talloc context in eventlog read call.
Guenther
2009-01-14 10:18:14 +01:00
Volker Lendecke
84292022bf Now that all policy_handle free_fn's are just TALLOC_FREE, dump free_fn 2009-01-08 22:29:54 +01:00
Volker Lendecke
baa5c5eeb0 Make use of a talloc_destructor for free_eventlog_info() 2009-01-08 22:29:53 +01:00
Günther Deschner
252d271fe4 s3-eventlog: minor cosmetics.
Guenther
2009-01-08 19:37:29 +01:00
Günther Deschner
c0f1309010 s3-eventlog: trying to avoid to pass around full ndr structures in rpc_server.
Jerry, please check.

Guenther
2009-01-08 19:37:29 +01:00
Volker Lendecke
907f126d3e Get rid of pipes_struct->pipe_user, we have server_info now --- YESSS! 2008-11-24 11:39:03 +01:00
Jeremy Allison
98bf3ee2f6 Second part of fix for bug #5891 - smbd crashed when viewing the eventlog exported by "eventlog list". Don't leak memory on error paths.
Jeremy.
2008-11-20 10:56:14 -08:00
Günther Deschner
f0e75484a7 s3-eventlog: remove trailing whitespace.
Guenther
2008-11-20 17:16:03 +01:00
Günther Deschner
70f55ddb70 s3-eventlog: avoid passing down full prs_struct in eventlog server.
Guenther
2008-11-20 17:15:38 +01:00
Michael Adam
172628dca2 eventlog: don't crash in sync_eventlog_params().
When freeing the talloc ctx at the end of the routine,
it must be a talloc ctx created inside. talloc_tos() needs
to be valid after the function finishes, since callers
(may) have data attached to it.

Michael

Signed-off-by: Günther Deschner <gd@samba.org>
2008-11-20 17:08:37 +01:00
Jeremy Allison
da683d6a73 This code mixes up int and uint32 when pulling out of a TDB. This is very bad. Fixing... May fix bug #5891, not sure.
Jeremy.
2008-11-19 16:49:03 -08:00
Jeremy Allison
c62427c7fc Fix bug 5891] : smbd crashed when viewing the eventlog exported by "eventlog list"
Don't mix TALLOC and SAFE_FREE().
Jeremy.
2008-11-11 14:38:59 -08:00
Jelmer Vernooij
ddcab787c4 Rename dos_errstr() to win_errstr() for consistency with Samba 4. 2008-11-01 17:19:26 +01:00
Jeremy Allison
8344e94574 Unify se_access_check with the S4 code. Will make
calculation of SEC_FLAG_MAXIMUM_ALLOWED much easier
for files.
Jeremy.
2008-10-31 10:51:45 -07:00
Günther Deschner
a31829ffcd Remove unused arguments in read_package_entry() in the eventlog rpc server.
Guenther
(This used to be commit c2e786d4e2cb53b5a8be45278f221acaa7f5122a)
2008-02-04 11:33:06 +01:00
Günther Deschner
5ab6d66f13 Use pidl for _eventlog_OpenEventLogW().
Guenther
(This used to be commit ef293be6cb95225f10e8062b3089dc1bbe5fd013)
2008-02-04 11:10:18 +01:00
Günther Deschner
221a2a9a5f Copy inline comment for _eventlog_ClearEventLogW() from rpc_parse to rpc_server.
Guenther
(This used to be commit 26eadadbf628f4d3aa4cd0ab4b55d47dc79c80ba)
2008-02-04 10:55:14 +01:00
Günther Deschner
48d2990d8c Use pidl for _eventlog_ClearEventLogW().
Guenther
(This used to be commit 70a4ba798cdd3b4daa01c2f6aa693de34288c8b9)
2008-02-04 10:53:59 +01:00
Günther Deschner
8d20f3f999 Use pidl for _eventlog_GetOldestRecord().
Guenther
(This used to be commit a6a5d99f5206dc4b94f3d0ecceb5198d66afdf41)
2008-02-04 10:44:51 +01:00
Günther Deschner
72d0deddc4 Use pidl for _eventlog_GetNumRecords().
Guenther
(This used to be commit af30a6373e7d85df4bb99e153588498938ddc368)
2008-02-04 10:10:12 +01:00
Gerald W. Carter
5dcc7f7e61 Fix a return value from sync_eventlog_params() (patch from Volker)
(This used to be commit 77085f1a58666ac4314924d18c87d4add0553dba)
2008-01-29 15:06:59 -06:00
Michael Adam
00f3df3c13 Convert sync_eventlog_params() to use reg_api instead of reg_frontend.
This is a step towards untangling the registry.
All places should use reg_api.c, reg_frontend should actually more
appropriately be named reg_backend_dispatcher and hidden from callers.

:-)

Michael
(This used to be commit 92e95fe58500dc8bf89bb43c1d65559702363767)
2008-01-17 16:25:11 +01:00
Volker Lendecke
bbf2cb6da9 Fix some C++ warnings
(This used to be commit 156c7f10bb63a610f85b52242cfd1b67bfa73c29)
2007-12-01 10:43:35 -08:00
Jeremy Allison
3a452a15b7 Remove pstring from everything in rpc_server except
srv_spoolss_nt.c and srv_srvsvc_nt.c.
They're next :-).
Jeremy.
(This used to be commit 55b4f9d003b036af69085f7b64e0df08c5ba440d)
2007-11-27 11:22:58 -08:00
Jeremy Allison
30191d1a57 RIP BOOL. Convert BOOL -> bool. I found a few interesting
bugs in various places whilst doing this (places that assumed
BOOL == int). I also need to fix the Samba4 pidl generation
(next checkin).
Jeremy.
(This used to be commit f35a266b3cbb3e5fa6a86be60f34fe340a3ca71f)
2007-10-18 17:40:25 -07:00
Andrew Tridgell
153cfb9c83 r23801: The FSF has moved around a lot. This fixes their Mass Ave address.
(This used to be commit 87c91e4362c51819032bfbebbb273c52e203b227)
2007-10-10 12:28:27 -05:00
Jeremy Allison
d824b98f80 r23779: Change from v2 or later to v3 or later.
Jeremy.
(This used to be commit 407e6e695b8366369b7c76af1ff76869b45347b3)
2007-10-10 12:28:20 -05:00
Jeremy Allison
d1d2157153 r23591: Fix bug #4725. Don't crash when no eventlogs specified. Needs
merging for 3.0.25b.
Jeremy.
(This used to be commit ae239fec6faa79018c818506b391b829ccd685f8)
2007-10-10 12:23:33 -05:00
Gerald Carter
97a164ba96 r23274: merge CloseEventlog() pidl conversion from 3.0.26 && fix a few init call renames for svcctl in the previous commit
(This used to be commit ebcae48ec10fefa74efcc3563cff50e3b9c2388c)
2007-10-10 12:23:02 -05:00
Stefan Metzmacher
bc2b6436d0 r22009: change TDB_DATA from char * to unsigned char *
and fix all compiler warnings in the users

metze
(This used to be commit 3a28443079c141a6ce8182c65b56ca210e34f37f)
2007-10-10 12:19:00 -05:00
Herb Lewis
e59e787b48 r20269: merge -r20264:20267 from SAMBA_3_0_24
more no previous prototype warnings
(This used to be commit 41be182f78762372ae13759ede5d2bd40a71d7f5)
2007-10-10 12:16:38 -05:00
Volker Lendecke
ecf90c495e r19991: Sorry for this 2000-liner...
The main thing here is a rewrite of srv_winreg_nt.c. The core functionality
has moved to registry/reg_api.c which is then usable by the rest of Samba as
well.

On that way it fixes creating keys with more than one element in the
path. This did not work before.

Two things that sneaked in (sorry :-) is the change of some routines from
NTSTATUS to WERROR the removed "parent" argument to regkey_open_internal.

Volker
(This used to be commit fea52801de8c7b85c578d200c599475680c5339f)
2007-10-10 12:16:18 -05:00
Volker Lendecke
1c91cca86e r19947: Change regkey_open_internal to take the parent key and a talloc_ctx as
arguments. This also replaces regkey_close_internal by TALLOC_FREE.

Volker
(This used to be commit a177bbb2d5611f03cec25b7577c2e6a542f94a69)
2007-10-10 12:16:14 -05:00
Volker Lendecke
bfad442144 r19780: Ok, regkey_open_internal needs a regkey_close_internal. Giving a talloc ctx is
misleading here. This needs fixing properly :-)

Volker
(This used to be commit f808182346aa16bb2f3a9383e28d318099a5e14e)
2007-10-10 12:15:55 -05:00
Volker Lendecke
e82cd437cc r19778: Make regkey_open_internal take a talloc ctx
(This used to be commit cb7f4211b8441642dce9594522dc9588475a7719)
2007-10-10 12:15:55 -05:00
Volker Lendecke
9bb1f909fd r19775: Fix typo
(This used to be commit 370e29ebb9da92c9072bdd4eec84980b5753089a)
2007-10-10 12:15:54 -05:00
Jeremy Allison
429cd6db0b r16542: Fix #3863, reported by jason@ncac.gwu.edu
Jeremy.
(This used to be commit cde8323fdc4d4ddaa30e8c59bec89dc130fe26a6)
2007-10-10 11:18:59 -05:00
Volker Lendecke
3c34f6085a r16409: Fix Klocwork ID's.
1177

In reg_perfcount.c: 1200 1202 1203 1204
In regfio.c: 1243 1245 1246 1247 1251

Jerry, the reg_perfcount and regfio.c ones, can you take a look please? This
is really your code, and I'm not sure I did the right thing to return an
error.

smbcacls.c: 1377
srv_eventlog_nt.c: 1415 1416 1417
srv_lsa_nt.c: 1420 1421
srv_netlog_nt.c: 1429
srv_samr_nt: 1458 1459 1460

Volker

Volker
(This used to be commit d6547d12b1c9f9454876665a5bdb010f46b9f5ff)
2007-10-10 11:18:52 -05:00
Volker Lendecke
e17302200c r15101: Little step towards getting Samba4 tdb into 3: tdb_lock_bystring does not
have the timeout argument in Samba4. Add a new routine
tdb_lock_bystring_with_timeout.

Volker
(This used to be commit b9c6e3f55602fa505859a4b2cd137b74105d685f)
2007-10-10 11:16:23 -05:00
Jeremy Allison
d1f91f7c72 r12043: It's amazing the warnings you find when compiling on a 64-bit
box with gcc4 and -O6...
Fix a bunch of C99 dereferencing type-punned pointer will break
strict-aliasing rules errors. Also added prs_int32 (not uint32...)
as it's needed in one place. Find places where prs_uint32 was being
used to marshall/unmarshall a time_t (a big no no on 64-bits).
More warning fixes to come.
Thanks to Volker for nudging me to compile like this.
Jeremy.
(This used to be commit c65b752604f8f58abc4e7ae8514dc2c7f086271c)
2007-10-10 11:05:42 -05:00
Gerald Carter
1ce2883865 r11762: fix my build breakage
(This used to be commit 9ee851630ec3443f27a61de6eaf222c74d2d064a)
2007-10-10 11:05:26 -05:00
Gerald Carter
5251618c7f r11761: * fix clearing of event logs by truncating the tdb.
This feature got broken in some of the other updates.
  Now each open handle stores an pointer to an open tdb
  data structure (not the tdb pointer itself).
  Clearing can be done with a simple elog_close_tdb( elog, True )
  to force a close and then calling elog_open_tdb( logname, True )
  to force an tdb truncate.  Permissions on existing tdbs are
  maintained which is important.

* We don't currently handle backup.  Haven't looked at the
  format of a backuped up eventlog to know what the deal is.
(This used to be commit 2df34c9403446d12f1ceeac38cbda5d3ba805b02)
2007-10-10 11:05:26 -05:00
Gerald Carter
70cac98b6e r11760: fix sequential reads in the eventlog; event viewer is behaving better now as well but needs more testing
(This used to be commit ba2f94aeae1f8e69d53fc360785adf222a8c9c6e)
2007-10-10 11:05:26 -05:00