1
0
mirror of https://github.com/samba-team/samba.git synced 2024-12-23 17:34:34 +03:00
Commit Graph

13696 Commits

Author SHA1 Message Date
Gerald Carter
c24dccd413 BUG 417: fix %UuGg variables expansion in include lines setging the current_user_info struct in register_vuid() -- shouldn't be any more broken than we were
(This used to be commit a90c3bd281)
2004-03-19 22:06:54 +00:00
Gerald Carter
fd312721ea missed some of Derrel's changes
(This used to be commit 3aac1e549e)
2004-03-19 17:48:08 +00:00
Gerald Carter
03992127fa add --with-libdir and --with-mandir (patch from Guenther Deschner)
(This used to be commit a1d6200cd5)
2004-03-19 16:58:16 +00:00
Gerald Carter
45355a1e84 bumping version to 3.0.3pre2
(This used to be commit 54de604054)
2004-03-19 16:23:54 +00:00
Gerald Carter
56ce613679 updating release notes & merging Derrel Lipman's libsmbclient patch from HEAD
(This used to be commit 5fbfaa687a)
2004-03-19 16:22:47 +00:00
Simo Sorce
ebf27cf5a1 backport from head
(This used to be commit e05eb14370)
2004-03-19 11:28:36 +00:00
Jeremy Allison
a79b205d92 Fix gcc warnings. Fix mkproto with new type.
Jeremy.
(This used to be commit 00fa66df3e)
2004-03-19 01:29:14 +00:00
Jeremy Allison
7942c2826b Merge from HEAD for Amanda group.
Apply Craig Barratt's fixes to allow multiple exlusion files and patterns.
Jeremy.
(This used to be commit 0272fac8ca)
2004-03-18 23:45:15 +00:00
Jim McDonough
357998ddbd Password lockout for LDAP backend. Caches autolock flag, bad count, and
bad time locally, updating the directory only for hitting the policy limit
or resetting.

This needed to be done at the passdb level rather than auth, because some
of the functions need to be supported from tools such as pdbedit.  It was
done at the LDAP backend level instead of generically after discussion,
because of the complexity of inserting it at a higher level.

The login cache read/write/delete is outside of the ldap backend, so it could
easily be called by other backends.  tdbsam won't call it for obvious
reasons, and authors of other backends need to decide if they want to
implement it.
(This used to be commit 2a679cbc87)
2004-03-18 19:22:51 +00:00
Gerald Carter
5d40499b9f BUG 932: ulrich@holeschak.de (Ulrich Holeschak); fix local password change using pam_smbpass
(This used to be commit f21182e24f)
2004-03-18 18:09:59 +00:00
Jeremy Allison
c66f52a5ac Correctness patch from fumiya@miraclelinux.com to count characters correctly,
doesn't affect what got put on the wire.
Jeremy.
(This used to be commit e8b68ef965)
2004-03-18 17:58:50 +00:00
Volker Lendecke
60a237b0b5 Fix sambaUserWorkstations for network samlogons against us as DC. Strip
the \\ off the workstation.

Volker
(This used to be commit d01cb00aad)
2004-03-18 07:36:36 +00:00
Volker Lendecke
ef4a7b3c40 Two little annoyances:
net rpc did not inform you if no smbd is running.

I never liked the error message (!) Success! when we established a trust.

Volker
(This used to be commit 4191a434d4)
2004-03-18 07:32:15 +00:00
Jeremy Allison
7e799b3036 Added a varient of Volker's patch to fix the "self-referrals as anonymous user"
problem.
Jeremy.
(This used to be commit 74de9a6140)
2004-03-18 02:17:23 +00:00
Jeremy Allison
41ea0d35ae Remove excess logging when probing for the length of the next mb char.
Jeremy.
(This used to be commit 6339c4690a)
2004-03-17 19:23:48 +00:00
Gerald Carter
aad3d8aeb0 asu/syntax/pc_netlink doesn't fill in the pipe name in the rpc_bind response so dont check for it
(This used to be commit 4d68d3d5dd)
2004-03-17 17:38:38 +00:00
Jeremy Allison
aa2e306a01 Change check_path_syntax() to use the new next_mb_char_size() function
to make it generic. Remove the mb-codepage "blacklist". Alexander, please
check this fix as it reverts your blacklist changes, but I'm hoping it
fixes the problem in a more generic way for all charsets. I'm not trying
to trample on your (excellent!) work here, just make things more generic
without special cases.
Jeremy.
(This used to be commit 5a9324525a)
2004-03-17 02:08:31 +00:00
Jeremy Allison
acad182a3f Add function next_mb_char_size() that returns a size_t of the number of
bytes in the mb character at a pointer. Will be useful in fixing check_path_syntax()
to not use a "blacklist". Also re-added my (C) to reply.c. I mean, really - I've
been adding code to the file for over 10 years and I recognise many of the
fuctions as mine ! :-).
Jeremy.
(This used to be commit d2b2a39fd2)
2004-03-16 21:59:11 +00:00
Gerald Carter
c340b2e5e4 fix overlapping memory bug when copying username
(This used to be commit a7cac639c2)
2004-03-16 20:28:47 +00:00
Gerald Carter
9073c95b97 BUG 979 -- fix quota display on AIX; patch from Heinrich.Mislik@univie.ac.at (Heinrich Mislik)
(This used to be commit 760b63496c)
2004-03-16 19:06:03 +00:00
Gerald Carter
8ef645c8a9 BUG 1182: patch from john.klinger@lmco.com (John Klinger) to reanable the -n 'no cache' option for winbindd
(This used to be commit d1848988d9)
2004-03-16 18:54:09 +00:00
Alexander Bokovoy
e2fd98af57 Fix check_path_syntax() for multibyte encodings which have no '\' as second byte.
This is intermediate fix as discussed with Jeremy until we move check_path_syntax() to UCS2 internally where all
ambiguity is resolved. Please add other encodings into charcnv.c with such property.'
'
(This used to be commit 2c404f6ba9)
2004-03-16 17:18:57 +00:00
Gerald Carter
dbb38cc6b5 merging print change notify fix from HP appliance. Also might address some one the issues in BUG 1007
(This used to be commit 17ecea4152)
2004-03-16 17:06:11 +00:00
Gerald Carter
d24b8a2032 BUG 1165, 1126: Fix bug with secondary groups (security = ads) and winbind use default domain = yes
(This used to be commit f2eaa14b1e)
2004-03-16 16:41:54 +00:00
Jeremy Allison
96c5a010bb Avoid mb conversion overflow when sending an announcement.
Jeremy.
(This used to be commit 188e1daaff)
2004-03-16 00:10:30 +00:00
Jeremy Allison
ce0c99312c Use "unix netbios name" type unstring - 64 bytes long to manipulate netbios
names in nmbd. Allows conversion from dos codepage mb strings (ie. SJIS) to
expand to utf8 size on read.
Jeremy.
(This used to be commit 834d816caf)
2004-03-15 21:45:45 +00:00
Gerald Carter
96c66b7be7 removing extra comma in --with-fhs
(This used to be commit 12f3f0268c)
2004-03-15 16:20:03 +00:00
Gerald Carter
56f2e80d58 include swatdir in 'make showlayout'
(This used to be commit b1115c0fc5)
2004-03-15 16:14:04 +00:00
Gerald Carter
dbe9e8a4cb fix byte ordering problem when storing the updating pid for the lpq cache; was causing an abort in process_exists() on solaris
(This used to be commit 26681cd2a1)
2004-03-15 15:06:33 +00:00
Volker Lendecke
0f9186a1ac When trying to remove a user from a group, winbind should be informed
about the user and group...

Volker
(This used to be commit 9fa2c40452)
2004-03-14 07:15:39 +00:00
Tim Potter
5a521453ba Use possessive in message asking for user's password.
(This used to be commit cc9765ce97)
2004-03-14 03:47:03 +00:00
Jeremy Allison
a0034d3586 Ensure we don't truncate strcmps to nstring anymore...
Jeremy.
(This used to be commit d7cf64b1e4)
2004-03-13 02:47:21 +00:00
Jeremy Allison
6b9dbbcd24 Modified fix for bugid #784. Based on a patch from moriyama@miraclelinux.com (MORIYAMA Masayuki).
Don't use nstrings to hold workgroup and netbios names. The problem with them is that MB netbios
and workgroup names in unix charset (particularly utf8) may be up to 3x bigger than the name
when represented in dos charset (ie. cp932). So go back to using fstrings for these but
translate into nstrings (ie. 16 byte length values) for transport on the wire.
Jeremy.
(This used to be commit b4ea493599)
2004-03-13 02:16:21 +00:00
Jeremy Allison
fd2d4f87d4 First part of patch from moriyama@miraclelinux.com (MORIYAMA Masayuki) to
fix up netbios names with mb strings. Includes reformat of libsmb/nmblib.c
so it's readable.
Jeremy.
(This used to be commit 966e49a48c)
2004-03-13 00:28:53 +00:00
Herb Lewis
220d663b74 if we are truncating to the . we need to start at the beginning in case
there are multiple "."'s in the name.

This code is protected with an #ifdef TRUNCATE_NETBIOS_NAME and this
is #define'd to 1 directly above. Should we also get rid of the #ifdef?
(This used to be commit 0375dace24)
2004-03-12 21:35:15 +00:00
Jeremy Allison
95fee5e3bf Fix from Robert.Dahlem@gmx.net (Robert Dahlem) for bugid #1048
when mangled names are turned off.
Jeremy.
(This used to be commit 29909ce26a)
2004-03-12 20:24:05 +00:00
Alexander Bokovoy
6011a89e24 Fix problems with very long filenames in both smbd and smbclient.
It appears that we pass filename through resolve_wildcards() as pstring and use fstring temporary buffer there.
As result, a long filename in unix charset (UTF-8 by default) can easily expand over 255 bytes while
Windows is able to send to us such names (e.g. Japanese name of ~190 mb chars) which we unable to process through
this small fstring buffer. Tested with W2K and smbclient, Japanese and Cyrillics.
(This used to be commit 83dac6571f)
2004-03-12 14:37:37 +00:00
Alexander Bokovoy
82053806f5 Fix build after Jeremy -- yet another place where convert_string() wasn't updated
(This used to be commit 9acd46ab46)
2004-03-12 12:57:39 +00:00
Alexander Bokovoy
938cef91ff Fix string overflow due to wrong size calculation
(This used to be commit e1d0b8fc7b)
2004-03-12 11:21:50 +00:00
Jeremy Allison
03c0e32c28 Allow msdfs symlink syntax to be more forgiving (it took me ages to remember
what it was :-). Allow msdfs links to now look like UNC paths : eg.
sym_link -> msdfs://server/share/path/in/share
or :
sym_link -> msdfs:\\server\share\path\in\share
Jeremy.
(This used to be commit 2979c3e388)
2004-03-12 01:43:25 +00:00
Jeremy Allison
e3f5b54270 Restore the contract on all convert_stringXX() interfaces. Add a "allow_bad_conv"
boolean parameter that allows broken iconv conversions to work. Gets rid of the
nasty errno checks in mangle_hash2 and check_path_syntax and allows correct
return code checking.
Jeremy.
(This used to be commit 7b96765c23)
2004-03-11 22:48:24 +00:00
Jim McDonough
3d18997afd Get MungedDial actually working with full TS strings in it for pdb_ldap.
I know this isn't pretty, but neither was our assumption that all strings
from the directory fit inside a pstring.  There was no way this worked
before will all versions of usrmgr (for example, the only version of
mine that has the TS Confic button).
(This used to be commit d275c0e384)
2004-03-11 16:32:19 +00:00
Herb Lewis
a26e22edfb add missing #ifdef HAVE_BICONV stuff
(This used to be commit 9ea0560b0b)
2004-03-11 15:12:59 +00:00
Gerald Carter
929b0b72d5 BUG 1088: patch from SATOH Fumiyasu <fumiya@miraclinux.com> -- use strchr_m() for query_host (smbclient -L)
(This used to be commit bc6992c4bf)
2004-03-11 14:39:32 +00:00
Jeremy Allison
f2efeca274 Ensure we use check_path_syntax() to pull out DFS paths.
Jeremy
(This used to be commit 28f1e21c58)
2004-03-11 00:42:33 +00:00
Jeremy Allison
83560bfcfa Fix processing of pathnames with embedded '\\' characters (0x5c) in CP932
character set. Because of the allowing of "broken conversions" for people
who have broken iconv libraries we can't rely on the return from convert_string()
to be valid - we must check errno instead. This is ripe for revisiting at
some stage. I prefer adding a bool parameter to all convert_string_XX varients
to specify if we will allow broken conversions or not. With "allow_broken_conversions"
set to false we could then rely on the return from convert_string rather than
checking errno.
Jeremy.
(This used to be commit 74722f2865)
2004-03-11 00:31:47 +00:00
Herb Lewis
2c2142d9d7 another typo
(This used to be commit e6c2d9a3f7)
2004-03-10 03:08:14 +00:00
Jeremy Allison
2867b9e2a0 Moving towards getting msdfs working again (this looks like it was broken
in 3.0.2a actually). We now send a correct referral back, but the client
refuses to follow it... Not sure why. Will do more tests.. Maybe unicode
character count is wrong (it looks it).
Jeremy.
(This used to be commit e2709f99fc)
2004-03-10 02:38:39 +00:00
Jeremy Allison
ccf93c36d8 Formatting reformat before I start to change anything here.
Jeremy.
(This used to be commit 80fde09fc4)
2004-03-10 01:32:26 +00:00
Herb Lewis
3edf42f921 fix typo for tag in proto file
(This used to be commit 2367d988ae)
2004-03-10 00:53:36 +00:00
Jeremy Allison
46a718189c Fix dfs referrals - don't use check_path_syntax. Also use mb char calls in
dfs code.
Jeremy.
(This used to be commit 42175b4518)
2004-03-09 23:26:58 +00:00
Rafal Szczesniak
addfc95df2 Yet another '\n' termination of debug message.
rafal
(This used to be commit 3e57c2c685)
2004-03-09 21:47:49 +00:00
Rafal Szczesniak
1fabcf0a12 Fix to debug message lacking termination with '\n'.
rafal
(This used to be commit 2a7dd46943)
2004-03-09 18:58:19 +00:00
Gerald Carter
f089f978c2 fix build with gcc 2.96 and --with-developer
(This used to be commit 11fc4da07f)
2004-03-09 15:29:16 +00:00
Andrew Bartlett
32665c36c8 Given how core this code is, I figure it should have it's own testsuite.
Big thanks to tpot and mbp for showing how easy it can be to write a simple
unit test, and for providing the STF.

This also changes the strstr_m() code to use strstr_w() (avoiding
duplication) and fixes it so that it passes the STF.

(We now always restart before doing the unicode run, until sombody can
show me why the testsuite is wrong).

Andrew Bartlett
(This used to be commit a893a324f3)
2004-03-09 11:15:44 +00:00
Andrew Bartlett
151faf6935 JRA's recent strstr_m work really badly broke our string_sub code.
For example:

strstr_m("%v foo bar", "%v") would fail...

only strstr_m("foo %v", "%v") could work.

I wonder what else this broke...

Fix is to move to using strncmp() inside the strstr_m function.

Tested on ASCII only.

Andrew Bartlett
(This used to be commit 44d304f84c)
2004-03-09 09:56:33 +00:00
Jeremy Allison
c9b7cbbfa5 Added strstr_m() function. Use in all places where we might run into mb
(should fix the mb service name problem, can't remember the bugid).
Jeremy.
(This used to be commit 94a272b9a8)
2004-03-09 00:17:14 +00:00
Jeremy Allison
3f14e8eb9d Fix assumption about following directory sep in check_path_syntax(). We
need to try and convert 1 byte, then 2 bytes if that fails. Fixes bug
reported by Simo.
Jeremy.
(This used to be commit 8702d00896)
2004-03-08 21:54:54 +00:00
Volker Lendecke
b3b93aaa3f Get us a little closer to Windows LSA semantics.
A windows DC does not reply to DCNAME\\Administrator, only to
DOMAIN\\Administrator. Fix that.

Without winbind we are wrong as domain members, we should forward the request
DOMAIN\\Username to the DC on behalf of the asking client. Winbind fixes that
nicely.

Volker
(This used to be commit 7ed61edbbe)
2004-03-07 08:22:06 +00:00
Volker Lendecke
6659353bd9 This might not be used a lot and might not survive for long, but at least it
should work as expected :-)

Fix wb_delgrpmember.

Volker
(This used to be commit 9fc0025d12)
2004-03-07 08:16:10 +00:00
Tim Potter
83d4d42462 Fix typo.
(This used to be commit e6e8b59f53)
2004-03-07 01:14:11 +00:00
Tim Potter
5e412188e9 Merge from HEAD.
(This used to be commit 89f3173f4f)
2004-03-07 00:50:37 +00:00
Tim Potter
bc8b6cd9eb Merge from HEAD.
(This used to be commit 1bba071126)
2004-03-07 00:09:36 +00:00
Jeremy Allison
48eb635f31 Several mb tidyups - getting ready to address the XXX_sub function.
Jeremy.
(This used to be commit 92c3ae3458)
2004-03-05 22:32:45 +00:00
Gerald Carter
474758956c BUG 488: fix the 'show client in col 1' button and corrctely enumerate active connections
(This used to be commit d77d38560d)
2004-03-05 18:37:01 +00:00
Gerald Carter
cb49c07c98 fix compiler warning
(This used to be commit df19b6066e)
2004-03-05 17:39:38 +00:00
Jelmer Vernooij
6643781811 Add -O (for writing downloaded files to standard out) based on patch by
Bas van Sisseren <bas@dnd.utwente.nl>
(This used to be commit cc164e5afb)
2004-03-05 17:17:31 +00:00
Jeremy Allison
893d5eba5d all_string_sub() is broken as it doesn't handle mb chars correctly (and
so breaks when substitution '/' and '\'). It's used by unix_clean_name(),
which is used by reduce_name, which is used by check_name() (phew!).
Now that we know all filenames passed to check_name() are in a "good"
format (no double slashes, all '\\' chars translated to '/' etc.) due
to the new check_path_syntax() we can avoid calling reduce_name unless
widelinks are denied. After this check-in I can fix all_string_sub() to
handle mb chars correctly as it won't be in the direct path in the
main path handling code.
Jeremy.
(This used to be commit 6080186fc4)
2004-03-05 01:37:12 +00:00
Jeremy Allison
4020fadb1a Fix my breakage of NT pipes from the previous patch (sorry). Use the
original srvstr_pull_buf() function to get the pipename not srvstr_get_path().
Jeremy.
(This used to be commit 2a263873fd)
2004-03-04 18:55:37 +00:00
Gerald Carter
9b882ce3e5 BUG 1015: patch from jmcd to fix statfs redeclaration of statfs struct on ppc
(This used to be commit fafb243278)
2004-03-04 18:34:45 +00:00
Gerald Carter
7f6d708f86 BUG 1080: fix declaration of SMB_BIG_UINT
(This used to be commit 810bc1e2a0)
2004-03-04 18:17:01 +00:00
Volker Lendecke
51deca6bc9 There's a specific error message NT_STATUS_ALIAS_EXISTS.
(This used to be commit f0d99f318c)
2004-03-04 17:57:21 +00:00
Volker Lendecke
5dc2b72f9b Another typo, sorry for samba-cvs spam :-)
(This used to be commit 3e39d157cb)
2004-03-04 17:51:29 +00:00
Volker Lendecke
869561ad76 Fix typo.
Volker
(This used to be commit 8ba5bdc330)
2004-03-04 17:47:14 +00:00
Jim McDonough
7dc6dd5884 Fix build farm, older compilers won't let you declare variables
right in the middle of the code.

I just love catching jra on stuff like this, after all the crap
I've done. :-)
(This used to be commit dc7dc51758)
2004-03-04 16:24:13 +00:00
Gerald Carter
e7efbb588a BUG 848: don't create winbind local users/groups that already exist in the tdb
(This used to be commit 89da3df07b)
2004-03-04 15:59:11 +00:00
Gerald Carter
43dd09f9da another fix for bug 761; don't default to bsd printing on linux
(This used to be commit d58139d64f)
2004-03-04 15:18:36 +00:00
Jeremy Allison
f0039da196 Added client "hardlink" commant to test doing NT rename with hard links.
Added hardlink_internals() code - UNIX extensions now use this too.
Jeremy.
(This used to be commit aad6eb2240)
2004-03-03 23:14:23 +00:00
Jeremy Allison
fba5a72249 Use a common function to parse all pathnames from the wire. This allows
much closer emulation of Win2k3 error return codes.
Jeremy.
(This used to be commit c9f31fafed)
2004-03-03 20:55:59 +00:00
Jim McDonough
b737769a74 more usrmgr fixes: display lockout timers in minutes, not seconds, for samr 2e
(This used to be commit 832674c099)
2004-03-03 17:44:00 +00:00
Jim McDonough
8d12b8768a quick for for usrmgr. unknown_6 is really max dimension of logon hours array. need to update passdb for this.
(This used to be commit fbf909926b)
2004-03-03 04:23:43 +00:00
Jim McDonough
78b8f3ca0c Merge fields_present function from HEAD. Now, a field will not be updated
on setuserinfo levels which include this field, unless the corresponding
bit (defined in passdb.h) is turned on.  Without this, newer versions
of usrmgr break us pretty bad.
(This used to be commit 840340bd96)
2004-03-02 21:02:09 +00:00
Gerald Carter
08d03a7039 BUG 1129: patch from shiro@miraclelinux.com (Shiro Yamada) to install image files for SWAT
(This used to be commit a01a7fdbd9)
2004-03-02 18:10:12 +00:00
Jeremy Allison
5f4b6ae77a Janitorial duty for tpot - --with-fhs fix.
Jeremy.
(This used to be commit 64eded518b)
2004-03-02 18:07:06 +00:00
Jim McDonough
db61673019 fix typo for callback bit
(This used to be commit 31a15164ff)
2004-03-02 18:04:16 +00:00
Gerald Carter
ef36785beb allow the 'printing' parameter to be set on a per share basis.
The problem was that the current_printif struct was set during
print_backend_init() based on the 'printcap name'.  So you could
not use cups and then override the setting for a specific printer
by setting 'printing = bsd' (a common setup for pdf generation
print services.

There is a subtle change in behavior in that the print
interface functions are selecting on the basis of lp_printing()
and not lp_printcap_name(), but the new behavior seems more
intuitive IMHO.
(This used to be commit 14de9c0657)
2004-03-02 14:26:45 +00:00
Gerald Carter
62a7e258a3 BUG 761: read the config file before initialized default values for printing options
(This used to be commit d358f72974)
2004-03-02 04:09:39 +00:00
Gerald Carter
659d6a2b61 BUG 692: patch from SATOH Fumiyasu <fumiya@miraclelinux.com> to correct truncation of share names and workgroup names
(This used to be commit 822e31d841)
2004-03-01 17:40:40 +00:00
Gerald Carter
1fe6e29637 BUG 1147; bad pointer case in get_stored_queue_info() causing seg fault
(This used to be commit 91af1fb73a)
2004-03-01 17:03:05 +00:00
Volker Lendecke
c4877403a0 net_rpc.c: Don't complain if [add|del]mem was successful.
srv_samr_nt.c: Correctly report that a user is not member of an alias.

Volker
(This used to be commit 540f625036)
2004-02-29 16:34:33 +00:00
Volker Lendecke
efd357b732 Print an informative error message if trying to add/remove members from
something not a group.

Volker
(This used to be commit 73f26de5c0)
2004-02-29 12:47:45 +00:00
Volker Lendecke
a92de03d9e Add 'net rpc group [add|del]mem' for domain groups and aliases.
Volker
(This used to be commit e597420421)
2004-02-28 18:41:16 +00:00
Volker Lendecke
0e2de3d27e Fix my fix to net rpc group list. We can certainly have more than a single
set of groups.

Volker
(This used to be commit e77fe4a77a)
2004-02-28 08:18:09 +00:00
Jeremy Allison
3fb52e5cc0 Can't set allocation size on directories, return correct error code on
fail if file exists and target is a directory. gentest.
Jeremy.
(This used to be commit f4a7ea6dc2)
2004-02-28 01:53:30 +00:00
Jeremy Allison
3c1d00d12a More gentest fixes. Fix up regression in IS_NAME_VALID and renames.
Jeremy.
(This used to be commit 367f5c3bc2)
2004-02-28 00:56:42 +00:00
Rafal Szczesniak
c0b23c6c8c Added copyrights I forgot about looong ago...
rafal
(This used to be commit 33d1e2dd63)
2004-02-27 22:15:38 +00:00
Tim Potter
9d3529105e Fix for writable printerdata problem - bugzilla #1112.
(This used to be commit a05b9f0cc5)
2004-02-26 23:04:11 +00:00
Volker Lendecke
e1190848a1 That const was one too many
(This used to be commit 005d92d57e)
2004-02-26 14:34:44 +00:00
Volker Lendecke
d9819ec090 Implement 'net groupmap set' and 'net groupmap cleanup'.
I was rather annoyed by the net groupmap syntax, I could never get it
right.

net groupmap set "domain admins" domadm

creates a mapping,

net groupmap set "domain admins" -C "Comment" -N "newntname"

should also do what you expect. I'd like to have some feedback on the usability
of this.

net groupmap cleanup

solves a problem I've had two times now: Our SID changed, and a user's primary
group was mapped to a SID that is not ours. net groupmap cleanup removes all
mappings that are not from our domain sid.

Volker
(This used to be commit eb4d4faff8)
2004-02-26 11:29:56 +00:00
Volker Lendecke
e692b991d1 And another little const
(This used to be commit f6bb3304fc)
2004-02-26 11:07:06 +00:00
Volker Lendecke
0689a2630d Apply some const
Volker
(This used to be commit 0b29d83d33)
2004-02-26 10:55:43 +00:00
Steve French
a3425dad72 Fixes to minor security bug pointed out by AB in the mount helper
(This used to be commit b83802c5a1)
2004-02-26 06:42:51 +00:00
Andrew Tridgell
79d5739893 fixed compilation with --enable-dmalloc
the macro redefinition of free() means we cannot have a structure
element called "free"
(This used to be commit d2d653a1a6)
2004-02-26 02:11:31 +00:00
Jeremy Allison
863c784ef4 Merging Richard's rename test.
Jeremy.
(This used to be commit 5646b6c989)
2004-02-26 01:33:35 +00:00
Jeremy Allison
fa81d1d7e7 Interesting fact found by IFSTEST /t LockOverlappedTest...
Even if it's our own lock context, we need to wait here as
there may be an unlock on the way.
So I removed a "&& !my_lock_ctx" from the following
if statement.

if ((lock_timeout != 0) && lp_blocking_locks(SNUM(conn)) && ERROR_WAS_LOCK_DENIED(status)) {

Jeremy.
(This used to be commit 3f35e3975f)
2004-02-26 01:31:10 +00:00
Andrew Bartlett
9e2a098a0a Fix bug in previous global_sam_sid() commit. I broke the 'read from
MACHINE.SID' file functionality.

Also, before we print out the results of 'net getlocalsid' and 'net
getdomainsid', ensure we have tried to read that file, or have
generated one.

Andrew Bartlett
(This used to be commit 191b43159e)
2004-02-25 23:12:29 +00:00
Andrew Bartlett
56bd63b1cd I *hate* global variables...
OK, what was happening here was that we would invalidate global_sam_sid
when we set the sid into secrets.tdb, to force a re-read.

The problem was, we would do *two* writes into the TDB, and the second one
(in the PDC/BDC case) would be of a NULL pointer.  This caused smbd startups
to fail, on a blank TDB.

By using a local variable in the pdb_generate_sam_sid() code, we avoid this
particular trap.

I've also added better debugging for the case where this all matters, which
is particularly for LDAP, where it finds out a domain SID from the sambaDomain
object.

Andrew Bartlett
(This used to be commit 86ad04d26d)
2004-02-25 22:01:02 +00:00
Jeremy Allison
fd6b9c02b9 Fixup strange rename error case (gentest).
Jeremy.
(This used to be commit d448fb801e)
2004-02-25 21:37:22 +00:00
Jim McDonough
af6f7254a9 Do the query part of the previous fix...reset time and duration are set in minutes, not seconds. Works from usrmgr.
(This used to be commit 98833a82fa)
2004-02-25 20:02:47 +00:00
Jim McDonough
8ccdcb3f1c reset time and duration are set in minutes, not seconds. Works from usrmgr.
(This used to be commit 700049d9ef)
2004-02-25 15:02:55 +00:00
Jeremy Allison
a45d29049b Figured out a new flags bit with gentest and ethereal....
Jeremy.
(This used to be commit b4b684f115)
2004-02-25 02:15:34 +00:00
Jeremy Allison
1d9f07735c More gentest fun :-). NB. I'm not fixing OpenX breakage 'cos if you look
at what W2K3 accepts here it's COMPLETELY BROKEN ! :-).
Jeremy.
(This used to be commit 5107f6ee70)
2004-02-25 01:35:14 +00:00
Jeremy Allison
01cb68643c More gentest fixes.
Jeremy.
(This used to be commit d34785194c)
2004-02-25 00:48:35 +00:00
Volker Lendecke
f934f5d7df Add 'net rpc group add'. For this parse_samr.c had to be changed: The
group_info4 in set_dom_group_info also has the level in the record
itself. This seems not to be an align. Tested with NT4 usrmgr.exe. It can
still create a domain group on a samba machine.

Volker
(This used to be commit 76c75bb8a7)
2004-02-24 18:00:41 +00:00
Volker Lendecke
6d3e45579e Remove unused variable.
Volker
(This used to be commit eece7ff000)
2004-02-24 17:28:17 +00:00
Volker Lendecke
2afb1b60d7 'net idmap restore' is too useful to be left broken :-)
Set the HWM values correctly after having manipulated the tdb.

Volker
(This used to be commit b1eba2188b)
2004-02-24 15:45:10 +00:00
Jeremy Allison
f96e84c682 Ensure '.' and '..' don't match in delete requests.
Jeremy.
(This used to be commit 1b0d54170a)
2004-02-24 01:46:24 +00:00
Jeremy Allison
5447f1f467 More gentest error fixups.
Jeremy.
(This used to be commit 00f71fc836)
2004-02-24 00:55:05 +00:00
Jeremy Allison
69058407ef Fixup bad-path error found by gentest.
Jeremy.
(This used to be commit 63d47f3364)
2004-02-24 00:38:39 +00:00
Jeremy Allison
b88f446352 Added NTrename SMB (0xA5) - how did we miss this.... ?
Jeremy.
(This used to be commit dfd7d1c2b7)
2004-02-24 00:06:08 +00:00
Jeremy Allison
13dd3e60bd Fixup correct timeout values for blocking lock timeouts (tested at connectathon
by Herb).
Jeremy.
(This used to be commit b38b3a5542)
2004-02-24 00:03:18 +00:00
Andrew Bartlett
06549b8886 Found by Fabien Chevalier <fabien.chevalier@supelec.fr> and
JustFillBug <mozbugbox@yahoo.com.au> on the Samba lists - a 'max
password age' of zero should be considered as 'never expire'.

For the timebeing we just set it like -1, but we might revisit this
for closer-to-ms behaviour.

Andrew Bartlett
(This used to be commit 9ffc490fce)
2004-02-23 21:09:09 +00:00
Jeremy Allison
aa4abfb3b5 Fix "unable to initialize" bug when smbd hasn't been run with
new system and a user is being added via pdbedit/smbpasswd.
Found at Connectathon setup.
Jeremy.
(This used to be commit f9c7a42e89)
2004-02-23 20:12:31 +00:00
Jim McDonough
24df38dbc6 Janitor for tpot...bugzilla #1098, msleep already exists on aix
(This used to be commit 4319df7fdc)
2004-02-23 02:54:03 +00:00
Jim McDonough
401959b7d7 Add bad password count/time attributes
(This used to be commit 003318939f)
2004-02-23 02:47:33 +00:00
Jim McDonough
ee5dd175e5 Add calls to password lockout functions. Should now work against tdbsam only.
(This used to be commit 3e8a9c3584)
2004-02-21 17:41:28 +00:00
Tim Potter
37d0cb0b70 printf -> d_printf
Bugzilla #1066.
(This used to be commit 2285ec9737)
2004-02-21 00:28:48 +00:00
Jeremy Allison
ef8f827449 Make SMB_FILE_ACCESS_INFORMATION call work correctly.
Jeremy.
(This used to be commit 0ea0ada6c6)
2004-02-20 23:19:39 +00:00
Jeremy Allison
7d7849b18a Make us bug-for-bug compatible with W2K3 - to get delete on close semantics
on an initial open the desired_access field *must* contain DELETE_ACCESS,
simply having it map from a GENERIC_ALL won't do. Fixes delete on close test.
Jeremy.
(This used to be commit 5c6f8b1053)
2004-02-20 22:45:53 +00:00
Jim McDonough
9264194340 handle both 0 and -1 as disabling reset count and lockout duration
(This used to be commit 84fe24e64e)
2004-02-20 16:00:25 +00:00
Jim McDonough
4a7d90424f Make default lockout duration and reset count time 30 minutes, to match windows, and also be valid (0 was invalid)
(This used to be commit 7ff42fffb2)
2004-02-20 15:59:05 +00:00
Gerald Carter
8adb394ee6 just say no to crack
(This used to be commit 66be4492aa)
2004-02-20 15:52:14 +00:00
Gerald Carter
11bf157469 <attr/xattr.h> & <sys/xattr.h> are mutually exclusive it seems; fix build on SuSE 8.2
(This used to be commit 34e6c5f8f3)
2004-02-20 15:50:18 +00:00
Jeremy Allison
1bfc09c51c Fixup correct (as per W2K3) returns for lookupsids as well as lookupnames.
Inspired by Volkers patch.
Jeremy.
(This used to be commit a47127e90e)
2004-02-19 23:00:01 +00:00
Gerald Carter
95bc32e93c sys/xattr.h merge from HEAD
(This used to be commit 798dd7299e)
2004-02-19 22:17:54 +00:00
Jim McDonough
5fc9dd0be6 Enable checking/resetting of account lockout and bad password based on policy
(This used to be commit bd2e55399c)
2004-02-19 21:40:22 +00:00
Jim McDonough
222d9a3ce2 Clean up bad pw count and autolock flag update fn()s
(This used to be commit 9a79f9fbcb)
2004-02-19 21:37:24 +00:00
Jim McDonough
e507a83617 Add bad pw count and autolock flag update fn()s
(This used to be commit 600fcd534b)
2004-02-19 18:35:43 +00:00
Jim McDonough
f56317baef Add bad password reset and display of bad password count/time
(This used to be commit 34fe16e445)
2004-02-19 16:00:29 +00:00
Jim McDonough
39a154ae92 Add functions to get/set bad password time
(This used to be commit 557f598c63)
2004-02-19 15:59:35 +00:00
Jim McDonough
955ec7c6e2 Add bad password time fields
(This used to be commit 59e7c3abab)
2004-02-19 15:57:53 +00:00
Jeremy Allison
8eec62ebfb Fix the "too many fcntl locks" scalability problem raised by tridge.
I've now tested this in daemon mode and also on xinetd and I'm pretty
sure it's working.
Jeremy.
(This used to be commit 14dee03801)
2004-02-19 01:55:24 +00:00
Steve French
5e39e9f313 Fix incorrect strnicmp len
(This used to be commit ad1ebb5000)
2004-02-17 22:51:42 +00:00
Jeremy Allison
8801465d30 Fix based on Volker's code to correctly return code from lsa_lookup_sids
on unmapped sids.
Jeremy.
(This used to be commit 37a52c3168)
2004-02-17 22:46:25 +00:00
Steve French
d5ad8c5099 Disable dev (MS_NODEV) on user mounts from cifs vfs
(This used to be commit 9b0d1072bc)
2004-02-17 21:31:25 +00:00
Volker Lendecke
8f3507338e When creating a group via a script, don't let winbind do it as well.
Volker
(This used to be commit 6a229f1488)
2004-02-17 21:25:42 +00:00
Volker Lendecke
34a9928ee1 Be able to set alias info for builtin as well.
Volker
(This used to be commit 7a947ecdf5)
2004-02-17 15:54:57 +00:00
Volker Lendecke
96a5c5e38c Don't try to show groups that could not be listed.
Volker
(This used to be commit d713e76a24)
2004-02-17 15:24:28 +00:00
Volker Lendecke
07892673ff In samr_lookup_names Windows does not return WKN_GRP(5) but ALIAS(4) when
you search in BUILTIN. Match that.

Volker
(This used to be commit 2863b21d8a)
2004-02-17 10:11:53 +00:00
Volker Lendecke
6b7e509004 If there are no alias members, don't ask for their sids :-)
Volker
(This used to be commit 99f03a641e)
2004-02-17 10:08:18 +00:00
Steve French
269082724a Disable suid on user mounts (can override with -DCIFS_ALLOW_USR_SUID)
(This used to be commit a718f16e0b)
2004-02-16 23:43:14 +00:00
Volker Lendecke
d2742ac2fc Cosmetic fix: Use sid_is_in_our_domain instead of doing it per hand.
Volker
(This used to be commit 04639e8862)
2004-02-16 14:24:35 +00:00
Volker Lendecke
f570f879bb Fix success message for net groupmap modify
Volker
(This used to be commit 19b30334a7)
2004-02-16 14:04:56 +00:00
Jeremy Allison
142ef0e829 Missed SAFE_FREE (typo).
Jeremy.
(This used to be commit ac1d03c05b)
2004-02-13 22:34:29 +00:00
Jelmer Vernooij
91cc4a1900 Fix ETA Calculation when resuming
(This used to be commit a5f09f0991)
2004-02-13 22:09:53 +00:00
Jeremy Allison
e3d755c5b2 Added Andrew Bartlett's patch to use an allocated buffer for count_chars.
Jeremy.
(This used to be commit cdbeb7d2eb)
2004-02-13 22:06:25 +00:00
Jeremy Allison
b545a8de0a Fixup the 'multiple-vuids' bugs.
Jeremy.
(This used to be commit f0f7a48327)
2004-02-13 19:05:25 +00:00
Gerald Carter
663f07d63b urban's changes for nosuid,nodev
(This used to be commit ed46d9aef3)
2004-02-13 17:32:20 +00:00
Jim McDonough
d21f23e01f Move tdbsam versioning/upgrade code into 3.0
(This used to be commit 730c07cac2)
2004-02-13 14:48:20 +00:00
Herb Lewis
727bc707b6 merge old change from 2.2 branch to give legend in heading
(This used to be commit ed4af810cf)
2004-02-12 20:43:23 +00:00
Jim McDonough
041f03151c Try to remove the last vestiges of unknown_3...
Jelmer, can you look at the sql and xml backends please to verify?
(This used to be commit b7706f7e25)
2004-02-12 19:09:21 +00:00
Gerald Carter
eaece3bbe6 abartlet's pdb_set/changed flag fix for NULL passwords
(This used to be commit cfe80f0df7)
2004-02-12 17:51:23 +00:00
Richard Sharpe
db40d06dd4 Commit Andrew Bartlett's interesting patch to smbclient that allows for
multiple logins and changing vuids. I fixed up a couple of variables so it
actually works.

We want to use this to test our multiple SIDs in the kernel changes etc.
(This used to be commit 4df824d38b)
2004-02-12 17:26:34 +00:00
Gerald Carter
b6a320bdc1 stupid cut-n=paste error; my fault
(This used to be commit ee8f142b87)
2004-02-12 17:09:01 +00:00
Jim McDonough
1fa1e931a3 More sync between passdb on 3.0 and HEAD.
Replace unknown_3 with fields_present.  Also causes rpc_samr structure field changes.
(This used to be commit 1976843345)
2004-02-12 16:16:53 +00:00
Jim McDonough
34232f9ec0 Start of merging HEAD changes. Right now, just move one fn() to eliminate
the prototype at the beginning, and change some comments so diffs to HEAD
aren't filled with useless info.
(This used to be commit 7b40f6c464)
2004-02-12 15:20:40 +00:00
Gerald Carter
c987e9e611 fix build of lock tests
(This used to be commit 70cc747fdf)
2004-02-12 05:29:05 +00:00
Gerald Carter
df6d2db4ce merge from old APP_HEAD
* remove corrupt tdb and shutdown (only for printing tdbs, connections,
  sessionid & locking)
* decrement smbd counter in connections.tdb in smb_panic()
* various Makefile hack to get things to link

'max smbd processes' looks like it might be broken.  The counter KEY is not
being set.  Will look into that tomorrow.
(This used to be commit 6e22c5da92)
2004-02-12 05:24:02 +00:00
Gerald Carter
a6a2a69680 updates for tdbsam code to help make merge into head easier; needs a bit more testing tomorrow but initial results seem ok
(This used to be commit daee8d7fee)
2004-02-12 05:07:44 +00:00
Jeremy Allison
9860bfe384 More paranoia checks.
Jeremy.
(This used to be commit adf8ee3df7)
2004-02-11 23:25:51 +00:00
Steve French
e7a09dd637 Update mount.cifs version to 1.1
(This used to be commit e73b6a5ae5)
2004-02-11 23:14:39 +00:00
Steve French
70fde6311d Mount helper fixes for nosetuid, noexec part two of two
(This used to be commit c2b4d81a8d)
2004-02-11 23:11:00 +00:00
Steve French
33b944911f Add missing nosetuid and noexec options
(This used to be commit 5bb6429cc4)
2004-02-11 22:54:01 +00:00
Jeremy Allison
16733020e3 Don't set an iterator to a piece of free'd memory, store it first.
Jeremy.
(This used to be commit e914230a2d)
2004-02-11 22:47:12 +00:00
Gerald Carter
3cd61b1597 BUG 900: TAKEDA yasuma <yasuma@miraclelinux.com; fix token processing in cmd_symlink, cmd_link, cmd_chown, cmd_chmod functions
(This used to be commit 60eb69ff64)
2004-02-11 21:42:20 +00:00
Gerald Carter
da52004988 fix set/getsampwent iterator in tdbsam to use an allocated list
(This used to be commit 8734d91cd7)
2004-02-11 21:10:04 +00:00
Jeremy Allison
9870830104 Paranoia fixes :-).
Jeremy.
(This used to be commit 86b030197d)
2004-02-11 19:59:17 +00:00
Jeremy Allison
90b5adc557 Added James Peach's fix for #1038.
Jeremy.
(This used to be commit 5379ad9824)
2004-02-11 19:07:02 +00:00
Gerald Carter
439bcaf9e7 BUG 1055; patch from SATOH Fumiyasu <fumiya@miraclelinux.com>; formatting fixes for 'net share'
(This used to be commit 44db163b30)
2004-02-11 14:59:08 +00:00
Gerald Carter
00e0a5ca90 marking 'only user' as deprecated (based on feedback in bug 66)
(This used to be commit a44f67b141)
2004-02-11 04:32:12 +00:00
Gerald Carter
45616e18a8 more fixes from the static changes; please move static functions to the top of files to prevent this from happening
(This used to be commit 7a61c2ae45)
2004-02-10 04:02:53 +00:00
Gerald Carter
19b8f496f8 fix more compiler warning after the latest static rampage
(This used to be commit 4f97988dd6)
2004-02-10 03:51:19 +00:00
Jeremy Allison
57dacbe948 Fix for possible crash bug from Sebastian Krahmer (SuSE).
Jeremy.
(This used to be commit e275835b51)
2004-02-10 02:21:38 +00:00
Gerald Carter
53f924e267 add smbget to cvs ignore list
(This used to be commit d85ee7b85b)
2004-02-09 18:51:03 +00:00
Gerald Carter
7da2745bdd bug 1046 (patch from Bostjan Golob <golob@gimb.org>); fix 20 month old bug where getpwent_list() was overoverwriting the username for entries. However the code path to the bug was introduced only on January 25
(This used to be commit ec346adf34)
2004-02-09 18:43:57 +00:00
Volker Lendecke
6268f1bdbc Expand 'net rpc group members' to local groups.
Volker
(This used to be commit 90fabe6ec0)
2004-02-09 18:19:25 +00:00
Volker Lendecke
24f2e0cc3e And another build fix.
Volker
(This used to be commit 6c78a096a5)
2004-02-09 15:21:42 +00:00
Volker Lendecke
42f763e6f0 Fix the build & get rid of a compiler warning.
Volker
(This used to be commit 38c9b775ce)
2004-02-09 14:43:18 +00:00
Tim Potter
cdcec269e0 Apply James' printf format checking patch for SGI MIPSPro compiler.
(This used to be commit 27242f44e6)
2004-02-09 00:59:22 +00:00
Andrew Bartlett
f1429b0edc Add more static...
Andrew Bartlett
(This used to be commit 203ce01836)
2004-02-08 11:28:51 +00:00
Andrew Bartlett
0f1dcf9839 nsswitch/winbindd_util.c:
add static

smbd/uid.c:
	remove unused function

Andrew Bartlett
(This used to be commit ab25af0e18)
2004-02-08 11:26:46 +00:00
Andrew Bartlett
46975eb92f When we set a domain sid, force get_global_sam_sid() to do it's work again.
This should ensure that the value it returns is always consistant.

Andrew Bartlett
(This used to be commit a4392ede33)
2004-02-08 11:05:34 +00:00
Andrew Bartlett
b401888b6b Add static, and assert that we will never overflow the static fstring
in pdb_encode_acct_ctrl()  (All current callers are fine)

Andrew Bartlett
(This used to be commit 01be89eb43)
2004-02-08 11:02:11 +00:00
Andrew Bartlett
8a547323d2 More 'static' work.
Andrew Bartlett
(This used to be commit 25a09004e8)
2004-02-08 11:00:25 +00:00
Andrew Bartlett
784c631a3a Make it possible to 'net rpc samdump' of any domain you are currently joined
to, despite any smb.conf settings.

Work to allow the same for 'net rpc vampire', but instead give a clear
error message on what is incorrect.

Andrew Bartlett
(This used to be commit 6b629344c5)
2004-02-08 10:59:09 +00:00
Andrew Bartlett
62df6251cc Add some help for 'net rpc password'.
Andrew Bartlett
(This used to be commit 4c7d6b9be3)
2004-02-08 09:25:58 +00:00
Andrew Bartlett
d198c55877 Make more functions static, and remove duplication in the use of functions
in lib/smbpasswd.c that were exact duplicates of functions in passdb/passdb.c

(These should perhaps be pulled back out to smbpasswd.c, but that can occour
later).

Andrew Bartlett
(This used to be commit fcdc5efb1e)
2004-02-08 08:38:42 +00:00
Andrew Bartlett
ae2c8656b2 Samba hasn't used this function for ages - it's now handled deep in the
auth subsystem.

Andrew Bartlett
(This used to be commit 5693730594)
2004-02-08 07:17:30 +00:00
Andrew Bartlett
a69cb9c963 Remove more unused portions of the 'password cache'.
Andrew Bartlett
(This used to be commit 318e11748a)
2004-02-08 05:31:01 +00:00
Andrew Bartlett
fac5f989d3 Remove more unused functions - this time parts of the 'password cache'.
Andrew Bartlett
(This used to be commit 66569546e8)
2004-02-08 02:49:30 +00:00
Andrew Bartlett
131bf59694 Another static function.
Andrew Bartlett
(This used to be commit 128c328ddb)
2004-02-08 01:30:59 +00:00
Andrew Bartlett
e0acf3780a Make this table static const.
Andrew Bartlett
(This used to be commit 0686bc9e07)
2004-02-08 01:02:12 +00:00
Andrew Bartlett
7540296fd4 Remove unused utility function.
Andrew Bartlett
(This used to be commit 4c4aa80177)
2004-02-08 00:58:56 +00:00
Andrew Bartlett
e45c217a14 Make get_dc_list static - we only ask for a sorted list externally.
Andrew Bartlett
(This used to be commit e10e176c83)
2004-02-08 00:54:32 +00:00
Andrew Bartlett
d57d2d0897 Bug found by gd - the new range-reterival code did still had 'member'
hardcoded into it.

This didn't matter, as we only use it for 'member' so far...

Andrew Bartlett
(This used to be commit 8621899112)
2004-02-08 00:31:36 +00:00
Andrew Bartlett
7acbbe9ba0 I should have done this years ago...
This adds the very simple 'admin set password' capability to 'net rpc',
much as we have it for 'net ads'.

Andrew Bartlett
(This used to be commit ced7fb5527)
2004-02-07 03:54:39 +00:00
Tim Potter
a13282b690 Replace .po with .@PICSUFFIX@
(This used to be commit b21b36d927)
2004-02-06 01:20:45 +00:00
Jeremy Allison
da371e74bb Fix final valgrind errors with #830. Catch mb conversion error that may not
terminate correctly.
Jeremy.
(This used to be commit 49142c6352)
2004-02-04 20:28:51 +00:00
Gerald Carter
471e558b28 move disabling code to context functions instead of backwards compatible wrappers
(This used to be commit e62ef2ba2d)
2004-02-04 19:46:29 +00:00
Jeremy Allison
ef743c0641 Fixup the allocate version of the function to do "crap" conversions too.
Embarrassing number of goto's in this :-(. Fixes #830 I think.
Jeremy.
(This used to be commit 4c182d3220)
2004-02-04 19:13:45 +00:00
Gerald Carter
c254d4a57d return NSS_SUCCESS if we have found the max number of gids possible on Solaris; patch from John Klinger <john.klinger@lmco.com>
(This used to be commit 28c2a74c85)
2004-02-04 17:22:36 +00:00
Andrew Bartlett
f125759072 Fix const warning
(This used to be commit 7a36cc4ac0)
2004-02-04 11:41:22 +00:00
Andrew Bartlett
ccaf0e7fb1 This should be the correct fix for the lack of a prototype for
remote_password_change().

Sorry for the original bug.

Andrew Bartlett
(This used to be commit 955436a6f6)
2004-02-04 11:12:25 +00:00
Jeremy Allison
39f8afa866 Working on #830. Cope with bad conversions better - don't just memcpy but
try a crap conversion instead. Next this needs to be done to the convert_alloc
function.
Actually fixes some valgrind warnings as well - cool !
Jeremy.
(This used to be commit 6a7919f254)
2004-02-04 02:09:41 +00:00
Jeremy Allison
160d3e2a9c Fix for a bug where the mutex could be left locked. Also remove the
memory keytab code which has no effect. Driven by bug report from
"Rob J. Caskey" <rcaskey@uga.edu>.
Jeremy.
(This used to be commit 4cb8facbf9)
2004-02-03 03:23:18 +00:00
Jeremy Allison
dac4fd693e A few fixes from "L. Lucius" <ib@digicron.com>. Don't use int when it's
really a size_t.
Jeremy.
(This used to be commit 2da24613ed)
2004-02-02 21:14:55 +00:00
Gerald Carter
cf55869f7b fix installmodules problem with make on True64
(This used to be commit ec30303669)
2004-02-02 20:54:14 +00:00
Gerald Carter
7ca6d16605 fix problems with proto.h
(This used to be commit 5a32f9568f)
2004-02-02 20:16:24 +00:00
Andrew Tridgell
7847b611ac there are places in the samba3 code that don't check properly for
packet-termination of strings. This change ensures that when we go
past the end of a packet we hit 2 null bytes, thus terminating. We are
relying on the SAFETY_MARGIN packet allocation stuff here.
(This used to be commit 655ec16828)
2004-02-02 12:09:35 +00:00
Andrew Tridgell
423ad90974 the conversion from int to size_t in charcnv did not take into account
one place where we checked "if (src_len > 0)".

I actually would greatly prefer to switch back to int for src_len. The
type *can* be negative, which means an unsigned type is
inappropriate. There is absolutely no reason why "int" should not be
used for a parameter like this.

I didn't change back to int as we are close to a release and I wanted
a mininal change, but please don't go changing types like this in
future without very careful testing and a damn good reason.

this bug broke pull_ucs2(), I would not be surprised if it caused all
sorts of nastiness. Thanks to vl for noticing the symptoms!
(This used to be commit 8b8f0c5279)
2004-02-02 12:02:43 +00:00
Volker Lendecke
590b60045d Remove bogus check. No functional change, just cosmetics.
Volker
(This used to be commit e3a5e2d9c2)
2004-02-02 07:53:56 +00:00
Andrew Bartlett
c45c03ac89 Always at least try to compile in cracklib support.
Andrew Bartlett
(This used to be commit 6cde5e8307)
2004-02-02 07:47:25 +00:00
Andrew Bartlett
1daa101516 Merge the 'use cracklib' parameter from HEAD back to 3.0
Andrew Bartlett
(This used to be commit 2202667ebb)
2004-02-02 07:45:50 +00:00
Gerald Carter
19cc1a9f20 remerge andrew's cracklib patch from HEAD and fix a compile warnings
(This used to be commit b60f6ec30d)
2004-02-02 00:08:35 +00:00
Tim Potter
4c49368dbc Include sys/acl.h in check for broken nisplus include files. Bug #1025.
(This used to be commit 5ca866f247)
2004-02-01 22:17:36 +00:00
Tim Potter
6d69dd9ae2 Don't log an error in tdb_brlock() if a non-blocking lock returns EAGAIN -
it's supposed to do that.
(This used to be commit 2423a45947)
2004-02-01 10:55:54 +00:00
Gerald Carter
575bc995c0 * BUG 101: patch from j.lu@tiesse.com to set the SV_TYPE_PRINTQ_SERVER;
* don't set the unix_ERR_XX code in mkdir_internal, let the error mapping
  handle it.
(This used to be commit 87343fc15a)
2004-01-31 18:25:57 +00:00
Gerald Carter
aa10de1fe4 cleanup patch for bug 977 so we don't display incorrect debug messages
(This used to be commit 11093ecfb7)
2004-01-31 14:44:27 +00:00
Andrew Bartlett
9751ccf2af If we are setting the NT or LM password to NULL, remove the attribute
rather than writing XXXXX

Andrew Bartlett
(This used to be commit ab7dd748a9)
2004-01-30 23:37:38 +00:00
Jeremy Allison
2f2e5b0191 Fix up name canonicalization (needed for krb5 keytab support later).
Remove source_env handler (no longer used in any codepath).
Jeremy.
(This used to be commit 3a3e336030)
2004-01-30 18:38:48 +00:00
Gerald Carter
3141a26677 disable any account that doesn't have a password and doesn't had the ACB_PWNOTREQ bit set
(This used to be commit 52bf070b10)
2004-01-30 14:59:40 +00:00
Gerald Carter
d4420dc902 more initialization fixes
(This used to be commit 9e590d6035)
2004-01-29 22:16:58 +00:00
Gerald Carter
f5bb18bfcb disable template accounts by default
(This used to be commit 02899224a1)
2004-01-29 20:15:12 +00:00
Gerald Carter
6566a89bee initialization fixes
(This used to be commit 54fd3992c3)
2004-01-29 20:14:50 +00:00
Gerald Carter
cf3bbe7385 removing more unused parameters
(This used to be commit 8135ea08b3)
2004-01-29 17:28:45 +00:00
Gerald Carter
0fa3773bac BUG 570: don't overwrite LDFLAGS; patch from MORIYAMA Masayuki <moriyama@miraclelinux.com>
(This used to be commit d39b1b3fd6)
2004-01-29 14:03:48 +00:00
Andrew Tridgell
a2b533c9f9 completely rewrote the AIX UESS backend (UESS is the AIX equivalent of
NSS). This time I think I've actually got it right. I wrote a fairly
good test suite for UESS modules (similar to nsstest.c) that allowed
me to explore how the modules supplied with AIX actually work.

This new module also incorporates authentication features, so you
don't need a PAM module at all. Just install this UESS module and
authentication will "just work". It also handles password change, so
/usr/bin/passwd can be used to change windows password.
(This used to be commit d62cb9454e)
2004-01-29 06:14:13 +00:00
Richard Sharpe
a01dfa47de Remove an unused parameter from reload_services_file.
(This used to be commit 0032c3f46a)
2004-01-29 00:10:40 +00:00
Jeremy Allison
a0cefa62e6 Merge of Chris's fix.
Jeremy.
(This used to be commit 1a7714ea32)
2004-01-28 23:41:55 +00:00
Gerald Carter
41ab2cebcc forgotten commit -- version == 3.0.3pre1
(This used to be commit 043a81b94d)
2004-01-27 19:00:06 +00:00
Gerald Carter
727afa9e1f prepping the SAMBA_3_0 branch for 3.0.3 work
(This used to be commit 50f278ddcc)
2004-01-27 15:29:30 +00:00
Gerald Carter
f104d75026 bug 977 - don't create a homes share for a user if a static share already exists by the same name
(This used to be commit 6b89a76aa7)
2004-01-27 15:28:33 +00:00
Andrew Bartlett
e2d301accf Clarify comment on set_effective_uid()
Andrew Bartlett
(This used to be commit ca24ae50ea)
2004-01-27 10:01:30 +00:00
Andrew Bartlett
36abff1609 Revise our server-side password change code to cope with the various
different feilds that different clients send.  (For example, not all clients
send both password types).

This also cleans up the code to make it clearer what is really going on,
and to make better use of common functions.

Andrew Bartlett
(This used to be commit 934e9f3bd0)
2004-01-26 09:03:09 +00:00
Andrew Bartlett
784b05c489 This adds client-side support for the unicode/SAMR password change scheme.
As well as avoiding DOS charset issues, this scheme returns useful error
codes, that we can map back via the pam interface.

This patch also cleans up the interfaces used for password buffers, to
avoid duplication of code.

Andrew Bartlett
(This used to be commit 2a2b1f0c87)
2004-01-26 08:45:02 +00:00
Andrew Bartlett
8be4584979 Add a few more NTSTATUS <=> PAM error mappings.
Andrew Bartlett
(This used to be commit 7495cafd42)
2004-01-26 08:38:34 +00:00
Andrew Bartlett
c26e4057ae Patch by Luca Bolcioni <Luca.Bolcioni@yacme.com>. Ensure we always
initialise the session key.  Fixes segfaults with security=server, and
encrypt passwords = no.

Andrew Bartlett
(This used to be commit 493ac5ce98)
2004-01-26 02:19:44 +00:00
Volker Lendecke
7ff912521a Fix memleak just introduced. Thanks to abartlet :-)
Volker
(This used to be commit be485eea81)
2004-01-25 10:14:50 +00:00
Volker Lendecke
4d6b478b19 On my SuSE 8.2 (glibc 2.3.2) the getpwnam inside pdb_getsampwnam reset
the surrounding getpwent loop to the first entry. So smbd went into an
endless loop.

Volker
(This used to be commit 1797b16fad)
2004-01-25 10:04:10 +00:00
Andrew Bartlett
b31ec210fc Fix the initialisation vectors for NTLM2, so that they at least make sense,
even if they don't work yet.

Andrew Bartlett
(This used to be commit 636b98dab9)
2004-01-25 01:11:10 +00:00