1
0
mirror of https://github.com/samba-team/samba.git synced 2025-01-20 14:03:59 +03:00

22538 Commits

Author SHA1 Message Date
Michael Adam
41c3ff6e27 r23583: Add a utility function to recursively delete a Registry
key with all its subkeys. (reg_deletekey will refuse to
delete a key with subkeys with WERR_ACCESS_DENIED).

Michael
2007-10-10 12:23:32 -05:00
Günther Deschner
aa3511a5b5 r23582: Fix event based krb5 ticket refreshing in winbindd.
We were incorrectly using the renew_till timestamp instead of the renewed
ticket's endtime to calculate the next refreshing date.

Guenther
2007-10-10 12:23:32 -05:00
Michael Adam
aa702e53a7 r23581: Move regkey_open_onelevel from reg_frontend to reg_api,
where it actually belongs, and make it static.

Michael
2007-10-10 12:23:32 -05:00
Michael Adam
56f82485ec r23579: Up to now, the "allparameters" argument to lp_next_parameter was
not effective for the global section (snum < 0). This checkin
makes it effective for the global section, too.

This does not produce changes in the results of the present calls of
lp_next_parameter: Beside the new use in utils/net_conf.c (which is
hereby fixed), the only calls of lp_next_parameter are in web/swat.c,
where it is effectively always called with allparameters == 1.

Michael
2007-10-10 12:23:32 -05:00
Michael Adam
0c9cb69b45 r23578: When calling DeleteKey for a key that has subkey(s), Windows
returns WERR_ACCESS_DENIED. This adapts reg_deletekey to behave
the same way.

Michael
2007-10-10 12:23:32 -05:00
Jeremy Allison
e076dc1646 r23577: Fix winbindd (sorry). Ensure I set the new child_pid
variable at the correct point just before the write
call is scheduled.
Jeremy.
2007-10-10 12:23:31 -05:00
James Peach
8f6cf4b8c2 r23576: Fix some confusion between HAVE_BROKEN_GETGROUPS and USE_BSD_SETGROUPS. 2007-10-10 12:23:31 -05:00
Michael Adam
235a5ae4cd r23575: Fix a segfault when lp_load is called before init_registry.
Michael
2007-10-10 12:23:31 -05:00
Jeremy Allison
f075620d20 r23574: Remove double-null check (I hate people bitching at me
on the lists :-).
Jeremy.
2007-10-10 12:23:31 -05:00
Jeremy Allison
c366df2fe7 r23573: Cope with terminating winbindd children on read/write/timeout
communication failures. Set timeout to 5 mins. Ensure that
we're terminating the correct child (the one we thought we
were talking to). Still setting up my testing environment
but I have high hopes for this being the fix for the 3.0.25b
showstopper.
Jeremy.
2007-10-10 12:23:31 -05:00
Jeremy Allison
0f10d2ed31 r23572: Ensure we obey Unicode consortium restrictions. Code
based on patch from MORIYAMA Masayuki <moriyama@miraclelinux.com>.
Jeremy.
2007-10-10 12:23:31 -05:00
Simo Sorce
d2846e6b90 r23571: Fix, parsing of multi byte share names.
Thanks to SATOH Fumiyasu
Fixes 4720

Jerry,
this is a showstopper for 3.0.25b, please grab it into
SAMBA_3_0_RELEASE before cuting the tarballs.

Simo.
2007-10-10 12:23:30 -05:00
Günther Deschner
27fdf995d1 r23569: Also dump fd_event in dump_event_list().
Guenther
2007-10-10 12:23:30 -05:00
Günther Deschner
7514a370ca r23568: Remove last traces of Heimdal KCM support (and don't misuse wbinfo where a
torture test would be much more appropriate). Fix #4408.

Guenther
2007-10-10 12:23:30 -05:00
Volker Lendecke
f2050f5a3a r23567: Fix bug 4721 2007-10-10 12:23:30 -05:00
Michael Adam
4b5d9b2ba7 r23566: Fix the sys_bsd_setgroups function. The actual workaround was inactive.
Michael
2007-10-10 12:23:30 -05:00
Günther Deschner
5456ea59ba r23565: Avoid double NULL pointer checks.
Guenther
2007-10-10 12:23:30 -05:00
Günther Deschner
2592e68a43 r23564: Handle MSG_DUMP_EVENT_LIST only in winbindd for now.
Guenther
2007-10-10 12:23:29 -05:00
Günther Deschner
0d956a8e45 r23563: Add dump-event-list command to smbcontrol.
Guenther
2007-10-10 12:23:29 -05:00
Günther Deschner
4e1e697ac4 r23562: Add dump_event_list() for debugging the event list.
Guenther
2007-10-10 12:23:29 -05:00
Jeremy Allison
3f70c1b105 r23556: Fix for error path from Atsushi Nakabayashi <nakabayashi@miraclelinux.com>.
Jeremy.
2007-10-10 12:23:28 -05:00
Jeremy Allison
dc287adff2 r23555: Fix some uninitialiazed variable uses.
Jeremy
2007-10-10 12:23:28 -05:00
Jeremy Allison
073fdc5a58 r23554: Fix bug #4711 by makeing cli_connect return an NTSTATUS.
Long overdue fix....
Jeremy.
2007-10-10 12:23:28 -05:00
Michael Adam
3695a66166 r23553: Also ignore "lock directory" in registry global options.
Michael
2007-10-10 12:23:28 -05:00
Michael Adam
a4714b3428 r23552: Use proper comparison function an fix logic.
Michael
2007-10-10 12:23:28 -05:00
Jeremy Allison
1e66a8340e r23550: Add more UNIX error -> NT status mappings.
Jeremy.
2007-10-10 12:23:27 -05:00
Michael Adam
41a8f8ec5f r23549: Make "net conf setparm" always use registry data type "sz".
This simplifies the usage of this command from
"net conf setparm <section> <param> <type> <value>"
to
"net conf setparm <section> <param> <value>".

Micheal
2007-10-10 12:23:27 -05:00
Michael Adam
73e41c1d0a r23548: Fix comments.
Michael
2007-10-10 12:23:27 -05:00
Michael Adam
f0992c0d79 r23547: Ignore parameter "include" in regsitry globals.
Michael
2007-10-10 12:23:27 -05:00
Michael Adam
ec22c30581 r23543: Adjust comments. 2007-10-10 12:23:27 -05:00
James Peach
1d941961e0 r23541: Linking the LSA pipe module only once is probably enough. 2007-10-10 12:23:27 -05:00
Kai Blin
13c6eacff0 r23539: Remove code duplication and unify behaviour of winbind_nss_*.h files 2007-10-10 12:23:26 -05:00
Volker Lendecke
48cdafc10a r23538: Fix for wild-card rename: We can't return directly on error, we need to
CloseDir.
2007-10-10 12:23:26 -05:00
Volker Lendecke
6affd7818f r23537: Revert the inbuf/outbuf part of r23528: This caused the Solaris CC make test
to break. The Solaris CC put the static char InBuffer[TOTAL_BUFFER_SIZE] on an
odd address, the malloc'ed one is always aligned. The problem showed up in
pull_ucs2, ucs2_align uses the address of InBuffer as an indication whether to
bump up the src of the string by one. Unfortunately in the trans calls the
data portion is malloced and thus has different alignment guarantees than a
static variable. This one is bigger....

Volker
2007-10-10 12:23:26 -05:00
Michael Adam
d90aa8368a r23536: Fix a typo. James: Please check!
Michael
2007-10-10 12:23:26 -05:00
Jeremy Allison
80d1da7e6c r23530: Fix bugs #4678 and #4697 which had the same root cause.
In make_server_info_pw() we assign a user SID in our
authoritative SAM, even though this may be from a
pure "Unix User" that doesn't exist in the SAM.
This causes lookups on "[in]valid users" to fail as they
will lookup this name as a "Unix User" SID to check against
the user token. Fix this by adding the "Unix User"\unix_username
SID to the sid array. The correct fix should probably be
changing the server_info->sam_account user SID to be a
S-1-22 Unix SID, but this might break old configs where
plaintext passwords were used with no SAM backend.
Jeremy
2007-10-10 12:23:26 -05:00
Volker Lendecke
009af09099 r23528: Two changes to make the valgrind massif (heap profiler) output readable:
Remove the allocated inbuf/output. In async I/O we copy the buffers
explicitly now, so NewInBuffer is called exactly once. This does not
reduce memory footprint, but removes one of the larger chunks that
clobber the rest of the massif output

In getgroups_unix_user on Linux 2.6 we allocated 64k groups x 4 bytes
per group x 2 (once in the routine itself and once in libc) = 512k just
to throw it away directly again. This reduces it do a more typical limit
of 32 groups per user. We certainly cope with overflow fine if 32 is not
enough. Not 100% sure about this one, a DEVELOPER only thing?
2007-10-10 12:23:26 -05:00
Simo Sorce
9dcbef9615 r23527: Use existing escaping function pointed by James 2007-10-10 12:23:25 -05:00
Simo Sorce
3635b30415 r23525: I believe this patch is ok, got no reply of it being not ok.
This closes #4624 for me.
2007-10-10 12:23:25 -05:00
Simo Sorce
54ca011212 r23524: Fix bug 2319.
Got report this is all ok form a tester. Close a loong
standing bug preventing people to freely use any character
in their password when printing via cups were involved.
2007-10-10 12:23:25 -05:00
Volker Lendecke
1a45ea28ce r23523: Gaa -- had renamed "name" to "path" and apparently not compiled after
that....

Volker
2007-10-10 12:23:25 -05:00
Volker Lendecke
34a13c82a3 r23522: Save us a kilobyte stack space in a hot code path: I can't see a reason
why check_path_syntax should not be able to run in-line. The destination
pointer either walks side by side with the source pointer or is
decremented. So as far as I can see s>=d is true throughout the whole
routine.

Jeremy, I'm checking this only into 3_0 for now. Please review and ack
or directly merge this to 3_0_26.

Thanks,

Volker
2007-10-10 12:23:25 -05:00
Volker Lendecke
e6e5703658 r23518: Remove the silly assumption that string_replace requires a pstring.
Jeremy, I am always very confused about the different length arguments
in convert_string and friends. Can you take a look at the change in
string_replace and verify it's ok? Thanks!

While at it, remove the pstring limit for strhasupper and strhaslower.
2007-10-10 12:23:25 -05:00
Volker Lendecke
aa16d8a649 r23517: After Jeremy has given is ack on irc:
Change rename_internals to open the file/directory and then call
rename_internals_fsp. Two reasons: Remove code duplication and remove a
race condition. The race condition was due to the fact that in
can_rename the share mode check closed the file and then after that did
the rename.
2007-10-10 12:23:24 -05:00
Jeremy Allison
cbf0829abc r23516: Fix bug found & fixed by Doug Rudoff (doug_rudoff@isilon.com)
- when cleaning up invalid locks make sure we mark the lck
struct as modified so it'll get saved back correctly (that
was the original intent).
Jeremy.
2007-10-10 12:23:24 -05:00
Jeremy Allison
5b2836e2d5 r23515: Ensure status isn't used uninitialized.
Jeremy.
2007-10-10 12:23:24 -05:00
Jeremy Allison
03763bc528 r23514: Remove unused function ads_get_dn_from_extended_dn().
Jeremy.
2007-10-10 12:23:24 -05:00
Jeremy Allison
fca5637dc6 r23513: Fix one more use of VALUE_PREFIX.
Jeremy.
2007-10-10 12:23:24 -05:00
Jeremy Allison
7885b68bb5 r23512: Fix conflict in #define for SECDESC_PREFIX. Ensure all
reg #defines use "REG_" prefix. Michael - please check
gcc warnings on compiles.
Jeremy.
2007-10-10 12:23:23 -05:00
James Peach
171dc060e2 r23510: Tidy calls to smb_panic by removing trailing newlines. Print the
failed expression in SMB_ASSERT.
2007-10-10 12:23:23 -05:00