1
0
mirror of https://github.com/samba-team/samba.git synced 2025-01-06 13:18:07 +03:00
Commit Graph

1507 Commits

Author SHA1 Message Date
Martin Pool
921e569ed5 Add a comment about the meaning of samba's internal character set and
how this interacts with it.
(This used to be commit eb876ee9cf)
2003-02-28 03:51:25 +00:00
Gerald Carter
97e7d2ffae additional fix for CR 601
* distinguish WinXP from Win2k
  * add a 1/3 of a second delay in OpenPrinter
    in order to trigger a LAN/WAN optimization in
    2k clients.
(This used to be commit 96570699d1)
2003-02-27 21:21:02 +00:00
Martin Pool
5c82d3f00a Doxygen janitor
(This used to be commit 67bf36c69d)
2003-02-27 05:53:25 +00:00
Jelmer Vernooij
d21b15ff57 - Rename 'modules = ' to 'preload modules = '
- Add smb_probe_module()
- Add init_modules()
- Call these functions
(This used to be commit f8f2165322)
2003-02-27 01:54:41 +00:00
Martin Pool
f7bb698298 init_valid_table: Fix a memory leak that would lose the
dynamically-created valid table every time the configuration was
reloaded.
(This used to be commit e42b237d98)
2003-02-26 06:19:16 +00:00
Andrew Bartlett
426cd68f74 Move off-by-one buggy malloc()/safe_strcpy() combination to strdup() instead.
Andrew Bartlett
(This used to be commit c26881633d)
2003-02-24 11:23:15 +00:00
Martin Pool
5b5453e6c7 Merge documentation from 3_0.
(This used to be commit 5002555a97)
2003-02-24 04:42:24 +00:00
Andrew Bartlett
ded88da1ea Add const
(This used to be commit ffaa608be0)
2003-02-24 02:11:32 +00:00
Andrew Bartlett
e68684aa65 Fix 2 off-by-one bugs in the use of malloc()ed strings and safe_strcpy().
safe_strcpy() isn't particularly safe (this has been noted before) as it does
not take the size of the buffer, but instead the size of the buffer *minus 1*

The locking.c fix was causing segfaults on machines running with
--enable-developer, and was tracked down thanks to the fact that vance's build
farm machine runs with such an option, and smbtorture's DIR1 test hits this
bug very well.

(The --enable-developer code writes to the last byte of the string, to check
for incorrect use of safe_strcpy()).

Andrew Bartlett
(This used to be commit e908fd164d)
2003-02-24 01:13:31 +00:00
Simo Sorce
bfc5f0ba8e move genparser to use talloc contexts instead of [m|c|re]alloc() and free()s
(This used to be commit 70fce680c0)
2003-02-23 17:40:43 +00:00
Andrew Bartlett
7e110f782a More signed/unsigned fixes (yes, I run with funny compiler options) and
make x_fwrite() match fwrite() in returning a size_t.

Andrew Bartlett
(This used to be commit 2943c69578)
2003-02-22 12:22:06 +00:00
Martin Pool
1fc2976e14 Doxygen janitor
(This used to be commit 3679975629)
2003-02-21 03:05:55 +00:00
Jelmer Vernooij
8d8a8c9633 Make init_module() and thus smb_load_module() return an int.
modules/developer.c: init_module() should return an int
(This used to be commit 7f59703550)
2003-02-20 22:26:28 +00:00
Andrew Bartlett
1f1125577c Move to a in-memory ccache for winbind, and replace setenv() properly.
(According to the manpages, you cannot put a stack variable into putenv()).

Yes, this leaks memory.

Andrew Bartlett
(This used to be commit 50bced1e26)
2003-02-19 11:33:35 +00:00
Jim McDonough
a0913929ef base64_decode() with heimdal libs, so I've renamed it base64_decode_inplace().
(This used to be commit 8c69212eeb)
2003-02-19 00:27:38 +00:00
Jeremy Allison
fb8d1412e1 Ensure we use getgrnam() unless BROKEN_GETGRNAM is defined. I now need
to set this for Tru64.
Jeremy.
(This used to be commit e7c4616c45)
2003-02-18 04:49:31 +00:00
Martin Pool
097bf66f71 Remove obsolete comment.
(This used to be commit e22465749d)
2003-02-18 02:01:38 +00:00
Martin Pool
54a09519a4 Doxygen janitor and some doc typo fixes.
(This used to be commit 82414706e6)
2003-02-18 00:52:42 +00:00
Martin Pool
5a35b2138e Doxygen janitor. No other changes.
(This used to be commit fa38e7956c)
2003-02-18 00:41:13 +00:00
Martin Pool
789780275c Add comment explaining the -DDEVELOPER safe_strcpy overflow hack.
(This used to be commit 90e1d8bdfa)
2003-02-17 23:33:55 +00:00
Andrew Bartlett
bc8c03b662 This is a very nice way to detect pstrcpy() into a malloc()ed string, but
it really is a developer hack...

Andrew Bartlett
(This used to be commit 3588ebb35b)
2003-02-17 12:33:24 +00:00
Andrew Bartlett
cc0202884b This patch fixes one of my longest-standing pet hates with Samba :-).
When we look see if a user is in a list, and we try to 'expand' an @group, we
should lookup the user's own list of groups, rather than looking for all the
members of a group.

I'm sure this will fix some nasty performance issues, particularly on large
domains etc.  In particular, this avoids contacting winbind at all, if the
group is not a winbind group.

(This caused a deadlock on my winbind-on-PDC setup).

The groups list always includes the user's primary group, as per the
getgrouplist manpage, and my recent changes to our implementation.

Andrew Bartlett
(This used to be commit 9be21976f7)
2003-02-17 12:27:34 +00:00
Andrew Bartlett
e33551bc0c Set the length back to zero when we free the data_blob.
(This used to be commit 4560594a67)
2003-02-17 12:19:12 +00:00
Andrew Bartlett
55da3690b7 Try to make our getgrouplist replacement better match the 'real' implemenations.
In particular, make sure we include the primary gid in the list.

Andrew Bartlett
(This used to be commit 0cd4b339b7)
2003-02-17 12:04:09 +00:00
Jelmer Vernooij
1cf9b9be79 Remove obsolete file lib/netatalk.c - We have a VFS module now
(This used to be commit 28653989cf)
2003-02-15 02:02:51 +00:00
Tim Potter
3b23695db6 Simplify some return values in gencache functions:
-	return ret == 0 ? True : False;
+	return ret == 0;

and

-	return tdb_close(cache) ? False : True;
+	return tdb_close(cache) != -1;
(This used to be commit 026b988b13)
2003-02-14 05:07:05 +00:00
Martin Pool
1f2a901d78 Add FIXME about checking exit code for popen'd commands.
Fix typo.
(This used to be commit 2b5664823e)
2003-02-13 04:46:55 +00:00
Andrew Tridgell
c713b6aaf5 pull_ucs2_talloc() should pull to a char**, not a void**
(This used to be commit 3cf539421f)
2003-02-12 00:39:36 +00:00
Andrew Bartlett
99f9caebe4 One more fix for the difference between FILE and X_FILE.
(This used to be commit 7e56014b28)
2003-02-08 01:00:55 +00:00
Andrew Bartlett
315e4f513b Ensure we don't get problems between FILE and X_FILE buffers - always use the
x_ varient of the command.

Andrew Bartlett
(This used to be commit 6a028507f0)
2003-02-07 23:39:47 +00:00
Jeremy Allison
5bff9ad142 Samba janitor: adding mbp's umask patch :-).
Jeremy.
(This used to be commit babbbd9c65)
2003-02-07 21:59:42 +00:00
Andrew Tridgell
4dc434c804 make sure we don't run over the end of 'name' in unix_convert()
Thanks to Andrew Bartlett for spotting this.
(This used to be commit b4c210ccb0)
2003-02-07 04:01:36 +00:00
Andrew Bartlett
7c1698d302 Bitmap offsets and counts are always positive.
(This used to be commit 8f495e8634)
2003-02-01 06:30:12 +00:00
Andrew Bartlett
c2b134cc3b Always escape ldap filter strings. Escaping code was from pam_ldap, but I'm to
blame for the realloc() stuff.

Plus a couple of minor updates to libads.

Andrew Bartlett
(This used to be commit 34b2e558a4)
2003-02-01 05:20:11 +00:00
Andrew Bartlett
cf4e0982fd Make it clear that the magic value is (size_t)-1.
Andrew Bartlett
(This used to be commit 0676b4e35f)
2003-02-01 04:40:00 +00:00
Jeremy Allison
b102e79e75 Add 3 second timeout when terminating server and sending print notify
messages. Stops build-up of large numbers of smbd's waiting to terminate
on large print throughput.
Jeremy.
(This used to be commit 4ae130bfa8)
2003-01-30 23:55:13 +00:00
Tim Potter
0310697963 Move debug level message handling into debug.c from messages.c
Removed duplicate message_register() for REQ_DEBUGLEVEL message.
(This used to be commit 6fee7196d6)
2003-01-30 04:00:28 +00:00
Tim Potter
ffaaa7a5af Removed duplicate fn to avoid compiler warning.
(This used to be commit 55d268fdd6)
2003-01-29 05:16:16 +00:00
Tim Potter
308efc0337 Return 0 instead of crashing when a NULL source string is passed
to rpcstr_pull()
(This used to be commit b9c4cc1195)
2003-01-29 02:55:39 +00:00
Tim Potter
1394248a10 Quieten debug about gencache.tdb not being able to be opened.
Perhaps we should try to open O_RDONLY if O_RDWR fails?
(This used to be commit 1e7236371d)
2003-01-29 02:54:36 +00:00
Jeremy Allison
012f7aae4e Fix memory leak found my Leo Qiu <leoxqiu@yahoo.com>.
Jeremy.
(This used to be commit af6e4ea640)
2003-01-24 19:20:01 +00:00
Tim Potter
644d31ae25 Merge of max log file fixes from appliance:
- smbd/process.c: check log file sizes more often than in
       timeout_processing()

 - lib/debug.c: increment debug_count inside Debug1() instead of
       when log file sizes are checked.
(This used to be commit 303710c206)
2003-01-23 03:02:08 +00:00
Tim Potter
aeaa901a72 Updated some comments.
(This used to be commit f150af98a7)
2003-01-21 06:30:11 +00:00
Tim Potter
4d3ec0020d Keep the list of dead WINS servers in gencache.tdb instead of in
memory.  This allows the information to be shared amongst all smbd
processes.

HP CR #1099
(This used to be commit 88d977ecce)
2003-01-21 05:05:10 +00:00
Tim Potter
4d6535dc1a Make the valstr and timeout return pointers optional so a caller can
pass NULL if it doesn't care about the gencache key.
(This used to be commit 9ff4fe7e0d)
2003-01-21 05:01:05 +00:00
Jim McDonough
1793c8f143 dlsym() can return NULL validly, so we can't use that as the error test.
dlerror() is the correct way to test.
(This used to be commit 41b1be15ba)
2003-01-17 21:23:14 +00:00
Jim McDonough
9eb368e068 Enable dynamic loading of RPC modules. See docs/textdocs/RPC_PLUGGIN.txt for instructions.
(This used to be commit d51e12df78)
2003-01-17 20:57:26 +00:00
Andrew Tridgell
31482b2c6b fix some undefined behaviour with increments in C. In theory a
compiler could have produced complete crap for this code.
(This used to be commit 0e90da0810)
2003-01-17 04:09:23 +00:00
Jeremy Allison
effbd70c21 Fixed up mutex protection around winbindd logon code. Sync with APP-HEAD.
Jeremy.
(This used to be commit 3d04872499)
2003-01-16 20:08:33 +00:00
Andrew Bartlett
d92b21280e Updates to the NTLMSSP code again - moving the base64 decode fuctionality out
of the SWAT code, and adding a base64 encoder.

The main purpose of this patch is to add NTLMSSP support to 'ntlm_auth', for
use with Squid.  Unfortunetly the squid side doesn't quite support what we need
yet.

Changes to winbind to get us the info we need, and a couple of consequential
changes/cleanups in the rest of the code.

Andrew Bartlett
(This used to be commit fe50ca8f54)
2003-01-16 03:29:54 +00:00