Volker Lendecke
921fbb25eb
r24332: schedule_aio_read_and_X does not need InBuf/OutBuf
...
(This used to be commit 9ad91bd20592850d7b6393e1ac7f0e0919d69668)
2007-10-10 12:29:30 -05:00
Volker Lendecke
d90f6fa1bd
r24328: Restore chain_reply error handling
...
Get the whole smb header from the second chained function, in particular
the error fields
(This used to be commit 0eb831ca0eadb725242cb4ad75eb7008a5c18bf2)
2007-10-10 12:29:30 -05:00
Volker Lendecke
26f6826dfc
r24327: First round of fixes to chain_reply
...
The argument to smb_setlen does not contain the nbt header of 4 bytes
The chained function might allocate outbuf itself (as now happens with
reply_read_and_X). This would erroneously overwrite the caller's outbuf.
Give it an outbuf pointer of it's own
(This used to be commit f923bba90866af14b32c0d0ab58acc00a5939fbb)
2007-10-10 12:29:29 -05:00
Volker Lendecke
bf47a89c98
r24326: Fix the build for Solaris CC
...
(This used to be commit 7af4c1f547accc973f8b3ed88958bdeaf941754a)
2007-10-10 12:29:29 -05:00
Volker Lendecke
bb373dbd6c
r24325: Push down reply_prep_legacy in reply_read_and_X
...
(This used to be commit 9d2354129dad1d4d015d463f138a196f9f72af2f)
2007-10-10 12:29:29 -05:00
Volker Lendecke
8e146e4b7b
r24324: No reply_prep_legacy() in reply_pipe_read_and_X
...
(This used to be commit 304843315c5457ff0288d66d31f1ddb1ef2796f4)
2007-10-10 12:29:29 -05:00
Volker Lendecke
8d6dcd94eb
r24323: Remove the reply_read_and_X wrapper function
...
(This used to be commit 96b218789401bb9e512339e7c6d9e0c9d9724420)
2007-10-10 12:29:29 -05:00
Volker Lendecke
61ee2d3720
r24322: Wrap reply_read_and_X in reply_prep_legacy
...
(This used to be commit 7926b5dfb8d05ad2fe40c3f7658a492f0450e505)
2007-10-10 12:29:28 -05:00
Volker Lendecke
23998e1da8
r24320: Fix the wct checks in reply_trans2 and the reply_trans calls
...
No idea what I've been smoking here.
Thanks to Stefan for closely looking
(This used to be commit 708f5af2e8c10d9a0d0027e3c31fa23689e746b8)
2007-10-10 12:29:28 -05:00
Volker Lendecke
d465b468c1
r24319: Check wct in reply_read_and_X
...
(This used to be commit 9ddacdfa131c4a4a852b3d30db1ee22d1852d0c2)
2007-10-10 12:29:28 -05:00
Volker Lendecke
c898c51984
r24318: Print a prominent warning when reply_prep_legacy is called
...
This is a temporary function anyway
(This used to be commit 9269e3d5882e97d1c884df6511fa6d63a7b1cfcd)
2007-10-10 12:29:27 -05:00
Volker Lendecke
3c5811c272
r24314: Attempt to fix bug 4868
...
(This used to be commit 0ced8fcfe124f99159061143f29775aacd6e1c8f)
2007-10-10 12:29:27 -05:00
Stefan Metzmacher
5cc4dbd449
r24312: revision 24091 removed the 'FORCE'...
...
metze
(This used to be commit 34d821daf0af6ef1e51dfd5cd99741f426d6956e)
2007-10-10 12:29:27 -05:00
Stefan Metzmacher
a5f412f305
r24311: add a reply_force_nterror() macro
...
metze
(This used to be commit b9ae00f4980c305f2f7334b139f9bc72fd9afbd6)
2007-10-10 12:29:27 -05:00
Stefan Metzmacher
c25f22562e
r24310: we should not call END_PROFILE(SMBntcreateX); twice...
...
metze
(This used to be commit 7a98e09f2e4d5eff074e2d71dd1ff2f019a4547a)
2007-10-10 12:29:27 -05:00
Stefan Metzmacher
66294f9db5
r24309: if no protocol matches, just return choise 0xffff
...
as we've done before revision 24002
metze
(This used to be commit 6014ecbbfd50bc8f4f351dec1f9dd35c3fe62456)
2007-10-10 12:29:26 -05:00
Stefan Metzmacher
aece6db714
r24308: this needs a better fix that compiles...
...
metze
(This used to be commit 1a177eb08d4022c1ef7b5400ffdf426bcb9b97ff)
2007-10-10 12:29:26 -05:00
Stefan Metzmacher
f210f7c432
r24307: fill in choise with value -1 on error
...
as we've done before revision 24002
metze
(This used to be commit 2961a35e90aae44c8560b1f4b56bfa6343c837d7)
2007-10-10 12:29:26 -05:00
Stefan Metzmacher
9239b8e8d3
r24306: the check_fsp() function has an explicit user argument
...
so use it...
metze
(This used to be commit 4154bee0d91dd2ace9a7a627418f652d0d11b959)
2007-10-10 12:29:26 -05:00
Volker Lendecke
12d94f77f9
r24279: Remove reply_prep_legacy from reply_write_and_X
...
(This used to be commit f18b7a9a282ebb5c31a89a601798f9a0db51867e)
2007-10-10 12:29:24 -05:00
Volker Lendecke
a6810cb9a3
r24278: Push down reply_prep_legacy in reply_write_and_X
...
Remove the need for reply_prep_legacy for reply_pipe_write_and_X
(This used to be commit de143d5fa61aa487613dda729a43dc3d59a72899)
2007-10-10 12:29:24 -05:00
Stefan Metzmacher
3e8fc031c8
r24272: try to fix the build on irix...
...
metze
(This used to be commit dd7e94258b0fc0157d890d71f05c6fe16b6a2ea9)
2007-10-10 12:29:24 -05:00
Volker Lendecke
b0dc209c19
r24271: Push reply_prep_legacy into reply_write_and_X
...
(This used to be commit 607e7d2447bf19eea872a3a4d1ad499a53f0a935)
2007-10-10 12:29:24 -05:00
Volker Lendecke
1f67efab7c
r24270: Fix some END_PROFILE(SMBwriteX)
...
(This used to be commit 36f2347561ab06b5d8175ad0a9c4da2817e759f9)
2007-10-10 12:29:23 -05:00
Volker Lendecke
bb9664302b
r24269: Check wct in reply_write_and_X
...
(This used to be commit 1297fac11778cb910d1bcd12b6d9d3a6269972db)
2007-10-10 12:29:23 -05:00
Volker Lendecke
456305325c
r24268: Fix two crashes for spoolss
...
strlcpy does not like a NULL source. Fix a use-after-free.
(This used to be commit c2a214501788b5f0b6f555bd01ed310d331d07fa)
2007-10-10 12:29:22 -05:00
Volker Lendecke
d18b7b1223
r24254: Fix a segfault in r24102
...
The really pure bugfix would have replaced pparam by *pparam, but we pulled
the fid anyway.
Metze, in line 2421 the FSP_BELONGS_CONN is commented out, is that intended?
The FSCTL_CREATE_OR_GET_OBJECT_ID ioctl did not have it.
Volker
(This used to be commit 2c1376225b98a9325dfc2d00bad1722e63cf522b)
2007-10-10 12:29:21 -05:00
Jeremy Allison
d75a38ae26
r24253: From Jan Martin <Jan.Martin@rwedea.com>.
...
----------------------------------------------------------
In rare cases, Samba 3.0.25b shows directory contents at the wrong
position in the file tree when displaying a subdirectory of a DFS link.
The problem occurs whenever Windows XP asks for a DFS referral for a
subdirectory of a DFS link with a trailing backslash.
Windows does not do this very often, but we saw it several times per day
on our central DFS server.
smbd/msdfs.c, dfs_path_lookup() does the following with the requested
path:
- in line 390, the local copy 'localpath' is 'unix_convert'ed; the
trailing backslash is removed inside unix_convert
- in lines 417-20, 'dfspath' (another copy of the requested path) is
mangled another way without removing trailing backslashes
That's why the following loop (lines 435-461) that is meant to
synchronously cut off the last path component from both strings until it
comes to a DFS link, does not handle both strings the same. When the
original path ended with a backslash, 'canon_dfspath' has always one
component more than 'localpath', so that *consumedcntp gets too big in
line 446. This value is reported to the client.
----------------------------------------------------------
Bug #4860 .
Jeremy.
(This used to be commit 42d1c6713a56197ca8dfebf74eb0d483102148f7)
2007-10-10 12:29:21 -05:00
Volker Lendecke
b0ed26faf0
r24244: Complete the conversion of reply_trans[s]
...
Remove reply_prep/post_legacy from send_trans_replies
(This used to be commit c08366f840ead5aba7199cf0b058587055b4d98e)
2007-10-10 12:29:20 -05:00
Volker Lendecke
d274724ebb
r24243: Remove reply_prep_legacy from api_reply
...
(This used to be commit b01664b43b0bd94bb59dec57480d2be954a7298a)
2007-10-10 12:29:20 -05:00
Volker Lendecke
43a77ab149
r24242: Remove reply_prep_legacy from api_rpc_trans_reply
...
(This used to be commit 160f65946af9b3e1609b0efb211edc81514fb36f)
2007-10-10 12:29:20 -05:00
Volker Lendecke
40f6afcea2
r24241: Remove reply_prep_legacy from api_WNPHS and api_SNPHS
...
(This used to be commit 8702450e91943b1097ae3c8979d60b6962a69632)
2007-10-10 12:29:20 -05:00
Volker Lendecke
b8de67a2f2
r24240: Push down reply_prep_legacy one level inside api_fd_reply
...
(This used to be commit 0bb95639d6b49b18f2a7f1131f54239355097119)
2007-10-10 12:29:20 -05:00
Volker Lendecke
fbe15d8db9
r24239: Push reply_prep_legacy into api_fd_reply
...
(This used to be commit e2a96497928ab959e36639fef2d493640bb6e951)
2007-10-10 12:29:20 -05:00
Volker Lendecke
bcd0bf8e5e
r24238: Push down reply_prep_legacy one level
...
(This used to be commit a6a2d97facf95c7997f3d12457f2811b3b7bde1b)
2007-10-10 12:29:19 -05:00
Volker Lendecke
d57a88a994
r24237: Add send_trans_reply_new
...
(This used to be commit f0598b3ca0ee04e31855c3e54f3198e6fd968737)
2007-10-10 12:29:19 -05:00
Volker Lendecke
97a817dceb
r24236: Push reply_prep_legacy() into named_pipe()
...
(This used to be commit b38f9347e81364d224e5ca00609099a74410e99c)
2007-10-10 12:29:19 -05:00
Volker Lendecke
3bb9f20bc3
r24235: Make handle_trans reply to errors itself
...
(This used to be commit 06d0c74b74754c55f4c8ef0899bda08476e7dd4b)
2007-10-10 12:29:19 -05:00
Volker Lendecke
abc519ff43
r24234: Reformatting -- SCNR
...
(This used to be commit 040d6d5db6d929f1612b1b0dc762b7f55c956740)
2007-10-10 12:29:19 -05:00
Volker Lendecke
e41528c3f4
r24233: Push reply_prep_legacy into handle_trans
...
(This used to be commit dc27c3c668f86d008c27b8a749f5726287ba54a5)
2007-10-10 12:29:19 -05:00
Volker Lendecke
0cfea6de67
r24232: Push down reply_prep_legacy inside reply_transs
...
(This used to be commit 511f8bc030a9a16c2e793ce5d06577608e101de4)
2007-10-10 12:29:18 -05:00
Volker Lendecke
1d3c1de502
r24231: Push allocating InBuffer/OutBuffer into reply_transs
...
(This used to be commit 74ae19cca6dd15b65deffbf464cfd0e485da8611)
2007-10-10 12:29:18 -05:00
Volker Lendecke
f1822fe737
r24230: Push down reply_prep_legacy in reply_trans
...
The last checkin was for reply_trans, not reply_transs
(This used to be commit 50a2bfd9e04d51aa5e3ae9d6620a98eeb158b6ea)
2007-10-10 12:29:18 -05:00
Volker Lendecke
133ef281c0
r24229: Push allocating InBuffer/OutBuffer into reply_transs
...
(This used to be commit 39a7809aa4c34bb26178589245c419df44796e22)
2007-10-10 12:29:18 -05:00
Volker Lendecke
5d2031915e
r24225: Convert reply_flush to the new API
...
(This used to be commit f843c02f0794964eba02ab983f9c0701801f415c)
2007-10-10 12:29:18 -05:00
Volker Lendecke
bf160bb621
r24224: Check wct in reply_trans
...
(This used to be commit fc8759e63ccec7f1cfb9f1d0ecd0f19a496e4153)
2007-10-10 12:29:18 -05:00
Volker Lendecke
c847b2afe7
r24223: Convert reply_echo to the new API
...
(This used to be commit 4863ff2899419e791ed0e340821072d004fb1d17)
2007-10-10 12:29:17 -05:00
Jeremy Allison
01ee1c7909
r24164: Fix for write cache corruption bug reported by Jean-Francois Panisset <panisset@A52.com>.
...
Awaiting confirmation from reporter.
Jeremy.
(This used to be commit 7bd65060bd965bd17a5d79639cf561b8b578cb36)
2007-10-10 12:29:17 -05:00
Volker Lendecke
c7a425f30f
r24163: Remove the send_trans2_replies_new wrapper
...
This changes send_trans2_replies to not depend on large buffers anymore
and finishes the trans2 conversion.
(This used to be commit b1d133e4ffa8c9b8219ba6e7b83e23ca4bdd1616)
2007-10-10 12:29:16 -05:00
Volker Lendecke
c2fb81bbf0
r24162: send_trans2_replies is now static in trans2.c
...
(This used to be commit 47261fb6fecc036cb1605f46bbe24e9b3661ff8c)
2007-10-10 12:29:16 -05:00