1
0
mirror of https://github.com/samba-team/samba.git synced 2024-12-27 03:21:53 +03:00
Commit Graph

16790 Commits

Author SHA1 Message Date
Jeremy Allison
92db75b4a2 r16202: Fix Klocwork #3. Strange - was already fixed in HEAD.
Jeremy.
(This used to be commit 319f80bbf0)
2007-10-10 11:17:25 -05:00
Volker Lendecke
edcffcbe28 r16201: Fix Klocwork 439
(This used to be commit b369d0891a)
2007-10-10 11:17:24 -05:00
Jeremy Allison
c0e4753cfc r16199: Fix Klocwork #1 - ensure we test the first
strtok for NULL.
Jeremy.
(This used to be commit 98751e8190)
2007-10-10 11:17:24 -05:00
Volker Lendecke
4d1688bf6b r16198: Fix Klocwork 1023
(This used to be commit 3a7d01afbe)
2007-10-10 11:17:24 -05:00
Volker Lendecke
8fa2907efd r16197: Fix Klocwork id 1338
(This used to be commit 963ae5bd14)
2007-10-10 11:17:24 -05:00
Volker Lendecke
15e26314b6 r16196: A bit of defensive programming:
Klocwork ID 1773 complained about oldest being dereferenced in line 2275 where
it could be NULL. I think you can construct extreme racy conditions where this
actually could happen.

Volker
(This used to be commit b5602cc4f1)
2007-10-10 11:17:24 -05:00
Gerald Carter
668727d035 r16195: starting development for 3.0.24pre1
(This used to be commit 1b64f9a48b)
2007-10-10 11:17:24 -05:00
Günther Deschner
395aa679f0 r16192: Fix timeformats in the winbind response struct.
(pam_winbind users were forced to change a password inappropriately)

Guenther
(This used to be commit 65643d3172)
2007-10-10 11:17:23 -05:00
Günther Deschner
1628d33ba0 r16190: Fix more memleaks.
Guenther
(This used to be commit dfebcc8e19)
2007-10-10 11:17:23 -05:00
Günther Deschner
2828356be3 r16187: Fix memleak.
Guenther
(This used to be commit e7d2b84aba)
2007-10-10 11:17:23 -05:00
Volker Lendecke
3ea740f5e5 r16156: Fix storing NULL in the wrong place. Klocwork id's 127 and 128.
Volker
(This used to be commit 7674a4f836)
2007-10-10 11:17:23 -05:00
Jeremy Allison
685aed3fb4 r16155: Janitor for jelmer.
Fix typo in DEBUG()
Jeremy.
(This used to be commit da768bf9c2)
2007-10-10 11:17:23 -05:00
Günther Deschner
ee1105754c r16154: Fix winbind function table typo.
Guenther
(This used to be commit aeff1f0c47)
2007-10-10 11:17:23 -05:00
Volker Lendecke
ab710c9e25 r16153: Fix possible NULL dereference found by Klocwork # 252
(This used to be commit 128260527b)
2007-10-10 11:17:23 -05:00
Volker Lendecke
780f121462 r16150: Fix possible NULL dereference found by Klocwork ID # 17
(This used to be commit 3159bd3a4e)
2007-10-10 11:17:22 -05:00
Volker Lendecke
21eeddb80d r16141: Dummy commit to make the build farm re-test against Samba4 16140
(This used to be commit a1fcacf756)
2007-10-10 11:17:22 -05:00
Alexander Bokovoy
21706838f5 r16138: By default, rootsbindir relies on SBINDIR so import it here
(This used to be commit a18af427d7)
2007-10-10 11:17:22 -05:00
Alexander Bokovoy
c403a5525c r16136: By default, rootsbindir relies on SBINDIR so import it here
(This used to be commit 5ffb424641)
2007-10-10 11:17:22 -05:00
Gerald Carter
7112413350 r16130: fix a shell portability issue for Solaris sh in installman.sh
(This used to be commit 9be3e07884)
2007-10-10 11:17:22 -05:00
Jeremy Allison
3b469083be r16126: Janitor for Volker..... This looks correct to me.
Jeremy.

Fix a parsing error that became apparent in 'make test': If we have no
group
rids in the info3 we set the array buffer pointer to "1" but fail to
actually
ship the array.

Volker.
(This used to be commit ee1b9207d3)
2007-10-10 11:17:22 -05:00
Günther Deschner
38060f70a5 r16122: As we use 'inetOrgPerson' as structural objectclass for new accounts for
eDir, we already add 'sn' as required attribute on LDAP add
operations.

When we modify an entry, we need to request 'sn' as well in our
attribute lists, so that we don't try to add it a second time.

Guenther
(This used to be commit e018ea3d1d)
2007-10-10 11:17:21 -05:00
Günther Deschner
d28456fe22 r16121: Fix a eDir related memory leak.
Guenther
(This used to be commit 322f1664df)
2007-10-10 11:17:21 -05:00
Günther Deschner
97f496a0e3 r16117: Make winbindd work again in security=ads.
We still used the old HOST/* UPN to get e.g. users, now we need
samaccountname$@REA.LM.

Guenther
(This used to be commit f6516a799a)
2007-10-10 11:17:21 -05:00
James Peach
c12c557a13 r16116: Hoist the slow CLOCK_REALTIME message inside the branch so we never
confuse an uninitialised __profile_clock with CLOCK_REALTIME. Flip the
condition argument to SMB_WARN around so that it's correct (though
completely non-intuitive).
(This used to be commit 60b5f9618b)
2007-10-10 11:17:21 -05:00
Günther Deschner
bf7a5433b4 r16115: Make "net ads changetrustpw" work again.
(adapt to the new UPN/SPN scheme).

Guenther
(This used to be commit 8fc70d0df0)
2007-10-10 11:17:21 -05:00
Günther Deschner
33c918b11a r16114: Make winbindd's group enumeration (set|get|endgrent) work again (when
enabled).

Do not bail out when a group just has 0 members.

Jeremy, please check, this has been removed with r13915.

Guenther
(This used to be commit 3a738a855d)
2007-10-10 11:17:21 -05:00
Jeremy Allison
088c571df8 r16112: Added Volker's fix for extra odd byte at the end
of UNIX_BASIC infolevel. Checked client implementations
(cifsfs and libsmb) and they ignore it. Thanks Volker.
Jeremy.
(This used to be commit 6cd1cb5c9d)
2007-10-10 11:17:20 -05:00
James Peach
8882d08b6b r16111: Patch from Björn JACKE <samba@j3e.de>.
This fixes a problem where the clock definition for clock_gettime() is
present at compile time, but is not available on the running system. In
this case, we fall back to less-preferred clocks until we find one that
we can use.
(This used to be commit fc6ed6a1aa)
2007-10-10 11:17:20 -05:00
Paul Green
b7eaff26dc r16103: Properly rebuild timelimit on systems with executable extensions.
Paul
(This used to be commit f5be3e12e2)
2007-10-10 11:17:20 -05:00
Günther Deschner
9467e6f41a r16080: Re-add accidentially excluded in-forest domain trusts (fixes bug #3823).
Guenther
(This used to be commit 8759a00fed)
2007-10-10 11:17:20 -05:00
Gerald Carter
564529b91a r16079: How embarassing. :-( Broke the build.
I will *always* compile before checking in...
I will *always* compile before checking in...
I will *always* compile before checking in...
I will *always* compile before checking in...
I will *always* compile before checking in...
(This used to be commit f3bd1c8c7d)
2007-10-10 11:17:20 -05:00
Gerald Carter
6b1b66904d r16078: Patch from Aleksey Fedoseev <fedoseev@ru.ibm.com> to correctly
set the type of 'acl compatibility from string to integer
after the changes in r14207.
(This used to be commit b01f289f1a)
2007-10-10 11:17:20 -05:00
Jeremy Allison
f897e7094f r16076: Fix for machine password timeout overflow from Shlomi Yaakobovich
<Shlomi@exanet.com>.
Jeremy.
(This used to be commit 5cd234a1ff)
2007-10-10 11:17:19 -05:00
Volker Lendecke
efdc5b72fd r16065: Re-add a strlower_m(account) in samr_create_user that was dropped for no
reason but to increase fidelity with W2k3. Tom Bork has raised valid concerns
that Unix scripts might rely on the account names being lower-case, so keep
that. We might later decide to only lower-case the unix name passed to
'add [user|group] script' but keep the passdb entry upper-case. But there are
enough user-visible changes in 3_0 already so that we should push this off to
a later date.

Tom, waiting for more bug reports from you ;-))

Thanks for insisting!

Volker
(This used to be commit bc78cca290)
2007-10-10 11:17:19 -05:00
Volker Lendecke
40dc4e2d1a r16064: Bug fix for another one Tom Bork has reported:
'valid users = +unixgroup' failed with smbpasswd if 'unixgroup' has a
(non-algorithmic) group mapping.

Thanks a lot!

People out there listening, please test current code, this release is

	   **BIG**

:-)

Volker
(This used to be commit 8f9ba5f96c)
2007-10-10 11:17:19 -05:00
Volker Lendecke
c594a5519d r16060: This is one of the more dirty patches I've put in lately. Parse enough of
SetUserInfo level 25 to survive the join method XP uses if the user did not
exist before. For good taste this contains way too much cut&paste, but for a
real fix there is just not enough time.

Up to 3.0.22 we completely ignored that a full level 21 is being sent together
with level 25, but we got away with that because on creation we did not set
the "disabled" flag on the workstation account. Now we correctly follow W2k3
in this regard, and we end up with a disabled workstation after join.

Man, I hate rpc_parse/. The correct fix would be to import PIDL generated samr
parsing, but this is would probably be a bit too much for .23...

Thanks to Tom Bork for finding this one.

Volker
(This used to be commit 5a37aba105)
2007-10-10 11:17:18 -05:00
James Peach
777c22b300 r16057: Coalesce the DMAPI configure tests into a single macro. Add
a more specific probe to try and eliminate old, incompatible
DMAPI implementations provided by IRIX 6.4 and AIX 4.3.
(This used to be commit aafd4db457)
2007-10-10 11:17:18 -05:00
Jeremy Allison
656d8c30db r16054: Janitor for Volker ? Volker - some reason you didn't
fix this in 3.0 ?
Jeremy.

We had no way to return NT_STATUS_OK from the netlogon serverpwset,
although
we successfully set the machine password...

One thing the samba3 join test found.

Volker
(This used to be commit e5b7acc9b5)
2007-10-10 11:17:18 -05:00
Jim McDonough
9291391885 r16047: Remove unnecessary line, as this value is set in either branch of the
'if' below.  Spotted by Aleksey Fedoseev.
(This used to be commit 00eb42791a)
2007-10-10 11:17:18 -05:00
Volker Lendecke
fbd296f2f6 r16046: Hmmm. I don't fully understand popt, but this is necessary for smbclient to
show a prompt again :-)

James, could you check that this is ok? I think this was part of your Revision
15848.

Thanks,

Volker
(This used to be commit 91534146b4)
2007-10-10 11:17:18 -05:00
Stefan Metzmacher
fd1b550851 r16025: make sure the samba4's smbtorture can be executed
metze
(This used to be commit bed220afb8)
2007-10-10 11:17:18 -05:00
Jeremy Allison
863aa313c1 r16019: This should not be a level zero message - it's harmless
and can happen though misconfiguration.
Jeremy.
(This used to be commit 4b9cf399a6)
2007-10-10 11:17:18 -05:00
Jeremy Allison
56460288bf r16017: Add Samba4 replacement for timegm to work
on Solaris.
Jeremy.
(This used to be commit b65c646865)
2007-10-10 11:17:17 -05:00
Jeremy Allison
3d4d799eee r16016: Add debug to be symetrical with reading from
cache.
Jeremy.
(This used to be commit da26565a2e)
2007-10-10 11:17:17 -05:00
Volker Lendecke
d7dbf37825 r16014: Correctly set the group RID in init_sam_from_buffer.
BIG THANKS to Tom Bork for reporting that Bug!

Volker
(This used to be commit 40339fdcce)
2007-10-10 11:17:17 -05:00
Jeremy Allison
61d2dfcd30 r15997: Fix bug in OS/2 Warp - it doesn't set the ff_last
offset correctly when doing info level 1 directory
scans. Thanks to Guenter Kukkukk <Guenter.Kukkukk@kukkukk.com>
for reporting this problem and testing the fix.
Jeremy.
(This used to be commit 65d4dfbd60)
2007-10-10 11:17:17 -05:00
Jeremy Allison
4fe9d1f897 r15995: Make smbldap obey config tests. Patch from "John E. Malmberg"
<wb8tyw@qsl.net>.
Jeremy.
(This used to be commit 93dd476a91)
2007-10-10 11:17:17 -05:00
Stefan Metzmacher
5c9e031adb r15989: try to make timelimit.c more portable
Patch from Bjoern Jacke (Thanks!)

metze
(This used to be commit b9d1440f46)
2007-10-10 11:17:17 -05:00
Günther Deschner
22a543f5bb r15985: Adding "own-domain" switch to wbinfo which is handy from time to time.
Guenther
(This used to be commit 3c9416c2be)
2007-10-10 11:17:16 -05:00
Günther Deschner
a6f5c79980 r15984: Correctly handle the case when there is no configuration file for
pam_winbind.

Guenther
(This used to be commit 29758ea1c4)
2007-10-10 11:17:16 -05:00