Andreas Schneider
92df015e30
s3-spoolss: Fixed the DeviceMode handling in winreg.
...
Signed-off-by: Günther Deschner <gd@samba.org>
2010-05-05 18:22:28 +02:00
Andreas Schneider
859a1e04fb
s3-spoolss: Added winreg security descriptor functions.
...
Signed-off-by: Günther Deschner <gd@samba.org>
2010-05-05 18:21:54 +02:00
Andreas Schneider
a76cc0a18c
s3-spoolss: Migrated winreg to spoolss_create_default_secdesc.
...
Signed-off-by: Günther Deschner <gd@samba.org>
2010-05-05 18:21:19 +02:00
Günther Deschner
ed3852c2c2
s3-spoolss: make sure to return success in winreg_get_driver_list() for a
...
non-existing architecture / version combination.
Guenther
2010-05-05 18:17:32 +02:00
Günther Deschner
83e324c417
s3-spoolss: talloc_steal the returned driver_list in winreg_get_driver_list().
...
Otherwise the function would return a pointer to a freed list.
Guenther
2010-05-05 18:17:23 +02:00
Simo Sorce
24225bf032
s3-spoolss: Fixed winreg_printer_query_XXX.
...
A cast to an incorrectly sized pointer was breaking
on 64bit architectures where size_t is 64bit.
Signed-off-by: Günther Deschner <gd@samba.org>
2010-05-05 18:17:13 +02:00
Andreas Schneider
740418a150
s3-spoolss: Added a winreg_printer_query_binary function.
...
Signed-off-by: Günther Deschner <gd@samba.org>
2010-05-05 18:16:38 +02:00
Andreas Schneider
66f7699511
s3-spoolss: Added a generic spoolss_create_default_secdesc function.
...
Signed-off-by: Günther Deschner <gd@samba.org>
2010-05-05 18:16:23 +02:00
Andreas Schneider
b2ea8fbcce
s3-spoolss: Added a function to create a default spoolss_DeviceMode.
...
Signed-off-by: Günther Deschner <gd@samba.org>
2010-05-05 18:08:56 +02:00
Volker Lendecke
5a56bc948e
s3: Fix bug 5972 -- remove -L testparm parameter
...
Thanks to TAKAHASHI Motonobu <monyo@samba.gr.jp> to point out that this does
not work and to agree it's not worth fixing :-)
2010-05-05 18:07:45 +02:00
Andreas Schneider
3f0562f4b4
s3-spoolss: Fixed memory error in winreg_get_driver.
...
The strings in the structure need to be initialized with an empty
string.
Signed-off-by: Günther Deschner <gd@samba.org>
2010-05-05 17:33:06 +02:00
Andreas Schneider
c95a79aae9
s3-spoolss: Added a sharename arg to winreg_update_printer.
...
Signed-off-by: Günther Deschner <gd@samba.org>
2010-05-05 17:32:59 +02:00
Andreas Schneider
053ed7d554
s3-spoolss: Added missing servername option to winreg_{create,get}_printer.
...
This is needed to be able to pass the correct servername from
Printer_entry.
Signed-off-by: Günther Deschner <gd@samba.org>
2010-05-05 17:32:51 +02:00
Andreas Schneider
a5fb4117e1
s3-spoolss: Added missing Printer Driver in winreg_{update,get}_printer.
...
Signed-off-by: Günther Deschner <gd@samba.org>
2010-05-05 17:32:33 +02:00
Günther Deschner
6659a0fe92
s3-net: fix crash in rap_share_add().
...
Guenther
2010-05-05 17:21:06 +02:00
Andrew Tridgell
10469d6606
s3-build: don't rebuild/link on every make run
2010-05-05 16:14:13 +02:00
Jeremy Allison
62143543ce
Fixed issue with return in a void function found by Björn JACKE <bj@SerNet.DE>
...
Jeremy.
2010-05-05 06:09:03 -07:00
Andreas Schneider
9e94354a4e
s3-libsmb: Fixed a recursion in cli_pull_print.
2010-05-05 09:28:04 +02:00
Luca Olivetti
a9e008ee36
Fix bug #7263 - Unable to print using Samba 3.5.1 and cups-1.1.23-40.46 on SLES10.
...
Fix cups encryption setting
I had the same problem and it's due to the fact that samba doesn't respect the
"cups encryption" setting since lp_cups_encrypt changes the value: if you set
"cups encryption=no", the first call will change it to HTTP_ENCRYPT_NEVER,
since that is 1 (i.e. true), the next call will change it to
HTTP_ENCRYPT_ALWAYS and after that it'll remain set as HTTP_ENCRYPT_ALWAYS.
This patch fixes this problem.
Don't mix up the HTTP_ENCRYPT_XXX constants up with the
enumeration constants (True, False, Auto) used in the
loadparm code.
2010-05-04 15:07:57 -07:00
Simo Sorce
17ce20ba96
s3-spoolss: Remove duplicate macro.
...
Signed-off-by: Günther Deschner <gd@samba.org>
2010-05-04 19:38:27 +02:00
Andreas Schneider
6683b0d4b6
s3-lib: Create a sec_desc_merge and sec_desc_merge_buf function.
...
Signed-off-by: Günther Deschner <gd@samba.org>
2010-05-04 19:37:39 +02:00
Günther Deschner
cc46f4a319
s3-libnetjoin: omit admin password in generated ndr_print function.
...
Guenther
2010-05-04 16:31:34 +02:00
Andrew Tridgell
f4000eecf4
s3-idl: update the 2nd build_idl.sh script
2010-05-04 13:47:08 +02:00
Andrew Tridgell
6f895fedf3
s3-idl: auto-build IDL files in Samba3
2010-05-04 13:47:07 +02:00
Andrew Tridgell
5bff08d9a9
s3-idl: removed gen_ndr files from source3/ as well
2010-05-04 13:47:07 +02:00
Volker Lendecke
a7b06f4c0d
s3: Fix a memleak in check_pac_checksum
2010-05-04 12:00:13 +02:00
Günther Deschner
4affc58c6a
s3-lanman: before trying to call spoolss_ClosePrinter make sure we have a connection.
...
Guenther
2010-05-03 17:04:00 +02:00
Günther Deschner
9cc10e6a57
s3-rpcclient: Fix Bug #7277 . rpcclient was sending invalid data, causing cupsaddsmb to fail.
...
Guenther
2010-05-03 16:30:13 +02:00
Günther Deschner
fe1617a818
s3-lanman: fix api_DosPrintQEnum().
...
This was a subtile bug where the OpenPrinter call (called directly via
dispatcher table) was modifiying r->in.printername in a way that all printers on
a server had the printername stripped off the server unc. Once we switch to full
NDR marshalling in inter RAP<->RPC server communication there is no danger
anymore to have these kind of nasty effects.
Guenther
2010-05-03 14:45:26 +02:00
Günther Deschner
fe33db6c06
s3-lanman: exit early for unsupported levels in api_PrintJobInfo().
...
Guenther
2010-05-03 14:43:34 +02:00
Matthew McGillis
6be5bc8e80
Consolidate all get SEC_DESC into single procedure get_secdesc
2010-05-03 08:07:03 +02:00
Matthew McGillis
0a8b2b2119
always pass filename as const char
2010-05-03 08:06:56 +02:00
Volker Lendecke
668e28b80e
s3: Unify DEBUG_KRB5_TKT_REGAIN and DEBUG_KRB5_TKT_RENEWAL
...
I don't think it makes sense to #ifdef this one case separately.
Metze, Bo Yang, please check!
2010-05-02 15:16:14 +02:00
Volker Lendecke
ef0adbff93
s3: Fix a typo
2010-05-02 15:16:14 +02:00
Volker Lendecke
685b4625bc
s3: Fix the code order in append_auth_data
...
This is to comply with the comment
"currently, anything from here on potentially overwrites extra_data."
Günther, please check!
2010-05-02 15:15:56 +02:00
Jeremy Allison
f4092ecec7
Plumb the SMB2 front end into the blocking lock backend.
...
Metze, you'll probably be happier with this work as it
doesn't abuse tevent in the way you dislike. This is a
first cut at the code, which will need lots of testing
but I'm hoping this will give people an idea of where I'm
going with this.
Jeremy.
2010-04-30 21:03:20 -07:00
Simo Sorce
dffeb12f3d
smbd: move printfile_offset() within write_file()
2010-04-30 11:52:39 -07:00
Jeremy Allison
e90444319c
Carefully label SMB1-specific locking calls.
...
Jeremy.
2010-04-29 17:08:12 -07:00
Jeremy Allison
ebf6340bb5
Move the global blocking lock records into the smb1 state.
...
Jeremy
2010-04-29 16:50:15 -07:00
Jeremy Allison
1f69a7a80e
Attempt to fix bug #7399 - SMB2: QUERY_DIRECTORY is returning invalid values.
...
Based on an initial patch from Ira Cooper <samba@ira.wakeful.net>.
Jeremy.
2010-04-29 13:40:25 -07:00
Volker Lendecke
ca860e4279
s3: range-check idmap script output
...
Not doing so results in the id mapping succeeding once unchecked and later on
being refused, because when reading from the tdb we do the checks.
2010-04-29 14:33:08 +02:00
Volker Lendecke
fcdba1b36f
s3: Fix an uninitialized variable in idmap_tdb2_sid_to_id()
...
When we find an invalid record in the database, there's no point in checking
the non-existing value against the range limits.
2010-04-29 14:33:08 +02:00
Volker Lendecke
81e75bacd3
s3: Fix some nonempty blank lines
2010-04-29 14:33:07 +02:00
Günther Deschner
9a313bbac0
s3-lanman: fix api_DosPrintQGetInfo().
...
Found by torture test.
Guenther
2010-04-29 13:47:33 +02:00
Günther Deschner
f5ac746091
s3-pdb_ldap: fix memleak.
...
Guenther
2010-04-29 12:05:42 +02:00
Günther Deschner
7e678ef0cf
s3-lanman: fix api_DosPrintQEnum.
...
Found by torture test.
Guenther
2010-04-29 12:05:42 +02:00
Jeremy Allison
4e7195be36
Update (C) for 2010.
...
Jeremy.
2010-04-28 14:56:12 -07:00
Günther Deschner
8878be3c45
s3-selftest: enable RAP-PRINTING against s3.
...
Guenther
2010-04-28 23:23:38 +02:00
Günther Deschner
d53544800f
s3-lanman: support level 0 NetPrintQEnum RAP query.
...
Guenther
2010-04-28 23:23:38 +02:00
Jeremy Allison
ac09506d36
Connect set security descriptor into SMB2 code.
...
Jeremy.
2010-04-28 14:13:22 -07:00