sin/samba-mirror
1
0
Fork 0
mirror of https://github.com/samba-team/samba.git synced 2024-12-27 03:21:53 +03:00
Code
57,823 Commits 60 Branches 1,144 Tags 452 MiB
932ab0c299
Commit Graph

30618 Commits

Author SHA1 Message Date
Jeremy Allison
6a61befe37 Fix more of the RAW-SEARCH test. Older info levels are 
not 4 byte aligned (levels 1 - 3).
Jeremy.
 2009-11-03 11:19:24 -08:00
Volker Lendecke
b067a5e4e8 s3: Remove debug_ctx() 
smbd just crashed on me: In a debug message I called a routine preparing a
string that itself used debug_ctx. The outer routine also used it after the
inner routine had returned. It was still referencing the talloc context
that the outer debug_ctx() had given us, which the inner DEBUG had already
freed.
 2009-11-03 11:30:00 +01:00
Jeremy Allison
f9c9dee013 Convert from numbers to correct SMB_FIND_XX constant names. 
Jeremy.
 2009-11-02 16:17:36 -08:00
Michael Adam
cc5b22a016 s3:registry: add an extra check for dsize==0 to regdb_fetch_keys_internal() 
Don't only rely on dptr == NULL.
I stumbled over this one when rewriting some of the dbwrap_ctdb code.

Michael
 2009-11-03 01:02:39 +01:00
Michael Adam
f6f2151a39 s3:registry: add safety check for return value of tdb_unpack to regdb_fetch_keys_internal() 
Prevents segfaults in some situations.

(For a non existent or empty record, we sometimes rely on the fetch operation
 to return dsize==0 and sometimes we rely on dptr==NULL.)

Michael
 2009-11-03 01:02:38 +01:00
Michael Adam
25bdf27eaa s3:dbwrap_ctdb: add debug message to transaction_fetch_start() 
for the case that another local process has started a transaction
bewteen releasing the transaction_lock record and starting the
transaction.

Michael
 2009-11-03 01:02:38 +01:00
Michael Adam
9fef6a6666 s3:dbwrap_ctdb: split combined check in two and add descriptive debug 
in db_ctdb_transaction_fetch_start() for error conditions when re-fetching
the transaction_lock record inside the transaction

Michael
 2009-11-03 01:02:38 +01:00
Michael Adam
f37439efd2 s3:dbwrap_ctdb: fix race condition with concurrent transactions on the same node. 
In ctdb_transaction_commit(), when the trans2_commit control fails, there
is a race condition in the 1 second sleep between the local transaction_cancel
and the call to ctdb_replay_transaction(): The database is not locked, and
neither is the transaction_lock record. So another client can start and possibly
complete a new transaction in this gap, but only on the same node: The locking
of the transaction_lock record on a different node which involves migration of
the record to the other node has been disabled by introduction of the
transaction_active flag on the db which closes precisely this gap from the start
of the commit until the call to TRANS2_FINISH or TRANS2_ERROR.
But this mechanism does not cover the case where a process on the same node
tries to start a transaction: There is no obstacle to locking the transaction_lock
record because the record does not need to be migrated.

This commit closes this race condition in ctdb_transaction_fetch_start()
by using the new ctdb_ctrl_transaction_active() call to ask the local
ctdb daemon whether it has a transaction running on the database.
If so, the check is repeated until the running transaction is done.

This does introduce an additional call to the local ctdbd when starting
transactions, but it does close the (hopefully) last race condition.

Michael
 2009-11-03 01:02:37 +01:00
Michael Adam
08d2a3f4bf s3:configure: add a check for the new CTDB_CONTROL_TRANS2_ACTIVE 
Michael
 2009-11-03 01:02:37 +01:00
Michael Adam
9be4d3dd4f s3:dbwrap_ctdb: add new db_ctdb_transaction_active() that calls CTDB_CONTROL_TRANS2_COMMIT 
Michael
 2009-11-03 01:02:37 +01:00
Michael Adam
9bd6b9d9f6 s3:dbwrap_ctdb: fix a race in starting concurrent transactions on a single node 
There are two races in concurrent transactions on a single node.
One in starting a transaction and one with replay during commit.

This commit closes the first race by storing the client pid in the
transaction-lock record and comparing the stored pid against its own
pid after releasing the lock and refetching the record inside the
transaction.

Michael
 2009-11-03 01:02:36 +01:00
Michael Adam
8d61b8abbc s3:dbwrap_ctdb: use db_ctdb_ltdb_fetch() inside db_ctdb_transaction_fetch_start 
Michael
 2009-11-03 01:02:36 +01:00
Michael Adam
0ec476fca1 s3:dbwrap_ctdb: use db_ctdb_ltdb_fetch() inside db_ctdb_transaction_fetch() 
Michael
 2009-11-03 01:02:36 +01:00
Michael Adam
4973ff66ac s3:dbwrap_ctdb: add a function db_ctdb_ltdb_fetch() 
This fetches a record from the db and splits out the ctdb header.

Michael
 2009-11-03 01:02:35 +01:00
Michael Adam
6a898348fa s3:dbrwap_ctdb: add a function db_ctdb_ltdb_store() 
and use it in db_ctdb_store() and db_ctdb_transaction_store().

Michael
 2009-11-03 01:02:35 +01:00
Michael Adam
d5aa758482 s3:dbwrap_ctdb: reformat a comment slightly to enhance clearness. 
Michael
 2009-11-03 01:02:35 +01:00
Jeremy Allison
494d8271d4 Fix bug 6867 - trans2findnext returns reply_nterror(req, ntstatus) In a directory with a lot of files. 
Jeremy.
 2009-11-02 12:15:25 -08:00
Volker Lendecke
d9bdd17522 s3: Fix a 100% CPU loop when ctdbd dies during a traverse 2009-11-02 17:02:20 +01:00
Günther Deschner
f35a1b95aa s3-gencache: restore gencache_get behavior with NULL args (with torture test). 
Without this, we panic in wins_srv_is_dead() and fail to start nmbd with
wins support.

Volker, please check.

Guenther
 2009-11-02 13:04:26 +01:00
Volker Lendecke
ad6ee94950 s3: Make "debug hires timestamp" default to true 
It does not cost much and can help a lot when debugging
 2009-11-02 10:08:39 +01:00
Andrew Bartlett
7a290130bd lib/util Use rfc1738.c from Squid for all our URL encode/decode needs. 
Andrew Bartlett
 2009-11-02 16:36:52 +11:00
Björn Jacke
7006352206 s3:ldap: don't search when no values where found 2009-11-02 01:55:27 +01:00
Volker Lendecke
9ab1f793ff s3: Fix the RPC server SUBSYSTEM declaration 
If I read SMB_SUBSYSTEM right then the 2nd argument needs to be the file where
the static_init_rpc (in this case) is defined. This seems to have moved from
server.c to process.c.

Jelmer, please check!

Volker
 2009-10-31 11:28:55 +01:00
Björn Jacke
a80a0b7728 s3:Makefile: add LIBREPLACE_LIBS for talloc, tdb and wbclient 2009-10-31 10:37:44 +01:00
Björn Jacke
4ae950d211 ѕ3:buildsystem: fix depenencies for libreplace 
This problem became visible after adding the picky -z defs linker option: On
Solaris libreplace had unresolved symbols, which showed up in the libtalloc
build. PAM_WINBIND_EXTRA_LIBS and WINBIND_NSS_EXTRA_LIBS had been workarounds
to make things work at two placeѕ. These variables have been obsoleted now.
This patch introduces LIBREPLACE_LIBS which contans the linker flags needed for
linking anything using libreplace.
 2009-10-31 00:48:20 +01:00
Björn Jacke
72cec4a031 ѕ3:ldap: search for account policies in objectclass sambaDomain, not * 2009-10-31 00:48:20 +01:00
Günther Deschner
2f3a40844d s3-rpcclient: add deletetrustdom command. 
Guenther
 2009-10-30 12:28:48 +01:00
Günther Deschner
fbdda19549 s3-rpcclient: add createtrustdom command. 
Guenther
 2009-10-30 12:28:48 +01:00
Günther Deschner
a98832189a s3-lsa: expand struct lsa_info to carry name and sd. 
Guenther
 2009-10-30 12:28:48 +01:00
Günther Deschner
820b2f4cfa s3-lsa: use switch in _lsa_QuerySecurity(). 
Guenther
 2009-10-30 12:28:48 +01:00
Jeremy Allison
921aa99b37 Start fixing the RAW-STREAMS test - ensure that the xattr 
used to store the stream info in streams_depot.so is not
seen in when enumerating EAs.
Jeremy.
 2009-10-29 16:14:12 -07:00
Jim McDonough
f88ab1b151 s3: Fix incorrect rc check of nscd_flush_cache. 
At least this only resulted in an incorrect debug message.
 2009-10-29 11:11:43 -04:00
Günther Deschner
184afaa04c s3-secrets: use autogenerated code for TRUSTED_DOM_PASS struct parsing from a tdb. 
Guenther
 2009-10-29 10:49:39 +01:00
Günther Deschner
e92e33238c s3: add secrets.idl. 
Guenther
 2009-10-29 10:49:35 +01:00
Stefan (metze) Metzmacher
25f96a4058 Add in Metze's new code to ndr encode the user.DOSATTRIB 
blobs. Next I'll change the create timestamp and dos attribute
code to use this.
 2009-10-28 15:42:47 -07:00
SATOH Fumiyasu
c27194a7e0 Fix bug 6572 - libsmbclient: unable to access 'msdfs proxy' share. 2009-10-28 12:48:36 -07:00
Björn Jacke
0ba004dc7d s3:net: fix output of net rpc trustdom list 
Move some messages from stderr to stdout. When some trusting DCs were
unreachable we lacked \n's on stdout which screwed up whole the output.
 2009-10-28 14:45:49 +01:00
Stefan Metzmacher
ee13e9c0be s3:configure: only check for gpfs_gpl.h 
The header is everything we need in order to build vfs_gpfs.

metze

Signed-off-by: Michael Adam <obnox@samba.org>
 2009-10-28 13:08:26 +01:00
Günther Deschner
4df8426768 s3-passdb: move open_schannel_session_store() to passdb/secrets_schannel.c. 
Guenther
 2009-10-28 12:37:39 +01:00
Günther Deschner
96bffa5bbd s3-net: acct_flags are uint32_t in net_sam_set_userflag(). 
Guenther
 2009-10-28 12:37:39 +01:00
Günther Deschner
abe9417303 s3-lsa: add lsa_trusted_domain_mapping. 
Guenther
 2009-10-28 12:37:38 +01:00
Günther Deschner
bda047afbc s3-passdb: add secrets_delete_generic(). 
Guenther
 2009-10-28 12:37:38 +01:00
Günther Deschner
7791d29c79 s3-lsa: add lsa_secret_mapping. 
Guenther
 2009-10-28 12:37:34 +01:00
Günther Deschner
880666cd94 s3-lsa: use correct function name in_lsa_RemoveAccountRights(). 
Guenther
 2009-10-28 12:24:25 +01:00
Günther Deschner
c352a73bad s3-lsa: pure cosmetic indentation fixes. 
Guenther
 2009-10-28 12:24:17 +01:00
Günther Deschner
6937e01e3e s3-lsa: use enum lsa_LookupNamesLevel in lsa_lookup_level_to_flags(). 
Guenther
 2009-10-28 12:24:08 +01:00
Michael Adam
8fdef14305 s3: pdbedit: add option --kickoff-time/-K to set the user's kickoff time 
Use "never" as argument to set this to unlimited.

Michael
 2009-10-27 15:39:09 +01:00
Jeremy Allison
9a2112ec66 Second part of the fix for bug 6828 - infinite timeout occurs when byte lock held outside of samba. 
Fixes case where a connection with a pending lock can me marked "idle", and ensures
that the lock queue timeout is always recalculated.
Jeremy.
 2009-10-26 21:20:22 -07:00
Karolin Seeger
f381faa8d6 s3: Rename new parameter "ldap ref follow" to "ldap follow referral". 
This parameter will be introduced with Samba 3.5.0.

Karolin
 2009-10-26 12:11:59 +01:00
Barry Sabsevitz
3054fe46d9 Fix bug 6802 - A created folder does not properly inherit permissions from parent. 2009-10-23 11:50:29 -07:00
Jeremy Allison
4a1a9f5792 Simplify the logic. 
Jeremy.
 2009-10-22 15:26:22 -07:00
Jeremy Allison
843adc1981 Fix bug 6829 - smbclient does not show special characters properly. 
All successful calls to cli_session_setup() *must* be followed by
calls to cli_init_creds() to stash the credentials we successfully
connected with. There were 2 codepaths where this was missing. This
caused smbclient to be unable to open the \srvsvc pipe to do an RPC
netserverenum, and cause it to fall back to a RAP netserverenum,
which uses DOS codepage conversion rather than the full UCS2 of
RPC, so the returned characters were not correct (unless the DOS
codepage was set correctly). Phew. That was fun to track down :-).
Jeremy.
 2009-10-22 15:06:38 -07:00
Volker Lendecke
5c6944d33f s3: Remove a pointless #endif/#ifdef pair 2009-10-22 16:33:44 +02:00
Björn Jacke
78a5e26783 s3:Makefile: add some explicit dependencies to libc 
Add libc as explicit dependency where we use "-z defs" linker flags. This is
to silence the Sun linker. Otherwise it whines:

malloc  ... (symbol belongs to implicit dependency /lib/libc.so.1)
 2009-10-21 22:50:39 +02:00
Günther Deschner
209a65bc6f s3-lsa: Fix _lsa_EnumTrustDom() and avoid infite windows client loop. 
Found by RPC-LSA-TRUSTED-DOMAIN torture test.

Guenther
 2009-10-21 03:13:59 +02:00
Günther Deschner
32f2cc4487 s3-lsa: make s3 pass against RPC-LSA-LOOKUPNAMES again. 
Do what W2k8 does and return the builtin domain for a NULL name.

Guenther
 2009-10-21 02:57:08 +02:00
Günther Deschner
b9d9353b54 nsswitch: fix the build of the winbind krb5 locator plugin. 
Guenther
 2009-10-21 02:56:18 +02:00
Jeremy Allison
9356265802 Turn on LOCK9 test which will test for regressions in bug 6828. 
Jeremy.
 2009-10-20 17:53:06 -07:00
Jeremy Allison
bb7cf9ad23 Fix bug 6828 - infinite timeout occurs when byte lock held outside of samba 
Jeremy.
 2009-10-20 17:52:34 -07:00
Jeremy Allison
49b23fe248 Fix comments on new test. 
Jeremy
 2009-10-20 17:41:27 -07:00
Jeremy Allison
e58f880381 Add local (or NFS) lock test to smbtorture. Checks that local locks 
conflict with CIFS locks (see bug 6868).
Jeremy.
 2009-10-20 17:37:43 -07:00
Jeremy Allison
e349e2c541 Fix "make install" by removing all references to python. Not currently 
needed in source3, and isn't working anyway.
Jeremy.
 2009-10-20 13:42:28 -07:00
Jeremy Allison
0d33b0bfca Remove pythonmods from the build in source3, it doesn't build anyway 
and isn't needed (as far as I can tell).
Jeremy.
 2009-10-20 13:28:05 -07:00
Jeremy Allison
c79e2ff69a Fix the pam_smbpass.so build with the recent linker flag changes. 
Jeremy.
 2009-10-20 13:09:42 -07:00
Günther Deschner
49a1323495 s3-lsa: Fix _lsa_EnumTrustDom(). 
Windows clients were showing a lot of duplicates in their list of trusted
domains.

Found by RPC-LSA-TRUSTED-DOMAIN torture test.

Guenther
 2009-10-20 21:46:06 +02:00
Günther Deschner
d168d7fe3c s3-pdb_ldap: fix crash bug in ldapsam_set_trusteddom_pw(). 
Thanks Volker for the hint.

Guenther
 2009-10-20 21:44:02 +02:00
Björn Jacke
205284c904 s3:Makefile: rename LDSHFLAG variables to make meaning more obvious 2009-10-20 20:47:22 +02:00
Günther Deschner
a5a7b9ebc2 s3-lsa: Fix _lsa_CreateAccount() for usage of SEC_FLAG_MAXIMUM_ALLOWED. 
Found by RPC-LSA-PRIVILEGES torture test.

Guenther
 2009-10-20 15:57:06 +02:00
Günther Deschner
870f2d336a s3-selftest: enable RPC-LSA-PRIVILEGES against Samba 3. 
Guenther
 2009-10-20 15:57:00 +02:00
Günther Deschner
c7023c5a3d s3-lsa: Allow to lookup 'NT AUTHORITY\Anonymous Logon' as well. 
This is to finally pass RPC-LSA-LOOKUPNAMES test.

Guenther
 2009-10-20 15:28:31 +02:00
Günther Deschner
1f4d26c487 s3-lsa: allow to lookup BUILTIN\ in lsa_LookupNames. 
Found by RPC-LSA-LOOKUPNAMES torture test.

Guenther
 2009-10-20 15:28:31 +02:00
Günther Deschner
18dd626160 s3-lsa: When looking up domains in LookupNames, do not strip the sid. 
Found by RPC-LSA-LOOKUPNAMES torture test.

Guenther
 2009-10-20 15:28:31 +02:00
Günther Deschner
b6d97a00b1 s3-lsa: allow to have NULL strings in lsa LookupName queries. 
Found by RPC-LSA-LOOKUPNAMES torture test.

Guenther
 2009-10-20 15:28:30 +02:00
Björn Jacke
4243e6e3a9 s3:configure: add support for Solaris' ld -z ignore 
try linker flags for ignoring unused libs in this order:
-Wl,--as-needed (gcc like + binutils)
-Wl,-z,ignore (gcc like + Solaris linker)
-z ignore (old Sun C)
 2009-10-20 10:52:07 +02:00
Björn Jacke
f96f8f9c77 s3: make unresolved symbols in libs throw errors 
except for the Samba internal plugins unresolved symbol references should not
show up in shared libraries. For historical reasons it's the default behaviour
of linkers to ignore those in shared libs. We use -z defs (alias
--no-undefined) to not ignore them in shared libs.
 2009-10-20 10:52:06 +02:00
Björn Jacke
438f400680 s3: allow using different LDFLAGS for internal libs/plugins 
internal libs have unresolved symbols intentionally.
Thanks to Buchan Milne for suggestion and patch. This addresses #6792.
 2009-10-20 10:52:06 +02:00
Karolin Seeger
fa08d0b44b Fix typo. 
privilage -> privilege

Karolin
 2009-10-19 09:47:33 +02:00
Björn Jacke
718d2801d6 s3:configure: fix avahi activation 
Avahi was correctly found but not activated since e4a26c942.
 2009-10-18 17:06:29 +02:00
Jeremy Allison
8d85757578 Fix posix_unlink test. Was doing grep without quotes around the 
target string.
Jeremy.
 2009-10-17 20:46:22 -07:00
Jeremy Allison
096589aead Trying to find out why the posix_unlink test build farm is still failing even 
though we're now successfully deleting the symlink.
Jeremy.
 2009-10-17 10:38:44 -07:00
Volker Lendecke
3e3214fd91 s3:winbind: Move fillup_pw_field() as static to wb_fill_pwent.c 2009-10-17 17:13:02 +02:00
Jeremy Allison
f1d9960284 Add comment explaining about symlink following & posix. 
Jeremy.
 2009-10-16 18:13:06 -07:00
Jeremy Allison
ea3c077236 Last 2 VFS_STAT -> LSTAT fixes I can see in the modules code. 
Jeremy.
 2009-10-16 17:20:40 -07:00
Jeremy Allison
010dfbf1fd Fix one missing STAT -> LSTAT with POSIX pathnames in vfs_xattr_tdb.c. Caught by the torture tester. I love unit tests :-). Jeremy. 2009-10-16 16:38:59 -07:00
Björn Jacke
7655282ede s3: build pam_smbpass when possible 2009-10-16 23:46:52 +02:00
Günther Deschner
64e8aa1b14 s3-netlogon: fix updating trust accout passwords with downlevel domains. 
When choosing the netlogon password set function, make sure to look at the
*negotiated* flags in the cli->dc state, not the ones we start the negotiation
with.

Guenther
 2009-10-16 18:03:32 +02:00
Matthias Dieter Wallnöfer
fef032fac7 s3:srv_samr_nt - another fix for the reject reason 2009-10-16 15:26:14 +02:00
Günther Deschner
8267564e1c s3-netlogon: Fix _netr_ServerPasswordSet2 cleartext blob handling. 
Following Andrew's advice, let's straight md4 the plaintext blob and avoid
trying to get a paintext string out of the input the client sends.

Guenther
 2009-10-16 14:54:57 +02:00
Matthias Dieter Wallnöfer
441f0326be s3: Try to fix the build on Solaris & AIX regarding the password change reject reason 2009-10-16 12:27:57 +02:00
Günther Deschner
a85799d5db s3-libnetapi: add nltest tool. 
Guenther
 2009-10-16 10:54:55 +02:00
Günther Deschner
ca19ffde80 s3-libnetapi: add I_NetLogonControl{2} example code. 
Guenther
 2009-10-16 10:50:29 +02:00
Günther Deschner
d308aa3de8 s3-libnetapi: add I_NetLogonControl{2} to public headers. 
Guenther
 2009-10-16 10:50:28 +02:00
Günther Deschner
e31c2c7eb1 s3-libnetapi: fill in I_NetLogonControl{2}_r. 
Guenther
 2009-10-16 10:50:28 +02:00
Günther Deschner
e8e1d60941 s3-libnetapi: add I_NetLogonControl{2} skeleton. 
Guenther
 2009-10-16 10:50:28 +02:00
Günther Deschner
8bd4378ff8 s3-libnetapi: add I_NetLogonControl{2} to IDL. 
Guenther
 2009-10-16 10:50:27 +02:00
Günther Deschner
3f80b06d9e s3-selftest: enable WINBIND-WBCLIENT against s3. 
Guenther
 2009-10-16 02:04:37 +02:00
Günther Deschner
8b247f3538 s3-net: fix build warning (missing default in switch). 
Guenther
 2009-10-16 02:04:03 +02:00
Jeremy Allison
5cc895983d Fix valgrind memory leak in bug #6814 - Fixes for problems reported by valgrind 
Jeremy.
 2009-10-15 16:55:40 -07:00
Andrew Tridgell
a6e4cb500b s3: fixed krb5 build problem on ubuntu karmic 
Karmic has MIT krb5 1.7-beta3, which has the symbol
krb5_auth_con_set_req_cksumtype but no prototype for it.

See also http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=531635
 2009-10-16 10:40:50 +11:00
Günther Deschner
ef194bc692 s3-spnego: fix memleak in spnego_parse_auth(). 
Guenther
 2009-10-15 15:45:20 +02:00
Günther Deschner
449ab398f5 s3-spnego: Fix Bug #6815. Windows 2008 R2 SPNEGO negTokenTarg parsing failure. 
When parsing a SPNEGO session setup retry (falling back from KRB5 to NTLMSSP),
we failed to parse the ASN1_ENUMERATED negResult in the negTokenTarg, thus
failing spnego_parse_auth() completely.

By just using the shared spnego/asn1 code, we get the parsing the correct way.

Guenther
 2009-10-15 14:41:22 +02:00
Björn Jacke
dc586b933d s3: fix outdated proto.h causing build error on AIX 
Matthias, please check!
 2009-10-15 10:27:34 +02:00
Jeremy Allison
1c1a883bd0 Fix the build, missing ->. 
Jeremy.
 2009-10-14 12:36:02 -07:00
Jeremy Allison
ce4542fbde Final part of fix for bug 6793 - winbindd crash with "INTERNAL ERROR: Signal 6" 
Don't use mapped_user uninitialized.
Jeremy.
 2009-10-14 11:16:03 -07:00
Volker Lendecke
c6fc461e71 s3:winbind: Fix a double-free 
Part of a fix for bug #6793.
 2009-10-14 11:15:53 -07:00
Volker Lendecke
db29d3eb40 s3:winbind: Fix bug 6793 -- segfault in winbindd_pam_auth 2009-10-14 11:14:57 -07:00
Günther Deschner
67b544ba96 s3-build: we need to have talloc 2.0.1 when building with external talloc. 
2.0.0 did not got the exports right.
This and the 2.0.1 talloc fixes resolve bug #6808.

Guenther
 2009-10-14 17:45:59 +02:00
Günther Deschner
075303560f s3-passdb: missed two prototypes while moving to enum netr_SchannelType. 
Guenther
 2009-10-14 15:26:14 +02:00
Björn Jacke
e33c23dc5c s3:net: simplify padding to single printf call 2009-10-14 00:22:08 +02:00
Björn Jacke
6deb1fcc88 s3:net simplify padding to single printf call 2009-10-14 00:19:35 +02:00
Volker Lendecke
8a27fdea89 s3:net: Fix a segfault in "net rpc trustdom list" for overlong domain names 
That was a complicated way to say "%-20.s"... But that code was from 2002 ...
 2009-10-13 23:09:05 +02:00
Jeremy Allison
3f5c077f2d Remove use of "int ret" when we already have errcode. 
Jeremy.
 2009-10-13 13:28:57 -07:00
Jeremy Allison
df22f8dbd9 Catch one more erroneous use of errno. 
Jeremy.
 2009-10-13 13:03:39 -07:00
Olaf Flebbe
367cb714a3 correctly handle aio_error() and errno 2009-10-13 12:59:23 -07:00
Volker Lendecke
94d5417d10 s3:torture: Add a notify-bench test 
This is a test that creates and deletes files in a directory as fast as the
network allows it. At the same time, it opens a filechangenotify. This test is
done to just torture handling a single directory together with the notify
infrastructure.
 2009-10-13 20:34:25 +02:00
Volker Lendecke
1302526a74 s3:libsmb: Add cli_notify 2009-10-13 20:34:25 +02:00
Volker Lendecke
f3869f90f5 s3:rpc: Fix is_known_pipename for dynamically loaded pipes 2009-10-13 20:34:25 +02:00
Volker Lendecke
1341d4509c s3: Fix some nonempty blank lines 2009-10-13 20:34:24 +02:00
Andrew Tridgell
6e48aad3be s3: Fix vfs_shadow_copy2 to allow in-path @GMT-xxx 2009-10-13 20:34:24 +02:00
Olaf Flebbe
5ec557d9f6 s3/loadparm: Fix severe HPUX compiler issue. 
Members of struct should be initialized explictly.
Fixes bug #6804.
 2009-10-13 18:38:39 +02:00
Günther Deschner
a3306e352d s3-winbindd: add wbint_ChangeMachineAccount implementation. 
Guenther
 2009-10-13 12:42:44 +02:00
Günther Deschner
ebe0e64ba9 s3: use enum netr_SchannelType all over the place. 
Guenther
 2009-10-13 10:21:46 +02:00
Günther Deschner
aa8c142b5e s3-netlogon: allow to change any type of trust account password in trust_pw_find_change_and_store_it(). 
Guenther
 2009-10-13 10:21:42 +02:00
Günther Deschner
4a1b50afd5 s3-netlogon: pass down account name to remote password set functions. 
Guenther
 2009-10-13 00:07:45 +02:00
Björn Jacke
faad888e1a ѕ3: fix domain trust documentation confusion 
fix some trusted/trusting mixups, make documentation more precise
and man page more verbose.
 2009-10-12 22:42:27 +02:00
Karolin Seeger
8def289c8e s3/proto.h: Add lp_ldap_ref_follow prototype. 
Fix build of smbldap.

Karolin
 2009-10-12 12:52:29 +02:00
Jan Engelhardt
c5d5969e24 s3/smbldap: add option to disable following LDAP refs 
Fix bug #6717.
 2009-10-12 11:34:58 +02:00
Simo Sorce
7bce1ab5e8 Fix builds with external tdb 
Make sure we do not reference our internal tdb directly.
Let configure define what tdb.h file to use so that builds that use an
extrenal tdb do not include 2 different versions of the tdb header.
 2009-10-11 09:48:53 -04:00
Matt Kraai
815b790c96 Use the method used by build_env.sh to discover the user name. 
so try USERNAME, then LOGNAME, then whoami, then id -un to find out who we
are.
 2009-10-11 12:44:42 +02:00
Simo Sorce
99cdbe3571 Fix builds with external talloc 
Make sure we do not reference our internal talloc directly.
Let configure define what talloc.h file to use so that builds that use an
extrenal talloc do not include 2 different versions of the talloc header.
 2009-10-09 13:14:08 -04:00
Jeremy Allison
333fcba1de Cope with old CIFSFS clients that use SMBunlink to remove 
symlinks instead of trans2:posix_unlink.
Jeremy.
 2009-10-08 15:36:36 -07:00
Björn Jacke
76f73c73ea s3: make linking of libwbclient --as-needed safe 
Partly fixes #6791. Thanks to Buchan Milne!
 2009-10-09 00:24:18 +02:00
Volker Lendecke
f0fd5df7fd s3: Fix shadow copy display on Windows 7 
Windows 7 is a bit more picky on our NT_STATUS_BUFFER_TOO_SMALL. Announce the
right buffer size, the same amount we later check for.
 2009-10-08 14:07:07 +02:00
Günther Deschner
efaa98e824 s3-winbindd: NDR_WBINT_CHECKMACHINEACCOUNT should not be cacheable. 
Guenther
 2009-10-08 10:40:42 +02:00
Matthias Dieter Wallnöfer
607ceff234 s3/s4 - Adapt the IDL changes on various locations 2009-10-08 09:50:19 +02:00
Jeremy Allison
14dc32a4f5 Oops. Don't break the build.. 
Jeremy.
 2009-10-07 15:43:43 -07:00
Jeremy Allison
94ce06f01d Make the logic a lot clearer and fix the comment to match. 
Jeremy
 2009-10-07 15:39:38 -07:00
Jeremy Allison
746fb5aa4f Correct fix for bug 6781 - Cannot rename subfolders in Explorer view with recent versions of Samba. 
Without this fix, renaming a directory ./a to ./b, whilst a directory ./aa was already open
would fail.
Jeremy.
 2009-10-07 15:14:50 -07:00
Günther Deschner
3c3725a340 s3-winbindd: libwbclient: implement secure channel verification for specific domains in wbcCheckTrustCredentials(). 
Guenther
 2009-10-07 11:18:18 +02:00
Günther Deschner
3d3134a7d6 s3-netlogon: pure cosmetic indent fixes in _netr_LogonControl2Ex(). 
Guenther
 2009-10-07 10:36:22 +02:00
Günther Deschner
fea2a78beb s3: re-run make samba3-idl. 
Guenther
 2009-10-07 10:34:15 +02:00
Jeremy Allison
7709db4c03 Test creating and deleting a bad symlink using the POSIX calls. Ensure 
we don't regress on bug 6769.
Jeremy.
 2009-10-06 17:18:15 -07:00
Volker Lendecke
a4aa38f8b9 s3:winbind: Make query_user_list in winbindd_rpc a bit more readable 2009-10-06 21:33:20 +02:00
Abhidnya P Chirmule
ac774c4969 s3: Add access_mask to the flock VFS call 2009-10-06 18:52:06 +02:00
Günther Deschner
c344bf0184 s3-winbindd: make sure to reset connections when machine account password change chain was broken. 
Guenther
 2009-10-06 16:50:23 +02:00
Günther Deschner
0c2fc9eedf s3-netlogon: setup NETLOGON credential chain in rpccli_netlogon_set_trust_password() only when needed. 
Guenther
 2009-10-06 16:50:23 +02:00
Volker Lendecke
872f9c4f91 Revert "s3: Attempt to fix machine password change" 
This reverts commit 20a8ea91e1.

Ooops, this should not have been committed.
 2009-10-05 22:14:06 +02:00
Volker Lendecke
5bafaa73f6 s3:winbind: Slightly simplify the logic of nss_init(), make it static 2009-10-05 22:12:35 +02:00
Volker Lendecke
f88e95c6b0 s3:winbind: Fix typos 2009-10-05 22:12:34 +02:00
Volker Lendecke
20a8ea91e1 s3: Attempt to fix machine password change 2009-10-05 22:12:20 +02:00
Jeremy Allison
3fa1d7332c Fix bug 6776 - Running overlapping Byte Lock test will core dump Samba daemon. 
Re-write core of POSIX locking logic.
Jeremy.
 2009-10-05 10:27:48 -07:00
Günther Deschner
55b12d032c s3-net: print error when "net rpc changetrustpw" has failed. 
Guenther
 2009-10-05 13:01:53 +02:00
Volker Lendecke
84de81b478 s3: Remove a scary error message -- talloc_move can not fail :-) 
Signed-off-by: Günther Deschner <gd@samba.org>
 2009-10-05 12:14:08 +02:00
Volker Lendecke
d696f9a7ed s3: Fix nonempty blank lines 
Signed-off-by: Günther Deschner <gd@samba.org>
 2009-10-05 12:14:08 +02:00
Günther Deschner
926457ec95 s3: remove unused PRS_POINTER_CAST macro. 
Guenther
 2009-10-05 11:05:21 +02:00
Günther Deschner
2497f70257 s3: remove unused SYSTEMTIME struct. 
Guenther
 2009-10-05 11:05:21 +02:00
Björn Jacke
984d001cae s3:Makefile: another attempt to fix the wbclient dependency 
in the dependencies we always used a variable that was not jet defined.
 2009-10-04 02:20:21 +02:00
Björn Jacke
71229dde1e s3:Makefile: another attempt to fix the netapi dependency 
in the dependencies we always used a variable that was not jet defined.
 2009-10-04 02:20:21 +02:00
Björn Jacke
a45716400d s3:Makefile: another attempt to fix the tdb dependency 
in the dependencies we always used a variable that was not jet defined.
 2009-10-04 02:20:21 +02:00
Björn Jacke
da597f2df0 s3:Makefile: another attempt to fix the talloc dependency 
in the dependencies we always used a variable that was not jet defined.
 2009-10-04 02:20:21 +02:00
Björn Jacke
63dedac08f Revert "s3:Makefile: fix talloc dependencies with static build (2nd try)" 
This reverts commit b60d87c207.
 2009-10-04 02:20:20 +02:00
Björn Jacke
19794ea541 Revert "s3:Makefile: fix libtdb dependencies with static build" 
This reverts commit da15726630.
 2009-10-04 02:20:20 +02:00
Björn Jacke
be348842f5 Revert "s3:Makefile: fix libwbclient dependencies with static build" 
This reverts commit d7795f2afa.
 2009-10-04 02:20:20 +02:00
Björn Jacke
eae87ffb3f Revert "s3:Makefile: fix libnetapi dependencies with static build" 
This reverts commit 110897a057.
 2009-10-04 02:20:20 +02:00
Volker Lendecke
d5bd2ec251 s3:winbind: use wb_fill_pwent in wb_getpwsid 2009-10-04 00:14:01 +02:00
Volker Lendecke
c83b80435b s3:winbind: No point in using strequal to detect a 0-length string 2009-10-04 00:14:01 +02:00
Volker Lendecke
2bd3994ac3 s3:winbind: use talloc_tos() instead of NULL in fillup_pw_field 2009-10-03 16:43:16 +02:00
Volker Lendecke
dc56d42aa3 s3:winbind: Fix a debug message 2009-10-03 16:39:10 +02:00
Volker Lendecke
70e1d816b3 s3: Make default_[static|shared]_modules a bit more readable 2009-10-03 14:39:51 +02:00
Björn Jacke
777143ef53 s3:Makefile: minor clean up 2009-10-03 00:22:54 +02:00
Björn Jacke
110897a057 s3:Makefile: fix libnetapi dependencies with static build 
analogical to previous libtalloc fix
 2009-10-03 00:22:53 +02:00
Björn Jacke
fbb6571367 s3:Makefile: eventlogadm dependency cleanup 
no need to link against popt lib
 2009-10-03 00:22:53 +02:00
Björn Jacke
d7795f2afa s3:Makefile: fix libwbclient dependencies with static build 
analogical to previous libtalloc fix
 2009-10-03 00:22:53 +02:00
Björn Jacke
da15726630 s3:Makefile: fix libtdb dependencies with static build 
analogical to previous libtalloc fix
 2009-10-03 00:22:53 +02:00
Björn Jacke
b60d87c207 s3:Makefile: fix talloc dependencies with static build (2nd try) 
When configure options --with-libtalloc=no --enable-shared-libs=no are used,
LIBTALLOC_TARGET stays empty. Actually LIBTALLOC_TARGET which is only used for
Makefile dependencies is obsolete as LIBTALLOC contains exactly the targets
that we depend on, libtalloc finally is the target to depend on.
 2009-10-03 00:22:52 +02:00
Björn Jacke
99c4480674 Revert "s3:Makefile: fix talloc dependencies with static build" 
This reverts commit 2af2334522.

a more correct way to fix the libtalloc dependencies follows
 2009-10-03 00:22:52 +02:00
Björn Jacke
7124b4fbeb s3:Makefile: libsmbsharemode dependency cleanup 
no need to link against ldap and krb5 libs
 2009-10-03 00:22:52 +02:00
Björn Jacke
09936d52d2 s3:Makefile: net utility dependency cleanup 
no need to link against iniparser lib
 2009-10-03 00:22:52 +02:00
Björn Jacke
e1ebadb85b s3:configure: use --aѕ-needed linker option when supported 
Based on a patch from Andreas Schneider but modified that --aѕ-needed is also
used when own libs are not build shared (--enable-shared). Also change order of
options so that user supplied LDFLAGS are put *after* the automatic --aѕ-needed
flag. This way it's pollible to force not use as-needed by setting LDFLAGS
environment variable to "-Wl,--no-as-needed".
 2009-10-03 00:22:51 +02:00
Jeremy Allison
6f22cd10ad Remove lots of duplicate code and move it into one 
function vfs_stat_fsp(). Stops code looking at fsp->posix_open
except for exceptional circumstances.
Jeremy.
 2009-10-02 13:45:38 -07:00
Jeremy Allison
1cebf2dad1 Missed one VFS_STAT -> VFS_LSTAT 
Jeremy.
 2009-10-02 11:07:17 -07:00
Jeremy Allison
1e322cf6a9 Fix more use of VFS_STAT when posix pathnames selected. 
Jeremy.
 2009-10-02 11:05:03 -07:00
Andrew Tridgell
4cb055cacd ds-flags: use the new name DS_DNS_FOREST_ROOT 
Update to use the new DS_DNS_FOREST_ROOT name, which makes it clearer
what this bit means (according to MS-ADTS doc)
 2009-10-02 12:02:00 +10:00
Andrew Tridgell
5d60a7e23e s3-ads: removed 3 unused defines 
These are in nbt.idl and netlogon.idl as well, no need to have them
here under different names, especially when the comments are wrong
 2009-10-02 12:01:59 +10:00
Jeremy Allison
ce791d6645 Fix bug #6769 - symlink unlink does nothing. 
Always use LSTAT for POSIX pathnames.
Jeremy.
 2009-10-01 16:54:06 -07:00
Björn Jacke
2af2334522 s3:Makefile: fix talloc dependencies with static build 
When configure options --with-libtalloc=no --enable-shared-libs=no are used,
LIBTALLOC_TARGET stays empty. Actually LIBTALLOC_TARGET which is only used for
Makefile dependencies is obsolete as LIBTALLOC contains exactly the targets
that make the dependencies are. Obnox, pleaѕe check!
 2009-10-01 19:27:37 +02:00
Björn Jacke
0265891cfc s3:configure: don't throw away PRINT_LIBS 
PRINT_LIBS might have been set before intentionally, so don't thow it away.
 2009-10-01 19:27:37 +02:00
Björn Jacke
e9616e4c6d s3: update comment about (deprecated) a6 records 2009-10-01 19:27:37 +02:00
Jeremy Allison
00ce3e143f Fix for CVE-2009-2813. 
===========================================================
== Subject:     Misconfigured /etc/passwd file may share folders unexpectedly
==
== CVE ID#:     CVE-2009-2813
==
== Versions:    All versions of Samba later than 3.0.11
==
== Summary:     If a user in /etc/passwd is misconfigured to have
==              an empty home directory then connecting to the home
==              share of this user will use the root of the filesystem
==              as the home directory.
===========================================================
 2009-10-01 10:23:29 -07:00
Karolin Seeger
75f90772ce s3/VERSION: Raise version number up to 3.6.0. 
Karolin
 2009-10-01 14:50:28 +02:00
Jeremy Allison
8a6b90d401 Fix for CVE-2009-2906. 
Summary:
Specially crafted SMB requests on
authenticated SMB connections can send smbd
into a 100% CPU loop, causing a DoS on the
Samba server.
 2009-10-01 14:32:36 +02:00
Günther Deschner
e80891db41 s3-perfcount: more cleanup. 
Guenther
 2009-10-01 12:19:48 +02:00
Günther Deschner
25ab8828a1 s3-perfcount: only pass down prs_struct when really required. 
Guenther
 2009-10-01 12:19:48 +02:00
Günther Deschner
cd82d4ba56 s3: add perfcount idl and generated files. 
Guenther
 2009-10-01 12:19:43 +02:00
Günther Deschner
c6a7ecf28b s3-registry: move rpccli_winreg_Connect to the only file it belongs. 
Guenther
 2009-10-01 11:40:31 +02:00
Günther Deschner
bbc71486a7 s3: remove unused rpcstr_pull and rpcstr_pull_talloc. 
Guenther
 2009-10-01 11:40:31 +02:00
Günther Deschner
347eb9b970 s3-printing: more use of pull_reg_sz(). 
Guenther
 2009-10-01 11:40:31 +02:00
Günther Deschner
ad836c4d48 s3-registry: use pull_reg_sz() where appropriate. 
(and move away from rpcstr_pull and rpcstr_pull_talloc).

Guenther
 2009-10-01 11:40:30 +02:00
Olaf Flebbe
087ba21b41 allow for outstanding_aio_calls to be decremented 2009-09-30 15:20:09 -07:00
Günther Deschner
bbf394f36d s3-printing: use regval_ctr_addvalue_multi_sz. 
Guenther
 2009-09-30 16:23:40 +02:00
Günther Deschner
05e8e90976 s3-registry: add regval_ctr_addvalue_multi_sz. 
Guenther
 2009-09-30 16:23:33 +02:00
Günther Deschner
afdea18fcf s3-rpc_parse: remove unused prs_string. 
Guenther
 2009-09-30 16:22:34 +02:00
Kamen Mazdrashki
0e1840b84a w32err: WERR_GROUP_NOT_FOUND renamed to WERR_GROUPNOTFOUND 
In Win 32 we have
NERR_GroupNotFound which maps to WERR_GROUP_NOT_FOUND currently
and we have
ERROR_GROUP_NOT_FOUND which maps to nothing, so it is to be added

Signed-off-by: Anatoliy Atanasov <anatoliy.atanasov@postpath.com>
 2009-09-30 15:48:41 +03:00
Kamen Mazdrashki
d9994a604b w32err: WERR_DC_NOT_FOUND replaced with WERR_DCNOTFOUND 
It turns out in win32 ERROR_DC_NOT_FOUND exists and it is
an error for Device Context (DC), not Domain Controller

Signed-off-by: Anatoliy Atanasov <anatoliy.atanasov@postpath.com>
 2009-09-30 15:48:40 +03:00
Günther Deschner
6c0abbdd35 s3-netlogon: properly implement _netr_NetrEnumerateTrustedDomains(). 
Guenther
 2009-09-30 00:37:13 +02:00
Günther Deschner
eb7a404225 s3: remove unused unistr2_term_codes. 
Guenther
 2009-09-30 00:36:05 +02:00
Günther Deschner
26e798da19 s3: remove unused regval_convert_multi_sz(). 
Guenther
 2009-09-30 00:34:01 +02:00
Günther Deschner
2ccf75d9a9 s3: remove unused regval_build_multi_sz(). 
Guenther
 2009-09-30 00:33:54 +02:00
Günther Deschner
76bb380839 s3-rpc_parse: remove unused UNISTR2 struct and init function. 
Guenther
 2009-09-30 00:33:47 +02:00
Günther Deschner
b0a66496f5 s3: use pull_reg_multi_sz in rpcclient and net. 
Guenther
 2009-09-30 00:31:42 +02:00
Günther Deschner
fc1c243348 s3-util: use pull_reg_multi_sz in reg_pull_multi_sz. 
Guenther
 2009-09-30 00:31:17 +02:00
Günther Deschner
661342ee2f s3-registry: use pull_reg_multi_sz(). 
Guenther
 2009-09-30 00:30:59 +02:00
Günther Deschner
f8016cfee9 s3-util: add pull_reg_sz() and pull_reg_multi_sz() convenience functions. 
Guenther
 2009-09-30 00:30:47 +02:00
Günther Deschner
2d6e5e160b s3: use push_reg_multi_sz(). 
Guenther
 2009-09-30 00:30:25 +02:00
Günther Deschner
1b0f3b7e3a s3-registry: use regval_ctr_addvalue_sz(). 
Greatly simplifies and cleanes up the code.

Guenther
 2009-09-30 00:30:12 +02:00
Günther Deschner
a50cc61ee6 s3-registry: add regval_ctr_addvalue_sz. 
Guenther
 2009-09-30 00:29:56 +02:00
Günther Deschner
2c11b73391 s3-registry: use push_reg_sz(). 
Guenther
 2009-09-30 00:29:49 +02:00
Günther Deschner
fcee9d2c97 s3-util: add push_reg_sz() and push_reg_multi_sz() convenience functions. 
Guenther
 2009-09-30 00:29:24 +02:00
Volker Lendecke
0cf317f36f s3: Remove the lua interpreter again 
This was meant to support async winbind. But as the hairy parts of async
winbind (getgrent) are done without it, it can go again.
 2009-09-29 13:51:43 +02:00
Jeremy Allison
325baf37ff Don't defer a talloc_move'd pointer. 
Jeremy.
 2009-09-28 21:36:15 -07:00
Jeremy Allison
2e989bab07 Second part of fix for bug #6235 - domain enumeration breaks if master browser has space in name. 
Ensure we ask for the #20 name as we're using it as a server.
Jeremy.
 2009-09-28 11:23:30 -07:00
Volker Lendecke
80ef513e90 s3:winbind: remove a pointless initialization 2009-09-28 19:50:51 +02:00
Volker Lendecke
2185490176 s3:gencache: Add my copyright 2009-09-28 19:47:19 +02:00
Volker Lendecke
dc8538b405 s3:winbind: Make check_info3_in_group, sanitize its memory handling 2009-09-28 17:54:20 +02:00
Volker Lendecke
f18d0b036c s3:winbind: Make "check_request_flags" publically available 2009-09-28 17:54:20 +02:00
Volker Lendecke
def5bf57c5 s3:winbind: Sanitize the args for find_auth_domain: It only needs the flags 2009-09-28 17:54:20 +02:00
Volker Lendecke
93db77adcb s3:winbind: Make append_data publically available as append_auth_data 2009-09-28 17:54:20 +02:00
Karolin Seeger
388470f1f3 s3/VERSION: Raise version up to 3.5.0. 
Karolin
 2009-09-28 16:57:29 +02:00
Christian Ambach
de0f3b657d changed debuglevel for two messages in the GPFS module from 0 to 10 they spammed the logs on a test machine and they are just debug messages, so let's move them to the level of the other debug messages in the file 
Signed-off-by: Christian Ambach <christian.ambach@de.ibm.com>
 2009-09-28 16:37:28 +02:00
Matthias Dieter Wallnöfer
fb1eb11267 s3:smbd/password - move list pointers into blocks 2009-09-25 10:59:13 +02:00
Günther Deschner
0650423edf s3-libndr: fix build warning. 
Guenther
 2009-09-25 11:46:51 +02:00
Stefan Metzmacher
bfd3a6f13a s3:winbindd_cm: don't invalidate the whole connection when just samr gave ACCCESS_DENIED 
metze
 2009-09-25 08:18:45 +02:00
Stefan Metzmacher
68b8149d1f s3:rpc_client: don't randomly fragment rpc pdu's in developer mode 
This is really confusing and also breaks against windows,
as it doesn't accept fragmented bind requests.

metze
 2009-09-25 05:20:16 +02:00
Jeremy Allison
1e4868d251 Reduce debug log level from 0 -> 7 on non-critical message. 
Jeremy.
 2009-09-24 17:44:45 -07:00
Jeremy Allison
536c4dd2d6 Revert b39c390280 - casts should not 
be here.
Jeremy.
 2009-09-24 15:44:28 -07:00
Jeremy Allison
4f10aa5973 Revert 918b5a7e05. This code 
should *not* return const.
Jeremy.
 2009-09-24 15:42:36 -07:00
Matthias Dieter Wallnöfer
b39c390280 s3: Fix up various string "const" warnings 
My changed introduced some warnings. Fix them.
 2009-09-24 23:58:36 +02:00
Matthias Dieter Wallnöfer
918b5a7e05 s3:util_str "str_list_make_v3" - introduce also here the "const" result 
I did this to match with the default util strlist library.
 2009-09-24 23:58:19 +02:00
Matthias Dieter Wallnöfer
506b0b6435 s3:vfs_default - correct function parameters 2009-09-24 23:49:41 +02:00
Günther Deschner
c789d041f0 s3-winbindd: no reason to call winbindd_can_contact_domain() three times in query_user(). 
Guenther
 2009-09-24 22:55:38 +02:00
Günther Deschner
4b01e378d2 s3: remove unused printing macros. 
Guenther
 2009-09-24 22:55:29 +02:00
Steven Danneman
60433b154d s3 onefs: Fix 1 second share mode delay handling 
When racing to the open and loosing we may get a share_mode violation.
In this case handle the 1-second delay via a defferred open properly.

This requires us to retrieve the share_mode_lock before deferring
open so we don't dereference a NULL pointer assuming we already had
the lck because we were the first opener.
 2009-09-24 11:31:35 -07:00
Steven Danneman
74c0a7a1d3 s3 onefs: Fix a race condition exists in onefs_open.c between multiple opens to the same file. 
Two openers can stat a file at the same time, see that it doesn't exist,
and then both race to open it first.  The loser will enter
onefs_open_file_ntcreate believing that the file doesnt exist, and thus
skip any current state lookups for that file.  This includes setting
the file_id, and having a valid stat buffer.

Normally on first create the file_id will be set during the open, but
the second opener in this scenario may fail the open (oplock/share mode)
and file_id will not be set, nor will the stat buffer be valid.

In the error paths of this patch, we now double check that the file_id
and the stat buffer are valid before doing other operations.
 2009-09-24 11:31:21 -07:00
Zack Kirsch
5e9aade516 s3 onefs: Add some debugging/asserts to give more info when there is bad deferred open state. 
Signed-off-by: Tim Prouty <tprouty@samba.org>
 2009-09-24 11:19:00 -07:00
Tim Prouty
86b1a4cb86 s3: Add more helpful debugging to some of the streams code 2009-09-24 10:59:33 -07:00
Aravind Srinivasan
32ee976708 vfs catia: Fix a NULL dereference when CATIA is loaded with no mappings specified. 
When we use the CATIA vfs module and don't have any mapping specified,
we return NULL for the mapped_name, thereby resulting in segfaults.
When we don't have catia mapping, we should just use the old name
instead of returning NULL for the mapped_name.

Signed-off-by: Tim Prouty <tprouty@samba.org>
 2009-09-24 10:59:33 -07:00
Aravind Srinivasan
637901c242 vfs catia: Fix the double translation that was happening with createfile and open. 
Since the catia translation is implemented for open, it should not
also be done in createfile.  By removing createfile from catia,
translation is now done correctly for the primary open path.

In order to support systems that have custom createfile
implementations that don't eventually call SMB_VFS_OPEN,
SMB_VFS_TRANSLATE_NAME has been expanded to take an additional
argument that specifies direction.

Signed-off-by: Tim Prouty <tprouty@samba.org>
 2009-09-24 10:59:33 -07:00
Aravind Srinivasan
c870043b27 vfs catia: Fix a possible NULL dereference 
Also free some unfreed memory.

Signed-off-by: Tim Prouty <tprouty@samba.org>
 2009-09-24 10:59:33 -07:00
Volker Lendecke
50f248a06c s3: Forgot to check in one build failure for vfs_gpfs.c 2009-09-24 13:11:46 +02:00
Volker Lendecke
69447de175 s3: Remove an unused variable 2009-09-24 13:11:46 +02:00