1
0
mirror of https://github.com/samba-team/samba.git synced 2025-02-04 17:47:26 +03:00

639 Commits

Author SHA1 Message Date
Andrew Tridgell
956b5a0003 fixed use of reference in pytalloc
The previous code caused memory leaks, and also caused situations
where talloc_free could be called on pointers with multiple parents

The new approach is to have two functions:

  py_talloc_import : steals the pointer, so it becomes wholly owned by
                     the python object
  py_talloc_reference: uses a reference, so it is owned by both python
                     and C
2009-07-01 15:15:37 +10:00
Michael Adam
e4e855563b lib/util: fix building tevent_ntstatus without config.h
(when called from places with "#define NO_CONFIG_H" set, such as configure)

 Michael
2009-06-29 16:51:52 +02:00
Stefan Metzmacher
857ed9ca5a tsocket/bsd: also ask for TEVENT_FD_READ when we want to write into a stream socket
Otherwise we would not notice a broken connection.

metze
2009-06-29 16:03:57 +02:00
Stefan Metzmacher
b1d5e515b2 tsocket/bsd: more correctly check if the cached tevent_fd is still valid
I some cases the pointer value of tevent_context is the same again,
if we do something like:

	ev1 = tevent_context_init();
	...
	fde = tevent_add_fd(ev1, fd, TEVENT_FD_READ...);
	...
	talloc_free(ev1);
	...
	ev2 = tevent_context_init();

	if (ev1 == ev2) {
		/* this can happen! */
	}

	if (tevent_fd_get_flags(fde) == 0) {
		/* this is always true */
	}

But the "talloc_free(ev1)" will set fde->event_ctx to NULL
and tevent_fd_get_flags() will always return 0.

metze
2009-06-29 16:03:57 +02:00
Andrew Bartlett
6e92505080 Fix ndrdump to use a common setup_logging() API
By adding a new common setup_logging_stdout() API, we no longer need to abuse the ABI compatability between the different setup_logging() calls in Samba3 and Samba4's DEBUG() subsystems.

The revert of 49a6d757b4d944cd22c91b2838beb83f04fbe1e9 works with this
to fix bug 6211.

Andrew Bartlett
2009-06-29 20:12:23 +10:00
Andrew Bartlett
0e95b807b9 Revert "s4:debug: make setup_logging() a bit more compatible with samba3"
The problem is that the enum was previously a 'rachet', that is, it
would only reset to a level higher than it was previouly set to.
Changing the order broke file-based logging for our production sites.

This reverts commit 49a6d757b4d944cd22c91b2838beb83f04fbe1e9.
2009-06-29 19:57:57 +10:00
Nathaniel McCallum
1e21adaaf6 Two patches which fix issues on cross compiling/building 2009-06-29 13:39:52 +10:00
Volker Lendecke
c687eb15d9 Properly free a downlevel readv request. Metze, please check 2009-06-27 23:17:49 +02:00
Volker Lendecke
22cb9bdfd3 Move asn1_load_nocopy() to lib/util/asn1.c 2009-06-20 18:54:07 +02:00
Volker Lendecke
ecf8cebf32 Move asn1_blob() to lib/util/asn1.c 2009-06-20 18:54:07 +02:00
Andrew Bartlett
17e1cbb6d3 Partially revert restriction of socket_wrapper to 1500 byte writes
This keeps the restriction for stream sockets (where the caller will
retry), without creating problems on datagram sockets (CLDAP is not
defined, as far as I know, across multiple UDP packets).

The commit adding this restriction was
47b106c0ae8b91c9cccfc21bf8e4e416b1abfd5d

Andrew Bartlett
2009-06-19 14:36:06 +10:00
Simo Sorce
c92505817d Revert "For tevent to install tevent_util.h"
This reverts commit b112cc5503350b248949bdbcce8072f5523ce877.

tevent_util.h is a private header. Must not be installed.
2009-06-18 07:56:51 -04:00
Eric Sandall
b112cc5503 For tevent to install tevent_util.h
Patch for bug #6270

This patch is for the future when samba4 builds using external libraries. With
this patch, tevent now installs tevent_util.h which is required by samba4.
2009-06-18 13:49:26 +10:00
Andrew Kroeger
71515ba190 s4: Call va_end() after all va_start()/va_copy() calls.
This corrects the issues reaised in bug #6129, and some others that were not
originally identified.  It also accounts for some code that was in the original
bug report but appears to have since been made common between S3 and S4.

Thanks to Erik Hovland <erik@hovland.org> for the original bug report.
2009-06-18 13:49:25 +10:00
Jelmer Vernooij
43b7a0e34e tdb: Fix help string in configure flag to enable Python bindings. 2009-06-17 21:12:50 +02:00
Simo Sorce
ac1d311e9c fix release scripts to always git clean
This makes sure we do not include foreign object files or other
build byproducts by mistake.
2009-06-17 14:18:03 -04:00
Simo Sorce
efccef09ae Add exports file and abi checker for tevent
This is a first attempt at exporting symbols only for public functions
We also provide a rudimentary ABI checker that tries to check that
function signatures are not changed by mistake.
Given our use of macros this is not an API checker.
It's all based on tevent.h contents and the gcc -aux-info option
2009-06-15 16:31:13 -04:00
Simo Sorce
e83f4b868b Add exports file and abi checker for talloc
This is a first attempt at exporting symbols only for public functions
We also provide a rudimentary ABI checker that tries to check that
function signatures are not changed by mistake.
Given our use of macros this is not an API checker.
It's all based on talloc.h contents and the gcc -aux-info option
2009-06-15 16:31:12 -04:00
Simo Sorce
7aee9f92e7 Add exports file and abi checker for tdb
This is a first attempt at exporting symbols only for public functions
We also provide a rudimentary ABI checker that tries to check that
function signatures are not changed by mistake.
Given our use of macros this is not an API checker.
It's all based on tdb.h contents and the gcc -aux-info option
2009-06-15 16:31:12 -04:00
Simo Sorce
f518e37c09 Add new replace check for --version-script
Allows us to pass an export files on Linux and Solaris so that we can expose
only symbols that are actually supposed to be global, and keep as local anything
else.
2009-06-15 16:31:12 -04:00
Simo Sorce
57ba31ca96 Add option to --disable-python on build 2009-06-15 16:31:11 -04:00
Volker Lendecke
b706265786 Fix a = vs == error in writev_handler 2009-06-15 07:48:48 +02:00
Andrew Bartlett
9b261c008a s4:heimdal: import lorikeet-heimdal-200906080040 (commit 904d0124b46eed7a8ad6e5b73e892ff34b6865ba)
Also including the supporting changes required to pass make test

A number of heimdal functions and constants have changed since we last
imported a tree (for the better, but inconvenient for us).

Andrew Bartlett
2009-06-12 07:45:48 +10:00
Jelmer Vernooij
68578d6374 selftest: Fix handling of testsuite, reintroduce progress indication. 2009-06-11 19:59:59 +02:00
Andrew Bartlett
223b30f593 Fix build of recurusion fix in reopen_logs() 2009-06-11 19:08:33 +10:00
Andrew Bartlett
e5353ce95b Don't recurse in reopen_logs().
Use the state to avoid recursion in reopen_logs(), as DEBUG() can call
this function.

Andrew Bartlett
2009-06-11 18:54:32 +10:00
Günther Deschner
27bb7ac5d1 lib-util: move set_blocking() call into own file.
Guenther
2009-06-10 21:25:57 +02:00
Andrew Tridgell
d42019644b added asn1 functions for handling booleans in a simple context 2009-06-10 11:45:53 +10:00
Andrew Tridgell
c0965e0eec It seems that IRIX doesn't have IOV_MAX 2009-06-09 14:54:15 +10:00
Andrew Tridgell
f7ba8ba5c3 try to get PICFLAG right for HP-UX with gcc 2009-06-09 14:18:58 +10:00
Andrew Tridgell
03dd06de9a fixed socket wrapper to determine family from the right structure
In convert_in_un_remote() the socket family can be accessed either as
si->family or inaddr->sa_family. We were using the si->family to
determine how to cast the inaddr structure, but if si->family !=
inaddr->sa_family then we will incorrectly be casting a in6 structure
as in4 or vice-versa.
2009-06-09 13:33:09 +10:00
Günther Deschner
7caf51c37a nss_wrapper: fix typo in testsuite.
Guenther
2009-06-08 22:45:16 +02:00
Jelmer Vernooij
7f52c8fb50 libsamba-util: Fix soversion. 2009-06-08 22:43:36 +02:00
Timur I. Bakeyev
40178dd81e Add langinfo.h to the system/locale.h
This patch for Samba4. It's not really inspired by any real need, just
for the consistency. We define replace/system/locale.h as a generic
header, that includes all locale related headers and we are using
nl_langinfo at least in Samba3. So, it would be consistent to add yet
another locale-related header to the set of locale.h headers.

Here is the patch.

With regards,
Timur Bakeyev.

Signed-off-by: Stefan Metzmacher <metze@samba.org>
2009-06-08 13:20:51 +02:00
Günther Deschner
7e8b3d8c06 nss_wrapper: add my copyright.
Guenther
2009-06-08 10:26:39 +02:00
Stefan Metzmacher
bccef82516 replace: add fallback define for IOV_MAX
This hopefully fixes the build on IRIX.

metze
2009-06-08 09:40:11 +02:00
Stefan Metzmacher
eff9bcc9c7 talloc: try to fix the source4 build on AIX
metze
2009-06-08 09:40:11 +02:00
Stefan Metzmacher
faabc97c9a async_sock: try fix the source4 build on FreeBSD, Solaris, SLES8
metze
2009-06-08 09:40:06 +02:00
Slava Semushin
497b9e460b lib/tdb/tools/tdbtorture.c: fixed memory leak.
Found by cppcheck:
[lib/tdb/tools/tdbtorture.c:326]: (error) Memory leak: pids
2009-06-06 22:33:39 +02:00
Volker Lendecke
537b257cca Use data_blob_null instead of data_blob(NULL, 0) 2009-06-06 10:42:55 +02:00
Volker Lendecke
a731eb64d9 Fix an uninitialized variable read in async_connect_send 2009-06-06 10:42:55 +02:00
Günther Deschner
0bf56f5cb3 nss_wrapper: rename nwrap_cache_{re,un}load as per metzes request.
Guenther
2009-06-06 02:00:36 +02:00
Günther Deschner
68a1ef2197 nss_wrapper: add support for loading nss_winbind.so via WINBIND_SO_PATH env.
Guenther
2009-06-06 01:01:25 +02:00
Günther Deschner
a845cb5ed3 nss_wrapper: fill in module nwrap_backend.
Guenther
2009-06-06 00:59:51 +02:00
Günther Deschner
2e78bc7b53 nss_wrapper: add missing return in nwrap_module_init().
Guenther
2009-06-05 23:10:58 +02:00
Günther Deschner
f3aa2a2b73 nss_wrapper: add skeleton for module nwrap_backend.
Guenther
2009-06-05 23:04:14 +02:00
Günther Deschner
6985f3995f nss_wrapper: add capability to load nss modules.
Guenther
2009-06-05 23:04:10 +02:00
Günther Deschner
47b5a55239 nss_wrapper: add struct nwrap_backend.
Guenther
2009-06-05 23:01:05 +02:00
Günther Deschner
61cf117f86 nss_wrapper: add cross checking test to testsuite.
Guenther
2009-06-05 15:58:22 +02:00
Günther Deschner
59ee0a1e8a nss_wrapper: add tests for getgrent_r to testsuite.
Guenther
2009-06-05 15:58:16 +02:00