sin/samba-mirror
1
0
Fork 0
mirror of https://github.com/samba-team/samba.git synced 2025-01-11 05:18:09 +03:00
Code
133,060 Commits 60 Branches 1,145 Tags 452 MiB
963688b3a5
Commit Graph

15 Commits

Author SHA1 Message Date
Andrew Bartlett
a85d257c1e librpc: Do not access name[-1] trying to push "" into a dnsp_name 
This simply matches the behaviour from before e7b1acaddf
when the logic for a trailing . was added.  This matches what is added in
the dnsRecord attribute for a name of "." over the dnsserver RPC
management interface and is based on what Windows does for that name
in (eg) an MX record.

No a security bug because we use talloc and so name will be just the
end of the talloc header.

Credit to OSS-Fuzz

Found using the fuzz_ndr_X fuzzer

Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>

Autobuild-User(master): Ralph Böhme <slow@samba.org>
Autobuild-Date(master): Fri Dec 20 11:33:52 UTC 2019 on sn-devel-184
 2019-12-20 11:33:52 +00:00
Volker Lendecke
ce9e4a3501 CVE-2016-2123: Fix DNS vuln ZDI-CAN-3995 
Thanks to Trend Micro's Zero Day Initiative and Frederic Besler for finding
this vulnerability with a PoC and a good analysis.

Signed-off-by: Volker Lendecke <vl@samba.org>
Bug: https://bugzilla.samba.org/show_bug.cgi?id=12409
 2016-12-20 07:51:14 +01:00
Garming Sam
89f5bbc971 dns: remove double talloc for strings 
Signed-off-by: Garming Sam <garming@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
 2016-05-03 08:10:09 +02:00
Stefan Metzmacher
1cc57a98d4 CVE-2016-0771: librpc: add ndr_dnsp_string_list_copy() helper function 
BUG: https://bugzilla.samba.org/show_bug.cgi?id=11128
BUG: https://bugzilla.samba.org/show_bug.cgi?id=11686

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Garming Sam <garming@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
 2016-03-10 06:52:23 +01:00
Matthieu Patou
0d1e326a68 librpc: simplify ndr_pull_dnsp_string 
total_len is 1 and never varies.

Signed-off-by: Matthieu Patou <mat@matws.net>
Reviewed-by: Michael Adam <obnox@samba.org>
 2014-10-03 11:01:42 +02:00
Volker Lendecke
6f133c911f librpc: Fix an incompatible pointer type warning 
Signed-off-by: Amitay Isaacs <amitay@gmail.com>
 2012-05-30 14:58:56 +02:00
Amitay Isaacs
7b8cd6fcf3 ndr: Add NDR pull, push, print functions for dnsp_string_list 2012-03-02 00:24:50 +11:00
Amitay Isaacs
c46763419a ndr: Fix NDR push function for dnsp_string 
Push the actual length of the string not including null-termination.
 2012-03-02 00:24:49 +11:00
Amitay Isaacs
ad1ef79486 ndr: Fix the error messages, add correct data type name 2012-03-02 00:24:49 +11:00
Andrew Tridgell
e7b1acaddf dns: cope with trailing '.' in dns_name 2010-12-21 11:18:20 +01:00
Andrew Tridgell
4820c97e9e dns: fixed the padding for dnsp_name fields in LDAP 
all names are NUL terminated, but may have additional padding as well

Autobuild-User: Andrew Tridgell <tridge@samba.org>
Autobuild-Date: Tue Dec 21 03:26:26 CET 2010 on sn-devel-104
 2010-12-21 03:26:26 +01:00
Andrew Tridgell
b9a2852fdd dnsp: fixed parsing of dns_name structures 
its not a pad byte, its a trailing zero
 2010-12-21 02:42:37 +01:00
Kai Blin
65d2cfdcf1 dnsp: Parse TXT records 2010-10-04 20:59:59 +02:00
Andrew Tridgell
7bb5d353e8 dnsp: dnsp_name is 2 byte aligned 
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
 2010-08-14 11:58:12 +10:00
Andrew Tridgell
1946ab5a1b s4-dns: ndr_dnsp helper functions 
these handle the dnsp_name type
 2010-08-05 17:31:29 +10:00