1
0
mirror of https://github.com/samba-team/samba.git synced 2025-01-12 09:18:10 +03:00
Commit Graph

28546 Commits

Author SHA1 Message Date
Stefan Metzmacher
18b4925031 s3:libads: use libcli/cldap code
metze
2009-03-19 16:26:00 +01:00
Stefan Metzmacher
4508152282 s3:build: compile lib/tsocket and libcli/cldap
metze
2009-03-19 16:25:59 +01:00
Björn Jacke
011ad7245d fix build on old Heimdal based systems
Signed-off-by: Günther Deschner <gd@samba.org>
2009-03-19 14:47:48 +01:00
Stefan Metzmacher
88dd6af605 s3:libsmb: always create bytes array in cli_trans code
Otherwise we return NO_MEMORY without a reason for fragmented trans
requests, as talloc_append_blob() returns buf if we append a 0 length
blob. When we pass buf = NULL we'll get back NULL and then assume
NO_MEMORY...

metze
2009-03-19 13:57:21 +01:00
Stefan Metzmacher
880fbc4e8c s3:libsmb: fix smb signing for fragmented trans/trans2/nttrans requests
Before we send the secondary requests we need to remove the
old mid=>seqnum mapping and reset cli->mid and make the new
mid=>seqnum mapping "persistent".

The bug we had in cli_send_trans was this:
The first cli_send_smb() incremented cli->mid
and the secondary requests used the incremented mid,
but as cli->outbuf still had the correct mid,
we send the correct mid to the server. The real problem
was that the cli_send_smb() function stored the seqnum
under the wrong mid.

cli_send_nttrans() was totally broken and now follows the
same logic as cli_send_trans().

The good thing is that in practice the problem is unlikely to happen,
because max_xmit is large enough to avoid secondary requests.

metze
2009-03-19 13:54:22 +01:00
Stefan Metzmacher
0dfdb7b911 s3:lib/util_sock: use sys_recv() instead of sys_read() on sockets
This ways the pcap support in socket wrapper sees the received data.

metze
2009-03-19 13:54:17 +01:00
Jeremy Allison
c5394cd7cf Modify simple POSIX open test to use filenames containing a ':'
character. Should stop regressions of bug #6196.
Jeremy.
2009-03-18 21:49:32 -07:00
Jeremy Allison
28e03f2011 Allow DFS client paths to work when POSIX pathnames have been
selected (we need to path in pathname /that/look/like/this).
Jeremy.
2009-03-18 20:57:47 -07:00
Jeremy Allison
a00a9e4e2c Fix bug #6196 - Unable to serve files with colons to Linux CIFS/VFS client
Looks like the pathname parsing for POSIX paths got
broken when the code for doing Windows streams parsing got added.
Jeremy.
2009-03-18 20:01:33 -07:00
Tim Prouty
710948c788 s3 onefs: Correctly error out when the read returns EOF
Also add some more debugging.
2009-03-18 16:51:41 -07:00
Jeremy Allison
f942cb616e Fix bug #6195 - Migrating from 3.0.x to 3.3.x can fail to update passdb.tdb correctly.
This is a really nasty one to fix as in order to successfully update the
passdb.tdb we must do the equivalent of a tdbbackup to move to the new hash
values before we do the upgrade.
Jeremy.
2009-03-18 15:44:13 -07:00
Günther Deschner
531af136f9 s3: remove POLICY_HND.
Guenther
2009-03-18 23:22:29 +01:00
Günther Deschner
7d7b1a8dcc s3-rpc_parse: remove some unused parsing code.
Guenther
2009-03-18 22:02:23 +01:00
Günther Deschner
a1256594b0 s3-spoolss: fix _spoolss_GetPrinterData printerserver handle query error code.
When _spoolss_GetPrinterData receives a query on a printserver handle for a
value that we have not stored or do not provide, we need to return
WERR_INVALID_PARAM, not WERR_BADFILE. Tested with w2k and w2k3 servers.
Found by torture test.

Guenther
2009-03-18 21:57:07 +01:00
Günther Deschner
43182fdff8 s3-spoolss: fix _spoolss_EnumPrinterDataEx error path.
When a windows clients queries the "" key, we need to make sure to return with
the appropriate error (WERR_INVALID_PARAM in that case), and not fall through
to the buffer size handling macros. Found by torture test.

Guenther
2009-03-18 21:56:38 +01:00
Günther Deschner
7a85a87edf s3-rpc_parse: remove unused BUFFER5 and UNISTR3.
Guenther
2009-03-18 20:17:01 +01:00
Günther Deschner
e966719049 s3-rpc_client: remove unused CLI_DO_RPC_WERR macro.
Guenther
2009-03-18 20:01:51 +01:00
Günther Deschner
21391f7fbe s3-smbcontrol: use correct PRINTER_NOTIFY flags.
Guenther
2009-03-18 17:46:00 +01:00
Günther Deschner
9d1ab9a001 spoolss: add my copyright.
Guenther
2009-03-18 17:18:46 +01:00
Günther Deschner
7fbdf8aae9 s3-spoolss: remove include/rpc_spoolss.h.
Guenther
2009-03-18 17:09:39 +01:00
Günther Deschner
36d0785806 s3-spoolss: remove rpc_server/srv_spoolss.c alltogether.
Guenther
2009-03-18 17:09:33 +01:00
Günther Deschner
a502392541 s3-spoolss: remove rpc_parse/parse_spoolss.c alltogether.
Good-Bye, last hand-marshalled rpc functions, rest in peace.

Guenther
2009-03-18 17:09:26 +01:00
Günther Deschner
a4e999c7e3 s3-spoolss: remove old spoolss_EnumPrinterDataEx.
Guenther
2009-03-18 17:09:18 +01:00
Günther Deschner
0cfb1aea29 s3-spoolss: use pidl for _spoolss_EnumPrinterDataEx.
Please note that this has been the last call in samba3 that was
using hand-marshalled rpc. With this commit all named pipe rpc services
in samba3 have now fully moved to pidl generated code :-)

Guenther
2009-03-18 17:07:39 +01:00
Günther Deschner
31106cdace s3-spoolss: use printer and job notify enums provided by idl.
Guenther
2009-03-18 16:47:01 +01:00
Günther Deschner
e61c9ca36d s3-spoolss: fix spoolss server after spoolss_Field changes.
Guenther
2009-03-18 16:46:49 +01:00
Günther Deschner
8b730ca1d8 s3-rpcclient: fix spoolss notify test after spoolss_Field changes.
Guenther
2009-03-18 16:46:42 +01:00
Günther Deschner
9ab8953d74 s3-rpc_parse: move prs_uint64 to rpc_parse/parse_prs.c.
Guenther
2009-03-18 16:43:28 +01:00
Günther Deschner
9fdeb7f7b3 s3-spoolss: remove custom syntax_spoolss and use the syntax defined in IDL.
Guenther
2009-03-18 14:18:42 +01:00
Günther Deschner
b0747651b9 s3-printing: use marshall/unmarshall_sec_desc_buf in sec_desc_upg_fn().
Guenther
2009-03-18 13:06:24 +01:00
Günther Deschner
ef02342562 s3-spoolss: add registry_value_to_printer_enum_value.
Guenther
2009-03-18 11:55:54 +01:00
Günther Deschner
f683341294 s3-spoolss: add SPOOLSS_BUFFER_ARRAY macro.
Guenther
2009-03-18 11:55:47 +01:00
Stefan Metzmacher
93c2057c8b s3:winbindd: accept new connections via fd events
metze
2009-03-18 07:00:42 +01:00
Stefan Metzmacher
3b8dd79f2b s3:winbindd: move non event related code out of process_loop() in the the caller
metze
2009-03-18 07:00:42 +01:00
Stefan Metzmacher
0685031ccf s3:winbindd: remove unused close_winbindd_socket() function
metze
2009-03-18 07:00:41 +01:00
Stefan Metzmacher
450252d2a1 s3:smbd: use tevent_loop_once() in the parent event loop
metze
2009-03-18 07:00:40 +01:00
Stefan Metzmacher
b659daf81f s3:printing: use tevent_loop_wait() instead of manual looping
metze
2009-03-18 07:00:39 +01:00
Stefan Metzmacher
339ea0503d s3:printing: use a fd event to monitor the pipe to the parent
metze
2009-03-18 07:00:39 +01:00
Stefan Metzmacher
445b37f4f3 s3:smbd: don't exit the parent when we have no connections
This code path can't really happen anymore, because
launchd support was removed with commit e5a951325a.
But it's confusing to have that code there...

metze
2009-03-18 07:00:38 +01:00
Günther Deschner
cd7f62ab70 s3-spoolss: use rpccli_spoolss_enumprinterdataex in ldap_printer.c.
Guenther
2009-03-18 02:37:57 +01:00
Günther Deschner
9d024d1715 s3-spoolss: remove old rpccli_spoolss_enumprinterdataex.
Guenther
2009-03-18 01:30:41 +01:00
Günther Deschner
f9712d568a s3-net: use rpccli_spoolss_enumprinterdataex.
Guenther
2009-03-18 01:30:34 +01:00
Günther Deschner
8c3ef2d900 s3-rpcclient: use rpccli_spoolss_enumprinterdataex wrapper.
Guenther
2009-03-18 01:30:26 +01:00
Günther Deschner
ab85fc78bd s3-spoolss: add rpccli_spoolss_enumprinterdataex convenience wrapper.
Guenther
2009-03-18 01:30:18 +01:00
Alexander Zagrebin
b4ae0e8d84 Missing break in conversion function prevents tdb password database update. 2009-03-17 15:38:33 -07:00
Jeremy Allison
8dd1faaa29 Remove the global "struct cm_cred_struct" and associated calls, make
callers pass in a struct user_auth_info * instead. This commit causes
smbc_set_credentials() to print out a message telling callers to use
smbc_set_credentials_with_fallback() instead, as smbc_set_credentials()
has a broken API (no SMBCCTX * pointer). No more global variables used
in the connection manager API for client dfs calls.
Jeremy.
2009-03-17 14:53:06 -07:00
Günther Deschner
153a837bd6 s3-rpcclient: say that we are displaying a REG_MULTI_SZ in display_reg_value().
Guenther
2009-03-17 22:15:20 +01:00
Steve Langasek
c6b570ce30 s3: Fix bugs in the detection of the GNU ld version (Bug #6147)
This bug results in a failure to use linker scripts to limit the set of symbols
exported by our shared libraries.

Signed-off-by: Michael Adam <obnox@samba.org>
2009-03-17 22:10:23 +01:00
Volker Lendecke
b29c69f459 Fix #6130: Don't crash in winbindd_rpc lookup_groupmem() on unmapped members
Thanks to François Legal <devel@thom.fr.eu.org> for reporting this bug
2009-03-17 21:19:32 +01:00
Stefan Metzmacher
6c290586e4 s3:events: add support for immediate events
metze
2009-03-17 19:59:07 +01:00
Stefan Metzmacher
d27be1d5fa s3:events: make use of tevent_common_loop_wait()
metze
2009-03-17 19:58:58 +01:00
Günther Deschner
77d2cd1ff7 s3-spoolss: remove unused RPC_BUFFER definition.
Guenther
2009-03-17 19:07:38 +01:00
Günther Deschner
b57d5eaac0 s3-spoolss: remove (disabled) enum_all_printers_info_1_remote.
Jerry, please check. I do not understand how this could work and in
it's current form, we cannot make this even compile anymore, I'm afraid :)
I think it is safe to remove.

Guenther
2009-03-17 19:07:38 +01:00
Günther Deschner
7f90a89d60 s3-spoolss: remove PRINTER_NOTIFY_TYPE and JOB_NOTIFY_TYPE now defined in IDL.
Guenther
2009-03-17 19:07:37 +01:00
Günther Deschner
479d91ae9f s3-spoolss: remove SPL Port definitions now in IDL.
Guenther
2009-03-17 19:07:37 +01:00
Günther Deschner
9b5666aa70 s3-spoolss: remove PRIORITY defines, that were never used.
Guenther
2009-03-17 19:07:36 +01:00
Günther Deschner
4cb3cbea84 s3-spoolss: move DRIVER_X_VERSION flags into the backend, where they belong to.
Guenther
2009-03-17 19:07:34 +01:00
Günther Deschner
f19faa0e76 s3-spoolss: remove unused DEVICEMODE parsing and header.
Guenther
2009-03-17 19:07:30 +01:00
Günther Deschner
5778a36357 s3-spoolss: rename convert_printer_info_new to convert_printer_info.
Guenther
2009-03-17 18:39:55 +01:00
Günther Deschner
1e7f602f8c s3-spoolss: rename convert_nt_devicemode_new to convert_nt_devicemode.
Guenther
2009-03-17 18:39:49 +01:00
Günther Deschner
6549408a4d s3-spoolss: rename construct_dev_mode_new to construct_dev_mode.
Guenther
2009-03-17 18:39:43 +01:00
Günther Deschner
827ba0a64b s3-spoolss/registry: use libndr to push a spoolss_DeviceMode in fill_in_printer_values().
Guenther
2009-03-17 18:39:36 +01:00
Günther Deschner
96998f0358 s3-spoolss/registry: use marshall_sec_desc in fill_in_printer_values().
Guenther
2009-03-17 18:39:29 +01:00
Günther Deschner
d759f9961a s3-spoolss: move SYSTEMTIME parsing to a more generic place, as suggested.
Guenther
2009-03-17 18:39:23 +01:00
Günther Deschner
47c024fd75 s3-spoolss: rename temporary convert_devicemode_new function.
Guenther
2009-03-17 18:39:17 +01:00
Günther Deschner
28d16866ee s3-spoolss: move PRINTER_ATTRIBUTE_SAMBA to printing backend, where they belong.
Guenther
2009-03-17 18:39:10 +01:00
Günther Deschner
2d318490ea s3-spoolss: remove PRINTER_MESSAGE flags and struct, this was never used.
Guenther
2009-03-17 18:39:03 +01:00
Volker Lendecke
bce98d8c03 Convert np_read to tevent_req 2009-03-17 17:31:22 +01:00
Volker Lendecke
89543d6c78 Convert np_write to tevent_req 2009-03-17 17:31:22 +01:00
Björn Jacke
c7dba467f2 remove needless rpath stuff for default paths as early as possible
Signed-off-by: Michael Adam <obnox@samba.org>
2009-03-17 16:50:38 +01:00
Björn Jacke
066cbb5835 clean up lib64 linking paths the same way as lib
Signed-off-by: Michael Adam <obnox@samba.org>
2009-03-17 16:11:14 +01:00
Björn Jacke
da06a345cc to be portable, use options first, arguments last
Signed-off-by: Michael Adam <obnox@samba.org>
2009-03-17 16:09:15 +01:00
Günther Deschner
e89e739e22 s3-spoolss: remove unused init_unistr_array().
Guenther
2009-03-17 12:21:31 +01:00
Günther Deschner
4a58f263b9 s3-spoolss: remove unused get_printer_dataex().
Guenther
2009-03-17 12:21:23 +01:00
Günther Deschner
2d10548ab1 s3: remove rpc_parse/parse_buffer.c completely.
Guenther
2009-03-17 12:21:15 +01:00
Günther Deschner
338c61060b s3-spoolss: remove old spoolss_EnumPrinterKey.
Guenther
2009-03-17 12:19:03 +01:00
Günther Deschner
63d78712bc s3-spoolss: use pidl for _spoolss_EnumPrinterKey.
Guenther
2009-03-17 12:18:57 +01:00
Günther Deschner
846b93f54f s3-spoolss: remove old rpccli_spoolss_enumprinterkey wrapper.
Guenther
2009-03-17 12:18:50 +01:00
Günther Deschner
e0c50aafce s3-net: use rpccli_spoolss_enumprinterkey wrapper.
Guenther
2009-03-17 12:18:43 +01:00
Günther Deschner
bc95ec04e6 s3-rpcclient: use rpccli_spoolss_enumprinterkey wrapper.
Guenther
2009-03-17 12:18:37 +01:00
Günther Deschner
86c25b3533 s3-spoolss: add rpccli_spoolss_enumprinterkey convenience wrapper.
Guenther
2009-03-17 12:18:28 +01:00
Günther Deschner
12c6ac6a43 s3-net: fix net_spoolss_setprinterdataex.
Guenther
2009-03-17 12:14:47 +01:00
Günther Deschner
56691dfe4b s3-spoolss: cleanup _spoolss_SetPrinterDataEx a little.
Guenther
2009-03-17 12:14:35 +01:00
Günther Deschner
d189824240 s3-spoolss: cleanup _spoolss_GetPrinterDataEx a little.
Guenther
2009-03-17 12:14:28 +01:00
Günther Deschner
96ae179aa3 s3-rpcclient: fix cmd_spoolss_getprinterdataex.
Guenther
2009-03-17 12:14:19 +01:00
Günther Deschner
acf523ad7e s3-net: fix net_spoolss_setprinterdata.
Guenther
2009-03-17 12:10:43 +01:00
Günther Deschner
2a8c078357 s3-net: use rpccli_spoolss_EnumPrinterData.
Guenther
2009-03-17 12:08:29 +01:00
Günther Deschner
ead6a49218 s3-spoolss: remove spoolss_EnumPrinterData.
Guenther
2009-03-17 12:08:06 +01:00
Günther Deschner
80ecd11050 s3-spoolss: use pidl for _spoolss_EnumPrinterData.
Guenther
2009-03-17 12:07:58 +01:00
Günther Deschner
57077f43a7 s3-spoolss: remove rpccli_spoolss_enumprinterdata.
Guenther
2009-03-17 12:07:50 +01:00
Günther Deschner
3e16ede0c2 s3-rpcclient: use rpccli_spoolss_EnumPrinterData in enumdata command.
Guenther
2009-03-17 12:07:40 +01:00
Günther Deschner
4ea46d69bb s3-net: temporary disable net_spoolss_setprinterdata.
Guenther
2009-03-17 12:01:29 +01:00
Günther Deschner
628c12e53b s3-spoolss: remove old spoolss_SetPrinterData.
Guenther
2009-03-17 11:57:33 +01:00
Günther Deschner
f9871a846d s3-spoolss: use pidl for _spoolss_SetPrinterData.
Guenther
2009-03-17 11:57:26 +01:00
Günther Deschner
4234969df7 s3-spoolss: remove old rpccli_spoolss_setprinterdata wrapper.
Guenther
2009-03-17 11:57:17 +01:00
Günther Deschner
b8a3e5ea0c s3-rpcclient: use rpccli_spoolss_SetPrinterData.
Guenther
2009-03-17 11:57:08 +01:00
Günther Deschner
6dca80518d s3-spoolss: remove old spoolss_GetPrinterData.
Guenther
2009-03-17 11:49:37 +01:00
Günther Deschner
aeba6381d3 s3-spoolss: use pidl for _spoolss_GetPrinterData.
Guenther
2009-03-17 11:49:30 +01:00
Günther Deschner
d77cc43784 s3-spoolss: remove old rpccli_spoolss_getprinterdata.
Guenther
2009-03-17 11:49:23 +01:00
Günther Deschner
704220c2a2 s3-rpcclient: use rpccli_spoolss_getprinterdata.
Guenther
2009-03-17 11:49:15 +01:00
Günther Deschner
08d170abc1 s3-spoolss: add rpccli_spoolss_getprinterdata convenience wrapper.
Guenther
2009-03-17 11:49:08 +01:00
Günther Deschner
754d136c32 s3-spoolss: remove unused ADD_JOBINFO_1.
Guenther
2009-03-17 11:48:59 +01:00
Volker Lendecke
7735650f2e Fix a valgrind error
Found in "make test" -- if we can't connect at all, "cli" is uninitialized
2009-03-17 11:32:23 +01:00
Günther Deschner
6df9e1f7aa s3-spoolss: add push_spoolss_PrinterData().
Guenther
2009-03-17 10:53:43 +01:00
Günther Deschner
9a8f19672d s3-spoolss: add pull_spoolss_PrinterData().
Guenther
2009-03-17 10:53:24 +01:00
Günther Deschner
88ca3e1743 s3-spoolss: remove more unused defines.
Guenther
2009-03-17 10:37:53 +01:00
Günther Deschner
04fd767c0b s3-spoolss: remove obsolete get_a_builtin_ntform.
Guenther
2009-03-17 10:37:53 +01:00
Jeremy Allison
382d8069ad Add some appropriate const.
Jeremy.
2009-03-16 16:38:15 -07:00
Volker Lendecke
8a2b7b3e56 Remove unused async_req references from wb_reqtrans.c 2009-03-16 21:05:02 +01:00
Volker Lendecke
05b49fd4c8 Convert wb_trans to tevent_req 2009-03-16 20:45:55 +01:00
Volker Lendecke
1624b58beb Remove an unnecessary variable 2009-03-16 20:45:55 +01:00
Volker Lendecke
a58eccfee7 Make struct wb_context private to wbclient.c 2009-03-16 20:45:55 +01:00
Volker Lendecke
5c848e47cc Use tevent_wakeup_send in wb_trans 2009-03-16 20:45:55 +01:00
Volker Lendecke
20cee26a3d Convert open_socket_out_defer to tevent_req 2009-03-16 19:32:01 +01:00
Volker Lendecke
cb9effdc63 Use tevent_wakeup_send in open_socket_out_defer 2009-03-16 18:49:54 +01:00
Stefan Metzmacher
a73bd05eec s3: only define TALLOC_ZERO if needed
metze
2009-03-16 11:14:53 +01:00
Björn Jacke
586a4da5dd fix configure check for external talloc libs 2009-03-16 07:51:46 +01:00
Jelmer Vernooij
e548ec9c24 display_sec: Remove use of samba3-specific data types. 2009-03-15 17:14:25 +01:00
Jelmer Vernooij
0ea702efae configure: Add common file with minimum versions of external libraries. 2009-03-15 16:35:13 +01:00
Jelmer Vernooij
c223beee2a Merge branch 'tdr' of /home/jelmer/samba4 2009-03-15 14:57:58 +01:00
Jelmer Vernooij
74299582c4 Depend on newer talloc for Samba 4 in the merged build as well. 2009-03-15 14:55:12 +01:00
Jelmer Vernooij
251bf8aab5 Merge branch 'checktalloc' of /home/jelmer/samba4 2009-03-15 13:52:01 +01:00
Volker Lendecke
8afd835cea Fix a malloc/talloc mismatch when cli_initialise() fails 2009-03-15 12:01:20 +01:00
Volker Lendecke
5fa4cf283f Add queue argument to wb_resp_write 2009-03-15 11:26:22 +01:00
Jelmer Vernooij
d56524ac04 Merge branch 'checktalloc' into tdr 2009-03-14 23:02:34 +01:00
Jelmer Vernooij
a3d2b77ddd Properly strip /usr/lib and /usr/include for the merged build. 2009-03-14 23:01:57 +01:00
Jelmer Vernooij
56ad85c0ea Fix build of tdr from merged build. 2009-03-14 22:57:02 +01:00
Jelmer Vernooij
acb6018091 Fix comment about shell in Makefile. 2009-03-14 21:08:09 +01:00
Jelmer Vernooij
0c72c503fa Fix fallback if system doesn't provide talloc. 2009-03-14 21:06:41 +01:00
Jelmer Vernooij
61447dfbbf Allow using external libtalloc. 2009-03-14 20:56:26 +01:00
Volker Lendecke
8174a90e43 Fix #3954 2009-03-14 12:40:58 +01:00
Tim Prouty
c3227b6233 s3: Don't return in a void funtion 2009-03-13 22:02:53 -07:00
Jeremy Allison
f48a345e4a Remove pwd_cache.c, it was doing nothing. Make user_name, domain, and
password talloc'ed strings within the cli_struct.
Jeremy.
2009-03-13 17:49:24 -07:00
Dave Richards
5df46fa35b s3 OneFS: Add kernel strict locking support 2009-03-13 14:21:40 -07:00
Dave Richards
1fcc11ff25 s3: Add strict lock/unlock calls to the vfs layer to replace is_locked 2009-03-13 14:16:55 -07:00
Stefan Metzmacher
1355dc2fd3 s4:build: require tevent 0.9.4
metze
2009-03-13 15:50:23 +01:00
Günther Deschner
7a41f299fc s3-spoolss: remove more unused marshalling code.
Guenther
2009-03-13 09:25:26 +01:00
Günther Deschner
0068abe716 s3-spoolss: remove some unused functions.
Guenther
2009-03-13 09:25:26 +01:00
Günther Deschner
348c4b6baa s3-spoolss: remove old spoolss_GetPrinter.
Guenther
2009-03-13 09:25:26 +01:00
Günther Deschner
1ceb298ed6 s3-spoolss: use pidl for _spoolss_GetPrinter.
Guenther
2009-03-13 09:25:25 +01:00
Günther Deschner
aaae578d0e s3-rpcclient: pure cosmetics for cmd_spoolss_getdriver.
Guenther
2009-03-13 09:25:25 +01:00
Günther Deschner
5d76a12cf5 s3-rpcclient: pure cosmetics for cmd_spoolss_getprinter.
Guenther
2009-03-13 09:25:25 +01:00
Günther Deschner
0658a402d7 s3-rpcclient: pure cosmetics for cmd_spoolss_enum_ports.
Guenther
2009-03-13 09:25:25 +01:00
Günther Deschner
7e753b28ea s3-spoolss: use snum_is_shared_printer (allows to make code a little easier to
read).

Guenther
2009-03-13 09:25:24 +01:00
Günther Deschner
0174d4d3b2 s3-spoolss: add snum_is_shared_printer fn.
Guenther
2009-03-13 09:25:24 +01:00
Günther Deschner
a1a02bfac2 s3-spoolss: remove old spoolss_EnumPrinters.
Guenther
2009-03-13 09:25:24 +01:00
Günther Deschner
f6f703f16e s3-spoolss: use pidl for _spoolss_EnumPrinters.
Guenther
2009-03-13 09:25:24 +01:00
Günther Deschner
16438e3a93 s3-spoolss: remove old enumprinters wrapper.
Guenther
2009-03-13 09:25:24 +01:00
Günther Deschner
f14d4267c9 s3-net: use rpccli_spoolss_enumprinters wrapper.
Guenther
2009-03-13 09:25:23 +01:00
Günther Deschner
0e66a244d3 s3-rpcclient: use rpccli_spoolss_enumprinters wrapper.
Guenther
2009-03-13 09:25:23 +01:00
Günther Deschner
9397ae5114 s3-spoolss: add rpccli_spoolss_enumprinters convenience wrapper.
Guenther
2009-03-13 09:25:23 +01:00
Günther Deschner
1b3e068e83 s3-spoolss: remove old spoolss_GetPrinterDriver2.
Guenther
2009-03-13 09:25:23 +01:00
Günther Deschner
8df8abb890 s3-spoolss: use pidl for _spoolss_GetPrinterDriver2.
Guenther
2009-03-13 09:25:23 +01:00
Günther Deschner
058f47d08d s3-spoolss: remove old leftover driver print functions.
Guenther
2009-03-13 09:25:23 +01:00
Günther Deschner
a540815b5f s3-spoolss: remove old spoolss_EnumPrinterDrivers.
Guenther
2009-03-13 09:25:23 +01:00
Günther Deschner
d6e2ef51ec s3-spoolss: use pidl for _spoolss_EnumPrinterDrivers.
Guenther
2009-03-13 09:25:23 +01:00
Günther Deschner
6928c5ce47 s3-spoolss: remove old rpccli_spoolss_enumprinterdrivers wrapper.
Guenther
2009-03-13 09:25:22 +01:00
Günther Deschner
7876d28d9a s3-net: use rpccli_spoolss_enumprinterdrivers wrapper.
Guenther
2009-03-13 09:25:22 +01:00
Günther Deschner
915c593926 s3-rpcclient: use rpccli_spoolss_enumprinterdrivers wrapper.
Guenther
2009-03-13 09:25:22 +01:00
Günther Deschner
5f46554228 s3-spoolss: add rpccli_spoolss_enumprinterdrivers convenience wrapper.
Guenther
2009-03-13 09:25:22 +01:00
Günther Deschner
e605e4503c s3-spoolss: remove old spoolss_GetJob and spoolss_EnumJob.
Guenther
2009-03-13 09:25:22 +01:00
Günther Deschner
9b143e6de5 s3-spoolss: use pidl for _spoolss_GetJob.
Guenther
2009-03-13 09:25:21 +01:00
Günther Deschner
b80e3e5724 s3-spoolss: use pidl for _spoolss_EnumJobs.
Guenther
2009-03-13 09:25:21 +01:00
Günther Deschner
661e81d48c s3-spoolss: add construct_dev_mode_new.
Guenther
2009-03-13 09:25:21 +01:00
Günther Deschner
3bd1aabcfe s3-spoolss: remove old rpccli_spoolss_enumjobs wrapper.
Guenther
2009-03-13 09:25:21 +01:00
Günther Deschner
d279e76cd2 s3-rpcclient: use rpccli_spoolss_enumjobs wrapper in enumjobs command.
Guenther
2009-03-13 09:25:20 +01:00
Günther Deschner
80284124ba s3-spoolss: add rpccli_spoolss_enumjobs convenience wrapper.
Guenther
2009-03-13 09:25:20 +01:00
Günther Deschner
427987d2bf s3-spoolss: use macros for _spoolss_GetForm and split out level 1 get.
Guenther
2009-03-13 09:25:20 +01:00
Günther Deschner
635b8070b6 s3-spoolss: use macros for _spoolss_EnumForms and split out level 1 enum.
Guenther
2009-03-13 09:25:20 +01:00
Günther Deschner
b2b3cfbe31 s3-spoolss: use macros for _spoolss_GetPrintProcessorDirectory.
Guenther
2009-03-13 09:25:20 +01:00
Günther Deschner
75d88f460f s3-spoolss: use macros for _spoolss_GetPrinterDriverDirectory.
Guenther
2009-03-13 09:25:19 +01:00
Günther Deschner
dfe71b05a7 s3-spoolss: use macros for _spoolss_EnumMonitors.
Guenther
2009-03-13 09:25:19 +01:00
Günther Deschner
8d6c719a4b s3-spoolss: use macros for _spoolss_EnumPrintProcDataTypes.
Guenther
2009-03-13 09:25:19 +01:00
Günther Deschner
c6e9dc11e5 s3-spoolss: use macros for _spoolss_EnumPorts.
Guenther
2009-03-13 09:25:19 +01:00
Günther Deschner
facf66b40c s3-spoolss: use macros for _spoolss_EnumPrintProcessors.
Guenther
2009-03-13 09:25:19 +01:00
Günther Deschner
84b38c8598 s3-spoolss: add macros from s4 spoolss server.
Guenther
2009-03-13 09:25:19 +01:00
Jeremy Allison
e5136e9849 Remove the static "struct client_connection" mess which is part of
the problem that stops libsmbclient being thread safe. Subsidiary
DFS connections are now hung off a list inside the cli_state struct.
Much more to do in order to get libsmbclient to thread safety, but
this is a good start.
Jeremy.
2009-03-12 17:59:24 -07:00
Tim Prouty
bace42d586 s3 torture: Fix unitialized variable to avoid closing a random fnum 2009-03-12 16:51:20 -07:00
Dan Sledz
b6616ca8dc s3 pdb_wbc_sam: LookupRids should return sAMAccountName, not NT4 names
Also fix an incorrect TALLOC_FREE
2009-03-12 13:00:47 -07:00
Jeremy Allison
5c63388f63 Fix bug #6186 - map readonly does not work
Jeremy.
2009-03-12 10:57:31 -07:00
Günther Deschner
4b57f6dd34 s3-spoolss: make jobname a const char * in print_job_start().
Guenther
2009-03-12 14:47:31 +01:00
Stefan Metzmacher
bd0f14c1d7 s3:events: pass __location__ to event_loop_*()
metze
2009-03-12 12:12:40 +01:00
Stefan Metzmacher
2fdbafbf54 Revert "s3:libsmb: add an option to cli_push to let the caller provide the buffers"
This reverts commit 9579a6f193.

It's confusing to have a boolean to alter the behavior of cli_push
and as the new feature isn't used yet I revert it.

We can readd a extra function later.

metze
2009-03-12 11:03:50 +01:00
Volker Lendecke
a0a9c5d170 Fix #6167: winbindd -n should disable the winbind idmap cache 2009-03-12 10:20:08 +01:00
Volker Lendecke
b17f9e15ef Make opt_nocache static to winbindd.c 2009-03-12 10:20:08 +01:00
Jeremy Allison
c260bfa5d7 Add simple POSIX open, mkdir and rmdir test.
Jeremy.
2009-03-11 14:28:47 -07:00
Tim Prouty
2bfd2c58f8 s3 torture: Simple warning fix 2009-03-11 13:09:24 -07:00
Björn Jacke
e6777e5266 fix configure check by avoiding main(main(...))
AC_TRY_LINK automatically wraps a main(). Double main() causes this test to fail
on some compilers.
2009-03-11 12:08:51 -07:00
Volker Lendecke
3d280639c4 Add a vfs_preopen module to hide fs latencies 2009-03-10 18:11:56 +01:00
Stefan Metzmacher
9579a6f193 s3:libsmb: add an option to cli_push to let the caller provide the buffers
metze
2009-03-10 14:07:56 +01:00
Stefan Metzmacher
c2993f74af s3:libsmb: only treat a return 0 as end of file
metze
2009-03-10 12:46:16 +01:00
Stefan Metzmacher
7fc8086e11 s3:libsmb: fix a lot of cli_push() bugs
There were the following problems:
1.) if window_size was a multiple of the chunk_size,
    we silently dropped the last truncated chunk.
2.) if window_size was 0 pushed only the first chunk
    to the server and silently dropped the rest.
3.) we had only transferred state->num_reqs writes,
    even if there would be more data to send.

metze
2009-03-10 11:03:15 +01:00
Andrew Tridgell
6f1f9f6d8d fixed a bug in message handling for code the change notify code
The change notify code registered a separate message handler for each
tree connect. This registration uses the global messaging context.

The messaging code would consider a 2nd registration for the same
messaging type as being an 'update' of the handler, rather than a new
handler. It also would only call the first handler in the linked list
for a given message type when dispatching messages.

This patch changes the messaging code to allow for multiple
registrations of the same message type, and allow for multiple calls
to different messaging handler for one incoming message.

This fixes the problem with the test_notify_tcon() test that I
recently committed to the S4 smbtorture
2009-03-10 16:45:45 +11:00
Jelmer Vernooij
3b181564c5 Merge branch 'master' of ssh://git.samba.org/data/git/samba 2009-03-09 21:42:13 +01:00
Björn Jacke
0d2de5380d use LIB_PATH_VAR in selftest.sh if we have it
if we have LIB_PATH_VAR we should use it, otherwise we'll unobtrusively
complain about not having it and use the most likely LD_LIBRARY_PATH.

Signed-off-by: Jelmer Vernooij <jelmer@samba.org>
2009-03-09 18:31:11 +01:00
Volker Lendecke
6b1170c9d6 Fix a typo 2009-03-09 16:13:31 +01:00
Stefan Metzmacher
1410490fe7 s3:lib: interfaces.c isn't used in the configure tests anymore
libreplace always provides the getifaddr() function.

This fixes the build on sles8.

metze
2009-03-09 12:49:13 +01:00
Björn Jacke
c3691b839c fix "dubious escape" warning of Studio compiler 2009-03-09 10:47:30 +01:00
Volker Lendecke
dea9621680 Don't copy the winbindd_request in wb_trans 2009-03-08 12:52:58 +01:00
Volker Lendecke
e503148225 Convert wb_open_pipe to tevent_req 2009-03-08 12:52:58 +01:00
Volker Lendecke
33db1e07a7 Convert wb_connect to tevent_req 2009-03-08 12:52:58 +01:00
Volker Lendecke
549c30e9fe Convert wb_int_trans to tevent_req 2009-03-08 12:52:58 +01:00
Volker Lendecke
eb177592b5 Add parameter "queue" to wb_int_trans_send 2009-03-08 12:52:58 +01:00
Volker Lendecke
c7df046339 Move "struct req_read_state" where it belongs 2009-03-08 11:21:00 +01:00
Volker Lendecke
1611e63ae5 Convert wb_resp_write to tevent_req 2009-03-08 11:21:00 +01:00
Volker Lendecke
80fcd76421 Convert wb_resp_read to tevent_req 2009-03-08 11:21:00 +01:00
Volker Lendecke
0a3a7d53eb Convert wb_req_read to tevent_req 2009-03-08 11:21:00 +01:00
Volker Lendecke
9a64d7cfbe Convert wb_req_write to tevent_req 2009-03-08 11:20:59 +01:00
Volker Lendecke
f5ee31602c Add tevent_req wbc helpers 2009-03-08 11:20:59 +01:00
Volker Lendecke
fe486d7b9f Add "queue" to writev_send
Unless higher levels queue themselves somehow, writev will *always* be queued.
So the queueing should be done at the right level.
2009-03-08 11:20:59 +01:00
Jelmer Vernooij
f992416e23 Revert accidental reintroduction of void ** bug. 2009-03-08 06:57:52 +01:00
Volker Lendecke
46bcb10b5a Shape up pdb_search a bit by making it a talloc ctx with a destructor 2009-03-07 17:51:21 +01:00
Volker Lendecke
e58ade4136 Fix a smbclient segfault against security=share servers 2009-03-07 15:27:13 +01:00
Volker Lendecke
c29826a697 Fix some nonempty blank lines 2009-03-07 15:27:02 +01:00
Günther Deschner
c9496ba18a s3-spoolss: remove more leftovers from old enumports call.
Guenther
2009-03-07 01:12:18 +01:00
Günther Deschner
d75d350287 s3-rpcclient: add enummonitors command to enumerate print monitors.
Guenther
2009-03-07 00:55:39 +01:00
Günther Deschner
33a441b0c2 s3-spoolss: add rpccli_spoolss_enummonitors convenience wrapper.
Guenther
2009-03-07 00:55:39 +01:00
Günther Deschner
d8a05bd55d s3-spoolss: remove old spoolss_EnumMonitors.
Guenther
2009-03-07 00:55:38 +01:00
Günther Deschner
2561b2d2e2 s3-spoolss: use pidl for _spoolss_EnumMonitors.
Guenther
2009-03-07 00:55:38 +01:00
Günther Deschner
e9179a6850 s3-rpcclient: use rpccli_spoolss_enumports wrapper.
Guenther
2009-03-07 00:55:37 +01:00
Günther Deschner
c7e19c2627 s3-spoolss: add rpccli_spoolss_enumports convenience wrapper.
Guenther
2009-03-07 00:55:37 +01:00
Günther Deschner
631f277d1c s3-spoolss: remove old spoolss_EnumPorts.
Guenther
2009-03-07 00:55:36 +01:00
Günther Deschner
03f1bec6ce s3-spoolss: use pidl for _spoolss_EnumPorts.
Guenther
2009-03-07 00:55:36 +01:00
Günther Deschner
62d73b8854 s3-rpcclient: add enumprocdatatypes command to enumerate print processor data
types.

Guenther
2009-03-07 00:55:15 +01:00
Günther Deschner
2d24d3a380 s3-spoolss: add rpccli_spoolss_enumprintprocessordatatypes convenience wrapper.
Guenther
2009-03-07 00:55:00 +01:00
Günther Deschner
f9019c1837 s3-spoolss: remove old spoolss_EnumPrintProcDataTypes.
Guenther
2009-03-07 00:49:52 +01:00
Günther Deschner
3cf22a8856 s3-spoolss: use pidl for _spoolss_EnumPrintProcDataTypes.
Guenther
2009-03-07 00:49:51 +01:00
Günther Deschner
a58e59fc6e s3-rpcclient: add enumprocs command to enumerate print processors.
Guenther
2009-03-07 00:49:47 +01:00
Günther Deschner
b73411d650 s3-spoolss: add rpccli_spoolss_enumprintprocessors convenience wrapper.
Guenther
2009-03-07 00:43:13 +01:00
Günther Deschner
066a47b994 s3-spoolss: remove old spoolss_EnumPrintProcessors.
Guenther
2009-03-07 00:43:12 +01:00
Günther Deschner
f48ccec957 s3-spoolss: use pidl for _spoolss_EnumPrintProcessors.
Guenther
2009-03-07 00:42:58 +01:00
Stefan Metzmacher
bf85a14182 s3:make_test: run CHAIN1 test
metze
2009-03-06 16:38:30 +01:00
Stefan Metzmacher
3f3e15ab91 s3:libsmb: merge cli_setup_signing_state() into cli_initialise_ex()
metze
2009-03-06 16:37:22 +01:00
Stefan Metzmacher
6e572d40a9 s3:libsmb: remove cli_setup_signing_state() and add struct cli_state *cli_initialise_ex()
This prepares the next changes.

metze
2009-03-06 16:37:21 +01:00
Stefan Metzmacher
589eb81e3f s3:winbindd_cm: remove useless cli_setup_signing_state(*cli, Undefined) call
cli_setup_signing_state() with Undefined is a noop.

metze
2009-03-06 16:37:20 +01:00
Stefan Metzmacher
196a5d0388 s3:signing: the seqnum should only be decremented by 1 for ntcancel requests
[MS-SMB] 3.3.5.1 Receiving Any Message says that the seqnum
is incremented by only for ntcancel requests for any other
request it's by incremented by 2, even if it doesn't expect
a response.

metze
2009-03-06 16:37:20 +01:00
Stefan Metzmacher
4b6cbe80b2 s3:errormap: add ECANCELED, ERRDOS/ERRbadfid, NT_STATUS_CANCELLED mapping
If someone knows a better dos error, please tell me...

metze
2009-03-06 16:37:19 +01:00
Stefan Metzmacher
918e6288fa s3:libsmb: smb signing works the same for extented and non-extended security
This is only cosmetic, but it makes it easier to understand.

metze
2009-03-06 16:18:50 +01:00
Günther Deschner
5ce523bbed s3-spoolss: Fix Coverity ID #891 (UNINIT).
Guenther
2009-03-06 14:58:49 +01:00
Günther Deschner
8614ce5ca7 s3-spoolss: remove old _spoolss_EnumForms.
Guenther
2009-03-06 14:32:46 +01:00
Günther Deschner
4541aa5f84 s3-spoolss: use form flags from idl in rpcclient and net.
Guenther
2009-03-06 14:32:46 +01:00
Günther Deschner
f9bf09e255 s3-spoolss: use pidl for _spoolss_EnumForms.
Guenther
2009-03-06 14:32:15 +01:00
Günther Deschner
9bdca59fc5 s3-spoolss: remove old rpccli_spoolss_enumforms.
Guenther
2009-03-06 14:30:26 +01:00
Günther Deschner
01e4f63c5e s3-net: use new rpccli_spoolss_enumforms wrapper.
Guenther
2009-03-06 14:30:17 +01:00
Günther Deschner
6336366abb s3-rpcclient: use new rpccli_spoolss_enumforms wrapper.
Guenther
2009-03-06 14:30:10 +01:00
Günther Deschner
c14a589a46 s3-spoolss: add convencience wrapper around rpccli_spoolss_EnumForms.
Guenther
2009-03-06 14:30:02 +01:00
Jeremy Allison
67d12e9c6b Get the sense of the integer wrap test the right way around. Sorry.
Jeremy.
2009-03-05 22:00:22 -08:00
Jeremy Allison
4e74d811aa Now we're allowing a lower bound for auth_len, ensure we
also check for an upper one (integer wrap).
Jeremy.
2009-03-05 21:06:48 -08:00
Jeremy Allison
66c0f3690a Fix bug #6161 - smbclient corrupts source path in tar mode
This was my fault. I broke the smbclient tar argument processing
in creating the string for chdir when removing pstrings.
Jeremy.
2009-03-05 17:19:18 -08:00
Jeremy Allison
0d9f4a2886 Last part of fix for #6154 - zfs does not honor admin users.
Jeremy.
2009-03-05 15:18:18 -08:00