sin/samba-mirror
1
0
Fork 0
mirror of https://github.com/samba-team/samba.git synced 2024-12-25 23:21:54 +03:00
Code
68,671 Commits 60 Branches 1,144 Tags 452 MiB
9997ee813b
Commit Graph

34499 Commits

Author SHA1 Message Date
Andrew Bartlett
170b345e0c s3-auth Use security_token_debug() from common code 
This prints the security token including the privileges as strings
instead of just a bitmap.

Andrew Bartlett

Signed-off-by: Andrew Tridgell <tridge@samba.org>
 2010-10-14 02:35:04 +00:00
Andrew Bartlett
58cf83732a s3-auth use security_token_has_sid() from the common code 
The wrapper call is left here to avoid changing semantics for
the NULL parameter case.

Andrew Bartlett

Signed-off-by: Andrew Tridgell <tridge@samba.org>
 2010-10-14 02:35:04 +00:00
Andrew Bartlett
deb7c02436 s3 Replace is_sid_in_token() with security_token_has_sid() from common code 
The two routines are identical, so there is no need to keep both.

Andrew Bartlett

Signed-off-by: Andrew Tridgell <tridge@samba.org>
 2010-10-14 02:35:04 +00:00
Christian Ambach
beb5afea54 s3:gpfs: Add support for the gpfs_ftruncate call 
ported from the v3-4-ctdb branch to master
This used to be commit 1f138cc9f4a

Autobuild-User: Volker Lendecke <vlendec@samba.org>
Autobuild-Date: Wed Oct 13 13:34:25 UTC 2010 on sn-devel-104
 2010-10-13 13:34:25 +00:00
Christian Ambach
22018b8b88 s3:vfs:gpfs convert sharemodes/leases parameter 
convert gpfs:sharemodes and gpfs:leases parameters from a global setting
to a per share setting
 2010-10-13 12:53:16 +00:00
Christian Ambach
9e4a386d67 s3:vfs:syncops add option to disable module per share 
add an option to disable the syncops module completely for a
share with
  syncops:disable = true
 2010-10-13 12:53:16 +00:00
Christian Ambach
c1dad16ede s3:vfs:syncops make it possible to specify syncops:onclose per share 
convert the onclose option of the vfs_syncops module from a
global option to a service-specific one

as preparation for further flags, use a struct to store in the VFS handle
instead of just the onclose flag
 2010-10-13 12:53:16 +00:00
Michael Adam
cda2db5edf s3:registry: fix some trailing spaces in reg_backend_db 
Autobuild-User: Michael Adam <obnox@samba.org>
Autobuild-Date: Tue Oct 12 14:15:42 UTC 2010 on sn-devel-104
 2010-10-12 14:15:42 +00:00
Andrew Bartlett
f768b32e37 libcli/security Provide a common, top level libcli/security/security.h 
This will reduce the noise from merges of the rest of the
libcli/security code, without this commit changing what code
is actually used.

This includes (along with other security headers) dom_sid.h and
security_token.h

Andrew Bartlett

Autobuild-User: Andrew Bartlett <abartlet@samba.org>
Autobuild-Date: Tue Oct 12 05:54:10 UTC 2010 on sn-devel-104
 2010-10-12 05:54:10 +00:00
Jeremy Allison
6f6094076f Make the vfs_acl_xattr and other modules work with NULL SD's. Fix 
the "protected" inheritance problem (bleeding up from the POSIX
layer).

Jeremy

Autobuild-User: Jeremy Allison <jra@samba.org>
Autobuild-Date: Tue Oct 12 00:57:41 UTC 2010 on sn-devel-104
 2010-10-12 00:57:41 +00:00
Jeremy Allison
6f4e782c53 Canonicalize incoming and outgoing ACLs. 
Jeremy.
 2010-10-11 17:10:28 -07:00
Jeremy Allison
71d9f51b4e Make the posix ACL module cope with a NULL incoming DACL and a 
missing owner/group.

Jeremy.
 2010-10-11 17:07:54 -07:00
Günther Deschner
33c6a4eb8a s3-spoolss: add more userlevel info validation to _spoolss_OpenPrinterEx. 
Guenther
 2010-10-11 14:31:06 +00:00
Günther Deschner
025290e9bf s3-spoolss: let set_printer_hnd_name return WERROR. 
Guenther
 2010-10-11 14:31:06 +00:00
Günther Deschner
c8a295ab7f s3-spoolss: convert open_printer_hnd to return WERROR. 
Guenther
 2010-10-11 14:31:06 +00:00
Günther Deschner
fe724c70d2 s3-spoolss: fix set_printer_hnd_name() to match torture test. 
Guenther
 2010-10-11 14:31:06 +00:00
Jeremy Allison
9e1e581120 More neccessary const. 
Autobuild-User: Jeremy Allison <jra@samba.org>
Autobuild-Date: Sat Oct  9 01:47:25 UTC 2010 on sn-devel-104
 2010-10-09 01:47:25 +00:00
Volker Lendecke
615482a83d s3: Hang the isilon kernel oplocks off the NULL context 
All I see is a fd_event that does not need a special destructor.

Tim, Steven, I've added the #error as well for you to remove after review.

Thanks,

Volker

Autobuild-User: Volker Lendecke <vlendec@samba.org>
Autobuild-Date: Fri Oct  8 20:48:11 UTC 2010 on sn-devel-104
 2010-10-08 20:48:11 +00:00
Volker Lendecke
703e438599 s3: Hang the irix kernel oplocks off the NULL ctx 
Just a fd_event to be cleaned up. The pipe is closed implicitly.
 2010-10-08 21:11:46 +02:00
Volker Lendecke
613a0b6c00 s3: Hang the linux kernel oplocks off the NULL ctx 
The destructor that is called removes the signal handler. But at process
exit the signal handling is lost anyway.
 2010-10-08 21:11:46 +02:00
Volker Lendecke
ef96bfe885 s3: Call printer_list_parent_init in the parent 
Simo, please check!
 2010-10-08 21:11:46 +02:00
Volker Lendecke
812580736a s3: Remove talloc_autofree_context() from get_printer_list_db() 
Another db that does not need explicit closing
 2010-10-08 21:11:45 +02:00
Volker Lendecke
1e98d5859d s3: Remove talloc_autofree_context() from loadparm.c 
None of these uses requires a special destructor
 2010-10-08 21:11:45 +02:00
Volker Lendecke
220aa311d1 s3: Add a little test for the echo responder 2010-10-08 21:11:45 +02:00
Volker Lendecke
5e482aeebf s3: Implement echo_TestSleep 2010-10-08 21:11:45 +02:00
Volker Lendecke
b5ed09c3af Move talloc_enable_null_tracking() to the s3 daemons 2010-10-08 21:11:45 +02:00
Günther Deschner
4e9508172d s3-waf: slowly getting modules to match how they look like in old build. 
Guenther

Autobuild-User: Günther Deschner <gd@samba.org>
Autobuild-Date: Fri Oct  8 09:31:01 UTC 2010 on sn-devel-104
 2010-10-08 09:31:01 +00:00
Volker Lendecke
7915142848 s3: Fix input check in is_encrypted_packet 
Autobuild-User: Volker Lendecke <vlendec@samba.org>
Autobuild-Date: Fri Oct  8 07:40:52 UTC 2010 on sn-devel-104
 2010-10-08 07:40:51 +00:00
Jeremy Allison
cd04af78d5 Fix bug 7716 - acl_xattr and acl_tdb modules don't store unmodified copies of security descriptors. 
As pointed out by an OEM, the code within smbd/posix_acl.c, even though passed
a const pointer to a security descriptor, still modifies the ACE entries within
it (which are not const pointers).

This means ACLs stored in the extended attribute by the acl_xattr module have
already been modified by the POSIX acl layer, and are not the original intent
of storing the "unmodified" ACL from the client.

Use dup_sec_desc to make a copy of the incoming ACL on talloc_tos() - that
is what is then modified inside smbd/posix_acl.c, leaving the original ACL
to be correctly stored in the xattr.

Jeremy.

Autobuild-User: Jeremy Allison <jra@samba.org>
Autobuild-Date: Fri Oct  8 00:37:53 UTC 2010 on sn-devel-104
 2010-10-08 00:37:53 +00:00
Volker Lendecke
fd9effce2b s3: Fix the async echo responder for netbios keepalives 
This fixes a crash in the echo responder when the client started to send the
NetBIOS-Level 0x85-style keepalive packets. We did not correctly check the
packet length, so the code writing the signing seqnum overwrote memory after
the malloc'ed area for the 4 byte keepalive packet.

Autobuild-User: Jeremy Allison <jra@samba.org>
Autobuild-Date: Thu Oct  7 19:47:35 UTC 2010 on sn-devel-104
 2010-10-07 19:47:35 +00:00
Günther Deschner
d8c86a7f77 s3-spoolss: make it possible to have and announce a [prnproc$] share on the printserver. 
Guenther

Autobuild-User: Günther Deschner <gd@samba.org>
Autobuild-Date: Thu Oct  7 16:09:14 UTC 2010 on sn-devel-104
 2010-10-07 16:09:14 +00:00
Günther Deschner
12112d545c s3-rpcclient: add openprinter_ex command. 
Guenther
 2010-10-07 17:26:00 +02:00
Günther Deschner
b7683a2c9d samr: for correctness, rename samr_RidTypeArray to samr_RidAttrArray. 
Guenther

Autobuild-User: Günther Deschner <gd@samba.org>
Autobuild-Date: Thu Oct  7 12:04:32 UTC 2010 on sn-devel-104
 2010-10-07 12:04:32 +00:00
Günther Deschner
71ab8f326b s3-samr: fix _samr_QueryGroupMember(). 
that array contains attributes, not sid types.

Guenther
 2010-10-07 13:24:22 +02:00
Ira Cooper
fdad0328e4 s3: Adding TCP_KEEPALIVE_THRESHOLD and TCP_KEEPALIVE_ABORT_THRESHOLD to the list of accepted socket settings. 
These are both exclusive to Solaris/OpenSolaris.

Autobuild-User: Jeremy Allison <jra@samba.org>
Autobuild-Date: Thu Oct  7 00:26:39 UTC 2010 on sn-devel-104
 2010-10-07 00:26:39 +00:00
Jeremy Allison
0cec0f0912 Fix crash in SMB2 rename found by gentest. We must always have an lcomp 
in the destination struct for a rename, so set the flag appropriately.

Jeremy.
 2010-10-06 22:59:15 +00:00
Volker Lendecke
342c79e265 s3: Make the write end of the echo responder pipe non-blocking 
Without this, we can get a writable pipe end, but the writev call on the pipe
will block.

Autobuild-User: Volker Lendecke <vlendec@samba.org>
Autobuild-Date: Wed Oct  6 13:57:30 UTC 2010 on sn-devel-104
 2010-10-06 13:57:30 +00:00
Andrew Tridgell
312d0977a2 s3-build: use the simpler "make bin/smbtorture" for s4 torture 
and the same for bin/ndrdump

Autobuild-User: Andrew Tridgell <tridge@samba.org>
Autobuild-Date: Wed Oct  6 12:58:21 UTC 2010 on sn-devel-104
 2010-10-06 12:58:21 +00:00
Andrew Tridgell
8a56f8ddb1 s3-spoolss: added another intermittent failure to knownfail 
Autobuild-User: Andrew Tridgell <tridge@samba.org>
Autobuild-Date: Wed Oct  6 11:55:00 UTC 2010 on sn-devel-104
 2010-10-06 11:55:00 +00:00
Jeremy Allison
77622acadd Fix crash in SMB2 rename found by gentest. We must always have an lcomp 
in the destination struct for a rename, so set the flag appropriately.

Jeremy.

Autobuild-User: Jeremy Allison <jra@samba.org>
Autobuild-Date: Wed Oct  6 00:29:51 UTC 2010 on sn-devel-104
 2010-10-06 00:29:51 +00:00
Günther Deschner
cef5a36cd1 selftest: make it more obvious we only expect the printjob tests to fail. 
Guenther
 2010-10-05 22:55:30 +02:00
Günther Deschner
a578ac028f s3-waf: add slightly different mkbuildoptions awk script for waf. 
This allows to run make test (w/o smbtorture4 for now) using waf.

Guenther

Autobuild-User: Günther Deschner <gd@samba.org>
Autobuild-Date: Tue Oct  5 18:24:55 UTC 2010 on sn-devel-104
 2010-10-05 18:24:55 +00:00
Günther Deschner
e481b66374 s3-waf: use more of the NDR_ subsystems. 
Guenther
 2010-10-05 19:43:38 +02:00
Jeremy Allison
4618e25c95 Fix bug 7704 - Possible error in fix to rpc_server/srv_spoolss_nt.c. 
From pjb1008@cam.ac.uk - Service numbers start from 0.

Autobuild-User: Jeremy Allison <jra@samba.org>
Autobuild-Date: Tue Oct  5 17:32:34 UTC 2010 on sn-devel-104
 2010-10-05 17:32:34 +00:00
Günther Deschner
505eaa9493 s3-selftest: enable smb2 torture tests against samba3. 
Guenther

Autobuild-User: Günther Deschner <gd@samba.org>
Autobuild-Date: Tue Oct  5 14:38:07 UTC 2010 on sn-devel-104
 2010-10-05 14:38:07 +00:00
Günther Deschner
caeb819861 s3-reg_parse: fix uninitialized variable in srprs_key(). 
Guenther
 2010-10-05 13:09:05 +00:00
Günther Deschner
0a1ce77e29 s3-libndr: handle NDR_ERR_IPV6ADDRESS case in ndr_errstr(). 
Guenther
 2010-10-05 13:09:05 +00:00
Günther Deschner
4aa8aaa6d2 s3-waf: convert NSS_INFO into a subsystem. 
We don't do the fancy symlinking to idmap modules though.

Guenther

Autobuild-User: Günther Deschner <gd@samba.org>
Autobuild-Date: Tue Oct  5 10:50:53 UTC 2010 on sn-devel-104
 2010-10-05 10:50:53 +00:00
Günther Deschner
d10a601ce0 s3-waf: add RPCCLI_WINREG subsystem. 
Guenther
 2010-10-05 10:10:19 +00:00
Volker Lendecke
ea08cd280c s3: Stop using the write cache after an oplock break 
Autobuild-User: Volker Lendecke <vlendec@samba.org>
Autobuild-Date: Tue Oct  5 10:09:38 UTC 2010 on sn-devel-104
 2010-10-05 10:09:38 +00:00
Volker Lendecke
515c8f0289 s3: Fix a pointer error 
It is not universally guaranteed that an enum is represented as a uint32_t.

This starts to be THE BUG (tm) in Samba. What can I do to explain this
to people a bit better? It seems that the verbose explanations I put into
the recent checkins fixing similar bugs are not clear enough.

Anybody who does is not 100% clear about what this patch fixes please
contact me directly so that we can talk it through on the phone to agree
on a wording that everybody can understand.

Thanks,

Volker
 2010-10-04 11:43:47 +02:00
Volker Lendecke
b958f98152 s3: Attempt to get the Tru64 build a bit further 2010-10-04 11:04:25 +02:00
Günther Deschner
279e0c9610 spoolss: fill in spoolss_SetPort IDL. 
Guenther
 2010-10-04 09:29:47 +02:00
Volker Lendecke
79a4be4f77 s3: Remove smbd_server_conn from msg_force_tdis 2010-10-03 18:17:09 +02:00
Volker Lendecke
e128b23165 s3: Remove smbd_server_conn from process_blocking_lock_cancel_message 2010-10-03 18:17:09 +02:00
Volker Lendecke
c0eb35c0a2 s3: Remove smbd_server_conn from smb1 receive_unlock_msg 2010-10-03 18:17:09 +02:00
Volker Lendecke
db607331d3 s3: Remove smbd_server_conn from msg_file_was_renamed 2010-10-03 18:17:09 +02:00
Volker Lendecke
3cf3d54fbc s3: Remove smbd_server_conn from validate_my_share_entries 2010-10-03 18:17:09 +02:00
Volker Lendecke
924357ab52 s3: Remove smbd_server_conn from msg_close_file 2010-10-03 18:17:09 +02:00
Volker Lendecke
898f7c9603 s3: Remove smbd_server_conn from smb2 receive_unlock_msg 2010-10-03 18:17:08 +02:00
Volker Lendecke
554f5e7c60 s3: Remove smbd_server_conn from process_kernel_oplock_break 2010-10-03 18:17:08 +02:00
Volker Lendecke
5d1d575e87 s3: Remove smbd_server_conn from process_oplock_break_message 2010-10-03 18:17:08 +02:00
Volker Lendecke
35d6d44e5a s3: Remove smbd_server_conn from process_oplock_async_level2_break_message 2010-10-03 18:17:08 +02:00
Volker Lendecke
1d3aa74e4c s3: Lift smbd_server_conn from initial_break_processing 2010-10-03 18:17:08 +02:00
Volker Lendecke
fb2f0c5bdd s3: Add msg_ctx_to_sconn 2010-10-03 18:17:08 +02:00
Volker Lendecke
4a768fbef7 s3: I thought I had compiled this.... 2010-10-03 13:22:03 +02:00
Volker Lendecke
48dccbf2b5 s3: Move #define VALGRIND to config.h 
This fixes the valgrind overrun in the tdb jenkins hash
 2010-10-03 12:03:36 +02:00
Volker Lendecke
ff48f7c00c s3: Attempt to fix the IRIX build 2010-10-03 10:54:28 +02:00
Volker Lendecke
97b76364e7 s3: Attempt to fix a ton of warnings on the build farm 2010-10-03 10:51:08 +02:00
Volker Lendecke
c87d4e5ddb s3: Remove talloc_autofree_context() from dmapi.c 
This is a place where an explicit dmapi_destroy_session would be needed. But we
don't use a destructor for this.
 2010-10-03 10:45:57 +02:00
Volker Lendecke
414cd919ff s3: Remove talloc_autofree_context() from unexpected.c 
Same argument as in 997a64f6fb: If tdb_close() was needed at exit
time, we'd have more severe problems by now.
 2010-10-03 10:45:57 +02:00
Volker Lendecke
da0ef65e04 s3: Remove talloc_autofree_context() from srv_samr_nt.c 
The dispinfo structs need to survive within a process across pipe opens,
but they don't have a special destructor
 2010-10-03 10:45:57 +02:00
Volker Lendecke
41b54a8931 s3: Remove talloc_autofree_context from pdb_interface 
None of the pdb backends have special destructors that need to be run at
program exit.
 2010-10-03 10:45:56 +02:00
Volker Lendecke
24f1893b5d s3: Attempt to fix the non-ads build 2010-10-03 00:17:44 +02:00
Volker Lendecke
13756d0e80 s3: Attempt to fix bug 7665 
Quite a few of our internal routines put stuff on talloc_tos() these days.
In top-level netapi routines, properly allocate a stackframe and clean it
again. Also, don't leak memory in the rpccli_ callers onto the libnetapi
context.
 2010-10-02 12:02:02 +02:00
Günther Deschner
d17a6f0493 s3-spoolss: Strip off ", DrvConvert" and ",LocalOnly" in OpenPrinterEx as seen from Win7 clients. 
These suffixes and their meaning are not documented (yet).

Guenther
 2010-10-02 00:42:52 +02:00
Andreas Schneider
455bbd5e1e s3-spoolss: Fixed print job access. 2010-10-02 00:04:45 +02:00
Andreas Schneider
b3fd5e11e5 s3-spoolss: Fixed print_access_check server_info. 2010-10-02 00:04:45 +02:00
Steven Danneman
100843ac23 s3:smbd: Increase unsupported IOCTL debug message to 2 
Even printing once per connection, level 0 was too spammy with
Windows clients frequently sending FSCTL_GET_OBJECT_ID which
is unsupported.
 2010-10-01 13:31:33 -07:00
Steven Danneman
455fccf86b s3:events: Call all ready fd event handlers on each iteration of the main loop 
Previously, only one fd handler was being called per main message loop
in all smbd child processes.

In the case where multiple fds are available for reading the fd
corresponding to the event closest to the beginning of the event list
would be run.  Obviously this is arbitrary and could cause unfairness.

Usually, the first event fd is the network socket, meaning heavy load
of client requests can starve out other fd events such as oplock
or notify upcalls from the kernel.

In this patch, I have changed the behavior of run_events() to unset
any fd that it has already called a handler function, as well
as decrement the number of fds that were returned from select().
This allows the caller of run_events() to iterate it, until all
available fds have been handled.

I then changed the main loop in smbd child processes to iterate
run_events().  This way, all available fds are handled on each wake
of select, while still checking for timed or signalled events between
each handler function call.  I also added an explicit check for
EINTR from select(), which previously was masked by the fact that
run_events() would handle any signal event before the return code
was checked.

This required a signature change to run_events() but all other callers
should have no change in their behavior.  I also fixed a bug in
run_events() where it could be called with a selrtn value of -1,
doing unecessary looping through the fd_event list when no fds were
available.

Also, remove the temporary echo handler hack, as all fds should be
treated fairly now.
 2010-10-01 13:31:33 -07:00
Günther Deschner
a88a7c76de s3-dcerpc: no point for printing NDR twice for internal pipes in log level 10. 
Guenther
 2010-10-01 22:30:22 +02:00
Günther Deschner
0ff7e0c998 samba: share readline wrappers among all buildsystems. 
Guenther
 2010-10-01 22:30:22 +02:00
Günther Deschner
405b7d843f s3-readline: move cmd_history to smbclient, the only user. 
Guenther
 2010-10-01 22:30:22 +02:00
Günther Deschner
b38d0542e1 samba: share select wrappers. 
Guenther
 2010-10-01 22:30:22 +02:00
Jelmer Vernooij
21475df35d s3-selftest: fix prefix in subunit output. 2010-10-01 18:49:40 +02:00
Jelmer Vernooij
f70a98605e s3: Add subunit-test target. 2010-10-01 18:49:40 +02:00
Jelmer Vernooij
9af570a2ef s3-configure: Require at least version 1.2.6 of external TDB, which has 
TDB_INCOMPATIBLE_HASH.
 2010-10-01 18:49:40 +02:00
Günther Deschner
3975203a02 s3-spoolss: fix do_drv_upgrade_printer() which must have been broken since the 
days we moved away from fstrings.

Guenther
 2010-10-01 08:33:47 +02:00
Günther Deschner
fa3264f89b s3-net: better handle obscure 0x80070002 error reply when trying to update an 
not yet published printer.

Guenther
 2010-10-01 08:33:46 +02:00
Günther Deschner
21576e3f8c s3-net: make sure we dont crash when publishing a single printer. 
Guenther
 2010-10-01 08:33:46 +02:00
Günther Deschner
5cb5e0aa98 s3-spoolss: make sure we dont crash on NULL setprinter level2 elements as seen from win7. 
Guenther
 2010-10-01 08:33:46 +02:00
Günther Deschner
48fca54a29 s3-spoolss: dont overwrite location change notify. 
Guenther
 2010-10-01 08:33:46 +02:00
Andrew Tridgell
62d87f8f88 s3-selftest: added samba3.posix_s3.rpc.spoolss.printer to knownfail 
this fails intermittently on sn-devel. Guenther suggested adding it to
knownfail

Autobuild-User: Andrew Tridgell <tridge@samba.org>
Autobuild-Date: Fri Oct  1 04:37:36 UTC 2010 on sn-devel-104
 2010-10-01 04:37:36 +00:00
Volker Lendecke
bad98e37e7 s3: Add "smbcontrol winbindd ip-dropped <local-ip>" 
This is supposed to improve the winbind reconnect time after an ip address
has been moved away from a box. Any kind of HA scenario will benefit from
this, because winbindd does not have to wait for the TCP timeout to kick in
when a local IP address has been dropped and DC replies are not received
anymore.
 2010-09-30 14:30:33 +02:00
Volker Lendecke
10f0c785c7 s3: Re-introduce a procid_self() 
Giving the parent pid to reinit_after_fork is not a good idea....
None of the other callers do this, checked it.
 2010-09-30 14:29:56 +02:00
Volker Lendecke
c7c4d84550 s3: Fix a typo in dump-domain-list smbcontrol usage msg 2010-09-30 13:17:45 +02:00
Günther Deschner
c82d6c0b96 s3-spoolss: make sure to exit early and with the appropriate error code in 
_spoolss_GetPrinterDriver2.

Guenther
 2010-09-30 02:59:36 +02:00
Günther Deschner
3797d48b76 s3-spoolss: Fix servername/printername handling which turns out to be very important to get right. 
Guenther
 2010-09-30 02:59:35 +02:00
Günther Deschner
9dcd5e6c8f s3-waf: add basic make test infrastructure, not able to test yet. 
Guenther
 2010-09-29 08:54:00 +02:00
Günther Deschner
bea8035c22 s3-waf: clean up socket-wrapper and nss-wrapper a little. 
Guenther
 2010-09-29 08:49:39 +02:00
Günther Deschner
292801bdf3 s3-waf: add vlp binary. 
Guenther
 2010-09-29 08:48:49 +02:00
Günther Deschner
ec33a87d58 s3-printing: skip metadata entry when traversing printerlist. 
We were creating a new printer (with a very broken name) out of the
lasttimestamp entry all the time.

Simo, please check.

Guenther
 2010-09-29 01:23:54 +02:00
Günther Deschner
46774388dc s3-waf: add in a little hack to deal with the ECHO rpc module for non-developer builds. 
This will be removed once we have the rpc modules subsystem in place.

Guenther
 2010-09-28 22:55:18 +02:00
Andrew Tridgell
cd3eddbb59 waf: we don't need the preprocessor recursion limit any more 
thanks to ita for this
 2010-09-28 11:36:40 -07:00
Günther Deschner
9d3046f098 s3-waf: add AUTH_SCRIPT module to AUTH subsystem (which is build as shared 
module by default).

Guenther
 2010-09-28 20:03:54 +02:00
Günther Deschner
2cf5c661c6 s3-waf: add vfs_linux_xfs_sgid to the list of default shared modules. 
Guenther
 2010-09-28 20:03:54 +02:00
Volker Lendecke
a3e211ca3f s3: Attempt to fix bug 7518 
If select returns -1, we can't rely on the fd sets. The current code might loop
endlessly because when putting an invalid fd (the closed socket?) on the read
set, a select implementation might choose not to touch it but directly return
with EINVAL. Thus run_events will see the socket readable, which leads to a
"return true", and thus a NT_STATUS_RETRY -> same game again.

We should never get into this situation, but to me the logfiles given in bug
7518 do not reveal enough information to understand how this can happen.
 2010-09-28 19:22:50 +02:00
Volker Lendecke
51bc104c5c s3: Increase the debuglevel for connection termination msgs 2010-09-28 10:40:17 +02:00
Günther Deschner
2a1891a9d6 s3-waf: fix dependencies in most of our module subsystems. 
Guenther
 2010-09-28 09:41:54 +02:00
Günther Deschner
5fcd0471e5 s3-waf: add pam_smbpass. 
Guenther
 2010-09-28 09:41:54 +02:00
Günther Deschner
07697fa053 s3-auth_util: make sure the system server info actually contains S-1-5-18. 
Without this, all security descriptor checks for the winreg spoolss backend fail
and make our spoolss system in its current shape basically unusable.

Andreas, please check.

Guenther
 2010-09-28 09:40:57 +02:00
Günther Deschner
314d738f90 s3-printing: remove unused old structs. 
Guenther
 2010-09-28 09:40:57 +02:00
Volker Lendecke
94dc2c106b s3: Lift smbd_messaging_context() from open_sockets_smbd() 2010-09-28 07:36:18 +02:00
Volker Lendecke
790ad3d1a4 s3: Remove two calls to procid_self() 2010-09-28 07:36:18 +02:00
Volker Lendecke
886b5b67ee s3: Remove talloc_autofree_context() from myhostname() 
No destructor needed, so we can as well use the NULL context
 2010-09-28 07:36:18 +02:00
Volker Lendecke
49b4d2e652 s3: Remove some remaining files.c globals to sconn 2010-09-28 07:36:18 +02:00
Volker Lendecke
d26d79b640 s3: Remove talloc_autofree_context() from files.c 2010-09-28 07:36:18 +02:00
Volker Lendecke
eadc4b5b78 s3: Lift smbd_server_conn from file_find_fd 2010-09-28 07:36:18 +02:00
Volker Lendecke
54f7b70212 s3: Remove smbd_server_conn from file_fsp 2010-09-28 07:36:18 +02:00
Volker Lendecke
3009178ee5 s3: Slightly simplify file_fnum 
req==NULL should never happen, see the comment
 2010-09-28 07:36:18 +02:00
Volker Lendecke
e57811440a s3: Remove smbd_server_conn from file_sync_all 2010-09-28 07:36:17 +02:00
Volker Lendecke
e2222fc19c s3: Remove smbd_server_conn from file_find_subpath 2010-09-28 07:36:17 +02:00
Volker Lendecke
75c6e0e5c7 s3: Lift smbd_server_conn from file_find_di_first 2010-09-28 07:36:17 +02:00
Volker Lendecke
b448e42de4 s3: Lift smbd_server_conn from file_find_dif 2010-09-28 07:36:16 +02:00
Volker Lendecke
fb8686962a s3: Remove smbd_server_conn from files_forall 2010-09-28 07:36:16 +02:00
Volker Lendecke
9fc9ff9bfa s3: Remove smbd_server_conn from file_close_user 2010-09-28 07:36:16 +02:00
Volker Lendecke
25ca1cd1a8 s3: Remove smbd_server_conn from file_close_pid 2010-09-28 07:36:16 +02:00
Volker Lendecke
6a1c4bad13 s3: Remove smbd_server_conn from file_close_conn 2010-09-28 07:36:16 +02:00
Volker Lendecke
c5d2799543 s3: Remove smbd_server_conn from file_new and file_free 2010-09-28 07:36:15 +02:00
Volker Lendecke
5276608151 s3: Lift smbd_server_conn from file_fnum 2010-09-28 07:36:15 +02:00
Volker Lendecke
5e26e4d30f s3: Move "Files" to smbd_server_connection 2010-09-28 07:36:15 +02:00
Volker Lendecke
f83e7d8f8c s3: Remove "server_fd" global variable 2010-09-28 07:36:15 +02:00
Volker Lendecke
93adf70d1a s3: Remove talloc_autofree_context() from receive_unexpected() 
This is freed in this routine a few lines down
 2010-09-28 07:36:15 +02:00
Jeremy Allison
d7c09f312e Add torture test BAD-NBT-SESSION as regression fix for bug 7698 - Assert causes smbd to panic on invalid NetBIOS session request. 
Jeremy.
 2010-09-27 18:24:53 -07:00
Jeremy Allison
a738f5b846 Small tweak to bugfix for 7698 - Assert causes smbd to panic on invalid NetBIOS session request. 
Don't just fail to reply on a bad NBT name, just don't do the
internal action.

Jeremy.
 2010-09-27 18:24:53 -07:00
Jeremy Allison
f98d217514 Change to using TDB_INCOMPATIBLE_HASH (the jenkins hash) on all 
TDB_CLEAR_IF_FIRST tdb's. For tdb's like gencache where we open
without CLEAR_IF_FIRST and then with CLEAR_IF_FIRST if corrupt
this is still safe to use as if opening an existing tdb the new
hash will be ignored - it's only used on creating a new tdb not
opening an old one.

Jeremy.
 2010-09-27 17:18:54 -07:00
Günther Deschner
77d4c28032 s3-spoolss: Fix _spoolss_EnumPrintProcDataTypes error handling 2010-09-28 01:17:16 +02:00
Günther Deschner
2921888a08 s3-spoolss: Fix _spoolss_EnumPrintProcessors error handling 2010-09-28 01:17:12 +02:00
Günther Deschner
0e1588aa98 s3-waf: add NDR_PERFCOUNT subsystem. 
Guenther
 2010-09-28 01:16:48 +02:00
Volker Lendecke
3235f44ac4 s3: Make file_fnum static 2010-09-27 18:14:47 +02:00
Volker Lendecke
f1c1959f13 s3: Remove some unused code 2010-09-27 18:14:47 +02:00
Volker Lendecke
6319e0da10 s3: Fix some comments 2010-09-27 18:14:47 +02:00
Gregor Beck
f4f5ad9774 s3:registry: proposed aix build fix for reg_parse_internal 
Signed-off-by: Michael Adam <obnox@samba.org>
 2010-09-27 11:36:49 +02:00
Günther Deschner
ff95491925 s3-waf: fix dependencies to NDR_XATTR. 
Guenther
 2010-09-27 07:46:52 +02:00
Günther Deschner
1e97e73c77 s3-waf: link PReg parser only in registry client side extension. 
Guenther
 2010-09-27 07:38:13 +02:00
Günther Deschner
122e35405e s3-waf: NDR_SRVSVC is defined now from the main librpc wscript_build. 
Guenther
 2010-09-27 07:18:16 +02:00
Günther Deschner
1622ad414f s3-waf: move SERVICES into a subsystem. 
Guenther
 2010-09-27 03:52:29 +02:00
Günther Deschner
f52fda4964 s3-waf: add PRINTING subsystems. 
Guenther
 2010-09-27 03:52:29 +02:00
Günther Deschner
cef16c2690 s3-waf: add two more REGF based subsystems. 
Guenther
 2010-09-27 03:52:28 +02:00
Günther Deschner
7afa7b8a84 s3-waf: rework static and shared list handling a little. 
Guenther
 2010-09-27 00:39:38 +02:00
Günther Deschner
4584a12b6a s3-waf: add missing IDMAP modules. 
Guenther
 2010-09-27 00:39:38 +02:00
Günther Deschner
b894847ca0 s3-waf: rework CLDAP and LIBCLI_LDAP subsystems. 
Guenther
 2010-09-27 00:39:38 +02:00
Günther Deschner
9f0b88de1a s3-waf: move gpext subsystem to libgpo/gpext/wscript_build. 
Guenther
 2010-09-27 00:39:38 +02:00
Günther Deschner
a742e0065a s3-waf: move perfcount subsystem to modules/wscript_build. 
Guenther
 2010-09-27 00:39:38 +02:00
Günther Deschner
3e35cc42b5 s3-waf: move charset subsystem to modules/wscript_build. 
Guenther
 2010-09-27 00:39:38 +02:00
Günther Deschner
6465dbce6d s3-waf: move idmap subsystem to winbindd/wscript_build. 
Guenther
 2010-09-27 00:39:38 +02:00
Günther Deschner
d7d33317c7 s3-waf: move pdb subsystem to pdb/wscript_build. 
Guenther
 2010-09-27 00:39:37 +02:00
Günther Deschner
fa8971d90f s3-waf: move auth subsystem to auth/wscript_build. 
Guenther
 2010-09-27 00:39:37 +02:00
Günther Deschner
2839c8f0b2 s3-waf: support --with-acl-support, at least for posix acls. 
Guenther
 2010-09-27 00:39:37 +02:00
Günther Deschner
89e151167c s3-waf: move VFS subsystem to modules/wscript_build. 
Guenther
 2010-09-27 00:39:37 +02:00
Günther Deschner
ca2bbe00dc s3-waf: add some module specific functions for s3 waf build. 
Thanks to Kai.

Guenther
 2010-09-27 00:39:37 +02:00
Günther Deschner
0326012db7 s3-waf: convert VFS into a subsystem. 
Guenther
 2010-09-27 00:39:37 +02:00
Günther Deschner
8a5dee26b3 s3-waf: convert GPEXT into a subsystem. 
Guenther
 2010-09-27 00:39:37 +02:00
Günther Deschner
6fcd2437e4 s3-waf: convert PERFCOUNT into a subsystem. 
Guenther
 2010-09-27 00:39:37 +02:00
Günther Deschner
a6025af503 s3-waf: convert CHARSET into a subsystem. 
Guenther
 2010-09-27 00:39:36 +02:00
Günther Deschner
ce56881696 s3-waf: convert IDMAP into subsystem. 
Guenther
 2010-09-27 00:39:36 +02:00
Günther Deschner
525dcaee51 s3-waf: convert PDB into subsystem. 
Guenther
 2010-09-27 00:39:36 +02:00
Günther Deschner
a9b05af447 s3-waf: convert AUTH into subsystem. 
Guenther
 2010-09-27 00:39:36 +02:00
Günther Deschner
065fc8bc10 s3-waf: convert LIBGPO into a subsystem. 
Guenther
 2010-09-26 21:31:00 +02:00
Günther Deschner
be9badc2f6 s3-waf: convert PLAINTEXT_AUTH, SLCACHE and DCUTIL into subsystems. 
Guenther
 2010-09-26 21:30:52 +02:00
Günther Deschner
51ea39c5c8 s3-vfs: fix the build of nfs4_acls.c 
Guenther
 2010-09-26 21:30:02 +02:00
Andreas Schneider
0fd69f5708 s3-waf: Link smbd against RPCECHO. 2010-09-26 19:28:51 +02:00
Volker Lendecke
d0739d436e s3: Remove talloc_autofree_context() from nametouid() 
pass is freed a few lines down
 2010-09-26 17:36:40 +02:00
Volker Lendecke
d4bfb5c488 s3: Remove talloc_autofree_context() from guest_user_info() 
pwd is freed a few lines down
 2010-09-26 17:36:40 +02:00
Volker Lendecke
227945d31c s3: Remove talloc_autofree_context() from getpwnam_alloc() 
This is given to the memcache a few lines down
 2010-09-26 17:36:40 +02:00
Volker Lendecke
3b2efdc7d7 s3: Remove talloc_autofree_context() from notify_internal_parent_init() 2010-09-26 17:36:40 +02:00
Jeremy Allison
03841f9e44 Fix bug #7698 - Assert causes smbd to panic on invalid NetBIOS session request. 
Found by the CodeNomicon test suites at the SNIA plugfest.

http://www.codenomicon.com/

If an invalid NetBIOS session request is received the code in name_len() in
libsmb/nmblib.c can hit an assert.

Re-write name_len() and name_extract() to use "buf/len" pairs and
always limit reads.

Jeremy.
 2010-09-26 03:01:03 -07:00
Andrew Tridgell
c0a1cbda5d s3-selftest: added samba3.posix_s3.rap.printing as a knownfail 
this fails intermittently on sn-devel, Günther suggests adding this to
knownfail for now
 2010-09-26 06:29:06 +00:00
Volker Lendecke
8a48ca4e3f s3: Remove talloc_autofree_context() from change_to_guest() 
pass is freed at the exit of this routine
 2010-09-26 03:29:29 +02:00
Volker Lendecke
4ebbbdd011 s3: Remove talloc_autofree_context() from swat 
In both cases, pass is freed immediately
 2010-09-26 03:29:29 +02:00
Volker Lendecke
bf6ca13346 s3: Remove talloc_autofree_context() from smbpasswd 
In both cases, pwd is freed immediately
 2010-09-26 03:29:29 +02:00
Volker Lendecke
77e96d3229 s3: Remove talloc_autofree_context() from net_sam_provision() 2010-09-26 03:29:29 +02:00
Volker Lendecke
2b601d72d5 s3: Remove talloc_autofree_context() from lookup_unix_user_name() 
pwd is freed in this routine immediately
 2010-09-26 03:29:28 +02:00
Volker Lendecke
9b2d3142c1 s3: Remove talloc_autofree_context() from pdb_init_ads() 2010-09-26 03:29:28 +02:00
Volker Lendecke
2d8b65066e s3: Remove two talloc_autofree_context() calls 
Both allocated blobs are freed in their routines
 2010-09-26 03:29:28 +02:00
Volker Lendecke
997a64f6fb s3: Remove talloc_autofree_context() from serverid_db() 
If we needed an explicit tdb_close() in the destructor, we'd be hosed
long ago.
 2010-09-26 03:29:28 +02:00
Volker Lendecke
34c0b166b6 s3: Remove talloc_autofree_context() from serverid_parent_init() 2010-09-26 03:29:28 +02:00
Volker Lendecke
8c55a9b459 s3: Remove talloc_autofree_context() from messaging_tdb_parent_init() 2010-09-26 03:29:28 +02:00
Volker Lendecke
c4efae77fa s3: Remove talloc_autofree_context() from ctdb_read_req() 2010-09-26 03:29:28 +02:00
Volker Lendecke
86919606c7 s3: Remove talloc_autofree_context() from get_root_nt_token() 
The memcache_add_talloc() later on steals it anyway
 2010-09-26 03:29:27 +02:00
Volker Lendecke
dda1dd63d3 s3: Avoid an explicit ZERO_STRUCT 2010-09-26 01:12:37 +02:00
Volker Lendecke
6ee0d866c2 s3: Lift talloc_autofree_context() from make_auth_context_fixed() 2010-09-26 01:12:37 +02:00
Volker Lendecke
242e329610 s3: Lift talloc_autofree_context() from make_auth_context_subsystem() 2010-09-26 01:12:37 +02:00
Volker Lendecke
2d8be31e88 s3: Lift talloc_autofree_context() from make_auth_context_text_list() 2010-09-26 01:12:37 +02:00
Volker Lendecke
61861e4b7d s3: Lift talloc_autofree_context() from make_auth_context() 2010-09-26 01:12:37 +02:00
Volker Lendecke
b12744513e s3: Fix a memleak in make_new_server_info_system() 2010-09-26 01:12:37 +02:00
Volker Lendecke
15a3afbd19 s3: Remove talloc_autofree_context() from init_system_info() 2010-09-26 01:12:37 +02:00
Volker Lendecke
e4591eb8c1 s3: Fix a typo 2010-09-25 15:45:09 -07:00
Volker Lendecke
a0d3ffbf92 s3: Fix some 64-bit warnings 2010-09-25 15:01:29 -07:00
Volker Lendecke
e81db37a87 s3: Fix bug 7470 
S_IREAD and S_IWRITE are not standard.

Thanks to Joachim Schmitz <schmitz@hp.com> for reporting!
 2010-09-25 10:59:15 -07:00