sin/samba-mirror
1
0
Fork 0
mirror of https://github.com/samba-team/samba.git synced 2025-01-22 22:04:08 +03:00
Code
121,332 Commits 60 Branches 1,146 Tags
Commit Graph

25 Commits

Author SHA1 Message Date
Andrew Bartlett
f7fe6fa550 lib/util/fault.c: Unify printing of the stack trace with the INTERNAL ERROR string 
We can diverged into the s3 and lib/fault panic action stuff once
we have printed the backtrace.

Our tests require we use the word PANIC, and some administrative scripts
might look for similar things, so keep those words.

The use of DEBUG(0, ... is deliberate to keep the output
of the PANIC line as consistent as possible with the historical smbd output.

Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>

Autobuild-User(master): Andrew Bartlett <abartlet@samba.org>
Autobuild-Date(master): Thu Feb 27 05:09:44 UTC 2020 on sn-devel-184
 2020-02-27 05:09:44 +00:00
Andrew Bartlett
4ee326f31d Move INTERNAL ERROR... printout into smb_panic() and improve "why" string 
The "why" string is now eg "Signal 11: Segmentation fault" and
so more descriptive, and hopefully this will encourage the
Samba version to be included in more error reports.

Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
 2020-02-27 03:42:35 +00:00
Björn Jacke
ec4c597552 fault.c: improve fault_report message text pointing to our wiki 
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14139

Signed-off-by: Bjoern Jacke <bjacke@samba.org>
Reviewed-by: Alexander Bokovoy <ab@samba.org>
 2019-09-23 11:40:36 +00:00
Martin Schwenke
abea597b7f util: Fix signed/unsigned comparisons by declaring as size_t 
Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Andreas Schneider <asn@samba.org>
 2019-07-01 06:44:13 +00:00
Andreas Schneider
9005943a12 lib:util: Fix checking for config.h #define in fault.c 
Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
 2018-12-16 21:04:09 +01:00
Andrew Bartlett
462eb4a44c lib/util: Call log_stack_trace() in smb_panic_default() 
This matches the AD DC with the behaviour in smbd.

Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>

Autobuild-User(master): Jeremy Allison <jra@samba.org>
Autobuild-Date(master): Wed Apr 11 04:03:07 CEST 2018 on sn-devel-144
 2018-04-11 04:03:07 +02:00
Andrew Bartlett
bf9551902a lib/util: Move log_stack_trace() to common code 
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
 2018-04-11 01:06:39 +02:00
Andrew Bartlett
3acc00b680 lib/util: Log PANIC before calling pacic action just like s3 
This is like the changes made in s3 by
4fa555980070d78b39711ef21d77628d26055bc2

Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
 2018-04-11 01:06:39 +02:00
Martin Schwenke
8dac190ee1 lib/util: Clean up includes for fault.c 
Add fault.h.  Allows standalone compiles without external includes.h.

Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Jeremy Allison <jra@samba.org>
 2014-10-04 00:11:21 +02:00
Stefan Metzmacher
cc2bc23e46 lib/util: declare smb_panic_default() as _NORETURN_ 
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
 2014-04-02 09:03:42 +02:00
Karolin Seeger
2ed035b5a0 fault.c: Fix typo in comment. 
redundent -> redundant

Signed-off-by: Karolin Seeger <kseeger@samba.org>
 2013-02-18 22:07:39 +11:00
Jeremy Allison
5df1c11539 Start to add truncate checks on all uses of strlcpy(). Reading lwn 
has it's uses :-).

Autobuild-User: Jeremy Allison <jra@samba.org>
Autobuild-Date: Thu Mar 29 20:48:15 CEST 2012 on sn-devel-104
 2012-03-29 20:48:15 +02:00
Jelmer Vernooij
c0288e0612 lib/util: Remove obsolete sys_getpid() and sys_fork(). 
The performance of these is minimal (these days) and they can return
invalid results when used as part of applications that do not use
sys_fork().

Autobuild-User: Jelmer Vernooij <jelmer@samba.org>
Autobuild-Date: Sat Mar 24 21:55:41 CET 2012 on sn-devel-104
 2012-03-24 21:55:40 +01:00
Ira Cooper
b990279304 util: Add --disable-fault-handling. 
On some platforms you can not debug coredumps after the default signal handler
gets done dumping core.  This allows waf to have an option to disable our
default signal handler.
 2012-03-15 05:55:03 +01:00
Stefan Metzmacher
f2b795e9cf lib/util: make sure panic action can attach a debugger on ubuntu (>=10.10) 
By default user processes can't attach a debugger to a process.
So explicitly allow that for all child processes, before calling
the panic action script.

metze
 2011-10-04 10:57:56 +02:00
Andrew Tridgell
18995cde5c s4-fault: changed to use %d for PID, instead of %PID% 
this matches the s3 behaviour

Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>
 2011-07-13 12:51:05 +02:00
Jeremy Allison
017e0c8d95 Fix simple uses of safe_strcpy -> strlcpy. Easy ones where we just remove -1. 2011-05-04 12:12:13 -07:00
Andrew Tridgell
580997ede0 fault: get fault.c ready for use by s4 
this moves the s3 specific dumpcore code into source3/lib/dumpcore.c,
and uses a function pointer to setup which smb_panic call to use
 2011-03-23 11:03:57 +11:00
Andrew Tridgell
058c3bb923 fault: moved s3 fault.c to top level 2011-03-23 11:03:57 +11:00
Andrew Tridgell
cb2cc34eff fault: rename fault.c to fault_s4.c 
this is in preparation for merging the s3 fault code into common
 2011-03-23 11:03:57 +11:00
Matthias Dieter Wallnöfer
f5ce61ea57 lib/util/fault.c - "call_backtrace" - no need to have "backtrace_size" as size_t 
The function "backtrace" returns an "int".
 2011-03-10 11:12:05 +01:00
Andrew Tridgell
da5c328b4b s4-dns: disable segfault handling in dlz_bind9 
we don't want bind9 calling the Samba segv handler
 2010-12-21 11:18:19 +01:00
Matthias Dieter Wallnöfer
619a49c421 lib/util/fault.c - fix "pid_t" printf warning on Solaris 
According to "http://www.ibm.com/developerworks/linux/library/l-solar/"
it's generally a 32bit "int" - therefore this cast should fit.
 2010-12-06 11:28:59 +01:00
Andreas Schneider
8ac0c9fc67 libutil: Remove obsolete signal type cast. 2010-02-23 12:23:44 +01:00
Jelmer Vernooij
caa4e42860 Move lib/util from source4 to top-level libutil. 
Conflicts:

	source4/Makefile
 2008-10-11 21:05:38 +02:00