1
0
mirror of https://github.com/samba-team/samba.git synced 2025-01-04 05:18:06 +03:00
Commit Graph

757 Commits

Author SHA1 Message Date
Marc VanHeyningen
3fc85d2259 Coverity fixes 2008-03-17 20:52:25 +01:00
Volker Lendecke
e6787aa133 Fix Coverity ID 563
dirmask is always set here, we've dereferenced it before anyway
2008-03-15 22:30:25 +01:00
Volker Lendecke
9ea0078c31 Fix Coverity ID 564
finfo1==NULL just does not happen in current code
2008-03-15 22:30:25 +01:00
Günther Deschner
1121633652 Use rpccli_srvsvc_NetShareEnumAll in smbclient.
Guenther
2008-03-10 04:33:06 +01:00
Derrell Lipman
b7f34e7ef2 Eliminate global variable in_client and a plethora of extern declarations.
Derrell
2008-03-06 10:41:42 -05:00
Volker Lendecke
1bcfef6a90 Change default bufsize to 512k
I did not do any scientific tests, but the dummy test on my laptop against a
w2k3 vmware shows that in this specific situation going beyond 512k seems not
to gain anything anymore.

smb: \> iosize 64512
iosize is now 64512
smb: \> lcd /dev
smb: \> get random null
getting file \random of size 104857600 as null (33453,1 kb/s) (average 19718,5 kb/s)
smb: \> get random null
getting file \random of size 104857600 as null (34236,0 kb/s) (average 20509,1 kb/s)
smb: \> iosize 524288
iosize is now 524288
smb: \> get random null
getting file \random of size 104857600 as null (49042,1 kb/s) (average 22521,9 kb/s)
smb: \> get random null
getting file \random of size 104857600 as null (49420,8 kb/s) (average 23432,9 kb/s)
smb: \> iosize 1048576
iosize is now 1048576
smb: \> get random null
getting file \random of size 104857600 as null (49420,8 kb/s) (average 24284,2 kb/s)
smb: \> get random null
getting file \random of size 104857600 as null (49136,3 kb/s) (average 25076,9 kb/s)
2008-03-06 13:28:23 +01:00
Volker Lendecke
e602f06cbb Use io_bufsize as window size in smbclient get command 2008-03-06 13:28:23 +01:00
Volker Lendecke
76f9b360ee Add async cli_pull support
This is the big (and potentially controversial) one. It took a phone call to
explain to metze what is going on inside cli_pull_read_done, but I would really
like everybody to understand this function. It is a very good and reasonably
complex example of async programming. If we want more asynchronism in s3, this
is what we will have to deal with :-)

Make use of it in the smbclient "get" command.

Volker
2008-03-06 13:28:23 +01:00
Volker Lendecke
5ab1cfda50 Revert "Add async cli_pull support"
This reverts commit 844a163458.
2008-03-01 09:38:14 +01:00
Volker Lendecke
413695e8d0 Revert "Fix warnings"
This reverts commit 9a966e5593.
2008-03-01 09:38:14 +01:00
Volker Lendecke
9a966e5593 Fix warnings 2008-02-29 15:17:38 +01:00
Karolin Seeger
5fbd98f706 Remove smbmount.
Karolin
2008-02-28 15:53:43 +01:00
Volker Lendecke
844a163458 Add async cli_pull support
This is the big (and potentially controversial) one. It took a phone call to
explain to metze what is going on inside cli_pull_read_done, but I would really
like everybody to understand this function. It is a very good and reasonably
complex example of async programming. If we want more asynchronism in s3, this
is what we will have to deal with :-)

Make use of it in the smbclient "get" command.

Volker
2008-02-28 15:27:55 +01:00
Volker Lendecke
d32066eaef Do the formatting change in all 3 places :-) 2008-02-25 09:55:53 +01:00
Volker Lendecke
19de47fef1 Fix confusing error message -- bug 5252
Thanks to Walter Franzini
2008-02-25 09:51:33 +01:00
Simo Sorce
ce57d38825 Make sure mount.cifs.c compiles on Fedora 9 with gcc 4.3 2008-02-22 14:10:28 -05:00
Tim Potter
a1d0746923 Replace C++-style comments with C. 2008-02-18 10:15:22 +01:00
Simo Sorce
c5b7d538ec Revert "Merge in J.Layton patch and resolve conflict."
This reverts commit 6b1a118eaa.

We found that this patch does not play well with currently released cifs.ko
code, so after discussions with Jeff Layton and Steve french we decided it
is best to back it off and re-think a better approach. Jeff will send new
patches later, but for now it is better to just revert to the previous code
2008-02-14 12:03:32 -05:00
Jeremy Allison
69aa076620 Fix bug #5247 "Wildcard expansion in mget is broken"
for 3.2.
Jeremy.
2008-02-08 16:59:52 -08:00
Volker Lendecke
ba771bd858 Convert receive_smb_raw to NTSTATUS 2008-02-02 11:03:23 +01:00
Volker Lendecke
71d6580c83 Fix bogus uninitialized variable warnings 2008-01-25 21:20:39 +01:00
Volker Lendecke
21d126c56a Fix Coverity ID 463 2008-01-24 16:31:55 +01:00
Volker Lendecke
fd34ce4370 strtok -> strtok_r 2008-01-23 15:08:04 +01:00
Jeremy Allison
3a1bcbfa7c Fix error message for new allinfo command.
Jeremy.
2008-01-18 13:47:10 -08:00
Volker Lendecke
3fa0cf3fe5 Add the "allinfo" command to smbclient
Modeled after the Samba4 allinfo command
2008-01-18 11:08:17 +01:00
Igor Mammedov
dfc80b4f1c Adds support for cifs.resolver upcall.
Here is a patch for userspace cifs.spnego handler that adds support for cifs.resolver
upcall used in DFS code.
Any comments are appreciated.

#############################

Cifs upcall with key type cifs.resolver is used for resolving
server names in handling DFS refferals.

Signed-off-by: Igor Mammedov <niallain@gmail.com>
2008-01-16 09:51:06 -05:00
Karolin Seeger
9c81125e6d Correct comment. Default debug level of smbclient is 1, not 0. 2008-01-09 12:21:44 +01:00
Steve French
d3b91e494c Merge branch 'v3-2-test' of git://git.samba.org/samba into v3-2-test 2008-01-05 14:51:23 -06:00
Jeremy Allison
ef1bbcdfb9 Use the common -e option not the custom one.
Jeremy.
2008-01-05 00:46:04 -08:00
Jeremy Allison
757653966f Add general '-e' option to enable smb encryption
on tools.
Jeremy.
2008-01-05 00:23:35 -08:00
Jeremy Allison
3a45f62310 Merge branch 'v3-2-test' of ssh://jra@git.samba.org/data/git/samba into v3-2-test 2008-01-04 19:06:37 -08:00
Jeremy Allison
4ce0bf7856 Fix idle client reading keepalive.
Jeremy.
2008-01-04 14:56:56 -08:00
Jeremy Allison
c4e5a50504 Refactor the crypto code after a very helpful conversation
with Volker. Mostly making sure we have data on the incoming
packet type, not stored in the smb header.
Jeremy.
2008-01-04 12:56:23 -08:00
Steve French
b9d2da4d10 Update mount.cifs help
Steve
2008-01-03 17:13:38 -06:00
Jeremy Allison
656c9d0844 We may use 127k read/write for encrypted connections.
Jeremy.
2007-12-30 18:05:33 -08:00
Jeremy Allison
a0494b115b Fix error message.
Jeremy.
2007-12-29 22:42:20 -08:00
Jeremy Allison
f02bf41928 Added -e, --encrypt option to smbclient that immediately
forces encrypted smb after initial connect. Will document
for 3.2 official release.
Jeremy.
2007-12-29 22:39:52 -08:00
Jeremy Allison
d241bfa577 Add the capability to set "smb encrypt = required"
on a share (or global) and have the server reply with
ACCESS_DENIED for all non-encrypted traffic (except
that used to query encryption requirements and set
encryption state).
Jeremy.
2007-12-27 23:51:03 -08:00
Jeremy Allison
d78045601a Add SMB encryption. Still fixing client decrypt but
negotiation works.
Jeremy.
2007-12-26 17:12:36 -08:00
Volker Lendecke
86d9412611 Remove next_token_nr_talloc and its associated global
Only client.c and clitar.c used this, I think they should carry the static
themselves. Also move the a bit funny routine toktocliplist to clitar.c, the
only place where it is used.
2007-12-21 09:58:20 +01:00
Volker Lendecke
e5bd32812d Fix a "no prototype" warning 2007-12-19 20:48:45 +01:00
Rishi Srivatsavai
db74b99d0e Add smbclient support for basic mDNS browsing.
Patch from Rishi Srivatsavai (bugzilla #4150), with tallocification
and minor syle changes by me.
2007-12-17 22:09:09 -08:00
Simo Sorce
6b1a118eaa Merge in J.Layton patch and resolve conflict. 2007-12-17 09:43:18 -05:00
Karolin Seeger
81dab4145f Revert smbclient changes.
Patch broke option -p.
Sorry for breaking the build!

Karolin
2007-12-14 12:08:30 +01:00
Karolin Seeger
04131b26de Make smbclient to display error message and usage in the case of invalid options. 2007-12-14 11:20:27 +01:00
Jeremy Allison
27078d1292 We don't need to call endpwent if we never call getpwent.
Jeremy.
2007-12-13 17:25:26 -08:00
Jeremy Allison
7fad5f38ea Add a varient of Steve Langasek <vorlon@debian.org> patch
for bug #4780. Cause user mounts to inherit uid= and gid= from the
calling user when called as non-root, except when overridden on the
commandline.
Jeremy.
2007-12-13 17:18:48 -08:00
Jeremy Allison
b215fb1ad0 Missed one strcpy call.
Jeremy.
2007-12-12 19:12:18 -08:00
Jeremy Allison
eff2b368e8 Add a portable version of strlcpy and strlcat and convert
all strncpy/strcat calls to them.
Convert all sprintf calls to snprintf. Safety first !
Jeremy.
2007-12-12 19:06:04 -08:00
Jeremy Allison
4f503ea891 Fix bug #4784. Patch from Steve Langasek <vorlon@debian.org>.
Jeremy.
2007-12-12 18:45:13 -08:00