1
0
mirror of https://github.com/samba-team/samba.git synced 2025-05-22 22:50:19 +03:00

272 Commits

Author SHA1 Message Date
Volker Lendecke
9eea6929e3 Fix an uninitialized variable found by the IBM Checker 2008-10-04 22:15:03 +02:00
Günther Deschner
f07431f5ba s3-nbt: use the new generated nbt.
Guenther
2008-09-24 03:34:23 +02:00
Günther Deschner
825f06c3f9 libads: remove unused vars.
Guenther
(This used to be commit ea9fc3bea31b11e715d9524defc18b75e5943842)
2008-08-20 22:07:40 +02:00
Gerald W. Carter
9ff1ffcbee libads: Add API call to connect to a global catalog server.
Extends ads_connect() to a new call ads_connect_gc() which connects on port
3268 rather than port 389.  Also makes ads_try_connect() static and
only used internally to ldap.c
(This used to be commit f4c37dbe2c986fb7bfe510cdff3b4a9fbc06d079)
2008-06-27 10:26:11 -04:00
Günther Deschner
7b1f015675 libads: add ads_connect_user_creds() that won't overwrite given user creds.
Guenther
(This used to be commit 026018c9f1ed0680b3ca5b26dd6b8dc466e27e0d)
2008-06-24 23:37:49 +02:00
Günther Deschner
0447e6a0a7 libads: add ads_get_machine_kvno() to make ads_get_kvno() a bit more generic.
Guenther
(This used to be commit cb7ace209c2051ae02647188715fa6ee324c2bf6)
2008-06-17 19:54:09 +02:00
Günther Deschner
3688eeafa3 libads: fix logic error in ads_get_kvno().
Guenther
(This used to be commit 132b038581a1a91b4e70c7c44f97f52866609812)
2008-06-17 19:51:14 +02:00
Volker Lendecke
aaa2a4f447 Revert "Fix a memleak in ads_find_dc() in case get_sorted_dc_list() fails"
This reverts commit df8d089bc63c2a52cbdf3504cded8df620a59902.
(This used to be commit 342f8858200ed7c446516c270e1b4284d92010d8)
2008-06-17 12:20:54 +02:00
Volker Lendecke
d261e16cfd Fix a memleak in ads_find_dc() in case get_sorted_dc_list() fails
This is really not a proper place to fix this, but as get_gc_list() and friends
are about to be replaced anyway, just work around the broken existing API
(This used to be commit df8d089bc63c2a52cbdf3504cded8df620a59902)
2008-06-05 10:56:18 +02:00
Tim Prouty
fb37f15600 Cleanup size_t return values in callers of convert_string_allocate
This patch is the second iteration of an inside-out conversion to cleanup
functions in charcnv.c returning size_t == -1 to indicate failure.
(This used to be commit 6b189dabc562d86dcaa685419d0cb6ea276f100d)
2008-05-20 22:40:13 +02:00
Günther Deschner
eeb126a379 libads/cldap: store client sitename also keyed by dns domain name.
Guenther
(This used to be commit 0388b2f0cc4d14b005c5b42f2c17ddcbc8bef12a)
2008-05-15 16:38:32 +02:00
Günther Deschner
847d385f7b Fix Bug #5465 (joining with createcomputer=ou1/ou2/ou3).
Guenther
(This used to be commit f3251ba03a69c2fd0335861177159a32b2bc9477)
2008-05-14 23:53:23 +02:00
Günther Deschner
cdd9913c4a cldap: let ads_cldap_netlogon() return all possible cldap replies.
Guenther
(This used to be commit 6f9d5e1cc94bc90685b54c04622b8f3357bd2f69)
2008-05-09 14:59:18 +02:00
Steven Danneman
778a5414b1 Fix bug 5419: memory leak in ads_do_search_all_args() when enumerating 1000s of entries
The ads_do_search_all_args() function attempts to string together several
LDAPMessage structures, returned across several paged ldap requests, into a
single LDAPMessage structure.  It does this by pulling entries off the second
LDAPMessage structure and appending them to the first via the OpenLDAP specific
ldap_add_result_entry() call.

The problem with this approach is it skips non-entry messages such as the
result, and controls.  These messages are leaked.

The short term solution as suggested by Volker is to replace the ads_*_entry()
calls with ads_*_message() calls so we don't leak any messages.

This fixes the leak but doesn't remove the dependence on the OpenLDAP specific
implementation of ldap_add_result_entry().
(This used to be commit f1a5405409c396df394611e2a234522572d2860a)
2008-04-26 08:11:20 -07:00
Günther Deschner
bcbac69d1a cldap: avoid duplicate definitions so remove ads_cldap.h.
Guenther
(This used to be commit 538eefe22ad69540b9f73ffaa613d6be045de199)
2008-04-21 20:21:40 +02:00
Günther Deschner
1dd7ab38e7 cldap: add talloc context to ads_cldap_netlogon().
Guenther
(This used to be commit 4cee7b1bd5cd97c414b73d6f39238958480cdcf3)
2008-04-21 20:21:40 +02:00
Günther Deschner
ba98dd4989 libads: Use libnbt for CLDAP reply parsing.
Guenther
(This used to be commit 751f3064a508341c0ebae45e8de9f5311d915d70)
2008-04-21 20:21:39 +02:00
Günther Deschner
33a3766f03 Add ads_check_ou_dn().
Guenther
(This used to be commit 380e9d26db5341d10807ccbfb413d0f53d3ffc71)
2008-03-28 16:43:59 +01:00
Volker Lendecke
561fb9daa4 Fix Coverity ID 487
(This used to be commit 22cee9c1afbc33b4920b72bc81569d79642172af)
2008-03-23 19:44:55 +01:00
Marc VanHeyningen
e06aa46b9f Coverity fixes
(This used to be commit 3fc85d22590550f0539215d020e4411bf5b14363)
2008-03-17 20:52:25 +01:00
Volker Lendecke
b361956942 str_list_free is not needed anymore
(This used to be commit feddc1447d585fd108d22a36bccc576fa81197ef)
2008-02-04 21:05:41 +01:00
Volker Lendecke
2762b9a975 Always pass a TALLOC_CTX to str_list_make and str_list_copy
(This used to be commit e2c9fc4cf5f0ff725330fa44f53782db65fca37e)
2008-02-04 20:57:49 +01:00
Günther Deschner
6c764172e5 When running with debug level > 10, dump ads_struct in ads_connect().
Guenther
(This used to be commit 2dd7c64fa8845fe502789068b877f5eaf060afc7)
2008-01-31 11:05:25 +01:00
Günther Deschner
f89fa0a6f8 Do not ignore provided machine_name in ads_get_upn().
Guenther
(This used to be commit ddc1307844379f99b3dde48fc351d0326d22a7ce)
2008-01-08 14:07:01 +01:00
Michael Adam
4aba7475ef Re-Indent function ldap_open_with_timeout().
This reverts commit #cafda34783f0961c9b463803c19cfcb69f836e3f .

I just learned (the hard way) that these indeted functions
are not indented by accident but that the intention of this
is to not include the prototype into proto.h.

Michael
(This used to be commit 2e5d01b2146bb9e057b2779d9fe7691ed46d9f45)
2008-01-04 22:56:10 +01:00
Michael Adam
b54310cbaa Add a debug message (when the LDAP server has really been connected).
Michael
(This used to be commit 7d9d2de39072b3291b95ac3965df0d19f83792b9)
2008-01-04 22:09:36 +01:00
Michael Adam
2cb68e3898 Untangle assignment and result check.
Michael
(This used to be commit 465a3b356cffb855e26569d3752f15cac07208c0)
2008-01-04 22:09:36 +01:00
Michael Adam
34e579fce5 Enhance DEBUG-verbosity of ldap_open_with_timeout().
Michael
(This used to be commit 9e70d1f24dd304c363a1bde97b5af618b46edc49)
2008-01-04 22:09:36 +01:00
Michael Adam
4ad3464fb9 Unindent function header.
Michael
(This used to be commit cafda34783f0961c9b463803c19cfcb69f836e3f)
2008-01-04 22:09:35 +01:00
Michael Adam
3f42428f9b Fix a misleading DEBUG message.
At this stage, the (tcp) connection to the LDAP server has not
been established, this is what is about to be attempted. What
has been succesfully done, is a CLDAP netlogon query.

Michael
(This used to be commit 71c3c8ad4c92c5f6267b84ee1d207e5e49e9a4ec)
2008-01-04 22:09:35 +01:00
Günther Deschner
b076a7e802 Add ads_get_joinable_ous().
Guenther
(This used to be commit 5bbceac88159ef6ff83d9cc62c77c7af2116967d)
2008-01-03 18:15:59 +01:00
Volker Lendecke
240391be53 Make use of [un]marshall_sec_desc
(This used to be commit 54576733d6c0511dc7379f964b1cb035913b7c8d)
2007-12-29 23:13:03 +01:00
Volker Lendecke
d365a43785 make use of unmarshall_sec_desc
(This used to be commit ced0c42f055a672f6b4ab6ba809b0f63c83b431e)
2007-12-16 14:15:16 +01:00
Volker Lendecke
2e07c2ade8 s/sid_to_string/sid_to_fstring/
least surprise for callers
(This used to be commit eb523ba77697346a365589101aac379febecd546)
2007-12-15 22:47:30 +01:00
Volker Lendecke
14ef4cdec1 Replace sid_string_static with sid_to_string
This adds 28 fstrings on the stack, but I think an fstring on the stack is
still far better than a static one.
(This used to be commit c7c885078be8fd3024c186044ac28275d7609679)
2007-12-15 22:09:37 +01:00
Volker Lendecke
900288a2b8 Replace sid_string_static by sid_string_dbg in DEBUGs
(This used to be commit bb35e794ec129805e874ceba882bcc1e84791a09)
2007-12-15 22:09:36 +01:00
Michael Adam
d8ac0cecae Remove an incredible amount of whitespace.
Sorry - could not resist. Michael
(This used to be commit 1000c98eae0886dbdf60beb1fe64d66ec009746b)
2007-12-06 14:08:54 +01:00
Jeremy Allison
6f46f75dfc Make strhex_to_str clear on string limits. Remove pstring from web/*.c
Jeremy.
(This used to be commit f9c8d62389f8cb47837e5360209936176537df13)
2007-12-03 17:17:05 -08:00
Volker Lendecke
1011b32678 Remove some statics
(This used to be commit 1fab16ffb888cd4ec18e52d9da33976a67a5d104)
2007-11-27 14:18:47 +01:00
Jeremy Allison
de51d3dd5f More pstring removal....
Jeremy.
(This used to be commit 809f5ab4c595740b28425e1667e395a6058b76a8)
2007-11-20 18:55:36 -08:00
Jeremy Allison
f88b7a076b This is a large patch (sorry). Migrate from struct in_addr
to struct sockaddr_storage in most places that matter (ie.
not the nmbd and NetBIOS lookups). This passes make test
on an IPv4 box, but I'll have to do more work/testing on
IPv6 enabled boxes. This should now give us a framework
for testing and finishing the IPv6 migration. It's at
the state where someone with a working IPv6 setup should
(theorecically) be able to type :
smbclient //ipv6-address/share
and have it work.
Jeremy.
(This used to be commit 98e154c3125d5732c37a72d74b0eb5cd7b6155fd)
2007-10-24 14:16:54 -07:00
Jeremy Allison
30191d1a57 RIP BOOL. Convert BOOL -> bool. I found a few interesting
bugs in various places whilst doing this (places that assumed
BOOL == int). I also need to fix the Samba4 pidl generation
(next checkin).
Jeremy.
(This used to be commit f35a266b3cbb3e5fa6a86be60f34fe340a3ca71f)
2007-10-18 17:40:25 -07:00
Günther Deschner
6ba2d944a0 r24252: Dump guid of msExchMailboxGuid when returned.
Guenther
(This used to be commit 1142f3df546cbf4780c6f54667f7ed31b1a7621b)
2007-10-10 12:29:21 -05:00
Volker Lendecke
8476d072d3 r24166: Fix Coverity ID 391
(This used to be commit 461974d2cc18c729f152356a9c30cc776f288906)
2007-10-10 12:29:17 -05:00
Günther Deschner
e6875b1b45 r23951: Fix segfault.
Guenther
(This used to be commit 1a5c8780ae79e5ae4e6a36bfb66cd92ae7d3aa88)
2007-10-10 12:28:48 -05:00
Stefan Metzmacher
07c034f7c4 r23945: add infrastructure to select plain, sign or seal LDAP connection
metze
(This used to be commit 2075c05b3d8baa7d6d8510cd962471a5781740a6)
2007-10-10 12:28:48 -05:00
Günther Deschner
9e0c550922 r23937: Use ads_config_path() when we need to know the configration context.
Guenther
(This used to be commit 1a62c731c6259bf4285d3735bff8b191002553f7)
2007-10-10 12:28:46 -05:00
Stefan Metzmacher
809c9d4d31 r23888: move elements belonging to the current ldap connection to a
substructure.

metze
(This used to be commit 00909194a6c1ed193dfdb296f50f58a53450583c)
2007-10-10 12:28:38 -05:00
Stefan Metzmacher
2fc53c947b r23886: add ads_disconnect() function
metze
(This used to be commit ba70737b7043cae89dd90f8668a24881212ac6fb)
2007-10-10 12:28:38 -05:00
Günther Deschner
ed0ffc5cef r23861: Fix return code in ads_find_samaccount().
Guenther
(This used to be commit 684fcf39dcc08bcf571272549222fdeb11d2725f)
2007-10-10 12:28:35 -05:00