1
0
mirror of https://github.com/samba-team/samba.git synced 2025-01-11 05:18:09 +03:00
Commit Graph

22639 Commits

Author SHA1 Message Date
Michael Adam
3618a07708 r23584: Use a while loop instead of a for loop without increment... :-)
Michael
(This used to be commit fb4ade3b4d)
2007-10-10 12:23:32 -05:00
Michael Adam
394291281a r23583: Add a utility function to recursively delete a Registry
key with all its subkeys. (reg_deletekey will refuse to
delete a key with subkeys with WERR_ACCESS_DENIED).

Michael
(This used to be commit 41c3ff6e27)
2007-10-10 12:23:32 -05:00
Günther Deschner
c66831e04b r23582: Fix event based krb5 ticket refreshing in winbindd.
We were incorrectly using the renew_till timestamp instead of the renewed
ticket's endtime to calculate the next refreshing date.

Guenther
(This used to be commit aa3511a5b5)
2007-10-10 12:23:32 -05:00
Michael Adam
7fd8a16d23 r23581: Move regkey_open_onelevel from reg_frontend to reg_api,
where it actually belongs, and make it static.

Michael
(This used to be commit aa702e53a7)
2007-10-10 12:23:32 -05:00
Michael Adam
de81984b5e r23579: Up to now, the "allparameters" argument to lp_next_parameter was
not effective for the global section (snum < 0). This checkin
makes it effective for the global section, too.

This does not produce changes in the results of the present calls of
lp_next_parameter: Beside the new use in utils/net_conf.c (which is
hereby fixed), the only calls of lp_next_parameter are in web/swat.c,
where it is effectively always called with allparameters == 1.

Michael
(This used to be commit 56f82485ec)
2007-10-10 12:23:32 -05:00
Michael Adam
f7de0933f3 r23578: When calling DeleteKey for a key that has subkey(s), Windows
returns WERR_ACCESS_DENIED. This adapts reg_deletekey to behave
the same way.

Michael
(This used to be commit 0c9cb69b45)
2007-10-10 12:23:32 -05:00
Jeremy Allison
f1d263eb62 r23577: Fix winbindd (sorry). Ensure I set the new child_pid
variable at the correct point just before the write
call is scheduled.
Jeremy.
(This used to be commit e076dc1646)
2007-10-10 12:23:31 -05:00
James Peach
0e67063cbc r23576: Fix some confusion between HAVE_BROKEN_GETGROUPS and USE_BSD_SETGROUPS.
(This used to be commit 8f6cf4b8c2)
2007-10-10 12:23:31 -05:00
Michael Adam
510ba543cc r23575: Fix a segfault when lp_load is called before init_registry.
Michael
(This used to be commit 235a5ae4cd)
2007-10-10 12:23:31 -05:00
Jeremy Allison
ead4ea509e r23574: Remove double-null check (I hate people bitching at me
on the lists :-).
Jeremy.
(This used to be commit f075620d20)
2007-10-10 12:23:31 -05:00
Jeremy Allison
8be22f89f0 r23573: Cope with terminating winbindd children on read/write/timeout
communication failures. Set timeout to 5 mins. Ensure that
we're terminating the correct child (the one we thought we
were talking to). Still setting up my testing environment
but I have high hopes for this being the fix for the 3.0.25b
showstopper.
Jeremy.
(This used to be commit c366df2fe7)
2007-10-10 12:23:31 -05:00
Jeremy Allison
3611cb13ed r23572: Ensure we obey Unicode consortium restrictions. Code
based on patch from MORIYAMA Masayuki <moriyama@miraclelinux.com>.
Jeremy.
(This used to be commit 0f10d2ed31)
2007-10-10 12:23:31 -05:00
Simo Sorce
6c7a17b820 r23571: Fix, parsing of multi byte share names.
Thanks to SATOH Fumiyasu
Fixes 4720

Jerry,
this is a showstopper for 3.0.25b, please grab it into
SAMBA_3_0_RELEASE before cuting the tarballs.

Simo.
(This used to be commit d2846e6b90)
2007-10-10 12:23:30 -05:00
Günther Deschner
851224a924 r23569: Also dump fd_event in dump_event_list().
Guenther
(This used to be commit 27fdf995d1)
2007-10-10 12:23:30 -05:00
Günther Deschner
d7c9bbccfd r23568: Remove last traces of Heimdal KCM support (and don't misuse wbinfo where a
torture test would be much more appropriate). Fix #4408.

Guenther
(This used to be commit 7514a370ca)
2007-10-10 12:23:30 -05:00
Volker Lendecke
622af1be30 r23567: Fix bug 4721
(This used to be commit f2050f5a3a)
2007-10-10 12:23:30 -05:00
Michael Adam
f7f3b72b21 r23566: Fix the sys_bsd_setgroups function. The actual workaround was inactive.
Michael
(This used to be commit 4b5d9b2ba7)
2007-10-10 12:23:30 -05:00
Günther Deschner
f4eb916e85 r23565: Avoid double NULL pointer checks.
Guenther
(This used to be commit 5456ea59ba)
2007-10-10 12:23:30 -05:00
Günther Deschner
fd881f4067 r23564: Handle MSG_DUMP_EVENT_LIST only in winbindd for now.
Guenther
(This used to be commit 2592e68a43)
2007-10-10 12:23:29 -05:00
Günther Deschner
36fc39d845 r23563: Add dump-event-list command to smbcontrol.
Guenther
(This used to be commit 0d956a8e45)
2007-10-10 12:23:29 -05:00
Günther Deschner
90773ab0be r23562: Add dump_event_list() for debugging the event list.
Guenther
(This used to be commit 4e1e697ac4)
2007-10-10 12:23:29 -05:00
Jeremy Allison
1deb049a02 r23556: Fix for error path from Atsushi Nakabayashi <nakabayashi@miraclelinux.com>.
Jeremy.
(This used to be commit 3f70c1b105)
2007-10-10 12:23:28 -05:00
Jeremy Allison
d0daf1a0c1 r23555: Fix some uninitialiazed variable uses.
Jeremy
(This used to be commit dc287adff2)
2007-10-10 12:23:28 -05:00
Jeremy Allison
ce02d0dfcb r23554: Fix bug #4711 by makeing cli_connect return an NTSTATUS.
Long overdue fix....
Jeremy.
(This used to be commit 073fdc5a58)
2007-10-10 12:23:28 -05:00
Michael Adam
04c75d9c95 r23553: Also ignore "lock directory" in registry global options.
Michael
(This used to be commit 3695a66166)
2007-10-10 12:23:28 -05:00
Michael Adam
9b11c3e08f r23552: Use proper comparison function an fix logic.
Michael
(This used to be commit a4714b3428)
2007-10-10 12:23:28 -05:00
Jeremy Allison
4a77ae5af8 r23550: Add more UNIX error -> NT status mappings.
Jeremy.
(This used to be commit 1e66a8340e)
2007-10-10 12:23:27 -05:00
Michael Adam
3b9e5d0b4f r23549: Make "net conf setparm" always use registry data type "sz".
This simplifies the usage of this command from
"net conf setparm <section> <param> <type> <value>"
to
"net conf setparm <section> <param> <value>".

Micheal
(This used to be commit 41a8f8ec5f)
2007-10-10 12:23:27 -05:00
Michael Adam
0d4e977f5d r23548: Fix comments.
Michael
(This used to be commit 73e41c1d0a)
2007-10-10 12:23:27 -05:00
Michael Adam
0027ca86b6 r23547: Ignore parameter "include" in regsitry globals.
Michael
(This used to be commit f0992c0d79)
2007-10-10 12:23:27 -05:00
Michael Adam
ac1a7e2f96 r23543: Adjust comments.
(This used to be commit ec22c30581)
2007-10-10 12:23:27 -05:00
James Peach
c7749c8f93 r23541: Linking the LSA pipe module only once is probably enough.
(This used to be commit 1d941961e0)
2007-10-10 12:23:27 -05:00
Kai Blin
fb2246f303 r23539: Remove code duplication and unify behaviour of winbind_nss_*.h files
(This used to be commit 13c6eacff0)
2007-10-10 12:23:26 -05:00
Volker Lendecke
8908bd64ea r23538: Fix for wild-card rename: We can't return directly on error, we need to
CloseDir.
(This used to be commit 48cdafc10a)
2007-10-10 12:23:26 -05:00
Volker Lendecke
864cad1353 r23537: Revert the inbuf/outbuf part of r23528: This caused the Solaris CC make test
to break. The Solaris CC put the static char InBuffer[TOTAL_BUFFER_SIZE] on an
odd address, the malloc'ed one is always aligned. The problem showed up in
pull_ucs2, ucs2_align uses the address of InBuffer as an indication whether to
bump up the src of the string by one. Unfortunately in the trans calls the
data portion is malloced and thus has different alignment guarantees than a
static variable. This one is bigger....

Volker
(This used to be commit 6affd7818f)
2007-10-10 12:23:26 -05:00
Michael Adam
c015c69285 r23536: Fix a typo. James: Please check!
Michael
(This used to be commit d90aa8368a)
2007-10-10 12:23:26 -05:00
Jeremy Allison
a4354d399d r23530: Fix bugs #4678 and #4697 which had the same root cause.
In make_server_info_pw() we assign a user SID in our
authoritative SAM, even though this may be from a
pure "Unix User" that doesn't exist in the SAM.
This causes lookups on "[in]valid users" to fail as they
will lookup this name as a "Unix User" SID to check against
the user token. Fix this by adding the "Unix User"\unix_username
SID to the sid array. The correct fix should probably be
changing the server_info->sam_account user SID to be a
S-1-22 Unix SID, but this might break old configs where
plaintext passwords were used with no SAM backend.
Jeremy
(This used to be commit 80d1da7e6c)
2007-10-10 12:23:26 -05:00
Volker Lendecke
5e8a4c12f9 r23528: Two changes to make the valgrind massif (heap profiler) output readable:
Remove the allocated inbuf/output. In async I/O we copy the buffers
explicitly now, so NewInBuffer is called exactly once. This does not
reduce memory footprint, but removes one of the larger chunks that
clobber the rest of the massif output

In getgroups_unix_user on Linux 2.6 we allocated 64k groups x 4 bytes
per group x 2 (once in the routine itself and once in libc) = 512k just
to throw it away directly again. This reduces it do a more typical limit
of 32 groups per user. We certainly cope with overflow fine if 32 is not
enough. Not 100% sure about this one, a DEVELOPER only thing?
(This used to be commit 009af09099)
2007-10-10 12:23:26 -05:00
Simo Sorce
a0c3774ab1 r23527: Use existing escaping function pointed by James
(This used to be commit 9dcbef9615)
2007-10-10 12:23:25 -05:00
Simo Sorce
f46690c3bb r23525: I believe this patch is ok, got no reply of it being not ok.
This closes #4624 for me.
(This used to be commit 3635b30415)
2007-10-10 12:23:25 -05:00
Simo Sorce
59c4506357 r23524: Fix bug 2319.
Got report this is all ok form a tester. Close a loong
standing bug preventing people to freely use any character
in their password when printing via cups were involved.
(This used to be commit 54ca011212)
2007-10-10 12:23:25 -05:00
Volker Lendecke
c1a2e8f6da r23523: Gaa -- had renamed "name" to "path" and apparently not compiled after
that....

Volker
(This used to be commit 1a45ea28ce)
2007-10-10 12:23:25 -05:00
Volker Lendecke
43e51b3989 r23522: Save us a kilobyte stack space in a hot code path: I can't see a reason
why check_path_syntax should not be able to run in-line. The destination
pointer either walks side by side with the source pointer or is
decremented. So as far as I can see s>=d is true throughout the whole
routine.

Jeremy, I'm checking this only into 3_0 for now. Please review and ack
or directly merge this to 3_0_26.

Thanks,

Volker
(This used to be commit 34a13c82a3)
2007-10-10 12:23:25 -05:00
Volker Lendecke
32ba5145b8 r23518: Remove the silly assumption that string_replace requires a pstring.
Jeremy, I am always very confused about the different length arguments
in convert_string and friends. Can you take a look at the change in
string_replace and verify it's ok? Thanks!

While at it, remove the pstring limit for strhasupper and strhaslower.
(This used to be commit e6e5703658)
2007-10-10 12:23:25 -05:00
Volker Lendecke
80c085d8ef r23517: After Jeremy has given is ack on irc:
Change rename_internals to open the file/directory and then call
rename_internals_fsp. Two reasons: Remove code duplication and remove a
race condition. The race condition was due to the fact that in
can_rename the share mode check closed the file and then after that did
the rename.
(This used to be commit aa16d8a649)
2007-10-10 12:23:24 -05:00
Jeremy Allison
9dee722b09 r23516: Fix bug found & fixed by Doug Rudoff (doug_rudoff@isilon.com)
- when cleaning up invalid locks make sure we mark the lck
struct as modified so it'll get saved back correctly (that
was the original intent).
Jeremy.
(This used to be commit cbf0829abc)
2007-10-10 12:23:24 -05:00
Jeremy Allison
b877360b2e r23515: Ensure status isn't used uninitialized.
Jeremy.
(This used to be commit 5b2836e2d5)
2007-10-10 12:23:24 -05:00
Jeremy Allison
5a80fa5c0c r23514: Remove unused function ads_get_dn_from_extended_dn().
Jeremy.
(This used to be commit 03763bc528)
2007-10-10 12:23:24 -05:00
Jeremy Allison
ebb53d7288 r23513: Fix one more use of VALUE_PREFIX.
Jeremy.
(This used to be commit fca5637dc6)
2007-10-10 12:23:24 -05:00
Jeremy Allison
72099d8f66 r23512: Fix conflict in #define for SECDESC_PREFIX. Ensure all
reg #defines use "REG_" prefix. Michael - please check
gcc warnings on compiles.
Jeremy.
(This used to be commit 7885b68bb5)
2007-10-10 12:23:23 -05:00