Simo Sorce
a04bbd281c
s3-auth: Refactor and rename auth_ntlmssp_server_info()
...
Rename it to auth_ntlmssp_steal_server_info() to make it clear that
the server_info struct is stolen from the auth_ntlmssp_state structure.
Use talloc_move instead of manual steal&clear
Add comments to explain what is going on.
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
2010-07-20 15:52:24 +10:00
Jeremy Allison
625a511389
Remove parse_negTokenTarg(), as it's actually incorrect. We're processing
...
negTokenInit's here. Use common code in spnego_parse_negTokenInit().
Jeremy.
2010-07-19 15:41:45 -07:00
Simo Sorce
c09dcb903c
s3-auth: Use talloc hierarchies to properly free auth_ntlmssp_state contexts
...
Turn auth_ntlmssp_end into a destructor and attach it to auth_ntlmssp_state.
Remote auth_ntlmssp_end and use TALLOC_FREE in the callers.
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
2010-07-19 14:20:04 +10:00
Simo Sorce
52f6bfea4b
s3-dcerpc: Move mere processing functions from srv_pipe_hnd.c to srv_pipe.c
2010-07-17 15:37:24 -04:00
Günther Deschner
c5e85a4987
s3-dcerpc: rename SCHANNEL_SIG_SIZE to NL_AUTH_SIGNATURE_SIZE and move to IDL.
...
Guenther
2010-07-16 23:09:54 +02:00
Simo Sorce
65116adceb
s3-dcerpc: Fix ability to receive Big Endian PDUs
2010-07-16 16:02:39 -04:00
Simo Sorce
53945a2e99
s3-dcerpc: Use a local function to dump pdu regions
...
Signed-off-by: Günther Deschner <gd@samba.org>
2010-07-16 01:51:18 +02:00
Simo Sorce
100d37fc46
s3-dcerpc: Use DATA_BLOB for pipes_struct input data
...
Signed-off-by: Günther Deschner <gd@samba.org>
2010-07-16 01:51:18 +02:00
Simo Sorce
79c207ed62
s3-dceprc: Use IDL defined constants for length calculations
...
Signed-off-by: Günther Deschner <gd@samba.org>
2010-07-16 01:51:17 +02:00
Simo Sorce
ca3bdca52e
s3-dcerpc: Padding is never done on a DCERPC_PKT_BIND_ACK packet.
...
Empirically verified against Windows.
It never pads the auth credentials on this packet type.
Signed-off-by: Günther Deschner <gd@samba.org>
2010-07-16 01:51:17 +02:00
Simo Sorce
2452a7a4c1
s3-dcerpc: consolidate respones packet creation code
...
Signed-off-by: Günther Deschner <gd@samba.org>
2010-07-16 01:51:16 +02:00
Simo Sorce
8cd3912afa
s3-dcerpc: Convert frag from prs_struct to a simple DATA_BLOB
...
Signed-off-by: Günther Deschner <gd@samba.org>
2010-07-16 01:51:16 +02:00
Simo Sorce
31b59bbf99
s3-dcerpc: Convert rdata from prs_struct to a simple DATA_BLOB
...
Signed-off-by: Günther Deschner <gd@samba.org>
2010-07-16 01:51:16 +02:00
Simo Sorce
8ffac961db
s3-dcerpc: Stop using hand marshalling in create_next_pdu_noauth()
...
Signed-off-by: Günther Deschner <gd@samba.org>
2010-07-16 01:51:16 +02:00
Simo Sorce
a678d4e3b4
s3-dcerpc: Stop using hand marshalling in create_next_pdu_schannel()
...
Signed-off-by: Günther Deschner <gd@samba.org>
2010-07-16 01:51:16 +02:00
Simo Sorce
5918a6c751
s3-dcerpc: Stop using hand marshalling in create_next_pdu_ntlmssp()
...
Signed-off-by: Günther Deschner <gd@samba.org>
2010-07-16 01:51:16 +02:00
Andrew Bartlett
0d95cee58f
s3:auth Change auth_ntlmssp_server_info API to return NTSTATUS
...
This fixes a bug where register_existing_vuid() could be called with a
NULL server_info if the alloction failed.
Andrew Bartlett
Signed-off-by: Andrew Tridgell <tridge@samba.org>
2010-07-14 16:22:49 +10:00
Simo Sorce
bc6a3e0030
s3-dcerpc: Use dcerpc_push_ncacn_packet() in api_pipe_alter_context()
...
Signed-off-by: Günther Deschner <gd@samba.org>
2010-07-13 14:44:12 +02:00
Simo Sorce
3ba93a986f
s3-dcerpc: Use dcerpc_push_dcerpc_auth() for spnego auth continuations.
...
Signed-off-by: Günther Deschner <gd@samba.org>
2010-07-13 14:44:12 +02:00
Simo Sorce
70500734f9
s3-dceprc: Use dcerpc_push_ncacn_packet() in api_pipe_bind_req()
...
Signed-off-by: Günther Deschner <gd@samba.org>
2010-07-13 14:44:12 +02:00
Simo Sorce
f6648c500b
s3-dcerpc: Use a DATA_BLOB in bind processing and avoid one mem copy
...
Also move dcerpc_push_dcerpc_auth() invocation in api_pipe_bind_req()
to simplify the workflow.
Signed-off-by: Günther Deschner <gd@samba.org>
2010-07-13 14:44:11 +02:00
Simo Sorce
8213bba892
s3-dcerpc: Rearrange api_pipe_bind_req() to do checks before allocating memory
...
Signed-off-by: Günther Deschner <gd@samba.org>
2010-07-13 14:44:11 +02:00
Simo Sorce
87605e2030
s3-dcerpc: fix dcerpc_push_ncacn_packet, pass arg by address
...
There is no need to copy the whole structure twice by passing it in by value.
Signed-off-by: Günther Deschner <gd@samba.org>
2010-07-13 14:44:11 +02:00
Simo Sorce
fe9036cf5b
s3-dcerpc: pass the packet to setup_bind_nack()
...
Allows to not rely on p->call_id but use the value directly from the request
packet header.
Signed-off-by: Günther Deschner <gd@samba.org>
2010-07-13 14:44:11 +02:00
Simo Sorce
29a3142be8
s3-dcerpc: Remove unused functions
...
Signed-off-by: Günther Deschner <gd@samba.org>
2010-07-13 14:44:11 +02:00
Simo Sorce
8e235df2de
s3-dcerpc: Use dcerpc_pull_ncacn_packet() to unmarshall dceprc requests
...
Signed-off-by: Günther Deschner <gd@samba.org>
2010-07-13 14:44:11 +02:00
Simo Sorce
77fb3649ce
s3-dceprc: Store opnum in its own variable
...
Signed-off-by: Günther Deschner <gd@samba.org>
2010-07-13 14:44:10 +02:00
Simo Sorce
a138b3d31e
s3-dceprc use a DATA_BLOB to hold the curren pdu in pipes_struct
...
Signed-off-by: Günther Deschner <gd@samba.org>
2010-07-13 14:44:10 +02:00
Simo Sorce
d078b54b22
s3-dcerpc: use dceprc_push_ncacn_packet_header in create_next_pdu_noauth()
...
Signed-off-by: Günther Deschner <gd@samba.org>
2010-07-13 14:44:10 +02:00
Simo Sorce
53e9c26271
s3-dcerpc: Use dcerpc_push_ncacn_packet_header() in create_next_pdu_schannel()
...
Signed-off-by: Günther Deschner <gd@samba.org>
2010-07-13 14:44:10 +02:00
Simo Sorce
98913d8f44
s3-dcerpc: use dcerpc_push_ncacn_packet_header() in create_next_pdu_ntlmssp()
...
Signed-off-by: Günther Deschner <gd@samba.org>
2010-07-13 14:44:10 +02:00
Simo Sorce
cf664b73a4
s3-dcerpc: Use dcerpc_set_frag_length()
...
Automatically calculate the fragment length where possible.
Signed-off-by: Günther Deschner <gd@samba.org>
2010-07-13 14:44:09 +02:00
Simo Sorce
966641b9fe
s3-dcerpc: Use dcerpc_pull_dcerpc_auth in api_pipe_bind_auth3()
2010-07-08 18:39:12 -04:00
Simo Sorce
207600991c
s3-dcerpc: Use dcerpc_auth in api_pipe_bind_req()
2010-07-08 18:39:01 -04:00
Simo Sorce
7236f8cda9
s3:dcerpc Use prs_parse_dcerpc_bind
2010-07-08 01:41:29 -04:00
Simo Sorce
ae526514a9
s3:rpc user idl define dcerpc_ctx_list instead of custom RPC_CONTEXT
2010-07-08 01:08:05 -04:00
Günther Deschner
0cbe0f3c5f
s3-dcerpc: use dcerpc_push_ncacn_packet() for setup_fault_pdu().
...
Guenther
Signed-off-by: Simo Sorce <idra@samba.org>
2010-07-07 23:45:50 -04:00
Günther Deschner
8fdc02aa63
s3-dcerpc: use dcerpc_push_ncacn_packet() for setup_bind_nak().
...
Guenther
Signed-off-by: Simo Sorce <idra@samba.org>
2010-07-07 23:45:50 -04:00
Simo Sorce
3721161d90
s3:auth Fix switch statement referencing a uninitialized variable
...
Looking at the original commit (9a747d500fad699038ecf75615c680a9fd9e4cc7)
this seem the right solution.
Andrew please check.
2010-07-01 18:18:41 -04:00
Jeremy Allison
7e388c8b27
Remove an unused chunk of code (will make it easier to talloc'ize prs_XXX).
...
Jeremy.
2010-06-16 10:27:54 -07:00
Volker Lendecke
34b29b1198
Revert "s3:auth Change auth_ntlmssp_server_info API to return NTSTATUS"
...
This reverts commit edba46ce94c335411ab337eeb4ef6f88fb3aae80.
Conflicts:
source3/auth/auth_ntlmssp.c
2010-06-08 11:38:08 +02:00
Andrew Bartlett
9a747d500f
s3:auth add hooks to indicate if signing or sealing is desired with NTLMSSP
...
This allows the right hooks to be called in GENSEC when s3compat
implements the auth_ntlmssp interface. Otherwise, we can't do the
signing or sealing as we have not negoitated it's use.
Andrew Bartlett
2010-06-07 23:34:29 +10:00
Andrew Bartlett
edba46ce94
s3:auth Change auth_ntlmssp_server_info API to return NTSTATUS
...
It's nicer to have an NTSTATUS return, and in s3compat there may be a
reason other than 'no memory' why this can fail.
Andrew Bartlett
2010-06-07 23:34:29 +10:00
Andreas Schneider
3344adc340
s3-rpc: Seperate rpc_srv_register for plain connection.
...
This will make it possible to create plain rpc named pipe connnections.
Reviewed-by: Simo Sorce <idra@samba.org>
2010-06-04 12:12:43 -04:00
Andrew Bartlett
d6fa371b92
s3:ntlmssp Use a TALLOC_CTX for ntlmssp_sign_packet() and ntlmssp_seal_packet()
...
This ensures the results can't be easily left to leak.
Andrew Bartlett
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Signed-off-by: Günther Deschner <gd@samba.org>
2010-05-31 15:11:27 +02:00
Andrew Bartlett
ebae21f023
ntlmssp: Make the ntlmssp.h from source3/ a common header
...
The code is not yet in common, but I hope to fix that soon.
Andrew Bartlett
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Signed-off-by: Günther Deschner <gd@samba.org>
2010-05-31 15:10:56 +02:00
Andrew Bartlett
723ea68d3b
s3:auth Remove AUTH_NTLMSSP_STATE typedef.
...
typedefs are no longer preferred Samba style.
Andrew Bartlett
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Signed-off-by: Günther Deschner <gd@samba.org>
2010-05-31 15:10:44 +02:00
Andrew Bartlett
3b706865f6
s3:auth Make AUTH_NTLMSSP_STATE a private structure.
...
This makes it a little easier for it to writen in terms of GENSEC in future.
Andrew Bartlett
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Signed-off-by: Günther Deschner <gd@samba.org>
2010-05-31 15:10:33 +02:00
Jelmer Vernooij
b8268cf7b0
s3: Remove use of iconv_convenience.
2010-05-18 11:45:31 +02:00
Stefan Metzmacher
dee63fe4ca
s3:ntlmssp: use client.netbios_name instead of workstation
...
metze
Signed-off-by: Günther Deschner <gd@samba.org>
2010-03-24 17:34:56 +01:00