Jeremy Allison
8380835fc6
Fix warning messages caused by addition of null check in fstrcpy macro.
2011-05-04 12:12:15 -07:00
Jeremy Allison
18582016d9
Fix off-by-one when used with safe_strcpy.
2011-05-04 12:12:14 -07:00
Jeremy Allison
cabd9e70e2
Simple +1 changes in hardcoded lengths when changing from safe_strcpy to strlcpy.
2011-05-04 12:12:14 -07:00
Jeremy Allison
265338c194
BUGFIX when converting from safe_strcpy to strlcpy.
...
We must have a blob legth > 0 in order to safely copy
the (possibly) 16 bytes + 1 byte zero character safely.
2011-05-04 12:12:14 -07:00
Volker Lendecke
0232604875
s3: Handle EINTR from sys_poll correctly
...
Autobuild-User: Volker Lendecke <vlendec@samba.org>
Autobuild-Date: Tue May 3 18:06:48 CEST 2011 on sn-devel-104
2011-05-03 18:06:48 +02:00
Björn Jacke
cd9a7c143c
s3: reply_readbraw_error needs an sconn as argument also in the non-LFS code path
...
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Autobuild-User: Björn Jacke <bj@sernet.de>
Autobuild-Date: Tue May 3 13:04:11 CEST 2011 on sn-devel-104
2011-05-03 13:04:11 +02:00
Günther Deschner
0e76eddcc8
s3: include ntdomain.h before including generated srv_ headers.
...
Guenther
2011-05-02 15:03:44 +02:00
Günther Deschner
61cd1067ef
s3-smbd: avoid using pipes_struct when only session_info is needed.
...
Guenther
2011-05-02 15:03:43 +02:00
Günther Deschner
c233c21425
s3-proto: move remaining spoolss protos to own header file.
...
Guenther
2011-05-02 15:03:43 +02:00
Günther Deschner
047d8c073b
s3-proto: move more rpc_server prototypes out of proto.h
...
Guenther
2011-05-02 15:03:43 +02:00
Jeremy Allison
2cb53f066e
Fix bug #8112 - POSIX extension opens of a directory are denied with EISDIR.
...
Ensure create_options are passed down to SMB_VFS_CREATE_FILE().
Correctly set create_options is SMB_O_DIRECTORY is set or pathname
is known to be a directory.
Jeremy.
2011-04-29 16:15:55 -07:00
Jeremy Allison
76739435fc
Fix bug 8111 - CIFS VFS: unexpected error on SMB posix open
...
We are conflating the O_CREAT|O_EXCL with the O_TRUNC
processing, they need to be separate. We need to chose
using (O_CREAT|O_EXCL) first, then modify if O_TRUNC is
set. This needs two separate switch statements.
Jeremy
2011-04-29 23:31:06 +02:00
Günther Deschner
bbacaec4e9
s3-proto: move more headers to rpc_server/rpc_ncacn_np.h where they origin from.
...
Guenther
Autobuild-User: Günther Deschner <gd@samba.org>
Autobuild-Date: Fri Apr 29 22:05:07 CEST 2011 on sn-devel-104
2011-04-29 22:05:07 +02:00
Günther Deschner
bc781bf7d9
s3-proto: remove duplicate prototypes.
...
Guenther
2011-04-29 21:01:05 +02:00
Günther Deschner
50883cfeb4
s3-tevent: only include ../lib/util/tevent wrappers where needed.
...
Guenther
Autobuild-User: Günther Deschner <gd@samba.org>
Autobuild-Date: Fri Apr 29 14:00:30 CEST 2011 on sn-devel-104
2011-04-29 14:00:30 +02:00
Günther Deschner
12476223c6
s3-tsocket: only include ../lib/tsocket/tsocket.h where needed.
...
Guenther
2011-04-29 12:19:04 +02:00
Günther Deschner
bc6f24e89f
s3-build: remove some unused headers.
...
Guenther
2011-04-29 12:19:03 +02:00
Andrew Bartlett
0520da2bbe
s3-smb Use FILE_ATTRIBUTE_ARCHIVE intead of aARCH
...
This means we use just one constant for this file attribute.
Andrew Bartlett
2011-04-29 16:38:13 +10:00
Andrew Bartlett
0eca33bbf6
s3-smb Use FILE_ATTRIBUTE_DIRECTORY intead of aDIR
...
This means we use just one constant for this file attribute.
Andrew Bartlett
2011-04-29 16:38:13 +10:00
Andrew Bartlett
08c90d6f2d
s3-smb Use FILE_ATTRIBUTE_VOLUME intead of aVOLID
...
This means we use just one constant for this file attribute.
Andrew Bartlett
2011-04-29 16:38:13 +10:00
Andrew Bartlett
0a3c84b554
s3-smb Use FILE_ATTRIBUTE_SYSTEM intead of aSYSTEM
...
This means we use just one constant for this file attribute.
Andrew Bartlett
2011-04-29 16:38:13 +10:00
Andrew Bartlett
317e19aeb3
s3-smb Use FILE_ATTRIBUTE_HIDDEN intead of aHIDDEN
...
This means we use just one constant for this file attribute.
Andrew Bartlett
2011-04-29 16:38:12 +10:00
Andrew Bartlett
7f66ebde2e
s3-smb Use FILE_ATTRIBUTE_READONLY intead of aRONLY
...
This means we use just one constant for this file attribute.
Andrew Bartlett
2011-04-29 16:38:12 +10:00
Volker Lendecke
77ea148f7f
s3: Fix a typo
...
Autobuild-User: Volker Lendecke <vlendec@samba.org>
Autobuild-Date: Tue Apr 26 13:31:08 CEST 2011 on sn-devel-104
2011-04-26 13:31:08 +02:00
Jeremy Allison
d00f1febd5
No longer need to call SMB_VFS_LSTAT - check name hasn't changed above is sufficient.
...
Autobuild-User: Jeremy Allison <jra@samba.org>
Autobuild-Date: Mon Apr 25 23:35:37 CEST 2011 on sn-devel-104
2011-04-25 23:35:37 +02:00
Jeremy Allison
eeb24c1773
Correctly detect and deny symlinks anywhere in a path (not just the last component) if "follow symlinks = no".
2011-04-25 22:49:04 +02:00
Stefan Metzmacher
9127e555ab
s3:smbd/trans2: make use of BVAL() and remove ugly LARGE_SMB_OFF_T ifdef's
...
We rely on uint64_t for a long time now...
metze
2011-04-24 09:48:49 +02:00
Stefan Metzmacher
4a4a774e61
s3:smbd/nttrans: make use of BVAL() and remove ugly LARGE_SMB_OFF_T ifdef's
...
We rely on uint64_t for a long time now...
metze
2011-04-23 11:17:46 +02:00
Volker Lendecke
018595e258
s3: Fix Coverity ID 2335, CHECKED_RETURN
2011-04-22 10:06:36 +02:00
Jeremy Allison
e919e767fb
Cosmetic. Fix bad indentation.
...
Autobuild-User: Jeremy Allison <jra@samba.org>
Autobuild-Date: Fri Apr 22 03:16:43 CEST 2011 on sn-devel-104
2011-04-22 03:16:43 +02:00
Jeremy Allison
20baa11f33
Remove duplicate code - move to parent_dirname() as a common function.
2011-04-21 17:09:50 -07:00
Günther Deschner
c7073f8b54
s3-vfs: rename open function to open_fn.
...
This should finally fix the AIX build and allow to remove AIX specific ifdefs.
Guenther
Signed-off-by: Jeremy Allison <jra@samba.org>
Autobuild-User: Jeremy Allison <jra@samba.org>
Autobuild-Date: Thu Apr 21 02:01:20 CEST 2011 on sn-devel-104
2011-04-21 02:01:20 +02:00
Günther Deschner
ae61a5c3d0
s3-smbd: fix the AIX 5.3 build.
...
(AIX defines open to be open64)
Guenther
2011-04-20 18:16:28 +02:00
Jeremy Allison
e49893c68e
Use handle based xattr set if available.
...
Autobuild-User: Jeremy Allison <jra@samba.org>
Autobuild-Date: Fri Apr 15 22:11:12 CEST 2011 on sn-devel-104
2011-04-15 22:11:12 +02:00
Jeremy Allison
525ccd589e
Ensure vfs_chown_fsp() is safe against races.
2011-04-15 12:21:39 -07:00
Jeremy Allison
4389bf4bc9
Ensure change_dir_owner_to_parent() can't be raced.
...
Autobuild-User: Jeremy Allison <jra@samba.org>
Autobuild-Date: Thu Apr 14 23:39:55 CEST 2011 on sn-devel-104
2011-04-14 23:39:55 +02:00
Jeremy Allison
9c2ba9436d
Optimization for change_file_owner_to_parent() and change_dir_owner_to_parent()
...
Don't do the chown if the owner is already correct.
2011-04-14 12:49:58 -07:00
Volker Lendecke
8b5d163d89
s3: Fix smbd with the async echo responder
...
We need to read from the echo socket, pass the socket to read
from down to the read routines
Autobuild-User: Volker Lendecke <vlendec@samba.org>
Autobuild-Date: Thu Apr 14 15:34:36 CEST 2011 on sn-devel-104
2011-04-14 15:34:36 +02:00
Volker Lendecke
15d6c70707
s3: Fix a typo
...
Autobuild-User: Volker Lendecke <vlendec@samba.org>
Autobuild-Date: Thu Apr 14 11:55:56 CEST 2011 on sn-devel-104
2011-04-14 11:55:56 +02:00
Andrew Bartlett
9d62ee2a81
s3-lib Move strisnormal to it's only user in mangle_hash.c
2011-04-14 12:31:18 +10:00
Günther Deschner
165521e20d
s3: only include smb profiling where needed.
...
Guenther
Autobuild-User: Günther Deschner <gd@samba.org>
Autobuild-Date: Thu Apr 14 01:31:39 CEST 2011 on sn-devel-104
2011-04-14 01:31:39 +02:00
Jeremy Allison
df269c0834
Don't print "success" message after error message in change_file_owner_to_parent(). Remove "goto" in change_dir_owner_to_parent().
2011-04-13 14:13:24 -07:00
Günther Deschner
9824e2e5ee
s3-rpc_client: add and use rpc_client/rpc_client.h.
...
Guenther
2011-04-13 22:23:59 +02:00
Volker Lendecke
015511d12a
s3: Make send_nt_replies() static
...
Autobuild-User: Volker Lendecke <vlendec@samba.org>
Autobuild-Date: Wed Apr 13 16:25:29 CEST 2011 on sn-devel-104
2011-04-13 16:25:29 +02:00
Andrew Bartlett
ce2f217bd2
s3-lib Move strdup_w to it's only user in mangle_hash.c
...
Andrew Bartlett
Signed-off-by: Andrew Tridgell <tridge@samba.org>
2011-04-13 14:47:07 +10:00
Andrew Bartlett
e3138f2ffe
s3-lib Move isvalid83_w to mangle_hash.c
...
This means that there is no need for the 'valid.dat' table to be
loaded by anything other than smbd, so the unloader is also removed.
The concept of a 'valid dos character' has been replaced by the hash2
mangle method.
Andrew Bartlett
Signed-off-by: Andrew Tridgell <tridge@samba.org>
2011-04-13 14:47:07 +10:00
Andreas Schneider
b137156acb
s3-smbd: Added a become_user_by_session() function.
...
This uses the provided session_info instead of searching the user via
the vuid. This is useful to work with fake connnection you need to
create if someone connects directly to a rpc service.
Signed-off-by: Jeremy Allison <jra@samba.org>
2011-04-11 22:10:22 +02:00
Andreas Schneider
27cb378283
s3-smbd: Added a change_to_user_by_session() function.
...
Signed-off-by: Jeremy Allison <jra@samba.org>
2011-04-11 22:10:21 +02:00
Jeremy Allison
c6c17242d2
Subtle change. Microsoft SMB2 tests return different access mask than for SMB1 with raw.acls.
2011-04-08 16:18:56 -07:00
Jeremy Allison
b6a30be702
Fix bug #7080 - Quota only shown when logged as root.
...
Remove the final incorrect uses of conn->session_info->utok.uid.
When we're in the "admin users" list, then this value is not set
to zero.
Inspired by the comment on this bug by Dmitry Butskoy <dmitry@butskoy.name>.
I'll create a different fix for 3.5.x.
Jeremy.
Autobuild-User: Jeremy Allison <jra@samba.org>
Autobuild-Date: Tue Apr 5 21:53:59 CEST 2011 on sn-devel-104
2011-04-05 21:53:59 +02:00