Andrew Bartlett
6abb880519
s3-auth remove unused ntlmssp.h
...
Signed-off-by: Stefan Metzmacher <metze@samba.org>
2012-01-05 17:17:29 +01:00
Andrew Bartlett
16e463e169
s3-auth Remove ntlmssp_wrap.h which is no longer required
...
Signed-off-by: Stefan Metzmacher <metze@samba.org>
2012-01-05 17:17:28 +01:00
Andrew Bartlett
3042e38d51
s3-auth use gensec directly rather than via auth_generic_state
...
This is possible because the s3 gensec modules are started as
normal gensec modules, so we do not need a wrapper any more.
Andrew Bartlett
Signed-off-by: Stefan Metzmacher <metze@samba.org>
2012-01-05 17:17:28 +01:00
Andrew Bartlett
1075efabc7
s3-auth Add TALLOC_CTX * to auth_generic_prepare()
...
This makes the long term owner of this memory more clear. So far only the
clear cases have been moved from NULL however.
Andrew Bartlett
Signed-off-by: Stefan Metzmacher <metze@samba.org>
2012-01-05 17:17:28 +01:00
Volker Lendecke
fed2fba0a9
s3: Move basic SMB checking to a much earlier point
2012-01-05 13:09:35 +01:00
Volker Lendecke
f7439f81be
s3: Add a suicide mode to smbd
...
To test our cleanup code paths properly, we need a way to make smbd exit hard
without cleaning up
2012-01-05 13:09:35 +01:00
Volker Lendecke
69a67a1b73
s3: Check for the packet size before accessing it
...
Autobuild-User: Jeremy Allison <jra@samba.org>
Autobuild-Date: Wed Jan 4 15:16:20 CET 2012 on sn-devel-104
2012-01-04 15:16:20 +01:00
Volker Lendecke
bed281dad7
s3: Remove the unused "file_existed" parameter from smbd_calculate_access_mask
...
Autobuild-User: Volker Lendecke <vlendec@samba.org>
Autobuild-Date: Tue Jan 3 15:16:50 CET 2012 on sn-devel-104
2012-01-03 15:16:49 +01:00
Volker Lendecke
c01f02a4b9
s3: Avoid "file_existed" in smbd_calculate_maximum_allowed_access
...
We access the file by name anyway, so we can just try to access it. The file
system will for sure tell us if the file does not exist.
2012-01-03 13:38:02 +01:00
Volker Lendecke
49a520217c
s3: Remove some else{} branches in smbd_calculate_maximum_allowed_access
2012-01-03 13:38:01 +01:00
Volker Lendecke
8cadd19a91
s3: Directly use *p_access_mask in smbd_calculate_maximum_allowed_access
2012-01-03 13:38:01 +01:00
Volker Lendecke
a5a4b581b7
s3: Factor out smbd_calculate_maximum_allowed_access
2012-01-03 13:38:00 +01:00
Jeremy Allison
e39df67669
Final part of fix for bug #8679 - recvfile code path using splice() on Linux leaves data in the pipe on short write.
...
The code to set a DOS error on short writeX return is amazingly
legacy code, and also breaks the reply as fixup_chain_error_packet()
enforces a 2-byte wct on any reply where smb_rcls != 0.
Found in testing by Andrew Bartlett. Thanks Andrew !
Autobuild-User: Jeremy Allison <jra@samba.org>
Autobuild-Date: Sat Dec 31 08:05:35 CET 2011 on sn-devel-104
2011-12-31 08:05:35 +01:00
Andrew Bartlett
c17131685c
s3-auth remove auth_ntlmssp_start(), call auth_generic_start() directly
...
This makes it clear that this can support more than just NTLMSSP.
Andrew Bartlett
Signed-off-by: Stefan Metzmacher <metze@samba.org>
2011-12-22 19:25:10 +01:00
Andrew Bartlett
1100f6eca5
s3-auth rename auth_ntlmssp_prepare() -> auth_generic_prepare()
...
This function handles more than NTLMSSP now, at least when we are an AD DC
and so changing the name may avoid some confusion in the future.
Andrew Bartlett
Signed-off-by: Stefan Metzmacher <metze@samba.org>
2011-12-22 19:25:10 +01:00
Andrew Bartlett
6391fff9da
s3-auth rename auth_ntlmssp_state -> auth_generic_state
...
This structure handles more than NTLMSSP now, at least when we are an AD DC
and so changing the name may avoid some confusion in the future.
Andrew Bartlett
Signed-off-by: Stefan Metzmacher <metze@samba.org>
2011-12-22 19:25:10 +01:00
Stefan Metzmacher
460fc521cf
s3:smb2_negprot: add support for PROTOCOL_SMB2_24
...
metze
2011-12-22 15:58:45 +01:00
Jeremy Allison
c23f1ee0c9
Allow an object to be deleted from a directory if the caller has DELETE_CHILD access
...
even if we don't have access to read the ACL on the object. Fixes bug #8673 - NT ACL issue.
Different fix needed for 3.6.x.
Autobuild-User: Jeremy Allison <jra@samba.org>
Autobuild-Date: Tue Dec 20 22:13:51 CET 2011 on sn-devel-104
2011-12-20 22:13:51 +01:00
Volker Lendecke
75d3b9ce08
s3: Fix some False/NULL hickups
...
Autobuild-User: Volker Lendecke <vlendec@samba.org>
Autobuild-Date: Tue Dec 20 13:13:17 CET 2011 on sn-devel-104
2011-12-20 13:13:17 +01:00
Jeremy Allison
b939144071
check_name() not needed in mkdir.
...
Autobuild-User: Jeremy Allison <jra@samba.org>
Autobuild-Date: Sat Dec 17 02:44:55 CET 2011 on sn-devel-104
2011-12-17 02:44:55 +01:00
Jeremy Allison
1dfa3ee986
Ensure VALID_STAT before accessing fields.
2011-12-17 01:10:41 +01:00
Jeremy Allison
a6854f2c0a
Fix bug #8664 - Renaming a symlink fails if the symlink target is outside of the share.
...
Autobuild-User: Jeremy Allison <jra@samba.org>
Autobuild-Date: Fri Dec 16 23:32:26 CET 2011 on sn-devel-104
2011-12-16 23:32:26 +01:00
Jeremy Allison
7dcef878cd
Restrict UCF_UNIX_NAME_LOOKUP (symlink allowed) to restricted set of calls.
2011-12-16 21:54:23 +01:00
Stefan Metzmacher
cbb67e9e2e
s3:smbd: remove unused sconn_server_id()
...
metze
2011-12-16 13:19:33 +01:00
Stefan Metzmacher
704cf10645
s3:smbd: avoid using sconn_server_id()
...
metze
2011-12-16 13:19:32 +01:00
Volker Lendecke
7000bb6933
s3: Add some const to find_oplock_types
...
Autobuild-User: Volker Lendecke <vlendec@samba.org>
Autobuild-Date: Fri Dec 16 09:10:07 CET 2011 on sn-devel-104
2011-12-16 09:10:06 +01:00
Volker Lendecke
2349c027c1
s3: Make open_file_ntcreate a bit easier to read
...
Move the declaration of "id" closer to its use
2011-12-16 07:34:48 +01:00
Volker Lendecke
ce30a7ae7b
s3: Make open_file_ntcreate a bit easier to read
...
Move the calculation of "new_file_created" closer to its use
2011-12-16 07:34:48 +01:00
Volker Lendecke
98f7ba52e3
s3: Make open_file_ntcreate a bit easier to read
...
Remove a negation where it's not necessary
2011-12-16 07:34:48 +01:00
Volker Lendecke
432ea5f5c6
s3: Slightly simplify delay_for_exclusive_oplocks
2011-12-16 07:34:48 +01:00
Volker Lendecke
b3d8ecaf52
s3: Slightly simplify delay_for_batch_oplocks
2011-12-16 07:34:47 +01:00
Jeremy Allison
c5cbe481a7
Third part of fix for bug #8663 - deleting a symlink fails if the symlink target is outside of the share.
...
smbd_check_access_rights() - we can always delete a symlink.
Autobuild-User: Jeremy Allison <jra@samba.org>
Autobuild-Date: Fri Dec 16 03:32:15 CET 2011 on sn-devel-104
2011-12-16 03:32:15 +01:00
Jeremy Allison
f448c0e6db
Second part of fix for bug #8663 - deleting a symlink fails if the symlink target is outside of the share.
...
Ensure we use UCF_UNIX_NAME_LOOKUP flags on filename_convert()
when doing a UNIX infolevel in trans2setfilepathinfo().
2011-12-15 16:33:37 -08:00
Jeremy Allison
8eca223123
First part of fix for bug #8663 - deleting a symlink fails if the symlink target is outside of the share.
...
Remove two unneeded check_name() calls. They have already been done
in order to get here.
2011-12-15 16:31:51 -08:00
Stefan Metzmacher
19078b9b05
s3:smbd/globals: remove unused msg_ctx_to_sconn()
...
metze
Autobuild-User: Stefan Metzmacher <metze@samba.org>
Autobuild-Date: Thu Dec 15 14:24:59 CET 2011 on sn-devel-104
2011-12-15 14:24:59 +01:00
Stefan Metzmacher
03455519e7
s3:smbd: pass smbd_server_connection and a snumused function pointer to reload_services()
...
metze
2011-12-15 11:11:24 +01:00
Stefan Metzmacher
e412b8bfcc
s3:smbd: split smb_conf_updated into parent and child versions
...
metze
2011-12-15 11:03:00 +01:00
Stefan Metzmacher
715933a3d3
s3:smbd: split ID_CACHE_* message handling into parent and child parts
...
metze
2011-12-15 08:16:31 +01:00
Volker Lendecke
1bea57a6c3
s3: Fix raw.mux after UNUSED_SHARE_MODE_ENTRY was removed
...
See the large comment in notify_deferred_opens for an explanation
Autobuild-User: Volker Lendecke <vlendec@samba.org>
Autobuild-Date: Wed Dec 14 19:08:30 CET 2011 on sn-devel-104
2011-12-14 19:08:30 +01:00
Volker Lendecke
c889c8d705
s3: Slightly simplify the logic in defer_open
...
Doing 3 &&ed conditions in a single if-statement is easier to understand to me
than continuing out separately.
2011-12-14 17:34:21 +01:00
Volker Lendecke
f7e84f2809
s3: Remove UNUSED_SHARE_MODE_ENTRY
2011-12-14 17:34:21 +01:00
Stefan Metzmacher
ffa996e479
s3:smb2_lock: use talloc_get_type_abort() as private_data can't be NULL
...
metze
Autobuild-User: Stefan Metzmacher <metze@samba.org>
Autobuild-Date: Wed Dec 14 13:34:25 CET 2011 on sn-devel-104
2011-12-14 13:34:25 +01:00
Stefan Metzmacher
324e66fd45
s3:smbd/oplock: make process_oplock_async_level2_break_message() static
...
metze
2011-12-14 12:00:07 +01:00
Stefan Metzmacher
dabc2cb9cb
s3:smbd/oplock: use talloc_get_type_abort() as private_data can't be NULL
...
metze
2011-12-14 12:00:07 +01:00
Stefan Metzmacher
940f21e5c6
s3:smbd/open: use talloc_get_type_abort() as private_data can't be NULL
...
metze
2011-12-14 12:00:07 +01:00
Stefan Metzmacher
e3e56e209f
s3:smbd/conn_msg: use talloc_get_type_abort() as private_data can't be NULL
...
metze
2011-12-14 12:00:07 +01:00
Stefan Metzmacher
95384d11a3
s3:smbd/close: use talloc_get_type_abort() as private_data can't be NULL
...
metze
2011-12-14 12:00:07 +01:00
Stefan Metzmacher
500d703977
s3:smbd/blocking: use talloc_get_type_abort() as private_data can't be NULL
...
metze
2011-12-14 12:00:07 +01:00
Stefan Metzmacher
2e0bc74a6e
s3:smbd: remove brl_register_msgs()
...
metze
2011-12-14 12:00:06 +01:00
Stefan Metzmacher
c51da25769
s3:smbd/server: avoid msg_ctx_to_sconn() in smbd_accept_connection()
...
This is the place where we should create smbd_server_connection,
when we're ready to remove the global variable.
metze
Autobuild-User: Stefan Metzmacher <metze@samba.org>
Autobuild-Date: Wed Dec 14 11:23:42 CET 2011 on sn-devel-104
2011-12-14 11:23:42 +01:00