sin/samba-mirror
1
0
Fork 0
mirror of https://github.com/samba-team/samba.git synced 2025-02-08 05:57:51 +03:00
Code
23,087 Commits 62 Branches 1,150 Tags
Commit Graph

1139 Commits

Author SHA1 Message Date
Derrell Lipman
2fde343150 r24410: - I got tricked by function naming. Contrary to what seemed obvious to me, 
prs_mem_free() is not the function to be called to free memory allocated by
  prs_alloc_mem().  I've added a comment so others may not get bitten too.

- Remove incorrect memory free calls added yesterday to replace SAFE_FREE.
  The memory is actually now on a talloc context, so gets freed by the caller
  when that context is freed.  We don't need to free it iternally.

Derrell
 2007-10-10 12:29:41 -05:00
Volker Lendecke
dab5449f38 r24291: Fix Coverity ID 364 
We've checked num_rids != 0 above.
 2007-10-10 12:29:25 -05:00
Volker Lendecke
411a1a2037 r24067: Fix a type mismatch found by the IBM checker 2007-10-10 12:29:01 -05:00
Andrew Tridgell
87c91e4362 r23801: The FSF has moved around a lot. This fixes their Mass Ave address. 2007-10-10 12:28:27 -05:00
Andrew Tridgell
b0132e94fc r23784: use the GPLv3 boilerplate as recommended by the FSF and the license text 2007-10-10 12:28:22 -05:00
Jeremy Allison
407e6e695b r23779: Change from v2 or later to v3 or later. 
Jeremy.
 2007-10-10 12:28:20 -05:00
Volker Lendecke
51a3933b3d r23665: Remove two unneeded global variables 2007-10-10 12:23:43 -05:00
Günther Deschner
e9a7512a9f r23627: Allow to pass down the lookup-level to rpccli_lsa_lookup_names(). 
Guenther
 2007-10-10 12:23:38 -05:00
Jim McDonough
afabd68b6a r23616: Fix bugzilla #4719: must change password is not set from usrmgr.exe. 
This was only affecting the newer versions of usrmgr.exe, because they
use a user_info_25 struct.  The password is getting set separately
inside that code, so the password last set time was getting set from the
password change logic.

We also were not parsing a number of fields (like logon hours) from the
user_info_25.  That should also be fixed.
 2007-10-10 12:23:36 -05:00
James Peach
171dc060e2 r23510: Tidy calls to smb_panic by removing trailing newlines. Print the 
failed expression in SMB_ASSERT.
 2007-10-10 12:23:23 -05:00
Jeremy Allison
9300b92f7a r23400: Fix lsa crash bug #4683. The "names" enum struct 
in a lookup_sidX reply isn't optional - like the
lookup_sidX query it needs to be defined in the
struct.
All this will go away with PIDL (thank goodness....).
Jerry - I think this is a showstopper to be merged
for 3.0.25b.
I'll be watching the build farm to see if anything broke.
Jeremy.
 2007-10-10 12:23:13 -05:00
Günther Deschner
5e75ea7f2b r23380: netr_getdcname returns WERROR not NTSTATUS. 
Guenther
 2007-10-10 12:23:12 -05:00
Jeremy Allison
34144c63ad r23342: Stop Coverity from getting confused. 
Jeremy.
 2007-10-10 12:23:07 -05:00
Gerald Carter
ebcae48ec1 r23274: merge CloseEventlog() pidl conversion from 3.0.26 && fix a few init call renames for svcctl in the previous commit 2007-10-10 12:23:02 -05:00
Gerald Carter
0b1bc3521f r23271: merge service control pidl change for CloseServiceHandle() from SAMBA_3_0_26 2007-10-10 12:23:01 -05:00
Günther Deschner
def6464c87 r23210: Very funny, we thought to use netr_GetDcName (e.g. in winbind) but were using 
netr_GetDcAnyName all the time (which is the correct thing to do).

Fix the naming and opcode mixup in all branches.

Guenther
 2007-10-10 12:22:54 -05:00
Günther Deschner
37ae7f4197 r23127: Fill in some more netlogon dsgetdcname flavours (netr_DsRGetDCNameEx, 
netr_DsRGetDCNameEx2) and add new ds request and reply flags, also add some
more WERROR codes.

Guenther
 2007-10-10 12:22:48 -05:00
Jeremy Allison
a871191395 r23122: Fix bug #4655. We marshall the enumdataex correctly, 
but W2K3 doesn't follow our rules when sending data to
us. Ensure we look for the data at the correct offsets
when reading the data.
Too late for 3.0.25a - don't merge.
Jeremy.
 2007-10-10 12:22:48 -05:00
Volker Lendecke
123290d094 r23091: Add rpccli_netlogon_sam_network_logon_ex, fix its parsing. This does not 
use the credential chain and only works over netlogon, but it would
allow multiple outstanding auth requests for a single workstation
account.
 2007-10-10 12:22:44 -05:00
Jeremy Allison
9a10736e6f r23080: Fix bug #4637 - we hads missed some cases where 
we were calling PRS_ALLOC_MEM with zero count.
Jeremy.
 2007-10-10 12:22:43 -05:00
Gerald Carter
f65214be68 r22852: merge fixes for CVE-2007-2446 and CVE-2007-2447 to all branches 2007-10-10 12:22:02 -05:00
Volker Lendecke
3d3d61687e r22844: Introduce const DATA_BLOB data_blob_null = { NULL, 0, NULL }; and 
replace all data_blob(NULL, 0) calls.
 2007-10-10 12:22:01 -05:00
Jeremy Allison
c73963a60a r22676: Fix zero alloc with create_rpc_blob(). 
Jeremy.
 2007-10-10 12:19:54 -05:00
Jeremy Allison
9e4c6ab739 r22673: Fix for Jerry's reversion. We still need to check size 
before talloc.
Jeremy.
 2007-10-10 12:19:54 -05:00
Gerald Carter
cf11b43149 r22630: Revert svn r22576 (parse change to enum_aliasmem(). Original code was correct 2007-10-10 12:19:50 -05:00
Jeremy Allison
8ad13718af r22588: Make all uses of TALLOC_MEMDUP consistent. 
Jeremy.
 2007-10-10 12:19:48 -05:00
Jeremy Allison
c622fb8536 r22585: Get us into a consistent state with TALLOC_ZERO_ARRAY also. 
Jeremy.
 2007-10-10 12:19:47 -05:00
Jeremy Allison
3df99006f8 r22577: Change all of parse/*.c to use standard form. Fix some 
marshalling bugs.
Jeremy.
 2007-10-10 12:19:46 -05:00
Jeremy Allison
415c476f72 r22576: Fix marshalling bug in aliasmem. 
Jeremy.
 2007-10-10 12:19:45 -05:00
Jeremy Allison
da78488b86 r22564: Move the _strict -> _zeronull functions into lib/util.c 
and out of talloc at tridge's request.
Jeremy.
 2007-10-10 12:19:45 -05:00
Jeremy Allison
f6fa3080fe r22542: Move over to using the _strict varients of the talloc 
calls. No functional changes. Looks bigger than it is :-).
Jeremy.
 2007-10-10 12:19:44 -05:00
Jeremy Allison
99abe96b2b r22163: Pure reformatting. I hate 4 space tabstops :-). 
Jeremy.
 2007-10-10 12:19:18 -05:00
Gerald Carter
eab9ca7e7d r22104: BUG 4439: Fix the object picket on x64 WIndopws XP/2003. 
Enable the DsRoleGetPrimaryDomainInfo() server code.
Tested by Win2000/XP/2003/Vista (x86) and WinXP (x64)
 2007-10-10 12:19:12 -05:00
Jeremy Allison
0c8949ff5d r22062: Fix the parsing of info level 3. Flags is not a flags 
field, but an offset. Fixed 64-bit display of ACLs on
printers.
Jeremy.
 2007-10-10 12:19:07 -05:00
Jelmer Vernooij
ad98126187 r22055: Port the endpoint mapper (and functions it requires) to Samba 3. 2007-10-10 12:19:06 -05:00
Stefan Metzmacher
3a28443079 r22009: change TDB_DATA from char * to unsigned char * 
and fix all compiler warnings in the users

metze
 2007-10-10 12:19:00 -05:00
Stefan Metzmacher
fa322f0cc9 r22001: change prototype of dump_data(), so that it takes unsigned char * now, 
which matches what samba4 has.

also fix all the callers to prevent compiler warnings

metze
 2007-10-10 12:18:59 -05:00
Stefan Metzmacher
724c6fa337 r21987: split tdb_prs_*() functions in version which take a keystr and a TDB_DATA key 
metze
 2007-10-10 12:18:56 -05:00
Gerald Carter
6a69caf690 r21507: Fix some "cannot access LDAP when no root" bugs. 
The two culprits were

* pdb_get_account_policy()
* pdb_get_group_sid()
 2007-10-10 12:18:09 -05:00
Günther Deschner
7bbb3409a5 r21393: Fix typo. 
Guenther
 2007-10-10 12:18:01 -05:00
Jeremy Allison
60e26a9039 r21346: FIXME ! Our parsing here is wrong I think, 
but for a level3 it makes no sense for
ptr_sec_desc to be NULL. JRA. Based on
a Vista sniff from Martin Zielinski <mz@seh.de>.
Jerry - part of the Vista patchset.
Jeremy.
 2007-10-10 12:17:57 -05:00
Jeremy Allison
b35fa5168e r21096: Fix formatting. 
Jeremy
 2007-10-10 12:17:36 -05:00
Gerald Carter
a3602cc6d4 r20904: This is a placeholder fix. Apparently Windows 2000 
is sharing the IDL for the SAMR pipe with Windows 2003
but returning NT_STATUS_NOT_SUPPORTED rather than a DCE/RCE
fault.  We need to catch this in the general sense
by looking at the returned PDU size.  But this immediate
change fixes password changes via pam_winbind against Windows 2000
DCs.
 2007-10-10 12:17:18 -05:00
Herb Lewis
41be182f78 r20269: merge -r20264:20267 from SAMBA_3_0_24 
more no previous prototype warnings
 2007-10-10 12:16:38 -05:00
Volker Lendecke
2d4b5f5727 r19288: tdb_prs_store is right now used to store printer and share security 
descriptors. Both databases are long-lived and not frequently written, so I
think storing it deserves a tdb transaction.

Volker
 2007-10-10 12:15:28 -05:00
Günther Deschner
6091c8152a r19161: Add NET_GETANYDCNAME (getdcname only gives the PDC while getanydcname 
gives just any DC), also make sure to set timeouts in rpcclient
accordingly so that we actually get the DC's reply.

Guenther
 2007-10-10 12:15:18 -05:00
Günther Deschner
44e228ac79 r19143: getdcname on the NETLOGON pipe returns WERROR, not NTSTATUS. 
Guenther
 2007-10-10 12:15:16 -05:00
Volker Lendecke
d7248b6cfa r19028: Implement getprinterinfo level 6 (only the status) and get rid of snum in the 
getprinter calls. Survives the RPC-SAMBA3-SPOOLSS test which I will activate
when the Samba4 build farm has picked it up.

Volker
 2007-10-10 12:15:03 -05:00
Gerald Carter
cbfe1a4b49 r18919: * Get the new rpccli_winreg_XXXX() functions into the tree 
There some broken functionality here that I'm still working on.
* remove unneeded parsing routines
 2007-10-10 12:14:46 -05:00
Jeremy Allison
fd97f48ba3 r18846: Fix the same bug Volker noticed when marshalling/unmarshalling 
SEC_ACE. "type" is also an enum that may be any size. Treat as
a uint8.
Jeremy.
 2007-10-10 12:01:04 -05:00